From f5e17567f9fc8f5a82f3cdd2da2aaaa27e5d056e Mon Sep 17 00:00:00 2001
From: Samir Talwar <samir.talwar@digitalasset.com>
Date: Tue, 31 Aug 2021 14:37:19 +0200
Subject: [PATCH] sandbox-classic: Remove default parameters in
 `SqlLedger.Owner`. (#10718)

* sandbox-classic: Remove default parameters in `SqlLedger.Owner`.

The defaults can be dangerous.

CHANGELOG_BEGIN
CHANGELOG_END

* sandbox-classic: Revert LedgerResource's index schema to the mutable one.
---
 .../platform/sandbox/stores/ledger/sql/SqlLedger.scala      | 6 +++---
 .../test/lib/scala/platform/sandbox/LedgerResource.scala    | 3 +++
 .../sandbox/stores/ledger/sql/SqlLedgerSpecAppendOnly.scala | 1 +
 3 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/ledger/sandbox-classic/src/main/scala/platform/sandbox/stores/ledger/sql/SqlLedger.scala b/ledger/sandbox-classic/src/main/scala/platform/sandbox/stores/ledger/sql/SqlLedger.scala
index e4d436f4ce..3729e563ec 100644
--- a/ledger/sandbox-classic/src/main/scala/platform/sandbox/stores/ledger/sql/SqlLedger.scala
+++ b/ledger/sandbox-classic/src/main/scala/platform/sandbox/stores/ledger/sql/SqlLedger.scala
@@ -87,9 +87,9 @@ private[sandbox] object SqlLedger {
       metrics: Metrics,
       lfValueTranslationCache: LfValueTranslationCache.Cache,
       engine: Engine,
-      validatePartyAllocation: Boolean = false,
-      enableAppendOnlySchema: Boolean = false,
-      enableCompression: Boolean = false,
+      validatePartyAllocation: Boolean,
+      enableAppendOnlySchema: Boolean,
+      enableCompression: Boolean,
   )(implicit mat: Materializer, loggingContext: LoggingContext)
       extends ResourceOwner[Ledger] {
 
diff --git a/ledger/sandbox-classic/src/test/lib/scala/platform/sandbox/LedgerResource.scala b/ledger/sandbox-classic/src/test/lib/scala/platform/sandbox/LedgerResource.scala
index 7bef07855f..115d767ae5 100644
--- a/ledger/sandbox-classic/src/test/lib/scala/platform/sandbox/LedgerResource.scala
+++ b/ledger/sandbox-classic/src/test/lib/scala/platform/sandbox/LedgerResource.scala
@@ -93,6 +93,9 @@ private[sandbox] object LedgerResource {
           metrics = new Metrics(metrics),
           lfValueTranslationCache = LfValueTranslationCache.Cache.none,
           engine = new Engine(),
+          validatePartyAllocation = false,
+          enableAppendOnlySchema = false,
+          enableCompression = false,
         )
       } yield ledger
     )
diff --git a/ledger/sandbox-classic/src/test/suite/scala/platform/sandbox/stores/ledger/sql/SqlLedgerSpecAppendOnly.scala b/ledger/sandbox-classic/src/test/suite/scala/platform/sandbox/stores/ledger/sql/SqlLedgerSpecAppendOnly.scala
index c7ff2c0da2..1c14697b0f 100644
--- a/ledger/sandbox-classic/src/test/suite/scala/platform/sandbox/stores/ledger/sql/SqlLedgerSpecAppendOnly.scala
+++ b/ledger/sandbox-classic/src/test/suite/scala/platform/sandbox/stores/ledger/sql/SqlLedgerSpecAppendOnly.scala
@@ -342,6 +342,7 @@ final class SqlLedgerSpecAppendOnly
         engine = new Engine(),
         validatePartyAllocation = validatePartyAllocation,
         enableAppendOnlySchema = true,
+        enableCompression = false,
       ).acquire()(ResourceContext(system.dispatcher))
     createdLedgers += ledger
     ledger.asFuture