* Add choice collisions in scala name collision chk
This brings it in line with the LF spec.
This PR also adds collisions for inherited (interface) choices.
Closes#11137.
changelog_begin
changelog_end
* scalafmt
* Apply suggestions from code review
Co-authored-by: Remy <remy.haemmerle@daml.com>
Co-authored-by: Remy <remy.haemmerle@daml.com>
CHANGELOG_BEGIN
[ledger-api] - Return FAILED_PRECONDITION gRPC status code, instead of INVALID_ARGUMENT, for an invalid command deduplication duration
CHANGELOG_END
We need to make some changes to have any chance of ARM support working
and I’d rather make those on top of the latest version.
Also deletes an unused patch.
changelog_begin
changelog_end
This PR has been created by a script, which is not very smart
and does not have all the context. Please do double-check that
the version prefix is correct before merging.
@robin-da is in charge of this release.
Commit log:
```
7391a3cdcd Migrate language-support codegen tests to sandbox (#11508)
da76e2825b iface: check for interface implementations precond (#11494)
9e045c105b Remove a leftover from `check-protobuf-stability.sh` (#11513)
17c2fa9122 ErrorCodeDocumentationGenerator uses multiple prefixes for scanning classpaths (#11504)
a8ae4d6f9c LF: Rename GenNode to Node (#11469)
73b6f8b613 Fixed ledger-api-bench-tool random distribution in submission phase. (#11507)
92495b0662 Upgrade nixpkgs (#11490)
48afb7b5ea interface: Add inherited choice names in scala AST (#11503)
9f8b039be3 [Trigger-Service] Migrate tests to sandbox (#11501)
6bafeb03e8 DPP-662 Support archivals in bench tool (#11474)
63d855f202 Pass `damlc build` logs through daml logger (#11485)
565dfac2e5 Bump rules_nodejs to 4.4.2 (#11495)
9214956218 Enable experimental nix command (#11498)
f81d880bcc LF: drop com.daml.lf.transaction.Transaction.Transaction type alias. (#11470)
505a7f59f3 Extend debug logging around dependencies/data-dependencies (#11488)
55d35e5521 Drop TLA+ from dev-env (#11492)
3a5cb18e7f [Self-service error codes] Adapt all grpc assertions to additionally take self-service error codes [DPP-680] (#11437)
98e7461fc5 LF: ContractInstance should be a CidContainer (#11487)
9afb3b36bd Add and wire ledger-end-cache [DPP-703] (#11480)
cdd2accc26 Explicitly import Java runtime from Nix/dadew (#11411)
b5540a9c3b Evidence for contract-key testing (#11479)
78735a8d27 Less logging on //docs:generate-error-codes-json (#11486)
d8898b8c80 Check fixed choices in name collision checker (#11481)
7a0198ba52 daml-react: allow for React 17 (#11463)
c415d9d1ee Migrate trigger tests from sandbox-classic to sandbox (#11478)
f9ec12be12 Add cocreature as a codeowner of the docs (#11450)
a79cc08687 DbDispatcher handles SQL exceptions with self-service error codes [DPP-690] (#11435)
164cdbbd7d update compat versions for 1.18.0-snapshot.20211026.8179.0.e474b2d1 (#11426)
741a6e75a7 interfaces: Add list of fixed choices in TemplateImplements structure. (#11364)
79505b5474 oracle debug (#11386)
257d5365c2 Switch from sandbox to sandbox-classic in daml test-script (#11476)
e91ced54f3 KV: generate self-service error docs [KVL-1148] (#11431)
8ffd835f24 Migrate daml script tests to Sandbox next (#11472)
df65d02c4e Exclude dedup tests affected by current changes (#11471)
45beaf7aac interfaces: typecheck for precond, haskell side. (#11468)
e445fe1aee LfEngineToApi conversions do not have to deal with version. (#11414)
d3712745e2 Sandbox-classic: contracts sent to the engine do not need enrichment (#11416)
05312f1ca0 Lift out constraint tuples to synonyms in dfun contexts (#11467)
a492a6cad0 [DPP-636] Update docs on MacOS firewall issue when running tests (#11460)
5a85881cfa rotate release duty after 1.18.0-snapshot.20211026.8179.0.e474b2d1 (#11422)
1096f9144b Adds default keepalive support for postgreSQL [DPP-697] (#11453)
379996348f Fix akka-streams shutdown at LedgerConfigurationSubscriptionFromIndex (#11462)
e89da7c1ed Move non-repudiation proxy conformance tests to their own package (#11464)
b98a3ade29 interfaces: precondition, scala ast, decoder/encoder (#11452)
fd973e6b86 Drop assistant integration tests for relative/absolute DAML_PROJECT (#11461)
05505e3d03 Multiplex multiple virtual query streams through a single web socket (#10221)
3098b70624 pretty print contract IDs properly (#11359)
bb4f4c5a40 DPP-665 Make in-flight commands configurable (#11456)
bf00956143 replace OneAnd party Sets with NonEmpty Set (#11420)
570160b718 Add LoggingValue instance for Time.Timestamp (#11444)
bad50a51e9 Type reexports explicitly use 'type' namespace (#11451)
d3b9c84908 ifaces: preconditions, proto changes (#11448)
73718a22fa Mark script export tests as flaky (#11449)
22e9e6b56e Multi-observer command submission in the ledger-api-bench-tool [DPP-660] (#11413)
3eacbf9d67 Bazel cache retry on connection reset by peer (#11445)
fcc7e581cf Make stable packages dependent on supported LF versions (#11382)
6c45f099bb Remove TODO (#11446)
d8b92b7c99 Drop flaky marker from lsp-tests (#11442)
68f44325a6 Improve evidence of testing (#11428)
6126fc2230 Remove append only prefix from conformance tests [KVL-1152] (#11424)
926655d3c3 Drop daml ledger timeout tests from compat tests (#11441)
15cb84093b Switch back to binary execution logs (#11440)
ac28e615b8 Update ScalaPB to the latest version (0.11.6) (#11409)
a71a8f999e Prevent overflow in DeduplicationPeriod (#11432)
6c88e55509 Pass submission id as correlation id to error codes in Ledger API (#11381)
ba106873b9 Replace 1.14 min version conformance test by custom test (#11433)
a600f75c9f Bump bazel memory limit to 3gb (#11436)
ebe742098d fix es ingest: file too large (#11415)
d86eca0b05 Add documentation annotations to KV self-service errors [KVL-1144] (#11385)
46d31d5d48 [DPP-676][Self-service error codes] Adapt ApiConfigManagementService (#11402)
927b2378c3 Make Oracle tests exclusive (#11408)
68d7f83a5f Switch bazel exec logs to json format (#11430)
12e782b1ea ifaces: update ghc-parser (#11383)
503e39160d [Short] Typo (#11410)
3031190994 [DPP-676][Self-service error codes] Adapt request validators (#11379)
b412f7191d Fix MonotonicRecordTimeIT for pruned participants (#11423)
500e5b068e release 1.18.0-snapshot.20211026.8179.0.e474b2d1 (#11421)
d678a4046d LF: remove type parameter from ContractInstance (#11419)
```
Changelog:
```
- [@daml/react] Our React bindings now request the `react` library as a
peer dependency, and will accept React 17 in addition to the current
React 16. For new projects, the `create-daml-app` template now uses
React 17.
- [Integration Kit] Document KV-specific self-service errors
[TS bindings] When using daml-react and daml-ledger, all streaming request to the query endpoint will be multiplexed through a single web socket.
[daml LF] - Add LoggingValue instance for Time.Timestamp
- [Integration Kit] - ledger-api-bench-tool can generate synthetic contracts with multiple observers
[api-test-tool] - remove AppendOnly prefix from test suites as the append-only schema is the only one left
```
CHANGELOG_BEGIN
CHANGELOG_END
Co-authored-by: Azure Pipelines Daml Build <support@digitalasset.com>
* ledger-offset: Add a conversion to ByteString.
I seem to be doing this a lot.
CHANGELOG_BEGIN
CHANGELOG_END
* ledger-offset: Add a conversion from ByteString.
DPP-695 is gift that keeps on giving and seems to also result in
timeouts here. Just marking all of our tests that depend on Sadbonx as
flaky doesn’t seem all that helpful so switch to a postgres-backed
sandbox instead.
changelog_begin
changelog_end
* iface: check for interface implementations precond
We change speedy to also check all preconditions defined in interface
implementations upon a create.
CHANGELOG_BEGIN
CHANGELOG_END
* Update daml-lf/interpreter/src/main/scala/com/digitalasset/daml/lf/speedy/Compiler.scala
Co-authored-by: Remy <remy.haemmerle@daml.com>
* format
* interfaces: lfconversion for iface preconditions
This adds interface preconditions to the interface implementations
during completion phase in the LF conversion.
CHANGELOG_BEGIN
CHANGELOG_END
* format
* rebase
Co-authored-by: Remy <remy.haemmerle@daml.com>
* Migrate trigger service tests to sandbox from sandbox-classic
CHANGELOG_BEGIN
CHANGELOG_END
* remove config override for EngineMode.Dev based on code review
* Pass `damlc build` logs through daml logger
This gives us some timings which can be useful in some
circumstances (I want timings around data-dependencies next).
I also changed the default log level to INFO. The `damlc build` output
doesn’t get any noisier from that.
Example output:
```
2021-11-01 15:25:17.16 [INFO] [build] []
Compiling foobar to a DAR.
2021-11-01 15:25:17.80 [INFO] [build] []
Created .daml/dist/foobar-0.0.1.dar
```
changelog_begin
changelog_end
* Adjust scenario service log level
changelog_begin
changelog_end
* Adjust tests
changelog_begin
changelog_end
* delete comment
changelog_begin
changelog_end
Ran into an issue on M1 and there has been some recent work around
that area. Not sure this actually fixes it but why not upgrade anyway.
changelog_begin
changelog_end
* Enable experimental nix command
Nix 2.4 got released which confusingly marked the nix command as
experimental despite it being actively worked on and being more stable
than before.
changelog_begin
changelog_end
* switch to CLI flag
changelog_begin
changelog_end
* Revert "switch to CLI flag"
This reverts commit 58d6a25d83.
After dropping type parameter from GenTransaction we do not
com.daml.lf.transaction.Transaction.Transaction type alias. We use
instead directly com.daml.lf.transaction.VersionedTransaction, wich is
anyway more informative.
CHANGELOG_BEGIN
CHANGELOG_END
* Adapt self-service error codes in conformance tests
* Assertions.assertGrpcError and assertGrpcErrorRegex assert self-service error codes based on feature descriptor
* Adapted all GRPC error assertions to expect self-service error codes as well
* Added TODO and exclusions list to conformance-test-self-service-error-codes in anticipation of some missing
self-service error codes implementation.
CHANGELOG_BEGIN
CHANGELOG_END
* Correct errorCode id assertion
* Fixed incorrect error assertion in CommandService
* Exclude entire KVCommandDeduplicationIT due to flakiness
* To be fixed in the subsequent PR
In #11419 we drop the implicit call that convert ContractInstance in
CidContainer. Thie is used by Canton and should be restore.
Note that now ContractInstance is not polymorphic anymore, hence we
can inherite CidContainer instead of defining an implicit.
CHANGELOG_BEGIN
CHANGELOG_END
* Add a simple cache implementation
* Add support for ReadOnlySqlLedgerWithMutableCache
* Add support for ReadOnlySqlLedgerWithTranslationCache
* Add support for sandbox-classic
changelog_begin
changelog_end
* Fix rules_scala Windows launcher
* Define nixpkgs_java_configure
To generate a java_runtime based on a Nix provided JDK similar to how it
is done with the Python and CC toolchain.
changelog_begin
changelog_end
* Enable Nix provided Java runtime on Linux and MacOS
* Define dadew_java_configure
To import a JDK and JAVA_HOME from dadew similar to
nixpkgs_java_configure.
* Enable dadew Java runtime on Windows
* Remove now unused java_home_runtime
Co-authored-by: Andreas Herrmann <andreas.herrmann@tweag.io>
* Split contract-key tests from engine tests, and mark for evidence.
CHANGELOG_BEGIN
CHANGELOG_END
* remove contract key tests from their original location
* evidence for unique/non-unique contract keys
* Check fixed choices in name collision checker
This is a follow up to #11364. This PR checks that the list of inherited
choice names is correct in the type checker, and moves the "fixed choice name
collision" check into the name collision checker using this data.
Haskell side only for now. Part of #11137.
changelog_begin
changelog_end
* Update compiler/daml-lf-tools/src/DA/Daml/LF/TypeChecker/Check.hs
Co-authored-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
Co-authored-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
See #11358.
CHANGELOG_BEGIN
- [@daml/react] Our React bindings now request the `react` library as a
peer dependency, and will accept React 17 in addition to the current
React 16. For new projects, the `create-daml-app` template now uses
React 17.
CHANGELOG_END
* Add cocreature as a codeowner of the docs
Currently we have no active codeowner of the docs which is an
unfortunate situation since PRs just end up sitting until someone
happens to find it or someone else asks for a ping.
Not necessarily saying I’m the right one to review all docs but I can
at least make sure PRs advance.
changelog_begin
changelog_end
* Update CODEOWNERS
Co-authored-by: Stefano Baghino <43749967+stefanobaghino-da@users.noreply.github.com>
* Update CODEOWNERS
Co-authored-by: Stefano Baghino <43749967+stefanobaghino-da@users.noreply.github.com>
* DbDispatcher handles transient and non-transient SQL exceptions with specific error codes
CHANGELOG_BEGIN
CHANGELOG_END
* Handle retries when verifying ledger id
* Addressed Pawel's comments
* Logging clean-up and small refactoring
* Exhaustive match against Oracle and PSQL exceptions
* Switch from sandbox to sandbox-classic in daml test-script
changelog_begin
changelog_end
* apparently sadbonx next also has ce and ee
changelog_begin
changelog_end
* Migrate daml script tests to Sandbox next
This does not yet drop all dependencies from daml script. In
particular `daml test-script` still depends on Sandbox classic. Will
tackle that in a separate PR.
changelog_begin
changelog_end
* Speedup maxInboundMessageSize tests
changelog_begin
changelog_end
