* Add link to support page (and indirectly to the support portal)
changelog_begin
changelog_end
* Update docs/source/support/support.rst
Co-authored-by: carrielaben-da <91496516+carrielaben-da@users.noreply.github.com>
Co-authored-by: carrielaben-da <91496516+carrielaben-da@users.noreply.github.com>
* Add HasField instances for DA.Stack.SrcLoc (#15142)
changelog_begin
[DA.Stack] The SrcLoc datatype now supports dot syntax for field access (#15142)
changelog_end
* Add daml-test-file SrcLocFields to test dot syntax on DA.Stack.SrcLoc
* Define 'HasField f SrcLoc t' instances using record syntax
* Additional security tests for Ledger API [DPP-1256]
CHANGELOG_BEGIN
CHANGELOG_END
* Additional security tests for Ledger API [DPP-1256]
CHANGELOG_BEGIN
CHANGELOG_END
* Segregates ContractStore (pulls out MaximumLedgerTimeService)
* Renames lookupContractForValidation to lookupContractStateWithoutDivulgence, and adds the contractInstance to the results
* Adds implementation for MaximumLedgerTime computation depending on lookupContractStateWithoutDivulgence
* Adds unit tests for the implementation
* Adapts/fixes other tests
* Removes original MaximumLedgerTime implementation from MutableCacheBackedContractStore
CHANGELOG_BEGIN
CHANGELOG_END
* turn on -Xlint -Werror for Java bindings
* remove unused locals
* remove raw casts for deprecated Record
* fix rawtypes
* don't check for serialVersionUID
* some javadoc for DefinedDataType
* add lint to bindings-rxjava; deprecate ledger identity client
* document DamlRecord
* fix rawtypes in Java codegen output
* fix unused cast in Java codegen output
* enable -Xlint for Java codegen output
CHANGELOG_BEGIN
- [Java codegen] Now outputs code that should pass ``-Xlint:rawtypes``
as well as other ``-Xlint`` warnings.
CHANGELOG_END
* note that makeExerciseCmd is not for application use
* notes on Contract, *Companion
* doc View type parameter
* fromContractId is also internal API
CHANGELOG_BEGIN
CHANGELOG_END
* Extract encodeVariant
* Add special case for encoding record members of variants
* Test special case for encoding record members of variants
* Test variant records in 'daml ledger export' golden test 'export-values'
* Update TODOs
* Add comments for untested cases in export-values golden test
changelog_begin
- [Daml export] Fixed an issue with the handling of sums-of-products (#14723)
changelog_end
* On Dispatcher cancel, fail sources with distinct throwables
changelog_begin
Fixes an issue where failing multiple sources with the same StatusRuntimException
leads to an unhandled error in the gRPC serialization layer. This issue was
caused by serialization actually mutating the non-thread-safe io.grpc.Metadata
contained in the StatusRuntimeException.
changelog_end
* Fix ApiVersionService internalError
* Log error on ServerCall.close() errors
* Address Sergey's review comments
* Addressed more review comments
* Accessor method for call.close to bypass IllegalAccessErrors
* Use unique kill switches per stream in generated Akka Grpc streaming services
This change has two benefits:
- The error is logged only on an actual stream termination
- The throwable is not shared between streams, avoiding concurrent Metadata access errors
* Addressed Marton's review comments
* passed value decoder to interface Companion
CHANGELOG_BEGIN
CHANGELOG_END
* throw IllegalArgumentException if view type not found for an interface
CHANGELOG_BEGIN
CHANGELOG_END
* address comments
* test
* test
Co-authored-by: Chun Lok Ling <lokling@gmail.com>
* drop payload and key instead of passing through
* build a "hidden" dar with a new template for build-and-lint-test
* test the events that come back; passing
* test key and that template is definitely not registered
* confirm test fails without changes to @daml/ledger
✕ undecodable exercise result event data is discarded (334 ms)
● interfaces › undecodable exercise result event data is discarded
Failed to look up template 24124e8b5ae6c7f06835529d5b7338ed32308cdcb6409ba72f88351da9145ff1:Hidden:NotVisibleInTs. Make sure your @daml/types version agrees with the used Daml SDK version.
at lookupTemplate (../../../../language-support/ts/daml-types/index.ts:269:11)
at ../../../../language-support/ts/daml-ledger/index.ts:196:59
at ../node_modules/@mojotech/json-type-validation/src/decoder.ts:795:31
at Result.andThen (../node_modules/@mojotech/json-type-validation/src/result.ts:130:19)
at Decoder.decode (../node_modules/@mojotech/json-type-validation/src/decoder.ts:795:7)
at Decoder.decode (../node_modules/@mojotech/json-type-validation/src/decoder.ts:312:37)
at Decoder.decode (../node_modules/@mojotech/json-type-validation/src/decoder.ts:501:31)
at decodeValue_1 (../node_modules/@mojotech/json-type-validation/src/decoder.ts:371:68)
at ../node_modules/@mojotech/json-type-validation/src/decoder.ts:375:65
at Array.reduce (<anonymous>)
CHANGELOG_BEGIN
- [JS codegen] Exercise no longer fails on unrecognized templates occurring in
create/archive events resulting from an exercise, such as may happen when
exercising interface choices; instead, any such "uninterpretable creates" have
their payloads changed to ``{}`` and their keys removed.
CHANGELOG_END
* use Consume.syntax
* added exercise in interface "sub query endpoint" test case. checked template id of archive. it is asserting to be template id but not interface id which is wrong. I will change it back to interface id after all CI passed
* test that the archive events have the interface ID; add the template-ID-to-interface-ID mapping to archive events in websocket result stream
* Add change log
CHANGELOG_BEGIM
CHANGELOG_END
* Add change log
CHANGELOG_BEGIN
CHANGELOG_END
* use JSON converter instead of hand-writing JSON
* factor assertions for created records
* combine value assertions
Co-authored-by: Stephen Compall <stephen.compall@daml.com>
* Point to latest GHC with archive choices on interfaces
* Update Desugared daml for interfaces Archives
* satisfy changelog check
CHANGELOG_BEGIN
CHANGELOG_END
* Update daml-doc test files
* Add relevant identifiers to SignatureReaderSpec for iface Archive choice
* lint
* Point to GHC with generated HasArchive instance
* Add test for archive on interface
* Test that second archive doesn't work
* Update desugar tests
* Point to GHC merge
* FromValue Interface
* add deprecated and new fromvalue method
* debug log
* added apply
* no semicolon
* colon
* fix VariantConstructorClass
* fix VariantConstructorClass
* fix VariantConstructorClass
* fix VariantConstructorClass
* fix test cases
* add changelog
CHANGELOG_BEGIN
CHANGELOG_END
* For template, use the fromValue in contract companion
* Added private value decoder method for passing in to contract companion
* WIP
* move variant sub type decoder method to the base variant class
* remove debug log
* don't call deprecated value
* pass value decoder instead of lambda
* move PrimitiveValueDecoders to codegen package
* rename from FromValue to ValueDecoder
* rename from method fromValue to valueDecoder
* extract isVariantRecord
* remove unused import
* added java doc for valueDecoder method
* format
* address comments
* address comments
TLDR: Remove broken code which constructs stackTrace().
Happy never to have to read those NOTE(MH) comments in the pushLocation code again!
(1) This code was fundamentally broken for various reasons:
- It doesn't make sense to track location info on the continuation stack. The continuation stack is a record of the evaluation still to come; not a context for the current evaluation.
- Stack traces can't sensibly be provided in a language such as Daml which promises that tail-recursion is evaluated in constant stack-space.
- Attempting to keep location info on the continuation stack does not play well when exceptions are thrown and the stack is unwound.
(2) The stack-trace management code was also very hacky:
- The pushLocation code contained special cases when the continuation stack was headed by a KArg/SToken continuation. This is an internal implementation detail. The KArg doesn't even exist when we stop using the deprecated SEAppGeneral expression constructor.
- The pushLocation code also contained special support for copying stack-traces into SEVal and SDefinition caches, and then later back on to the continuation stack. Yuck!
(3) The stackTrace() code was barely used:
- Some time ago an alternative/simpler location tracking system (lastLocation) was implemented.
- Only ScenarioRunner makes use of the stackTrace()
- Only a single test changes behaviour when we drop use of stackTrace() in favour of getLastLocation
* use Objects.equals instead
CHANGELOG_BEGIN
CHANGELOG_END
* add () back
* specfy type of object to avoid java.io.Serializable being inferred which wartremover doesn't like it
* remove warnings
* address Stephen's comment
* address Stephen's comment
* Add test for typesignature.add codelens with HasField
* Reexport class HasField from DA.Internal.RebindableSyntax
* Update expected signature in test for typesignature.add codelens with HasField
changelog_begin
- [Daml Studio] Suggested type signatures no longer qualify HasField typeclass
See `#13790 <https://github.com/digital-asset/daml/issues/13790>`__.
changelog_end
* Update expected error in RelTimeDetailsHidden1 daml-test-file
@akrmn is taking care of [testing](https://github.com/digital-asset/daml/blob/main/release/RELEASE.md) today's release, so they get pushed back to the end of the line.
Please do not merge this before the release is fully tested.
CHANGELOG_BEGIN
CHANGELOG_END
Co-authored-by: Azure Pipelines Daml Build <support@digitalasset.com>
