* Fix compat tests for 2.0.0
We also killed our automation by making the releases from the assembly repo.
changelog_begin
changelog_end
* .
changelog_begin
changelog_end
* .
changelog_begin
changelog_end
* allocate public party
changelog_begin
changelog_end
Process:
- `git ls-files | xargs sed -i 's/DAML/Daml/g'`
- `git add -p`
To review:
- Check for false positives by carefully reviewing the diff in this PR.
- Check for false negatives with `git grep DAML`.
CHANGELOG_BEGIN
- Removed all traces of DAML. This may affect error messages and debug
outputs.
CHANGELOG_END
* Add Oracle compatibility tests
changelog_begin
changelog_end
* Clean up
* Remove debug change
* Skip Oracle tests if there is nothing to do
* Add missing line warp
* Use ORACLE_PORT
Co-authored-by: mziolekda <marcin.ziolek@digitalasset.com>
Co-authored-by: mziolekda <marcin.ziolek@digitalasset.com>
* Move //ledger/ledger-api-test-tool to //ledger/ledger-api-tests/tool.
And conformance.bzl to //ledger/ledger-api-tests.
* Move test tool infra to //ledger/ledger-api-tests/infrastructure.
* Split the ledger API test tool into smaller libraries.
There is no change to behavior.
CHANGELOG_BEGIN
CHANGELOG_END
* ledger-api-tests: Encapsulate performance tests.
* ledger-api-tests: Extract a "runner" library.
* ledger-api-tests: Publish libraries to Maven Central.
* ledger-api-tests: Fix Scaladoc so it compiles correctly.
Unfortunately I had to remove some Scaladoc in ActiveContractsServiceIT
which is incorrectly interpreted as not being attached to anything.
Fortunately, it's not actually that helpful.
* compatibility: Fix paths to the Ledger API Test Tool.
* Fix release types for ledger API test libraries.
* test-common: Publish generated Scala.
These libraries are dependencies of the ledger API tests components.
* ledger-api-tests: Use "com.daml" as the group ID everywhere.
* ledger-api-tests: Check that tests in `--additional` are valid.
* compatibility: Fix a reference to ledger-api-test-tool I missed.
* Remove the possibility to turn on legacy error codes
CHANGELOG_BEGIN
- Switching to the legacy error codes is not possible.
CHANGELOG_END
* Revert breaking experimental features proto definitions
* Deprecate legacy error codes in proto definitions
* Proper todo naming
* Adjust compatibility tests
* Fix unintentional paste
Somehow left this in accidentally.
Perhaps surprisingly it is harmless since we call this before we
enable `set -e` and the command fails but it is extremely confusing.
changelog_begin
changelog_end
* create-daml-app: Use alias templates for display names
We introduce Alias contracts to the create-daml-app Daml model and use
them to display aliases in the UI instead of party identifier strings.
CHANGELOG_BEGIN
CHANGELOG_END
* fix tests
* addressing review
* Add comments to Setup.daml
* factor out alias to option conversion
CHANGELOG_BEGIN
CHANGELOG_END
* small fix in setup.daml
* replace user dropdown with input in login screen
* fix compatibility tests
* fix alias loading flick in mainscreen
* remove canton incompatible sandbox options from daml.yaml
* fix gsg-trigger.patc
* Move some daml-script compat tests to sandbox-on-x
The new sandbox doesn't accept LF < 1.14, so move those cases to
sandbox-on-x.
changelog_begin
changelog_end
* add comment
* buildifier
* ledger-api-test-tool: Enable command deduplication tests by default.
CHANGELOG_BEGIN
- [Ledger API Test Tool] More command deduplication tests have been
enabled by default. This should not affect testing a fully functioning
ledger. If any tests fail, they can be temporarily excluded.
CHANGELOG_END
This fixes the timeout on trigger compat tests for the new sandbox (with LF >= 1.14).
The issue was that the trigger was "readAs"-ing with a party that
doesn't exist, since party ids aren't predictable with the new sandbox.
The solution is to allocate the Alice party ahead of time, and then
pass the allocated party in when calling `daml trigger`.
changelog_begin
changelog_end
* ledger-api-test-tool: Enable `ParticipantPruningIT` for everyone.
CHANGELOG_BEGIN
- [Ledger API Test Tool] The ``ParticipantPruningIT`` test case has
been enabled by default. You may need to disable specific test cases
accordingly.
CHANGELOG_END
run-full-compat: true
* Enable more ParticipantPruningIT tests across the board.
* ledger-api-test-tool: Exclude a multi-participant test by default.
The test, `PRImmediateAndRetroactiveDivulgence`, will now only run if
more than one participant is specified.
* ledger-api-test-tool: Use a `for` comprehension for readability.
Co-authored-by: tudor-da <tudor.voicu@digitalasset.com>
Co-authored-by: tudor-da <tudor.voicu@digitalasset.com>
Part of #11831. This kills another two uses of sandbox-kv.
Also fixes a daml-helper issue where we weren't passing "localhost" to the
ledger flags, so it was complaining about starting outside of a project.
changelog_begin
changelog_end
* ledger-api-test-tool: Rename "ParticipantFeature" to "Features".
* ledger-api-test-tool: Govern ContractIdIT test runs through a feature.
Rather than making it optional, we can expose a feature that instructs
whether we support certain kinds of contract IDs.
This accidentally works for Canton too as it defaults to "false" for
both options, which holds for Canton.
CHANGELOG_BEGIN
- [Ledger API Test Tool] The "ContractIdIT" test is now run by default,
using ledger feature flags to determine which test cases are run. You
will need to configure the ``StandaloneApiService`` accordingly.
CHANGELOG_END
* ledger-api: Add some documentation to `ContractIdFeatures`.
* compatibility: Update for ContractIdIT.
run-full-compat: true
* ledger-api: Clarify the contract ID features and remove v0 support.
We also remove the tests for v0 contract IDs from ContractIdIT.
* ledger-api-test-tool: Re-introduce tests for v0 contract IDs.
* ledger-api-test-tool: Case class with named parameters in ContractIdIT.
* ledger-api: All ledgers must support suffixed contract IDs.
* compatibilty: Add a start for ContractIdIT.
We can't exclude a test until it exists.
run-full-compat: true
Rather than switching to sandbox-classic for older ledger API test
tool versions we just want to exclude them completely but apparently
I’m too stupid for boolean logic.
changelog_begin
changelog_end
* Rename daml sandbox to daml sandbox-kv
Also drop the default sandbox on `daml start`
Part of #11831
changelog_begin
changelog_end
* update release test instructions
* try to fix a couple compat tests
* dont need special 0.0.0 logic
* buildifier-fixx
* Switch ledger-api-test-tool compat tests to sandbox on x
This only works for HEAD right now not releases because we don’t yet
have a release with sandbox on x. Will fix that on the next snapshot.
It also doesn’t migrate everything. I’ll migrate the other tests in
separate steps.
changelog_begin
changelog_end
* fix windows maybe
changelog_begin
changelog_end
* Fix more stuff
changelog_begin
changelog_end
* and even more stuff
changelog_begin
changelog_end
* .
changelog_begin
changelog_end
* .
changelog_begin
changelog_end
* .
changelog_begin
changelog_end
* Update compatibility/bazel_tools/testing.bzl
Co-authored-by: tudor-da <tudor.voicu@digitalasset.com>
Co-authored-by: tudor-da <tudor.voicu@digitalasset.com>
* Fix compat test exclusions
Old versions don’t have those tests so we cannot exclude it.
changelog_begin
changelog_end
* more fixes
changelog_begin
changelog_end
* Clarify unhandled exception error message
The previous error doesn’t make it clear that this is an exception in
user code rather than a Scala exception in our code.
Daml-lf exception would technically be more correct but I don’t think
it’s helpful here so I went with Daml exception.
changelog_begin
changelog_end
* adjust ledger api test tool
changelog_begin
changelog_end
* Update test assertions
changelog_begin
changelog_end
* fix another assertion
changelog_begin
changelog_end
changelog_begin
[ledger-api-test-tool] - Merge command deduplication ledger API tests (`KVCommandDeduplicationIT`, `CommandDeduplicationIT`) into a single suite(`CommandDeduplicationIT`) which uses feature descriptors to handle different participant behaviors
changelog_end
Somewhat error-prone, so please review carefully.
Reasons we need this:
- Some file types are not properly handled by the script.
- The only exclusion mechanism we currently have (`NO_AUTO_COPYRIGHT`)
is overly coarse.
CHANGELOG_BEGIN
CHANGELOG_END
New year, new copyright, new expected unknown issues with various files
that won't be covered by the script and/or will be but shouldn't change.
I'll do the details on Jan 1, but would appreciate this being
preapproved so I can actually get it merged by then.
CHANGELOG_BEGIN
CHANGELOG_END
changelog_begin
ledger-api - Remove validation for duration deduplication periods, which was validating that the deduplication duration is smaller than the max deduplication duration. This is now up to the ledger to enforce.
changelog_end
* [Self-service error codes] Enabled by default
* Flag changed to `use-pre-1.18-error-codes` (disabled by default)
CHANGELOG_BEGIN
[Ledger API Specification] The Ledger API returns enriched error codes (see https://docs.daml.com/error-codes/self-service/index.html)
For backwards-compatibility, a new API flag `--use-pre-1.18-error-codes` is introduced for preserving the legacy behavior for
clients that want to migrate incrementally to the changed gRPC status code responses and error details format.
CHANGELOG_END
* Adapted HttpServiceIntegrationTest
* Renamed `Feature Flag` to `Configuration` in docs
* Fix Daml Script tests
changelog_begin
changelog_end
* Fix Repl functests
changelog_begin
changelog_end
* Fix haskell binding tests
changelog_begin
changelog_end
* Fix CommandClientIT test
* Fixed Sandbox and CommandServiceBackpressureIT tests
Please enter the commit message for your changes. Lines starting
* Adapt //compiler/damlc/tests:repl-functests again
* Fix more tests and address Miklos' comments
* Flag name changed to `grpc-status-codes-compatibility-mode`
* Remove useless flags sandbox-classic
* Sandbox-classic tests fix for ContractKeysIT and ExceptionsIT
* Created 2 deprecated test suites that have the more generic assertions as returned
by the deprecated in-memory backend
* More fixes for CommandServiceIT
* Fixes compilation issue with the deprecated exceptionsIT class for Sandbox-classic in-memory
* Compatibility mode for old test tools
* Change flag name to `use-pre-1.18-error-codes`
* Apply suggestions from code review
Co-authored-by: Miklos <57664299+miklos-da@users.noreply.github.com>
Co-authored-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
Co-authored-by: Miklos <57664299+miklos-da@users.noreply.github.com>
CHANGELOG_BEGIN
kvutils - The deduplication duration passed in the command is now used for command deduplication, and is no longer always overwritten with the max deduplication duration. The command deduplication duration can still be extended by the committer to account for time skews.
CHANGELOG_END
* Use error validators in ApiPackageManagementService
CHANGELOG_BEGIN
CHANGELOG_END
* Exclude PackageManagementServiceIT from compatibility tests after 1.17
CHANGELOG_BEGIN
CHANGELOG_END
