I _believe_ this is what has been tripping up the check-releses job for
the past few days: while updating the signing key, I did not update the
key fingerprint to match, and therefore trying to check any signature
fails.
The failure mode of the existing script is still pretty bad, regadless:
looping on the same release until the hard drive is full is definitely
not expected. Our retry policies are supposed to have time bounds, and
failure should result in cleaning up the workdir.
run-full-compat: true
* Retire changelog entries mechanism
It is no longer used these days, so it simply imposes unnecessary
work. If it ever becomes useful again, retrieving the relevant
scripts from history should be relatively easy.
* Remove references to `unreleased.sh`
* Re-add `unreleased.sh` for summarization -- feedback from @mziolekda`
This is very much a "just make it work" type of patch. The main issues
were:
- A bunch of type errors in the `index.test.ts` file when opened in VS
Code. I'm not sure how it happened, but it's possible I'm just using a
more recent TS compiler than whoever edited this last.
- `localhost`, on my machine at least, resolves to `::1`, and therefore
the connections were just not established. I've opted for replacing
`localhost` with explicit `127.0.0.1`.
- `npm-cli.js` was not an executable in my `PATH`, and won't be for
most users, but `npm` is not on our testing infrastructure's `PATH`.
Those tests are obviously not tested by CI, so please review carefully /
test this on your own machine before approving.
CHANGELOG_BEGIN
CHANGELOG_END
From output of currently failed jobs:
```
The key 'detect.npm.dependency.types.excluded' in property source
'commandLineArgs' contained a value that could not be reasonably
converted to the properties type. The exception was: Unable to parse raw
value 'NON_PRODUCTION' and coerce it into type 'NoneEnum or
NpmDependencyType'. Value was must be one of NONE,DEV,PEER
```
It looks like I was a bit overeager on #14995.
CHANGELOG_BEGIN
CHANGELOG_END
In #14622, I inadvertently changed the artifact names from using `macos`
to using `macOS`, which may break any number of external references,
from Canton's dependency (which is how I found out) to the assembly
script and the `daml install` command. This reverts that.
CHANGELOG_BEGIN
CHANGELOG_END
- The `check_releases` job seems to take between 4.5h and `TIMEOUT`
these days, with no clear cause for the large span in running time.
Hopefully bumping the limit from 4.5 to 8 hours will give us some
breathing room (this is not by any means a long-term solution, I'm well
aware of that).
- I couldn't find anybody who seemed to care about running the
create-daml-app compatibility tests on macOS, and they're super flaky
(typically requiring 5 reruns to succeed).
CHANGELOG_BEGIN
CHANGELOG_END
run-full-compat: true
After discussion with the team, we've reached the conclusion that the
JSON API is not changing enough for these performance tests to bring
much value: we're not in a situation where we think there's a high risk
of performance regressions, nor trying to focus on performance
improvements.
Note that this is only removing the tests from the daily run; the team
does see value in keeping the code for these tests around in case any
performance-focused work does arise in the future.
(This PR also disables running the `check_releases` job outside of main
branch runs, because there's really never been a good reason to.)
Fixes#14608.
CHANGELOG_BEGIN
CHANGELOG_END
run-full-compat: true
Since yesterday, this test is failing with an OOM error. I hoped I'd
have time to investigate today, but since I didn't and I'm off next week
disabling the test for now seems like the best option to let the overall
daily tests succeed.
The last known success was on 0bf28176a7,
and the first failure was on 444fff1fcf.
We don't test every commit, so any commit in-between could be the cause
of the issue.
Note that the failure does not seem to be flaky, but further testing may
be warranted.
CHANGELOG_BEGIN
CHANGELOG_END
CHANGELOG_BEGIN
- The base image used by the `digitalasset/daml-sdk` Docker image has
been bumped from Ubuntu Focal to Ubuntu Kinetic. Please remember that
this image is meant for demonstration purposes only and is not supported
for use in any kind of production setup.
CHANGELOG_END
There were two issues:
1. The `Directory.listFilesRecursive` function returns paths that
include its first argument, so there was never any overlap between
the sets.
2. That full path doesn't exist on AWS, and was given to AWS because
`s3Path opts f` returns just `f` if it starts with `/`.
This means that, on the one hand, the script tried to delete
_everything_ from the top-level, which is a bit bad, but, on the other
hand, the script did not actually manage to delete anything at all,
which is basically the status quo.
Note that deleting everything isn't _that_ bad as we reupload right
after and we have a cache in front on the site, so this would only
impact users if they were the first to try and view a given page in that
small time window between deletion and reupload.
This PR should fix both issues by removing the version-specific prefix.
CHANGELOG_BEGIN
CHANGELOG_END
There's a small, subtle bug that made its way into #14287: apparently
`/dev/stdout` is not defined on CI.
On the bright side, we don't actually need the `out` parameter, so
removing it seems like the easiest fix here.
CHANGELOG_BEGIN
CHANGELOG_END
* Merge ci/cron/wednesday.yml open_pr function into ci/bash-lib.yml
* remove unused function reset from ci/cron/wednesday.yml
* Request review from current release person for rotation PR
changelog_begin
changelog_end
The check_releases job has been a major player in the flakiness of the
daily test lately, simply by _timing out_ despite its 6h limit.
There are smarter, more "permanent" fixes we could implement here, but
as a quick stopgap measure I wanted to try out how much faster we would
go if we didn't need to reestablish a GCloud identity for each file.
CHANGELOG_BEGIN
CHANGELOG_END
run-full-compat: true
After yet another report of a ghost file, I stared at the code even
harder than before and finally figured out what was going wrong (or at
least one way it was going wrong): `listDirectory` is not recursive, so
the current code would only delete top-level files.
Hopefully this fixes that. I'll try to do some manual cleanup too.
CHANGELOG_BEGIN
CHANGELOG_END
This adds parameters to the "split release" job. At the moment, when
run, the job just builds the current commit with a snapshot version.
With this change, we'll be able to build a split release for any commit
with any version tag.
The reason for this change is we want to trigger this job from the
assembly repo, to reduce the number of manual interventions needed in
the release process.
CHANGELOG_BEGIN
CHANGELOG_END
It looks like the default image changed from Focal to Jammy, and for
whatever reason that completely breaks `curl`.
This pins us to Focal (for better or worse).
CHANGELOG_BEGIN
CHANGELOG_END
Azure is telling us to stop using 2019, so I've updated the job to be
compatible with 2022. (And future Windows images, too.)
CHANGELOG_BEGIN
CHANGELOG_END
This PR collects and pushes to Artifactory the dependencies of the
sphinx-source-tree target. This is a first step in moving the actual
source tree to the docs repo.
CHANGELOG_BEGIN
CHANGELOG_END
With the new 2.0.0 release process, we're not releasing from the main CI
build anymore, so the compat update PRs are not getting created.
This restores that by making those PR creations part of the daily CI
build.
CHANGELOG_BEGIN
CHANGELOG_END
* Add parens around 'fromAnyException' view pattern in '_tryCatch' desugaring
* Add parens around desugared 'setField' calls and around its first argument.
* Update desugaring golden files
* Add golden test for parens around 'setField' in renamed daml
changelog_begin
changelog_end
- Add notifications so I don't miss te updates.
- Add explicit `fetch` so we can detect if the same branch already
exists.
- Run from `main` so we geet a fresh view in case of reruns.
CHANGELOG_BEGIN
CHANGELOG_END
The installer is now created in the assembly repo. Keeping the code
around here is just confusing.
Note that this should not impact our ability to publish patch releases
on pre-2.0 versions, as all of the files involved are non-yml.
CHANGELOG_BEGIN
CHANGELOG_END
The release process for 2.1.0 is ongoing. I think it's safe to say at
this point if we need to change the RC we'll do it with backports.
CHANGELOG_BEGIN
CHANGELOG_END
After 2.0, the docs need to be built alongside Canton files, and that is
taken care of by the [docs.daml.com] repo.
[docs.daml.com]: https://github.com/digital-asset/docs.daml.com
CHANGELOG_BEGIN
CHANGELOG_END
* ghc-lib:remove unused let bindings
This updates ghc-lib, such that no unused let bindings are created in
Archive choices.
Fixes#13431.
CHANGELOG_BEGIN
CHANGELOG_END
* update ghc-lib hash
* Update of InterfaceDesugared.daml
