Commit Graph

159 Commits

Author SHA1 Message Date
Moritz Kiefer
97db5aca2f
Switch compat tests over to sandbox on x (#12716)
* Switch compat tests over to sandbox on x

changelog_begin
changelog_end

* .

changelog_begin
changelog_end

* .

changelog_begin
changelog_end

* .

changelog_begin
changelog_end

* .

changelog_begin
changelog_end

* .

changelog_begin
changelog_end

* .

changelog_begin
changelog_end

* .

changelog_begin
changelog_end

* .

changelog_begin
changelog_end

* .

changelog_begin
changelog_end

* .

changelog_begin
changelog_end

* .

changelog_begin
changelog_end

* .

changelog_begin
changelog_end
2022-02-03 11:32:33 +01:00
Moisés Ackerman
e4764cc426
Upgrade to GHC 9.0.2 (#12300)
changelog_begin
changelog_end

Co-authored-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
2022-02-01 11:27:11 +01:00
nicu-da
182edde951
[compatiblity tests] Limit the exclusion to versions that have the CommandDeduplication:Participant* tests (#12660) 2022-01-31 07:20:38 -08:00
tudor-da
cfa8d30491
[Sandbox-on-X] Ledger-side in-memory command deduplication [DPP-872] (#12596)
* [Sandbox-on-X] Ledger-side in-memory command deduplication

changelog_begin
changelog_end

* Enirched SequenceSpec test

* Participant-side deduplication compatibility tests exclusions

* Fix LedgerConfigurationServiceIT

* Disable command deduplication tests for SoX without conflict checking

* Remove redundant max-dedup-seconds bridge config

* Default max deduplication time 5 minutes

* Deduplication queue length metrics

* Add back removed ledger config test in SequenceSpec
2022-01-28 11:42:25 +00:00
Sofia Faro
613e0709f0
Wrap client instead of runner in script test (#12630)
I also added a couple debug statements in the script so I can have piece of mind that the script is actually running.

changelog_begin
changelog_end
2022-01-27 16:58:39 +00:00
Robin Krom
345e26790c
create-daml-app: Use alias templates for display names (#12390)
* create-daml-app: Use alias templates for display names

We introduce Alias contracts to the create-daml-app Daml model and use
them to display aliases in the UI instead of party identifier strings.

CHANGELOG_BEGIN
CHANGELOG_END

* fix tests

* addressing review

* Add comments to Setup.daml

* factor out alias to option conversion

CHANGELOG_BEGIN
CHANGELOG_END

* small fix in setup.daml

* replace user dropdown with input in login screen

* fix compatibility tests

* fix alias loading flick in mainscreen

* remove canton incompatible sandbox options from daml.yaml

* fix gsg-trigger.patc
2022-01-27 14:07:39 +01:00
Sofia Faro
53edac1fd7
Move some daml-script compat tests to sandbox-on-x (#12595)
* Move some daml-script compat tests to sandbox-on-x

The new sandbox doesn't accept LF < 1.14, so move those cases to
sandbox-on-x.

changelog_begin
changelog_end

* add comment

* buildifier
2022-01-26 17:43:34 +00:00
Sofia Faro
deb7f3a628
Move some trigger compat tests to sandbox-on-x (#12598)
changelog_begin
changelog_end
2022-01-26 13:41:56 +00:00
Samir Talwar
3366c6f39b
compatibility: Exclude another command deduplication test. (#12592)
CHANGELOG_BEGIN
CHANGELOG_END
2022-01-26 11:35:50 +00:00
Samir Talwar
ac3ca1d20c
ledger-api-test-tool: Enable command deduplication tests by default [KVL-1261] (#12541)
* ledger-api-test-tool: Enable command deduplication tests by default.

CHANGELOG_BEGIN
- [Ledger API Test Tool] More command deduplication tests have been
  enabled by default. This should not affect testing a fully functioning
  ledger. If any tests fail, they can be temporarily excluded.
CHANGELOG_END
2022-01-25 12:51:45 +01:00
Sofia Faro
8692d80b33
Fix trigger compat test for canton sandbox (#12549)
This fixes the timeout on trigger compat tests for the new sandbox (with LF >= 1.14).

The issue was that the trigger was "readAs"-ing with a party that
doesn't exist, since party ids aren't predictable with the new sandbox.

The solution is to allocate the Alice party ahead of time, and then
pass the allocated party in when calling `daml trigger`.

changelog_begin
changelog_end
2022-01-24 12:24:33 +00:00
Samir Talwar
4d26f0899e
ledger-api-test-tool: Enable ParticipantPruningIT for everyone. [KVL-1261] (#12529)
* ledger-api-test-tool: Enable `ParticipantPruningIT` for everyone.

CHANGELOG_BEGIN
- [Ledger API Test Tool] The ``ParticipantPruningIT`` test case has
  been enabled by default. You may need to disable specific test cases
  accordingly.
CHANGELOG_END

run-full-compat: true

* Enable more ParticipantPruningIT tests across the board.

* ledger-api-test-tool: Exclude a multi-participant test by default.

The test, `PRImmediateAndRetroactiveDivulgence`, will now only run if
more than one participant is specified.

* ledger-api-test-tool: Use a `for` comprehension for readability.

Co-authored-by: tudor-da <tudor.voicu@digitalasset.com>

Co-authored-by: tudor-da <tudor.voicu@digitalasset.com>
2022-01-21 16:16:57 +00:00
Samir Talwar
f5d7821ace
compatibility: Disable MultiParticipantIT for old versions. (#12526)
They don't support the `definite_answer` gRPC error metadata entry.

CHANGELOG_BEGIN
CHANGELOG_END
2022-01-21 16:08:14 +01:00
Sofia Faro
a5f56e0671
Use canton sandbox in script+trigger compat tests (#12514)
Part of #11831. This kills another two uses of sandbox-kv.

Also fixes a daml-helper issue where we weren't passing "localhost" to the
ledger flags, so it was complaining about starting outside of a project.

changelog_begin
changelog_end
2022-01-20 17:10:11 +00:00
Samir Talwar
f03fa6a5f1
ledger-api-test-tool: Govern ContractIdIT test runs through a feature. (#12454)
* ledger-api-test-tool: Rename "ParticipantFeature" to "Features".

* ledger-api-test-tool: Govern ContractIdIT test runs through a feature.

Rather than making it optional, we can expose a feature that instructs
whether we support certain kinds of contract IDs.

This accidentally works for Canton too as it defaults to "false" for
both options, which holds for Canton.

CHANGELOG_BEGIN
- [Ledger API Test Tool] The "ContractIdIT" test is now run by default,
  using ledger feature flags to determine which test cases are run. You
  will need to configure the ``StandaloneApiService`` accordingly.
CHANGELOG_END

* ledger-api: Add some documentation to `ContractIdFeatures`.

* compatibility: Update for ContractIdIT.

run-full-compat: true

* ledger-api: Clarify the contract ID features and remove v0 support.

We also remove the tests for v0 contract IDs from ContractIdIT.

* ledger-api-test-tool: Re-introduce tests for v0 contract IDs.

* ledger-api-test-tool: Case class with named parameters in ContractIdIT.

* ledger-api: All ledgers must support suffixed contract IDs.

* compatibilty: Add a start for ContractIdIT.

We can't exclude a test until it exists.

run-full-compat: true
2022-01-19 22:40:12 +01:00
azure-pipelines[bot]
96f454acdd
update compat versions for 1.18.1 (#12430)
* update compat versions for 1.18.1

CHANGELOG_BEGIN
CHANGELOG_END

* fix exclusions

changelog_begin
changelog_end

Co-authored-by: Azure Pipelines DAML Build <support@digitalasset.com>
Co-authored-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
2022-01-19 17:40:18 +00:00
Moritz Kiefer
9518f15408
Fix sandbox on x compat test switch (#12478)
Rather than switching to sandbox-classic for older ledger API test
tool versions we just want to exclude them completely but apparently
I’m too stupid for boolean logic.

changelog_begin
changelog_end
2022-01-19 13:51:09 +01:00
Sofia Faro
e40c221b8e
Fix compatibility tests. (#12465)
changelog_begin
changelog_end
2022-01-19 08:11:37 +00:00
Sofia Faro
a0aee0f248
Rename daml sandbox to daml sandbox-kv (#12394)
* Rename daml sandbox to daml sandbox-kv

Also drop the default sandbox on `daml start`

Part of #11831

changelog_begin
changelog_end

* update release test instructions

* try to fix a couple compat tests

* dont need special 0.0.0 logic

* buildifier-fixx
2022-01-17 10:36:06 +00:00
Moritz Kiefer
846bc385f8
Switch ledger-api-test-tool compat tests to sandbox on x (#12393)
* Switch ledger-api-test-tool compat tests to sandbox on x

This only works for HEAD right now not releases because we don’t yet
have a release with sandbox on x. Will fix that on the next snapshot.

It also doesn’t migrate everything. I’ll migrate the other tests in
separate steps.

changelog_begin
changelog_end

* fix windows maybe

changelog_begin
changelog_end

* Fix more stuff

changelog_begin
changelog_end

* and even more stuff

changelog_begin
changelog_end

* .

changelog_begin
changelog_end

* .

changelog_begin
changelog_end

* .

changelog_begin
changelog_end

* Update compatibility/bazel_tools/testing.bzl

Co-authored-by: tudor-da <tudor.voicu@digitalasset.com>

Co-authored-by: tudor-da <tudor.voicu@digitalasset.com>
2022-01-13 15:47:04 +01:00
Moritz Kiefer
9513c64b7e
Fix compat test exclusions (#12378)
* Fix compat test exclusions

Old versions don’t have those tests so we cannot exclude it.

changelog_begin
changelog_end

* more fixes

changelog_begin
changelog_end
2022-01-12 20:49:28 +01:00
Moritz Kiefer
8bc5ff06a7
Clarify unhandled exception error message (#12353)
* Clarify unhandled exception error message

The previous error doesn’t make it clear that this is an exception in
user code rather than a Scala exception in our code.

Daml-lf exception would technically be more correct but I don’t think
it’s helpful here so I went with Daml exception.

changelog_begin
changelog_end

* adjust ledger api test tool

changelog_begin
changelog_end

* Update test assertions

changelog_begin
changelog_end

* fix another assertion

changelog_begin
changelog_end
2022-01-11 17:57:07 +00:00
nicu-da
50deee3ef1
[ledger-api-test-tool] - Merge KVCommandDeduplicationIT and CommandDeduplicationIT (#12257)
changelog_begin
[ledger-api-test-tool] - Merge command deduplication ledger API tests (`KVCommandDeduplicationIT`, `CommandDeduplicationIT`) into a single suite(`CommandDeduplicationIT`) which uses feature descriptors to handle different participant behaviors
changelog_end
2022-01-11 01:53:55 -08:00
Moritz Kiefer
2783b7bdad
Support user management in create-daml-app (#12089)
fixes #11998

changelog_begin
changelog_end
2022-01-07 12:45:13 +00:00
Gary Verhaegen
ea55ea2d14
Further copyright updates (#12249)
Somewhat error-prone, so please review carefully.

Reasons we need this:

- Some file types are not properly handled by the script.
- The only exclusion mechanism we currently have (`NO_AUTO_COPYRIGHT`)
  is overly coarse.

CHANGELOG_BEGIN
CHANGELOG_END
2022-01-04 16:32:17 +01:00
nicu-da
4b4fbf8c2a
[ledger-api-test-tool] - adapt the command deduplication conformance to use participant deduplication feature descriptor [kvl-1218] (#12222) 2022-01-04 07:10:48 -08:00
Gary Verhaegen
d2e2c21684
update copyright headers (#12240)
New year, new copyright, new expected unknown issues with various files
that won't be covered by the script and/or will be but shouldn't change.

I'll do the details on Jan 1, but would appreciate this being
preapproved so I can actually get it merged by then.

CHANGELOG_BEGIN
CHANGELOG_END
2022-01-03 16:36:51 +00:00
azure-pipelines[bot]
4cc4b3baf4
update compat versions for 1.18.0 (#12068)
CHANGELOG_BEGIN
CHANGELOG_END

run-full-compat: true
2021-12-24 18:06:04 +01:00
nicu-da
e182fc5026
[ledger-api] - Move deduplication duration validation into the KV WriteService (#12151)
changelog_begin
ledger-api - Remove validation for duration deduplication periods, which was validating that the deduplication duration is smaller than the max deduplication duration. This is now up to the ledger to enforce.
changelog_end
2021-12-20 05:33:46 -08:00
Moritz Kiefer
cf110a4bbf
Only run ledger API test tool compat tests between stable releases (#11954)
We break things way too frequently between releases so the exclusions
are a huge mess with little benefit.

changelog_begin
changelog_end
2021-12-02 09:34:20 +00:00
nicu-da
13797229cf
Adapt the compatibility exclusions (#11872)
changelog_begin
changelog_end
2021-11-26 10:07:02 +01:00
nicu-da
faddba4222
Increase range for excluded snapshots in compatilbility tests (#11802)
changelog_begin
changelog_end
2021-11-22 05:43:53 -08:00
tudor-da
8e31e8e6a8
[Self-service error codes] Enabled by default [DPP-691] (#11685)
* [Self-service error codes] Enabled by default
* Flag changed to `use-pre-1.18-error-codes` (disabled by default)

CHANGELOG_BEGIN
[Ledger API Specification] The Ledger API returns enriched error codes (see https://docs.daml.com/error-codes/self-service/index.html)
For backwards-compatibility, a new API flag `--use-pre-1.18-error-codes` is introduced for preserving the legacy behavior for
clients that want to migrate incrementally to the changed gRPC status code responses and error details format.
CHANGELOG_END

* Adapted HttpServiceIntegrationTest

* Renamed `Feature Flag` to `Configuration` in docs

* Fix Daml Script tests

changelog_begin
changelog_end

* Fix Repl functests

changelog_begin
changelog_end

* Fix haskell binding tests

changelog_begin
changelog_end

* Fix CommandClientIT test

* Fixed Sandbox and CommandServiceBackpressureIT tests
 Please enter the commit message for your changes. Lines starting

* Adapt //compiler/damlc/tests:repl-functests again

* Fix more tests and address Miklos' comments
* Flag name changed to `grpc-status-codes-compatibility-mode`

* Remove useless flags sandbox-classic

* Sandbox-classic tests fix for ContractKeysIT and ExceptionsIT
* Created 2 deprecated test suites that have the more generic assertions as returned
by the deprecated in-memory backend

* More fixes for CommandServiceIT
* Fixes compilation issue with the deprecated exceptionsIT class for Sandbox-classic in-memory

* Compatibility mode for old test tools

* Change flag name to `use-pre-1.18-error-codes`

* Apply suggestions from code review

Co-authored-by: Miklos <57664299+miklos-da@users.noreply.github.com>

Co-authored-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
Co-authored-by: Miklos <57664299+miklos-da@users.noreply.github.com>
2021-11-22 12:26:48 +00:00
nicu-da
8f458d8d2a
[ledger-api] Include the completion offset in the command_service.proto responses [KVL-1171] (#11658)
CHANGELOG_BEGIN
[ledger-api] - Include the completion offset in the responses from the command_service.proto
CHANGELOG_END
2021-11-18 04:37:26 -08:00
nicu-da
dd88ba24c3
kvutils - Backwards looking command deduplication [KVL-1174] (#11634)
CHANGELOG_BEGIN
kvutils - The deduplication duration passed in the command is now used for command deduplication, and is no longer always overwritten with the max deduplication duration. The command deduplication duration can still be extended by the committer to account for time skews.
CHANGELOG_END
2021-11-18 02:25:31 -08:00
tudor-da
92dfcdeb24
[Self-service error codes] Use error validators in ApiPackageManagementService (#11575)
* Use error validators in ApiPackageManagementService

CHANGELOG_BEGIN
CHANGELOG_END

* Exclude PackageManagementServiceIT from compatibility tests after 1.17

CHANGELOG_BEGIN
CHANGELOG_END
2021-11-09 21:54:26 +01:00
Hubert Slojewski
445031114f
Exclude/fix compatibility tests (#11529)
CHANGELOG_BEGIN
CHANGELOG_END
2021-11-04 19:50:49 +01:00
nicu-da
df65d02c4e
Exclude dedup tests affected by current changes (#11471)
CHANGELOG_BEGIN

CHANGELOG_END
2021-10-29 21:28:56 +02:00
nicu-da
6126fc2230
Remove append only prefix from conformance tests [KVL-1152] (#11424)
CHANGELOG_BEGIN
[api-test-tool] - remove AppendOnly prefix from test suites as the append-only schema is the only one left
CHANGELOG_END
2021-10-28 02:24:42 -07:00
Moritz Kiefer
926655d3c3
Drop daml ledger timeout tests from compat tests (#11441)
Testing the compatibility of the timeout flag is pretty useless and it
keeps flaking.

changelog_begin
changelog_end
2021-10-28 09:11:45 +00:00
fabiotudone-da
4295ecd1d0
Fix compatibility exclusions introduced by #11095 [KVL-1083] (#11141)
CHANGELOG_BEGIN
CHANGELOG_END
2021-10-06 21:58:33 +02:00
fabiotudone-da
c2084f6e14
Try and improve the explanation of compatibility test exclusions (#11114)
* Try and improve the explanation of compatibility test exclusions

CHANGELOG_BEGIN
CHANGELOG_END

* Fix scenario description

* Attempt #2 at trying and improving the explanation of compatibility test exclusions
2021-10-05 16:55:21 +02:00
fabiotudone-da
d4cb1f945e
KV ledgers: disable participant side command de-duplication [KVL-1083] (#11095)
* Extract common code for command dedup conformance tests

CHANGELOG_BEGIN

CHANGELOG_END

* Revert changes for parallel tests

* Fix compile warnings

* Disable participant deduplication for KV

CHANGELOG_BEGIN
CHANGELOG_END

* Always call submitRequestAndAssertDeduplication with parties

* Fix party in CommandDeduplicationBase

* Don't test KV-based command deduplication with static time as it's broken

* Don't disable participant-side command deduplication for sandbox-next on static time

* Revert "Don't test KV-based command deduplication with static time as it's broken"

This reverts commit 3dac41aa

* Add missing dependency

* Don't cross-test this ledger API test tool with existing versions

* Add the current PR to the list of PRs that resulted in exclusions

* Apply @garyverhaegen-da's suggestion for compatibility exclusions

Co-authored-by: Nicu Reut <nicu.reut@digitalasset.com>
2021-10-05 13:31:53 +02:00
Stefano Baghino
4860271a53
Port file was not written to... where? (#11108)
* Port file was not written to... where?

Adds the information on where the port file could not be written.
From the current phrasing it appears the intention was to add the
information but ultimately wasn't.

changelog_begin
changelog_end

* Address https://github.com/digital-asset/daml/pull/11108#pullrequestreview-770115835
2021-10-04 15:21:56 +00:00
azure-pipelines[bot]
4b31bf088f
update compat versions for 1.17.0 (#11075)
* update compat versions for 1.17.0

CHANGELOG_BEGIN
CHANGELOG_END

* add exclusions

* Revert "add exclusions"

This reverts commit 13a5083081.

* Fix command dedup for kv sandbox

changelog_begin
changelog_end

Co-authored-by: Azure Pipelines DAML Build <support@digitalasset.com>
Co-authored-by: Gary Verhaegen <gary.verhaegen@digitalasset.com>
Co-authored-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
2021-09-30 16:14:45 +00:00
Gary Verhaegen
79080839c1
add Auth0 support to create-daml-app (#10673)
As I was adding support to a sample app for the third time, I decided I
might as well clean it up a bit and add support for everyone.

This is completely optional, activated by (build-time) environment
variables, and should be trivial to remove for users who don't care
about it. In an ideal world we'd have options to `daml new` and this
would be one, but I think adding it out-of-the-box is a better
alternative than letting people figure this out on their own.

CHANGELOG_BEGIN
- The `create-daml-app` template now includes support for a third
  authentication scheme (in addition to the existing "dev mode" and Daml
  Hub support): Auth0.
CHANGELOG_END
2021-09-14 15:56:45 +02:00
nicu-da
37a1cb21b3
compatibility-tests - Exclude CommandDeduplicationIT from running for existing 1.17 snapshots (#10866)
Reason: in between snapshots there was a proto change (field number change) which broke compatibility

CHANGELOG_BEGIN

CHANGELOG_END
2021-09-14 06:58:42 +00:00
Hubert Slojewski
b50bb8e437
Populate definite_answer in ApiException [KVL-1004] (#10832)
CHANGELOG_BEGIN
CHANGELOG_END
2021-09-13 16:28:39 +00:00
Hubert Slojewski
d9178d2ac2
Clarify version usage in test tool exclusion docs (#10858)
CHANGELOG_BEGIN
CHANGELOG_END
2021-09-13 11:30:00 +00:00
Moritz Kiefer
c113954a35
Clarify docs for test tool exclusions (#10855)
* Clarify docs for test tool exclusions

changelog_begin
changelog_end

* clarify 0.0.0

changelog_begin
changelog_end
2021-09-13 10:12:20 +00:00