Commit Graph

1406 Commits

Author SHA1 Message Date
Neil Mitchell
e75d2b465e Make CPP work better with hie-core (#1903)
* Pull the CPP into a separate module

* Pass Nothing to indicate that a text buffer shoud just be used from disk

* Add save handlers, since the version changing to ModTime may have an impact

* Rename contents to mbContents in one place

* Change runCpp to take a Maybe StringBuffer and attempt to reuse the existing file, if it can

* Add a Bazel alias for hie-core

* Add notes about the sad path

* Avoid one use of filePathToUri

* Avoid another use of filePathToUri which went wrong for CPP output

* Normalize Uri's by replacing adjacent // with a single /

* Improve how CPP works if you have a modified buffer

* Move textToStringBuffer out to Util

* Switch to hPutStringBuffer which is in GHC 8.8

* Note why we are escaping to /

* Refactoring suggested by review
2019-06-27 22:17:37 +00:00
Moritz Kiefer
10d85b214e Remove zip-archive override and upgrade stackage snapshot (#1920)
The override of zip-archive was required at some point because the new
version added additional safety checks that blew up in our tests. The
codepaths affected by this are long gone so let’s just use whatever is
in stackage.

While I was touching packages anyway, I’ve also upgraded to the latest
snapshot in the LTS we are currently following.
2019-06-27 22:47:52 +01:00
Moritz Kiefer
61eace44fe
Switch to nixpkgs-unstable (#1921)
The main reason for doing this is that it saves us the trouble of
having to backport changes, e.g., a newer MacOS toolchain.
2019-06-27 18:47:42 +02:00
Gary Verhaegen
345b7aba58 remove cassandra (#1916) 2019-06-27 14:40:09 +00:00
nickchapman-da
0473734359
Hlb wrap more services (#1904)
* support: CommandCompletionService.completionEnd

* support checkpoints from: CommandCompletionService.completionStream

* address review comments

* add type for LedgerOffset; prefer AbsOffset when known

* extend submit/complete testcase
2019-06-27 15:30:47 +01:00
Moritz Kiefer
4ae4c9b08b
Release 0.13.8 (#1914) 2019-06-27 14:48:01 +02:00
Remy
c412d4e3d2 Add pretty C# namespaces in archive and leger-api protos (#1911)
* add nice C# namespace for in leger-api proto

fixes #1901

* add pretty C# namespace for archive protos

fix #1900
2019-06-27 11:39:33 +00:00
Remy
3f1b5d7761 daml-lf: Update spec for daml-lf 1.dev (#1899)
* daml-lf: Update spec for daml-lf 1.dev

* daml-lf: more details on interned package IDs in spec

* daml-lf: more comments in daml_lf_1.proto
2019-06-27 10:36:34 +00:00
Moritz Kiefer
1edb594ecb Exclude protobuf-lite from grpc-protobuf (#1910) 2019-06-27 10:03:54 +00:00
Robert Autenrieth
77d916288a
Update participant state v2 interfaces (#1800)
Moves party allocation to its own WriteService trait (similar to package upload).

Changes uploadDar to uploadPackages, so that the write service does not depend on the DAR file format.

Adds or improves many comments.
2019-06-27 11:44:15 +02:00
Gabor Aranyossy
d24366f3e2 Archives CLI args are not mandatory anymore (#1908)
* making archives optional

* amending CliSpec to match the new spec

* changelog
2019-06-27 09:15:22 +00:00
Jussi Mäki
c23af0eaa0
Introduce contract key to exercise node (#1783)
* Introduce contract key to exercise node

Track the contract key in NodeExercises. This is in
preparation for adding the key into exercise events, and
for support for contract keys in kvutils, where we need
to be able to compute the outputs of the submission, e.g.
the contract key that would be unset by a consuming exercise.

This introduces transaction version 8.

* Move release note on contract keys in exercises to unreleased.rst

* Address Stephen's review

- Drop changelog entry for this change as it is not user facing
- Add info on version 8 to transaction.rst. Fix typo in version 7.
- Reorder VersionTimeline as per review
- Only compare the NodeExercise 'key' if it is set in the original
  transaction (in order to compare transactions in a backwards
  compatible manner)

* Unbork unreleased.rst
2019-06-27 09:57:40 +02:00
Gary Verhaegen
a1424d3446 add authealing to hoogle cluster (#1906) 2019-06-27 05:46:01 +00:00
Gary Verhaegen
a8f8c7602d publish VSCode extension to marketplace on release (#1876) 2019-06-26 22:48:19 +00:00
Gary Verhaegen
18aee24e0f fix hoogle cron escaping (#1902) 2019-06-26 18:42:23 +00:00
Remy
6cd3f93d2e scala-codegen: add support for enum type (#1833)
* scala-codege: add support for enum type

* formatting

* first part of Stephen comments

* Address Stephen's comments
2019-06-26 17:50:37 +00:00
Remy
fe33450fa5 damlc: fix serializability of empty enum (#1893) 2019-06-26 17:16:16 +00:00
Neil Mitchell
8db9941858
Make hie-core outside an IDE work better (#1895)
* Move the hie-core demo files around (they aren't really a demo anymore)

* Split the command line parsing into a separate module

* Give messages about how long starting something takes

* Make the interactive mode say what it is doing a bit more

* Add a --cwd flag to hie-core

* Take a list of files and directories for hie-core

* Update the readme to say how to test using hie-core

* Fix up the bazel file

* Add HLint exception
2019-06-26 17:07:08 +01:00
Brian Healey
865d87841d Update issue templates (#1322)
* Update issue templates

* Update bug_report.md

* Update bug_report.md

* Update feature_request.md

* Update bug_report.md

* Update feature_request.md

* Update .github/ISSUE_TEMPLATE/bug_report.md

Co-Authored-By: Beth Aitman <bethaitman@users.noreply.github.com>

* Update .github/ISSUE_TEMPLATE/bug_report.md

Co-Authored-By: Beth Aitman <bethaitman@users.noreply.github.com>

* Update .github/ISSUE_TEMPLATE/bug_report.md

Co-Authored-By: Beth Aitman <bethaitman@users.noreply.github.com>

* Update .github/ISSUE_TEMPLATE/bug_report.md

Co-Authored-By: Beth Aitman <bethaitman@users.noreply.github.com>

* Update .github/ISSUE_TEMPLATE/bug_report.md

Co-Authored-By: Beth Aitman <bethaitman@users.noreply.github.com>

* Update .github/ISSUE_TEMPLATE/feature_request.md

Co-Authored-By: Beth Aitman <bethaitman@users.noreply.github.com>

* Update .github/ISSUE_TEMPLATE/bug_report.md

Co-Authored-By: Beth Aitman <bethaitman@users.noreply.github.com>

* Update .github/ISSUE_TEMPLATE/feature_request.md

Co-Authored-By: Beth Aitman <bethaitman@users.noreply.github.com>

* Update .github/ISSUE_TEMPLATE/feature_request.md

Co-Authored-By: Beth Aitman <bethaitman@users.noreply.github.com>

* Update .github/ISSUE_TEMPLATE/feature_request.md

Co-Authored-By: Beth Aitman <bethaitman@users.noreply.github.com>

* Update .github/ISSUE_TEMPLATE/feature_request.md

Co-Authored-By: Beth Aitman <bethaitman@users.noreply.github.com>

* Update .github/ISSUE_TEMPLATE/bug_report.md

Co-Authored-By: Beth Aitman <bethaitman@users.noreply.github.com>

* Update .github/ISSUE_TEMPLATE/bug_report.md

Co-Authored-By: Beth Aitman <bethaitman@users.noreply.github.com>

* Update .github/ISSUE_TEMPLATE/bug_report.md

Co-Authored-By: Beth Aitman <bethaitman@users.noreply.github.com>

* Update .github/ISSUE_TEMPLATE/feature_request.md

Co-Authored-By: Beth Aitman <bethaitman@users.noreply.github.com>

* Update .github/ISSUE_TEMPLATE/feature_request.md

Co-Authored-By: Beth Aitman <bethaitman@users.noreply.github.com>

* Update .github/ISSUE_TEMPLATE/bug_report.md

Co-Authored-By: Beth Aitman <bethaitman@users.noreply.github.com>

* Update .github/ISSUE_TEMPLATE/bug_report.md

Co-Authored-By: Beth Aitman <bethaitman@users.noreply.github.com>

* Update bug_report.md

* Update bug_report.md

* Delete feature_request.md

* Update bug_report.md
2019-06-26 15:55:09 +00:00
Fran
368242563c Fix daml-assistant install script. (#1896)
* Fix daml-assistant install script.

* Fix windows installer also.
2019-06-26 15:42:26 +00:00
Brian Healey
4f60c7a452
Add Zulu JDK link (#1877)
* Add Zulu link for JDK in addition to Oracle link

* Oracle not Sun
2019-06-26 11:29:10 -04:00
Martin Huschenbett
9b0399d5d9 Drop support for DAML-LF 1.4 from damlc (#1888)
* Drop support for DAML-LF 1.4 from damlc

This is part of #853.

* Remove exerciseWithActors and archiveWithActors
2019-06-26 15:15:22 +00:00
Remy
383888169d daml-lf: fix lf decoder (#1879) 2019-06-26 15:12:46 +00:00
Stephen Compall
7311dc8381 Refine, replace LF governors (#1892)
* Bring @gerolf-da and @hurryabit into LF governance, in place of @bitonic

* Add vacation backups to language CODEOWNERS
2019-06-26 16:37:50 +02:00
Stefano Baghino
f8bebffb4e Expose signatories and observers throughout the platform (#1814)
* Add signatories and observers to Ledger API

Cascade fixes deriving from compilation and test errors.

* Add signatories and observers to Java bindings and codegen

* Add signatories and observers to Scala bindings and codegen

* Add signatories and observers to navigator

* Add signatories and observers to the Haskell bindings

* Add integration test

* Comply with formatting standard

* Add release notes

* Apply edits from CI feedback and self-review

* Fix wrong input on test case for observers sorting

Co-Authored-By: Robert Autenrieth <31539813+rautenrieth-da@users.noreply.github.com>

* Read JSON as strings from DB, parse them as parties

Address https://github.com/digital-asset/daml/pull/1814#discussion_r296405252

* Change parties rendering and observer display condition

Address https://github.com/digital-asset/daml/pull/1814#discussion_r296390104

* Fix sorting tests, implement sorting by agreement

Address https://github.com/digital-asset/daml/pull/1814#discussion_r296397390

FIXME notes have been added for suspicious test cases

* Prevent any mutation of CreatedEvent arguments

Address https://github.com/digital-asset/daml/pull/1814#discussion_r296572639

* Comply with formatting standard

* Stakeholders are filtered up to the witnesses

Addresses https://github.com/digital-asset/daml/pull/1814#discussion_r297102521
2019-06-26 14:02:59 +00:00
Gary Verhaegen
798e96c9b9
prepare for VSCode marketplace (#1875) 2019-06-26 13:56:15 +01:00
Andreas Herrmann
10e7678d67 Fix CPP issue with default da-ghci (#1889)
* Fix CPP issue with default da-ghci

The default REPL target did not exclude the //nix targets that set the
CPP language extensions.

* da-ghci -e () requires explicit target
2019-06-26 12:53:13 +00:00
Moritz Kiefer
0866616cee
Release 0.13.7 (#1887) 2019-06-26 14:05:49 +02:00
Moritz Kiefer
7725d25a41
Mark lsp-tests as flaky (#1891) 2019-06-26 14:05:12 +02:00
Fran
91b862b09a
Refactor damldocs -- turn types into newtypes (#1883)
* Newtype some types.

* Renamed Markdown type to DocText

* Fix bazel formatting ...

* Use newtype deriving strategy for newtypes.

* Comparison doesn't require unwrapping modulename.
2019-06-26 13:01:51 +01:00
Remy
41574d33f7 java-codegen: Add support for enum types (#1648)
* java-codegen: add support for Enum

* Address Stefano's comment
2019-06-26 11:50:25 +00:00
Neil Mitchell
b01464339c
Delete bits of hie-core that were unused (#1885)
* Delete now unused code

* Make protocol not reexport LSP.Types

* Delete more comments

* HLint
2019-06-26 12:15:16 +01:00
Moritz Kiefer
6c2e7ae11c
Fix vscode extension (#1884)
I am honestly not sure how I managed to not hit this in testing, sorry
about this.
2019-06-26 12:34:11 +02:00
nickchapman-da
eba9af48ac
Hlb review comments (#1881)
* Define LedgerService using ReaderT to avoid boilerplate
* re-export TimeoutSeconds from GRPC.HighLevel.Client, instead of defining as a newtype
* rename: Valuable -> IsLedgerValue
2019-06-26 11:02:12 +01:00
Neil Mitchell
d431cfaf00
Move the DAML language server to be based on the hie-core server (#1880)
* Move the DAML language server to be based on the hie-core language server, supply extensions around the outside

* HLint
2019-06-26 11:01:42 +01:00
Michał Majcherski
7878120d5b
Fix hanging FFI call to scenario service problem on Windows (#1868)
* windows: hanging GRPC FFI call problem resolution

* windows: fix visual test

* windows: enabled back again some of disabled daml-assitant tests

* marking daml_ghc_integration_test as large
2019-06-26 11:45:52 +02:00
Moritz Kiefer
8e701cd229 Fix release process (#1878)
This PR adds a check that all artifacts that will be uploaded to Maven
central actually exists and fixes the artifacts for
daml_lf_archive_java.
2019-06-26 09:19:08 +00:00
Stephen Compall
9bcc925a40
intern package IDs in LF (#1614)
* specify the new fields for interning package IDs

* percolating intern tables

* crawl packages for package IDs as a pre-phase: generic prep

* stub case for interned_id in Scala packageref reader

* HasPackageRefs instances for the rest of the ast

* make intern table and use when encoding PackageRefs in v1

* don't need where

* stub out decode for interned package IDs

* no benefit to using uint32 instead of uint64

* percolate in encode one step

* interned case for decoding PackageRefs

* naming details

* intern table decoder

* finish propagating the intern table in encoder

* encode the package ID table

* document the vital assumption of encodeInternedPackageIds

* propagate the intern table through the LF decoder

- done by stacking ReaderT on top of Decode internally,
  as discussed with @hurryabit

* daml-lf-proto requires mtl

* stub out interned case in Scala LF decoder

* stub interface decoder function

* get the interned table to most places in InterfaceReader

* support for interned package IDs in Scala decoder

* use ImmArraySeq instead of Vector for Scala intern decode table

* adding that ghc extension didn't make sense

* implement interned ID decoding for InterfaceReader

* scenario service won't have interned package IDs

* test the interned ID resolution in Scala by examining the proto -> AST in detail

* proper precondition for the dev phase of interned IDs testing

* better error reporting for malformed DALFs in intern test

* just import Data.Int

- suggested by @neil-da; thanks

* pass around the lookup function instead of the vector in decoder

- suggested by @neil-da; thanks

* remove derivations for types deleted in e63b012d2d

* rename VersionAware to EncodeCtx

- suggested by @hurryabit; thanks

* rename MDecode to MonadDecode

- suggested by @hurryabit; thanks

* pass a function through the encoder instead of a set

- based on suggestions by @hurryabit and @neil-da; thanks

* daml-ghc test that interned IDs are generated

- suggested by @hurryabit; thanks

* adapt to 5b480c99ec #1844
2019-06-26 11:15:24 +02:00
Neil Mitchell
1a1d1591af
Make the hie-core server retargetable (#1873)
* Move mergeHandlers into Server

* Make partial handlers a proper newtype

* Pass the options in to runLanguageServer

* Take in user handlers

* Remove the code lens handler since we don't advertise it

* Add setSomethingModified, rather than faking it for the LSP VFS

* Rewrite the LSP notifications

* Improve the display of info messages around openning and modifying text documents

* Make sure stdout and stderr don't have buffering, so we see their output immediately

* Handle exit properly

* Make notifications forward on to their previous values

* Remove the exit handler, HIE already has a good default for it

* Add comments on FileStore
2019-06-26 09:04:10 +01:00
nickchapman-da
4432a79407
refactor (#1865) 2019-06-26 08:09:08 +01:00
Brian Healey
0375d0b49c
update css-loader (#1874) 2019-06-25 17:34:16 -04:00
Neil Mitchell
409eba0aab Correct hie-core grammar (#1871) 2019-06-25 19:24:56 +00:00
Moritz Kiefer
37ada7e770
Build javadoc for daml-lf-archive (#1867)
This is required for uploading to Maven.

The rational for needing our custom javadoc_library rule is documneted
in the file itself.
2019-06-25 21:12:25 +02:00
Martin Huschenbett
a5cf162b2a Remove two obsolete error messages from before complex contract keys (#1870) 2019-06-25 20:06:35 +01:00
Brian Healey
c83db69828
Correct links and address suggested wording changes (#1817)
* Correct links and address wording changes from beth

* daml-integration-kit: clarify ledgers being built section

- drop separate Deployment Platform column, as it was confusing. Added
  as references to managed offerings for partners that have them.
- use an intra-doc reference instead of a reference via docs.daml.com
  for Sandbox docs
- reword intro for kit to position platform overview better
2019-06-25 14:36:32 -04:00
Neil Mitchell
c6ba459709
Give the readme a significant pass (#1869) 2019-06-25 19:07:00 +01:00
Robin Krom
05d80eeeb4
language: upgrades: no generics for data types having the instances already (#1840)
language: upgrades: dont derive generics for data types having the instances already

We only derive generic instances on the fly for data types that don't
have them already.
2019-06-25 18:17:34 +02:00
Neil Mitchell
c8adb9810d Significantly alter the hie-core LanguageServer (#1862)
* Inline chunks of LSP.Server into LanguageServer

* Inline runServer

* Start figuring out a better API for gotoDefinition

* Remove old JIRA ticket numbers

* Add a hover handler in the new form

* Change the new handlers slightly

* Add a new module to handle notifications updating the virtual file system

* Rewrite the language server in hie-core to use the Handler more directly

* Add a cancel handler

* Ignore a few more handlers

* HLint

* REname functions that set handlers

* Rename a few more set handlers

* Delete the unused makeResponse

* Move mergeHandlers over to LanguageServer

* Rename RunHandler to WithMessage

* Switch from STM to IO

* Avoid the Protocol module

* Rename AddItem to Message

* Document why we use clientMsgChan

* Add comments around Message
2019-06-25 15:13:17 +00:00
Martin Huschenbett
25f1369cd7 Add support for DAML-LF's enum types to damlc (#1824)
* Add support for DAML-LF's enum types to damlc

This is part of #105.

* Address feedback
2019-06-25 14:44:21 +00:00
Moritz Kiefer
98e91d2ca2
Handle early exits of the scenario service (#1858)
fixes #1772
2019-06-25 15:34:02 +02:00