Commit Graph

65 Commits

Author SHA1 Message Date
Sergey Kisel
fe654eba21
Change ownership of test-evidence library (#13380)
CHANGELOG_BEGIN
CHANGELOG_END
2022-03-23 13:32:55 +01:00
Remy
6c2dc2d508
Move Replay from KV to LF land (#13243)
* Move Replay from KV to LF land

+ base it on submission entries instead of ledger export

CHANGELOG_BEGIN
CHANGELOG_END
2022-03-21 13:03:10 +01:00
Sofia Faro
930bceeea8
Assign codeowner for /compiler/ and related (#13255)
Also add @ray-roestenburg-da to the codeowners for daml-assistant

Just following up on this:
https://github.com/digital-asset/daml/pull/13246/files#r823623864

changelog_begin
changelog_end
2022-03-14 09:19:48 +00:00
Stephen Compall
e73963c88d
restrict SC's codeowners to desired notifications (#13252)
CHANGELOG_BEGIN
CHANGELOG_END
2022-03-10 15:20:31 +00:00
Moritz Kiefer
78112f17cb
Disown everything (#13246)
* Disown everything

changelog_begin
changelog_end

* Update CODEOWNERS

Co-authored-by: Remy <remy.haemmerle@daml.com>

Co-authored-by: Remy <remy.haemmerle@daml.com>
2022-03-10 12:31:00 +00:00
Hubert Slojewski
9881e7c64f
Remove ledger-on-sql [KVL-1350] (#13124) 2022-03-02 17:05:12 +01:00
Samir Talwar
83ed13d799
Split the ledger-api-test-tool into libraries, under /ledger/ledger-api-tests. [KVL-1076] (#12771)
* Move //ledger/ledger-api-test-tool to //ledger/ledger-api-tests/tool.

And conformance.bzl to //ledger/ledger-api-tests.

* Move test tool infra to //ledger/ledger-api-tests/infrastructure.

* Split the ledger API test tool into smaller libraries.

There is no change to behavior.

CHANGELOG_BEGIN
CHANGELOG_END

* ledger-api-tests: Encapsulate performance tests.

* ledger-api-tests: Extract a "runner" library.

* ledger-api-tests: Publish libraries to Maven Central.

* ledger-api-tests: Fix Scaladoc so it compiles correctly.

Unfortunately I had to remove some Scaladoc in ActiveContractsServiceIT
which is incorrectly interpreted as not being attached to anything.
Fortunately, it's not actually that helpful.

* compatibility: Fix paths to the Ledger API Test Tool.

* Fix release types for ledger API test libraries.

* test-common: Publish generated Scala.

These libraries are dependencies of the ledger API tests components.

* ledger-api-tests: Use "com.daml" as the group ID everywhere.

* ledger-api-tests: Check that tests in `--additional` are valid.

* compatibility: Fix a reference to ledger-api-test-tool I missed.
2022-02-10 13:25:23 +00:00
Stefano Baghino
69a4136057
Add @ray-roestenburg-da to CODEOWNERS (#12847)
* Add @ray-roestenburg-da to `CODEOWNERS`

Add @ray-roestenburg-da to `CODEOWNERS` for all code
in the App Runtime team (bindings, HTTP JSON API, trigger
service, auth middlware, non-repudiation middleware).

changelog_begin
changelog_end

* Address https://github.com/digital-asset/daml/pull/12847#discussion_r802700759
2022-02-09 19:35:36 +01:00
Hubert Slojewski
56baf036b7
Rename kv-transaction-support library [KVL-1168] (#12212)
CHANGELOG_BEGIN
CHANGELOG_END
2021-12-20 16:33:36 +01:00
Stefano Baghino
52110e31a3
Remove Extractor (#12188)
* Remove Extractor

Extractor is being removed after a long time being in Labs status.

This should improve the flakiness on CI.

🔥

changelog_begin
Extractor has been removed from the SDK
changelog_end

* Remove Extractor documentation

* Remove Extractor from CODEOWNERS

* Remove Extractor references in Daml-LF build files

* Remove Extractor references in the Daml SDK assistant

* Remove Extractor from the SDK

* Remove Extractor reference from CONTRIBUTING.md
2021-12-17 13:43:23 +00:00
Stefano Baghino
cd52f13464
Remove @aherrmann-da from CODEOWNERS (#11792)
changelog_begin
changelog_end
2021-11-19 14:27:02 +01:00
Simon Meier
56a6db8f73
codeowners: reflect change in onwership of meiersi-da (#11505)
CHANGELOG_BEGIN
CHANGELOG_END
2021-11-09 09:02:15 +01:00
Moritz Kiefer
af7f7f3f01
Fix LF coedowners (#11563)
GH uses the last matching rule not all matching rules so unfortunately
we have to duplicate entries.

changelog_begin
changelog_end
2021-11-04 20:02:52 +00:00
Moritz Kiefer
f9ec12be12
Add cocreature as a codeowner of the docs (#11450)
* Add cocreature as a codeowner of the docs

Currently we have no active codeowner of the docs which is an
unfortunate situation since PRs just end up sitting until someone
happens to find it or someone else asks for a ping.

Not necessarily saying I’m the right one to review all docs but I can
at least make sure PRs advance.

changelog_begin
changelog_end

* Update CODEOWNERS

Co-authored-by: Stefano Baghino <43749967+stefanobaghino-da@users.noreply.github.com>

* Update CODEOWNERS

Co-authored-by: Stefano Baghino <43749967+stefanobaghino-da@users.noreply.github.com>
2021-11-01 13:41:04 +00:00
Gary Verhaegen
ae41aa2c14
releases: check component status page (#11116)
The component status page have been neglected as of late. Craig
suggested adding a step to the release checklist.

CHANGELOG_BEGIN
CHANGELOG_END
2021-10-12 11:46:01 +02:00
Stefano Baghino
eb834907d7
Add @stefanobaghino-da and @adriaanm-da for approval of stable releases (#11203)
Also a couple of tweaks to `CODEOWNERS`

changelog_begin
changelog_end
2021-10-12 08:42:43 +00:00
Moritz Kiefer
45437059d4
Drop cocreature as a codeowner from runtime things (#10906)
Just cleaning up my notifications a bit

changelog_begin
changelog_end
2021-09-16 09:38:12 +02:00
Gerolf Seitz
e490b69471
Clarifications of code ownership in /ledger and /ledger-api (#10742)
CHANGELOG_BEGIN
CHANGELOG_END
2021-09-09 15:30:12 +02:00
Samir Talwar
0cbaa15465
Codeowners: Notify committer maintainers on API changes. (#10557)
* Codeowners: Notify committer maintainers on API changes.

Those of us that work on kvutils and committers based on it probably
need to know when certain packages under "ledger" change.

In addition, we seem to be working on the participant state API more
than anyone else, so I think it makes sense to change governance a
little bit.

CHANGELOG_BEGIN
CHANGELOG_END

* Codeowners: Use team names for directories under /ledger.

* Codeowners: Add the participant team back to the participant state APIs.

* Codeowners: Limit kvutils to the committer team, as before.

* Codeowners: Add kv-participant to the Sandbox project.
2021-08-16 08:38:09 +00:00
Samir Talwar
4f9de4ba3b
Add @hubert-da to CODEOWNERS for kvutils. (#10551)
CHANGELOG_BEGIN
CHANGELOG_END
2021-08-11 12:59:10 +00:00
Samir Talwar
b899ae1d37
Codeowners: Add @nicu-da to the kvutils code review. (#10292)
CHANGELOG_BEGIN
CHANGELOG_END
2021-07-15 14:48:19 +00:00
Moritz Kiefer
9e27ae0d85
Reshuffle cocreature in daml-lf codeowners (#10215)
No idea why I’m a codeowner for everything individually.

changelog_begin
changelog_end
2021-07-08 11:06:20 +00:00
Gary Verhaegen
87d3f898ba
offboarding @hurryabit (#9398)
:sadpanda:

CHANGELOG_BEGIN
CHANGELOG_END
2021-04-13 11:59:24 +00:00
Gerolf Seitz
8948e961db
Get codeowners for /ledger and /ledger-api in shape (#9266)
CHANGELOG_BEGIN
CHANGELOG_END
2021-03-29 15:45:34 +02:00
Stephen Compall
b382fc45ac
update areas to alert @S11001001 of changes (#9156)
CHANGELOG_BEGIN
CHANGELOG_END
2021-03-16 20:25:28 +00:00
Remy
498fcc66b4
KV specific LF library (#9100)
CHANGELOG_BEGIN
CHANGELOG_END
2021-03-15 13:33:57 +01:00
Stefano Baghino
c2362ef02c
Add //runtime-components to CODEOWNERS (#8851)
Initial owners are @stefanobaghino-da and @cocreature

changelog_begin
changelog_end
2021-02-15 16:28:57 +00:00
Moritz Kiefer
35a866fdc2
Add Moritz as a codeowner for daml-lf stuff (#8445)
changelog_begin
changelog_end
2021-01-11 09:43:24 +01:00
Stefano Baghino
355fa9dc63
Adjust CODEOWNERS for @stefanobaghino-da (#8377)
Remove @stefanobaghino-da from ledger subtrees, adding him to runtime app subtrees.

changelog_begin
changelog_end
2021-01-04 18:55:11 +01:00
Brian Healey
e29a09dc89
CODEOWNERS for NOTICES file change (#8297)
CHANGELOG_BEGIN
CHANGELOG_ENDs

Signed-off-by: Brian Healey <brian.healey@digitalasset.com>
2020-12-15 14:47:39 +00:00
Gary Verhaegen
6419ff2f34
remove leo (#7535)
Leo has left the team and so should not have access anymore.

CHANGELOG_BEGIN
CHANGELOG_END
2020-09-30 18:16:57 +02:00
Gerolf Seitz
86608c2d98
Update CODEOWNERS (#7336)
reflect recent org changes

CHANGELOG_BEGIN
CHANGELOG_END
2020-09-07 15:50:40 +00:00
Sofia Faro
63643a7e6a
Update CODEOWNERS. (#7144)
changelog_begin
changelog_end
2020-08-17 07:16:18 +01:00
Martin Huschenbett
d5d5cef561
Refelect Moritz' step up to tech lead in CODEOWNERS (#7103)
CHANGELOG_BEGIN
CHANGELOG_END
2020-08-12 10:59:05 +00:00
Gary Verhaegen
9b42790229
gary: subscribe to ts bindings updates (#7100)
I'm interested in keeping an eye on them.

CHANGELOG_BEGIN
CHANGELOG_END
2020-08-12 12:08:15 +02:00
Moritz Kiefer
aec5cacba5
Add Moritz as a codeowner for more things (#6908)
I like keeping track of what happens in the areas I’m responsible
for. I’ve also removed Shayne since it doesn’t make sense to keep him.

changelog_begin
changelog_end
2020-07-29 09:49:34 +02:00
Remy
cbe423fc6c
LF: rename library transaction-scalacheck to transaction-test-lib (#6347)
* LF: rename library transaction-scalacheck to transaction-test-lib

CHANGELOG_BEGIN
CHANGELOG_END

* move files in com/daml

* missing change in release/artifacts.yaml

* remove 'com/dam' from the path
2020-06-17 10:52:40 -04:00
Martin Huschenbett
b954361d5b
Make Remy and Martin codeowner of everything interpreter (#5952)
CHANGELOG_BEGIN
CHANGELOG_END
2020-05-13 10:51:28 +00:00
Moritz Kiefer
68b7dcfa1a
Setup codeowners for compatibility directory (#5703)
changelog_begin
changelog_end
2020-04-23 15:56:09 +02:00
Gerolf Seitz
a2d785e3ee
Use com.daml as root package (#5343)
Packages com.digitalasset.daml and com.daml have been unified under com.daml

Ledger API and DAML-LF DEV protos have also been moved from `com/digitalasset`
to `com/daml` on the file system.
Protos for already released DAML LF versions (1.6, 1.7, 1.8) stay in the
package `com.digitalasset`.

CHANGELOG_BEGIN
[SDK] All Java and Scala packages starting with
``com.digitalasset.daml`` and ``com.digitalasset`` are now consolidated
under ``com.daml``. Simply changing imports should be enough to
migrate your code.
CHANGELOG_END
2020-04-05 19:49:57 +02:00
Stefano Baghino
c19a20669f
Add CODEOWNERS for libs-scala (#5204)
changelog_begin
changelog_end
2020-03-26 08:56:40 +00:00
Samir Talwar
93e9dd9663
CODEOWNERS: Add owners for the LATEST file, used to manage releases. (#5191)
Namely @bame-da, @gerolf-da, and @hurryabit.

CHANGELOG_BEGIN
CHANGELOG_END
2020-03-25 20:05:11 +01:00
Samir Talwar
b815ab641d
Add the DAML-on-X team as code owners of /ledger/participant-state. (#5162)
* Add the DAML-on-X team as code owners of /ledger/participant-state.

Namely @dajmaki, @fabiotudone-da, @miklos-da, and @mziolekda.

CHANGELOG_BEGIN
CHANGELOG_END

* Add @dasormeter to the list of owners of /ledger/participant-state.

* DAML-on-X and Runtime own kvutils; just Runtime otherwise.

* Sort the owners of /ledger alphabetically.
2020-03-24 15:29:44 +00:00
Stephen Compall
37d36e1592
narrow LF codeowners; add ledger-service codeowners (#4704)
* codeown ledger-service

* daml-lf is too broad to be codeowned, narrow to something more sensible

CHANGELOG_BEGIN
CHANGELOG_END
2020-02-26 09:13:32 -08:00
Samir Talwar
72940d4487
Change @SamirTalwar to @SamirTalwar-DA in CODEOWNERS. (#4342)
I"m now using my Digital Asset-branded GitHub account.

CHANGELOG_BEGIN
CHANGELOG_END
2020-02-03 22:43:09 +00:00
Moritz Kiefer
9995b8563f
Fix codeowners file (#4306)
changelog_begin
changelog_end
2020-01-31 11:13:39 +01:00
Martin Huschenbett
b472b530af
Adjust CODEOWNERS file to new reality (#4293)
CHANGELOG_BEGIN
CHANGELOG_END
2020-01-30 21:23:14 +01:00
Gerolf Seitz
74c2306100
Add @SamirTalwar as codeowner of /ledger and /ledger-api (#3558) 2019-11-21 09:19:47 +01:00
Bernhard Elsner
9baced2b83
Add Nemanja as code-owner for docs (#3178) 2019-10-15 11:07:21 +02:00
Stefano Baghino
afa4659292
New Ledger API test tool (#2282)
* New acceptance test tool prototype

* Fix transaction filter helper

* Address https://github.com/digital-asset/daml/pull/2282#discussion_r308081386

* Address https://github.com/digital-asset/daml/pull/2282#discussion_r308082432

Moreover, creates specific helpers for test DAML code.

* Move helpers from session to context

Remove a circular dependency between session and context, and limits the
usage of implicits.

* Run tests with ledgers out of process

* Prepare for drop in

* Temporary timeout increase

* Move bulk of the logic to the test runner

* Have a map of tests for CLI integration

* Timeout per-test, runner uses context, renaming

* Allow usage of time service, integrate semantic tests

* Integrate CLI SSL configuration

* Integrate failure expectation CLI option

* Integrate with failure output verbosity CLI option

* Integrate with test listing and picking CLI options

* Integrate with timeout scaling CLI option

* Integrate with command TTL CLI option

* Review CODEOWNERS

* Drop previously unimplemented CLI parameters

* Expand test todo list to encompass latest additions

* Deduplicate some testing infrastructure, swap in new test tool

* Remove unused rule

* Address https://github.com/digital-asset/daml/pull/2282#discussion_r311045444

* Address https://github.com/digital-asset/daml/pull/2282#discussion_r311051974

* Address https://github.com/digital-asset/daml/pull/2282#discussion_r311035287

* Address https://github.com/digital-asset/daml/pull/2282#discussion_r311055290

* WIP

* Make gRPC thread factory spawn non-deamon threads

* Remove debug prints, complete divulgence test (missing assertion messages)

* Try to detect assertion failure line number

* Add Sandbox binary that starts an ephemeral postgres instance

This allows us to use the client_server_test bazel macro to run against
the sandbox backed by postgres.

Fixes #1543

* Add Sandbox binary that starts an ephemeral postgres instance

This allows us to use the client_server_test bazel macro to run against
the sandbox backed by postgres.

Fixes #1543

* Address https://github.com/digital-asset/daml/pull/2282#discussion_r311400695

* Remove TlsConfiguration duplicate, move original to commons

* Make assertion more readable

Co-Authored-By: Gerolf Seitz <gerolf.seitz@digitalasset.com>

* Fix build errors introduced in previous commit

- exclude time service tests from reference-v2
- add copyright header to TlsConfiguration

* Complete divulgence test and address review comments

Restores comments from original divulgence tests and strives to be as
close to them as possible.

- Address https://github.com/digital-asset/daml/pull/2282#discussion_r311429169
- Address https://github.com/digital-asset/daml/pull/2282#discussion_r311431156
- Address https://github.com/digital-asset/daml/pull/2282#discussion_r311431913

* Delete old divulgence tests

* Restore methods to fetch contracts by template identifier

* Run conformance tests on in-memory sandbox

* Run conformance tests on the persistent sandbox

* Remove workflow identifier workaround

* New contract keys test (#2452)

* Set channel type for LedgerSession

* Add ContractKeysIT

* Run tests against reference-server v2

* Removed the old ContractKeysIT. However, ...

... I cannot remove ContractKeysChecks completely, because we have
another test path for DARs created prior to DAML-LF 1.6, which doesn't
have the submitter == maintainer restriction for contract keys.

* Use codegen instead of custom code

* Add missing copyright headers

* Drop sandbox conformance test suite (seems to not work on Windows CI)

* Make time simpler

* Test tool tests to run only semantic tests

* Make CI behave more consistently

* Add missing files to run tests on Postrgres

* Fix flaky divulgence test, introduce readable identifiers

* Increase sandbox conformance tests timeout

* Address https://github.com/digital-asset/daml/pull/2282#discussion_r312363246

* Reintroduce test resource extraction

* Read semantic tests from the classpath rather than Bazel

* Use codegen types for ContractKeys integration test

allocateParty returns Primitive.Party and create and exercise also
accept Primitive.Party. This way we don't have to keep a String and
Primitive.Party representation around.

* Bump timeout for sandbox conformance tests

* Remove dependency on Bazel runfiles
2019-08-09 17:00:37 +02:00