mirror of
https://github.com/digital-asset/daml.git
synced 2024-09-20 09:17:43 +03:00
629ec732dd
* Include puppeteer tests in compat tests
This PR adds the puppeteer based tests to the compatibility
tests. This also means that they are now actually compatibility
tests. Before, we only tested the SDK side.
Apart from process management being a nightmare on Windows as usually,
there are two things that might stick out here:
1. I’ve replaced the `sh_binary` wrapper by a `cc_binary`. There is a
lengthy comment explaining why. I think at the moment, we could
actually get rid of the wraper completely and add JAVA to path in
the tests that need it but at least for now, I’d like to keep it
until we are sure that we don’t need to add more to it (and then
it’s also in the git history if we do need to resurrect it).
2. These tests are duplicated now similar to the `daml ledger *`
tests. The reasoning here is different. They depend on the SDK
tarball either way so performance wise there is no reason to keep
them. However, we reference the other file in the docs which means
we cannot change it freely. What we could do is to make this
sufficiently flexible to handle both the `daml start` case and
separate `daml sandbox`/`daml json-api` processes and then we can
reference it in the docs. There is still added complexity for
Windows but that’s necessary for users as well that want to run
this on Windows so that seems unavoidable. (I should probably also
remove my snarky comments 😇) I’d like to kee it duplicated
for this PR and then we can clean it up afterwards.
changelog_begin
changelog_end
* Bump timeouts
changelog_begin
changelog_end
|
||
|---|---|---|
| .. | ||
| bazel_tools | ||
| head_sdk | ||
| sandbox-migration | ||
| versions | ||
| .bazelignore | ||
| bazel-haskell-deps.bzl | ||
| BUILD | ||
| build-release-artifacts-windows.ps1 | ||
| build-release-artifacts.sh | ||
| build-ts-libs.sh | ||
| deps.bzl | ||
| README.md | ||
| stack-snapshot.yaml | ||
| test-windows.ps1 | ||
| test.sh | ||
| update-versions.sh | ||
| versions.bzl | ||
| WORKSPACE | ||
| workspace_status.sh | ||
This directory contains the infrastructure and test setup for cross-version compatibility testing. We make this a separate Bazel workspace to make it easier to enforce that we only depend on release artifacts.