daml/daml-lf/interpreter
Remy 7ec55d7f33
LF: Cache field index inside structural record projection builtin (#12338)
Currently we have two implementations for the projection of structural
record.

1- The first implementation takes as parameter the index of the
projected field and is therefore constant. This implementations is
used when the type checking is enable, as the index cannot be directly
inferred from the AST and must hence be filled in by the DAML-LF type
checker.

2- The second implementation takes as parameter the name of the
projected field and is therefore logarithmic as the field must be
lookup by binary search at each call. This version is used when the
type checking is disable as the index cannot be inferred without type
inference.

In this PR, we modify the second implementation so it cache the index
at the first call, hence avoiding the recomputation during further
calls.  In this way we reach an amortized constant complexity.  The
first implementation is decommissioned in benefit of the second one.

The advantages of this approach are:

- We have a unique implementation of the projection, so the behavior
  of a program is the same whenever the type checking is on or off.

- The AST for structural projection is immutable.

Benchmarks show no performance differences when the type checking is on.

Based on an idea by @sofiafaro-da.

CHANGELOG_BEGIN
CHANGELOG_END
2022-01-11 13:03:21 +01:00
..
perf update copyright headers (#12240) 2022-01-03 16:36:51 +00:00
src LF: Cache field index inside structural record projection builtin (#12338) 2022-01-11 13:03:21 +01:00
BUILD.bazel LF: Benchmark for structural record projection (#12329) 2022-01-11 10:36:48 +01:00