daml/compiler/damlc/daml-ide-core
Moritz Kiefer 0f070ff34e
Remove mkOptions and defaultOptionsIO (#4323)
* Remove mkOptions and defaultOptionsIO

`mkOptions` is a terrible API and this PR burns it with lots of 🔥.

The only thing that I didn’t simply move around is the validation
logic in `mkOptions` which validates that some directories
exist. Given that I’ve never actually see this be useful and the
options to set these directories (package dbs, import paths) are
internal I don’t think we actually gain anything from this.

I’ve also killed defaultOptionsIO which was a very confusing wrapper
around `mkOptions` that in addition to calling `mkOptions` also
enabled DLint. This was only used in tests, so I’ve enabled DLint in
the tests that need this.

changelog_begin
changelog_end

* newtype version header
2020-01-31 13:39:54 +00:00
..
src/Development/IDE/Core Remove mkOptions and defaultOptionsIO (#4323) 2020-01-31 13:39:54 +00:00
test/Development/IDE/State/API Remove mkOptions and defaultOptionsIO (#4323) 2020-01-31 13:39:54 +00:00
BUILD.bazel Remove mkOptions and defaultOptionsIO (#4323) 2020-01-31 13:39:54 +00:00
dlint.yaml Update hlint (#4276) 2020-01-30 00:06:18 +00:00