mirror of
https://github.com/digital-asset/daml.git
synced 2024-09-20 09:17:43 +03:00
a1d8e8dc33
* add getCommandsInFlight as a TriggerA action * immediately update commandsInFlight on emitCommands - delay until the rule had returned made sense before submitCommands was launched immediately; this also makes `getCommandsInFlight` more sensible * remove commands-in-flight argument from high-level Trigger rule CHANGELOG_BEGIN - [Triggers] The "commands in flight" or ``Map CommandId [Command]`` argument has been removed from high-level trigger ``rule`` functions; instead, the current commands-in-flight can be retrieved with the new ``getCommandsInFlight`` function, which can be done immediately at the beginning of the rule's ``do`` block to preserve exact existing trigger behavior. See `issue #7600 <https://github.com/digital-asset/daml/pull/7600>`__. CHANGELOG_END * remove commands-in-flight argument from trigger tests * update doc examples and copy in compatibility - compatibility change will most likely entail another flag day in compatibility tests, replacing last_pre_7456_trigger_version * update doc text for getCommandsInFlight * test that getCommandsInFlight gets updated during the rule * flag day for trigger compatibility tests sdk-version: 1.7.0-snapshot.20201006.5358.0.0c1cadcf File: src/CopyTrigger.daml Hidden: no Range: 55:11-55:19 Source: typecheck Severity: DsError Message: src/CopyTrigger.daml:55:12: error: • Couldn't match type ‘TriggerA ()’ with ‘() -> TriggerA ()’ Expected type: Party -> DA.Next.Map.Map CommandId [Command] -> () -> TriggerA () Actual type: Party -> ACS -> () -> TriggerA () • In the ‘rule’ field of a record In the expression: Trigger {initialize = \ _acs -> (), updateState = \ _acs _message () -> (), rule = copyRule, registeredTemplates = AllInDar, heartbeat = None} In an equation for ‘copyTrigger’: copyTrigger = Trigger {initialize = \ _acs -> (), updateState = \ _acs _message () -> (), rule = copyRule, registeredTemplates = AllInDar, heartbeat = None} * match docs on TriggerAState to current usage of these fields * remove emittedCommands, as commandsInFlight is now kept up-to-date * zoomed from where? Co-authored-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org> |
||
|---|---|---|
| .. | ||
| client_server | ||
| create-daml-app | ||
| daml_ledger | ||
| daml_script | ||
| daml_trigger | ||
| data_dependencies | ||
| test_utils | ||
| BUILD | ||
| create_daml_app_test.sh | ||
| daml_ledger_test.sh | ||
| daml_sdk.bzl | ||
| daml.cc.tpl | ||
| sandbox-with-postgres.sh | ||
| testing.bzl | ||
| versions.bzl | ||