mirror of
https://github.com/digital-asset/daml.git
synced 2024-09-20 17:28:46 +03:00
e54809cecc
The `sandbox-perf` build has been failing for a while with the following errors: ``` INFO: From Generating benchmark code for //ledger/sandbox-perf:sandbox-perf_codegen: JMH benchmark generation: JMH Benchmark generator failed JMH benchmark generation: Benchmark classes should not be final. [com.digitalasset.platform.sandbox.perf.LargeTransactionBench] JMH benchmark generation: The instantiated @State class cannot be abstract. [com.digitalasset.platform.sandbox.perf.PerfBenchState] ``` However, these errors are ignored; running the benchmarks runs the `AcsBench` benchmark and ignores the fact `LargeTransactionBench` and `SimpleBench` failed to compile. I've fixed the errors by making sure that classes are not final, and that `SimpleBench` uses a concrete state class. This also introduces a cheap patch to the Scala JMH Bazel rules that makes sure they fail if there are any errors. I'm not really sure how to patch the Bazel rules properly, but someone else might have an idea. :-) CHANGELOG_BEGIN CHANGELOG_END Co-authored-by: Samir Talwar <samir.talwar@digitalasset.com> |
||
|---|---|---|
| .. | ||
| client_server | ||
| dev_env_tool | ||
| docs | ||
| java_testing | ||
| packaging | ||
| runfiles | ||
| BUILD.bazel | ||
| create_workspace.bzl | ||
| docs.bzl | ||
| fat_cc_library.bzl | ||
| ghc_dwarf.bzl | ||
| ghci-template.sh | ||
| grpc-bazel-mingw.patch | ||
| grpc-haskell-core-cpp-options.patch | ||
| grpc-java-plugin-visibility.patch | ||
| haskell_public_ghci_repl_wrapper.patch | ||
| haskell-c2hs.patch | ||
| haskell-cc-wrapper-darwin-rpath-library-dirs.patch | ||
| haskell-ghci-grpc.patch | ||
| haskell-ghcide-expose-compat.patch | ||
| haskell-hie-bios.patch | ||
| haskell-lsp-test-no-reexport.patch | ||
| haskell-no-isystem.patch | ||
| haskell-opt.patch | ||
| haskell-optional-cabal-haddock.patch | ||
| haskell-windows-extra-libraries.patch | ||
| haskell-windows-remove-fake-libs.patch | ||
| haskell.bzl | ||
| hlint.bzl | ||
| java.bzl | ||
| javadoc_library.bzl | ||
| os_info.bzl | ||
| pkg.bzl | ||
| pom_file.bzl | ||
| pom_template.xml | ||
| proto-zlib-url.patch | ||
| proto.bzl | ||
| rules_nodejs_bash.patch | ||
| rules_nodejs_npm_cli_path.patch | ||
| scala-escape-jvmflags.patch | ||
| scala-fail-jmh-build-on-error.patch | ||
| scala.bzl | ||
| sdk_version.bzl | ||