mirror of
https://github.com/digital-asset/daml.git
synced 2024-09-19 00:37:23 +03:00
7f2a950da0
* Fix ./fmt.sh check We accidentally introduced hlint lints when we added the compatibility workspace. The hlint code in ./fmt.sh correctly detects that there is a hint but then exits with 0 since it uses the exit code from `echo` rather than the one from `hlint`. The info that we printed with `echo` didn’t actually make any sense so I added a new comment as to why we run hlint here. This requires some setup changes so that the compatibility workspace gets the same Haskell flags since otherwise using the same hlint rules obviously does not make sense. Fixes #5701 changelog_begin changelog_end * Update fmt.sh Co-Authored-By: Samir Talwar <samir.talwar@digitalasset.com> Co-authored-by: Samir Talwar <samir.talwar@digitalasset.com>
126 lines
4.8 KiB
Bash
Executable File
126 lines
4.8 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
# Copyright (c) 2020 Digital Asset (Switzerland) GmbH and/or its affiliates. All rights reserved.
|
|
# SPDX-License-Identifier: Apache-2.0
|
|
#
|
|
# Run formatters and linter, anything platform-independent and quick
|
|
#
|
|
# Usage: ./fmt.sh [--test]
|
|
set -euo pipefail
|
|
|
|
cd "$(dirname "$0")"
|
|
# load the dev-env
|
|
eval "$(dev-env/bin/dade-assist)"
|
|
|
|
## Config ##
|
|
is_test=
|
|
scalafmt_args=()
|
|
hlint_diff=false
|
|
dade_copyright_arg=update
|
|
buildifier_target=//:buildifier-fix
|
|
|
|
## Functions ##
|
|
|
|
log() {
|
|
echo "fmt.sh: $*" >&2
|
|
}
|
|
|
|
run() {
|
|
echo "$ ${*%Q}"
|
|
"$@"
|
|
ret=$?
|
|
if [[ $is_test = 1 && $ret -gt 0 ]]; then
|
|
log "command failed with return $ret"
|
|
log
|
|
log "run ./fmt.sh to fix the issue"
|
|
exit 1
|
|
fi
|
|
return 0
|
|
}
|
|
|
|
## Main ##
|
|
|
|
while [[ $# -gt 0 ]]; do
|
|
case "$1" in
|
|
-h | --help)
|
|
cat <<USAGE
|
|
Usage: ./fmt.sh [options]
|
|
|
|
Options:
|
|
-h, --help: shows this help
|
|
--test: only test for formatting changes, used by CI
|
|
USAGE
|
|
exit
|
|
;;
|
|
--test)
|
|
shift
|
|
is_test=1
|
|
scalafmt_args+=(--test)
|
|
dade_copyright_arg=check
|
|
buildifier_target=//:buildifier
|
|
;;
|
|
--diff)
|
|
shift
|
|
scalafmt_args+=(--mode=diff --diff-branch=origin/master)
|
|
hlint_diff=true
|
|
;;
|
|
*)
|
|
echo "fmt.sh: unknown argument $1" >&2
|
|
exit 1
|
|
;;
|
|
esac
|
|
done
|
|
|
|
echo "\
|
|
─────────────────────────────▄██▄
|
|
──FORMAT ALL THE THINGS!!!───▀███
|
|
────────────────────────────────█
|
|
───────────────▄▄▄▄▄────────────█
|
|
──────────────▀▄────▀▄──────────█
|
|
──────────▄▀▀▀▄─█▄▄▄▄█▄▄─▄▀▀▀▄──█
|
|
─────────█──▄──█────────█───▄─█─█
|
|
─────────▀▄───▄▀────────▀▄───▄▀─█
|
|
──────────█▀▀▀────────────▀▀▀─█─█
|
|
──────────█───────────────────█─█
|
|
▄▀▄▄▀▄────█──▄█▀█▀█▀█▀█▀█▄────█─█
|
|
█▒▒▒▒█────█──█████████████▄───█─█
|
|
█▒▒▒▒█────█──██████████████▄──█─█
|
|
█▒▒▒▒█────█───██████████████▄─█─█
|
|
█▒▒▒▒█────█────██████████████─█─█
|
|
█▒▒▒▒█────█───██████████████▀─█─█
|
|
█▒▒▒▒█───██───██████████████──█─█
|
|
▀████▀──██▀█──█████████████▀──█▄█
|
|
──██───██──▀█──█▄█▄█▄█▄█▄█▀──▄█▀
|
|
──██──██────▀█─────────────▄▀▓█
|
|
──██─██──────▀█▀▄▄▄▄▄▄▄▄▄▀▀▓▓▓█
|
|
──████────────█▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓█
|
|
──███─────────█▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓█
|
|
──██──────────█▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓█
|
|
──██──────────█▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓█
|
|
──██─────────▐█▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓█
|
|
──██────────▐█▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓█
|
|
──██───────▐█▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓█▌
|
|
──██──────▐█▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓█▌
|
|
──██─────▐█▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓█▌
|
|
──██────▐█▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓█▌
|
|
"
|
|
|
|
# Check for correct copyrights
|
|
run dade-copyright-headers "$dade_copyright_arg" .
|
|
|
|
# We do test hlint via Bazel rules but we run it separately
|
|
# to get linting failures early.
|
|
if [ "$hlint_diff" = "true" ]; then
|
|
changed_haskell_files="$(git diff --name-only origin/master | grep '\.hs$' || [[ $? == 1 ]])"
|
|
if [ "" != "$changed_haskell_files" ]; then
|
|
hlint -j4 $changed_haskell_files
|
|
fi
|
|
else
|
|
hlint --git -j4
|
|
fi
|
|
|
|
# check for scala code style
|
|
run scalafmt "${scalafmt_args[@]:-}"
|
|
|
|
# check for Bazel build files code formatting
|
|
run bazel run "$buildifier_target"
|