daml/rules_daml
dylant-da 5527dda0e6
Participant Upload-Time Check for Upgrades (#18102)
* initial progress

* lint

* Implement typechecks for fields of datatypes

* lint

* check keys, refactor datatype origin check

* Rewrite test to check canton output

* Emit upgradeability errors in package service, test in UpgradesIT

* Refactor packageManagementClient Upgrades test for multiple dars

* lint

* check using upgraded pair, refactor upgrades

run-all-tests: true

* Re-enable warnings, fix up comments

* track ValidUpgrade

* Start writing variants for upgrade errors

* Move upgrades typechecking into validation, improve naming

* omit unnecessary curly braces

* lint

* Make TypecheckUpgrades fields private

* Rename stripPackageIds to unifyPackageIds, small syntactic fixes

* Fix dataTypeOrigin to not rebuild the ChoiceNameMap each time

* Improve logging, inline some declarations in for comprehensions

* revert `cantonFixtureDebugMode = true` to false

* Structure error messages in Upgrading

* Fix expected error messages

* Fix expected message for upgrade notification

* Port new checks from https://github.com/digital-asset/daml/pull/18172

* Fix bug that makes package resolution fail

* Implement rest of error messages, and expect them - some refactoring

run-all-tests: true

* Replace curly braces with `with` keyword in tests

* lint

* Move UpgradesIT to validation tests

* Turn adding a template key into an upgrade error

* Fix deps for upgrades integration test

* lint

run-all-tests: true

* Remove temporary files after reading log info

* Make UpgradeError extend ValidationError, use Unhandled for other errs

* Port DamlcUpgrades over to scala-side UpgradesSpec

* lint

* remove inplace files

* fix metadata flatMap, add back deps for other daml-lf validations tests

* Clarify "this package" to "upgrading package"

* update TODO comment to point to relevant PR (#18377)

* lint

* update expected messages for Missing{Module,Template,Choice,Datatype}

* Use 3-part enum for cantonFixtureDebugMode (debug or remove/keep files)

* apply Remy's recommended linting changes, reorg code slightly

* lint

* More refactoring, fix package service for changed error fields

* Reset canton/community codedrop, remove canton participant upgrade test

---------

Co-authored-by: Carl Pulley <carl.pulley@digitalasset.com>
2024-02-05 18:54:56 +00:00
..
BUILD.bazel update copyright (#18167) 2024-01-15 20:27:42 +01:00
daml.bzl Participant Upload-Time Check for Upgrades (#18102) 2024-02-05 18:54:56 +00:00
generate-dar-hash.py update copyright (#18167) 2024-01-15 20:27:42 +01:00