mirror of
https://github.com/digital-asset/daml.git
synced 2024-09-20 09:17:43 +03:00
29ed16b4cc
* Improve handling of exposed-modules with data-dependencies Previously, we tried to rename all modules of a dependency via --package. This fails if some of those modules are not exported. This was trivial to hit as a user since the ``daml-trigger`` library made use of this. This PR adds a few things to improve the situation: 1. We only rename modules that are exposed. This fixes the issue if you don’t actually reference a non-exposed module from your data-dependency. 2. I’ve removed the exposed-modules from daml-trigger. I don’t think they are essential here given that the module name has `Internal` in the name and it’s too easy to have something that actually references the non-exposed module since the types are reexported. 3. I’ve added documentation that mentions this issue. 4. I’ve added a warning if your exposed-modules are excluding some modules. Maybe worth turning this into an error in the future. changelog_begin changelog_end * Update compiler/damlc/lib/DA/Cli/Damlc/Packaging.hs Co-Authored-By: associahedron <231829+associahedron@users.noreply.github.com> Co-authored-by: associahedron <231829+associahedron@users.noreply.github.com> |
||
|---|---|---|
| .. | ||
| daml | ||
| runner | ||
| service | ||
| tests | ||