daml/ledger
Stefano Baghino f9839a7e4c
Re-order fields in records if all labels are provided (#989)
* Re-order fields in records if all labels are provided

Fixes #988

* Add line to release notes

* Fix line on release notes

* Document change on the Ledger API definition

* Simplify pattern matching

* Improve and fix tests

Integration tests now look for the "Missing field label" rather then the
"Mismatching record label" when inspecting errors. Furthermore, a test
has been added that ensures that repetitions in labels still raise an
error.

* Add comment

Comment about relationship between fields length check and fields reordering based on labels

Co-Authored-By: stefanobaghino-da <43749967+stefanobaghino-da@users.noreply.github.com>

* Improve Ledger API docstring

Explicitly state the semantics of labeled fields (i.e. repeated keys are not accepted)

Co-Authored-By: stefanobaghino-da <43749967+stefanobaghino-da@users.noreply.github.com>
2019-05-08 12:54:53 +02:00
..
api-server-damlonx Upgrade to nixpkgs 19.03 (again) (#962) 2019-05-07 13:55:30 +02:00
backend-api respect contract visibility when looking up contract keys (#753) 2019-05-02 14:02:30 +00:00
ledger-api-akka Enforce consistent formatting of BUILD files. (#412) 2019-04-12 13:10:16 +02:00
ledger-api-client CommandService returns useful data for successful submissions (#875) 2019-05-03 16:01:41 +02:00
ledger-api-common Daml lf type safty (Party & PackageId) (#761) 2019-05-06 20:40:43 +02:00
ledger-api-domain Ledger Api: drop ledger api domain values in favor of LF-values (#649) 2019-04-25 23:15:12 +00:00
ledger-api-integration-tests Re-order fields in records if all labels are provided (#989) 2019-05-08 12:54:53 +02:00
ledger-api-scala-logging Add TransactionService methods for looking up flat transactions (#830) 2019-05-03 09:03:12 +02:00
ledger-api-server-example Daml lf type safty (Party & PackageId) (#761) 2019-05-06 20:40:43 +02:00
ledger-api-test-tool Extend test durations on CI for Ledger API Test Tool driven test. (#944) 2019-05-07 14:52:49 +02:00
participant-state Fixes to kvutils when used as external workspace (#984) 2019-05-07 17:55:11 +02:00
participant-state-index Daml lf type safty (Party & PackageId) (#761) 2019-05-06 20:40:43 +02:00
sandbox making batch queries nicer (#968) 2019-05-07 15:34:26 +02:00
sandbox-perf Daml lf type safty (Party & PackageId) (#761) 2019-05-06 20:40:43 +02:00
scripts correct jq in dev-env (#463) 2019-04-12 16:44:15 -04:00
API.md open-sourcing daml 2019-04-04 09:33:38 +01:00
CONTRIBUTING.md open-sourcing daml 2019-04-04 09:33:38 +01:00
README.md Update README.md (#640) 2019-04-23 17:47:54 +00:00
UNRELEASED.md open-sourcing daml 2019-04-04 09:33:38 +01:00

ledger

Home of our reference ledger implementation (Sandbox) and various ledger related libraries.

v1 gRPC API

The v1 gRPC API is described here

Logging

Logging Configuration

Ledger Server uses Logback for logging configuration.

Log Files

By default our log configuration creates two log files:

  • a plaintext file logs/ledger.log
  • a json file logs/ledger.json.log (for Logstash type log processors)

The path the file is stored in can be adjusted by setting -Dlogging.location=some/other/path. The filename used can be adjusted by setting -Dlogging.file=my-process-logs.

By default no output is sent to stdout (beyond logs from the logging setup itself).

standard streams logging

For development and testing it can be useful to send all logs to stdout & stderr rather than files (for instance to use the IntelliJ console or getting useful output from docker containers).

We ship a logging configuration for this which can be enabled by using -Dlogback.configurationFile=classpath:logback-standard.xml -Dlogging.config=classpath:logback-standard.xml.

INFO level and below goes to stdout. WARN and above goes to stderr.

_Note: always use both -Dlogback.configurationFile and -Dlogging.config. Logback is first initialized with the configuration file from logback.configurationFile. When the Spring framework boots it recreates logback and uses the configuration specified in logging.config.

Log levels

As most Java libraries and frameworks, ledger server uses INFO as the default logging level. This level is for minimal and important information (usually only startup and normal shutdown events). INFO level logging should not produce increasing volume of logging during normal operation.

WARN level should be used for transition between healthy/unhealthy state, or in other close to error scenarios.

DEBUG level should be turned on only when investigating issues in the system, and usually that means we want the trail loggers. Normal loggers at DEBUG level can be useful sometimes (e.g. DAML interpretation).

gRPC and back-pressure

RPC

Standard RPC requests should return with RESOURCE_EXHAUSTED status code to signal back-pressure. Envoy can be configured to retry on these errors. We have to be careful not to have any persistent changes when returning with such an error as the same original request can be retried on another service instance.

Streaming

gRPC's streaming protocol has built-in flow-control, but it's not fully active by default. What it does it controls the flow between the TCP/HTTP layer and the library so it builds on top of TCP's own flow control. The inbound flow control is active by default, but the outbound does not signal back-pressure out of the box.

AutoInboundFlowControl: The default behaviour for handling incoming items in a stream is to automatically signal demand after every onNext call. This is the correct thing to do if the handler logic is CPU bound and does not depend on other reactive downstream services. By default it's active on all inbound streams. One can disable this and signal demand by manually calling request to follow demands of downstream services. Disabling this feature is possible by calling disableAutoInboundFlowControl on CallStreamObserver.

ServerCallStreamObserver: casting an outbound StreamObserver manually to ServerCallStreamObserver gives us access to isReady and onReadyHandler. With these methods we can check if there is available capacity in the channel i.e. we are safe to push into it. This can be used to signal demand to our upstream flow. Note that gRPC buffers 32Kb data per channel and isReady will return false only when this buffer gets full.