dillonkearns/elm-pages-v3-beta
1
1
Fork 0
mirror of https://github.com/dillonkearns/elm-pages-v3-beta.git synced 2024-12-27 05:44:17 +03:00
Code Issues Packages Projects Releases Wiki Activity

Remove module contract requirement for View.placeholder since it is obsolete now with new scaffolding.

Browse Source
This commit is contained in:
Dillon Kearns 2022-09-09 13:09:02 -07:00
parent 2d7f1961e3
commit 459f6df9de
3 changed files with 4 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
examples/todos/app/View.elm
View File

@ -1,4 +1,4 @@
module View exposing (View, map, placeholder)
module View exposing (View, map)
{-|
@ -22,11 +22,3 @@ map fn doc =
{ title = doc.title
, body = List.map (Html.map fn) doc.body
}
{-| -}
placeholder : String -> View msg
placeholder moduleName =
{ title = "Placeholder - " ++ moduleName
, body = [ Html.text moduleName ]
}

2
src/Pages/Review/NoContractViolations.elm
View File

@ -130,7 +130,7 @@ coreModulesAndExports =
, ( [ "ErrorPage" ], [ "ErrorPage", "notFound", "internalError", "view", "statusCode", "head" ] )
, ( [ "Shared" ], [ "Data", "Model", "Msg", "template" ] )
, ( [ "Site" ], [ "config" ] )
, ( [ "View" ], [ "View", "map", "placeholder" ] )
, ( [ "View" ], [ "View", "map" ] )
]

4
tests/Pages/Review/NoContractViolationsTest.elm
View File

@ -292,7 +292,7 @@ invalid = Debug.todo ""
, [ Review.Test.error
{ message = "A core elm-pages module needs to expose something"
, details =
[ "The View module must expose `View`, `map`, `placeholder`"
[ "The View module must expose `View`, `map`"
]
, under = "exposing (invalid)"
}
@ -325,7 +325,7 @@ routes = Debug.todo ""
, """module Site exposing (config)
routes = Debug.todo ""
"""
, """module View exposing (View, map, placeholder)
, """module View exposing (View, map)
routes = Debug.todo ""
"""
]