Review fixes.

This commit is contained in:
Dillon Kearns 2021-06-03 18:10:06 -07:00
parent 03f8ee359f
commit 605b353065
10 changed files with 29 additions and 22 deletions

View File

@ -32,9 +32,10 @@ import Review.Rule as Rule exposing (Rule)
config : List Rule
config =
[ -- NoExposingEverything.rule
--, NoImportingEverything.rule []
NoMissingTypeAnnotation.rule
[ NoExposingEverything.rule
--NoImportingEverything.rule []
, NoMissingTypeAnnotation.rule
, NoMissingTypeAnnotationInLetIn.rule
, NoMissingTypeExpose.rule
|> Rule.ignoreErrorsForFiles

View File

@ -1,4 +1,4 @@
module Pages.Internal.Platform.Mode exposing (..)
module Pages.Internal.Platform.Mode exposing (Mode(..), modeDecoder)
import Json.Decode as Decode exposing (Decoder)

View File

@ -1,4 +1,14 @@
module Pages.Internal.Platform.ToJsPayload exposing (..)
module Pages.Internal.Platform.ToJsPayload exposing
( FileToGenerate
, InitialDataRecord
, ToJsPayload(..)
, ToJsSuccessPayload
, ToJsSuccessPayloadNew
, ToJsSuccessPayloadNewCombined(..)
, successCodecNew2
, toJsCodec
, toJsPayload
)
import BuildError exposing (BuildError)
import Codec exposing (Codec)

View File

@ -1,4 +1,4 @@
module Pages.Internal.String exposing (..)
module Pages.Internal.String exposing (chopEnd, chopForwardSlashes, chopStart)
{-| Remove a piece from the beginning of a string until it's not there anymore.

View File

@ -1,4 +1,4 @@
module Pages.ProgramConfig exposing (..)
module Pages.ProgramConfig exposing (ProgramConfig)
import ApiRoute
import Browser.Navigation

View File

@ -1,4 +1,10 @@
module RenderRequest exposing (..)
module RenderRequest exposing
( IncludeHtml(..)
, RenderRequest(..)
, RequestPayload(..)
, decoder
, maybeRequestPayload
)
import ApiRoute
import HtmlPrinter

View File

@ -1,4 +1,4 @@
module RequestsAndPending exposing (..)
module RequestsAndPending exposing (RequestsAndPending, decoder, get)
import Dict exposing (Dict)
import Json.Decode as Decode
@ -8,11 +8,6 @@ type alias RequestsAndPending =
Dict String (Maybe String)
init : RequestsAndPending
init =
Dict.empty
get : String -> RequestsAndPending -> Maybe String
get key requestsAndPending =
requestsAndPending
@ -20,11 +15,6 @@ get key requestsAndPending =
|> Maybe.andThen identity
insert : String -> String -> RequestsAndPending -> RequestsAndPending
insert key value requestsAndPending =
Dict.insert key (Just value) requestsAndPending
decoder : Decode.Decoder RequestsAndPending
decoder =
Decode.dict (Decode.string |> Decode.map Just)

View File

@ -1,4 +1,4 @@
module ApiRouteTests exposing (..)
module ApiRouteTests exposing (all)
import ApiRoute exposing (..)
import Expect

View File

@ -1,4 +1,4 @@
module PagesHttp exposing (..)
module PagesHttp exposing (expectString)
import Http exposing (Response(..))
import Pages.Http exposing (..)

View File

@ -1,4 +1,4 @@
module RouteTests exposing (..)
module RouteTests exposing (all)
import Expect
import List.Extra