mirror of
https://github.com/dillonkearns/elm-pages-v3-beta.git
synced 2024-12-29 14:56:36 +03:00
Scroll to top of page on page changes since Browser.application doesn't do that out of the box for you.
This commit is contained in:
parent
a8f114c0eb
commit
aef38a9a63
@ -1,6 +1,7 @@
|
||||
module Pages.Internal.Platform exposing (Content, Flags, Model, Msg, Page, Parser, Program, application, cliApplication)
|
||||
|
||||
import Browser
|
||||
import Browser.Dom as Dom
|
||||
import Browser.Navigation
|
||||
import Dict exposing (Dict)
|
||||
import Head
|
||||
@ -370,6 +371,7 @@ type AppMsg userMsg metadata view
|
||||
| UserMsg userMsg
|
||||
| UpdateCache (Result Http.Error (ContentCache metadata view))
|
||||
| UpdateCacheAndUrl Url (Result Http.Error (ContentCache metadata view))
|
||||
| PageScrollComplete
|
||||
|
||||
|
||||
type Model userModel userMsg metadata view
|
||||
@ -446,8 +448,24 @@ update allRoutes canonicalSiteUrl viewFunction pathKey onPageChangeMsg toJsPort
|
||||
( model, Browser.Navigation.load href )
|
||||
|
||||
UrlChanged url ->
|
||||
let
|
||||
navigatingToSamePage =
|
||||
url.path
|
||||
== model.url.path
|
||||
&& url
|
||||
/= model.url
|
||||
in
|
||||
( model
|
||||
, model.contentCache
|
||||
, if navigatingToSamePage then
|
||||
-- this saves a few CPU cycles, but also
|
||||
-- makes sure we don't send an UpdateCacheAndUrl
|
||||
-- which scrolls to the top after page changes.
|
||||
-- This is important because we may have just scrolled
|
||||
-- to a specific page location for an anchor link.
|
||||
Cmd.none
|
||||
|
||||
else
|
||||
model.contentCache
|
||||
|> ContentCache.lazyLoad document url
|
||||
|> Task.attempt (UpdateCacheAndUrl url)
|
||||
)
|
||||
@ -527,13 +545,19 @@ update allRoutes canonicalSiteUrl viewFunction pathKey onPageChangeMsg toJsPort
|
||||
, contentCache = updatedCache
|
||||
, userModel = userModel
|
||||
}
|
||||
, userCmd |> Cmd.map UserMsg
|
||||
, Cmd.batch
|
||||
[ userCmd |> Cmd.map UserMsg
|
||||
, Task.perform (\_ -> PageScrollComplete) (Dom.setViewport 0 0)
|
||||
]
|
||||
)
|
||||
|
||||
Err _ ->
|
||||
-- TODO handle error
|
||||
( { model | url = url }, Cmd.none )
|
||||
|
||||
PageScrollComplete ->
|
||||
( model, Cmd.none )
|
||||
|
||||
CliMsg _ ->
|
||||
( model, Cmd.none )
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user