@@ -5,7 +5,6 @@ module Control.Distributed.Process.Tests.Mx (tests) where
6import Control.Distributed.Process.Tests.Internal.Utils
6import Control.Distributed.Process.Tests.Internal.Utils
7import Network.Transport.Test (TestTransport(..))
7import Network.Transport.Test (TestTransport(..))
8−import Control.Exception (SomeException)
9import Control.Distributed.Process hiding (bracket, finally, try)
8import Control.Distributed.Process hiding (bracket, finally, try)
10import Control.Distributed.Process.Internal.Types
9import Control.Distributed.Process.Internal.Types
11 ( ProcessExitException(..)
10 ( ProcessExitException(..)
@@ -39,7 +38,7 @@ import Control.Monad.Catch(finally, bracket, try)
39import Control.Rematch (equalTo)
38import Control.Rematch (equalTo)
40import Data.Binary
39import Data.Binary
41import Data.List (find, sort, intercalate)
40import Data.List (find, sort, intercalate)
42−import Data.Maybe (isJust, fromJust, isNothing, fromMaybe)
41+import Data.Maybe (isJust, fromJust, isNothing, fromMaybe, catMaybes)
43import Data.Typeable
42import Data.Typeable
44import GHC.Generics hiding (from)
43import GHC.Generics hiding (from)
45#if ! MIN_VERSION_base(4,6,0)
44#if ! MIN_VERSION_base(4,6,0)
@@ -67,7 +66,7 @@ awaitExit pid =
68 withMonitorRef p = bracket (monitor p) unmonitor
67 withMonitorRef p = bracket (monitor p) unmonitor
70−testAgentBroadcast :: TestResult () -> Process ()
69+testAgentBroadcast :: TestResult (Maybe ()) -> Process ()
71testAgentBroadcast result = do
70testAgentBroadcast result = do
72 (resultSP, resultRP) <- newChan :: Process (SendPort (), ReceivePort ())
71 (resultSP, resultRP) <- newChan :: Process (SendPort (), ReceivePort ())
@@ -82,10 +81,10 @@ testAgentBroadcast result = do
82 mxNotify ()
81 mxNotify ()
83 -- Once the publisher has seen our message, it will broadcast the Publish
82 -- Once the publisher has seen our message, it will broadcast the Publish
84 -- and the consumer will see that and send the result to our typed channel.
83 -- and the consumer will see that and send the result to our typed channel.
85− stash result =<< receiveChan resultRP
84+ stash result =<< receiveChanTimeout 10000000 resultRP
87− kill publisher "finished" >> awaitExit publisher
86+ kill publisher "finished"
88− kill consumer "finished" >> awaitExit consumer
87+ kill consumer "finished"
90testAgentDualInput :: TestResult (Maybe Int) -> Process ()
89testAgentDualInput :: TestResult (Maybe Int) -> Process ()
91testAgentDualInput result = do
90testAgentDualInput result = do
@@ -100,6 +99,8 @@ testAgentDualInput result = do
100 else mxReady)
99 else mxReady)
103 mxNotify (1 :: Int)
104 mxNotify (1 :: Int)
104 nsend "sum-agent" (3 :: Int)
105 nsend "sum-agent" (3 :: Int)
105 mxNotify (2 :: Int)
106 mxNotify (2 :: Int)
@@ -107,7 +108,10 @@ testAgentDualInput result = do
107 mxNotify (5 :: Int)
108 mxNotify (5 :: Int)
109 stash result =<< receiveChanTimeout 10000000 rp
110 stash result =<< receiveChanTimeout 10000000 rp
110− awaitExit s
111+ died <- receiveTimeout 10000000 [
112+ matchIf (\(ProcessMonitorNotification r _ _) -> r == mRef) (const $ return True)
114+ died `shouldBe` equalTo (Just True)
112testAgentPrioritisation :: TestResult [String] -> Process ()
116testAgentPrioritisation :: TestResult [String] -> Process ()
113testAgentPrioritisation result = do
117testAgentPrioritisation result = do
@@ -121,10 +125,10 @@ testAgentPrioritisation result = do
121 (sp, rp) <- newChan
125 (sp, rp) <- newChan
122 s <- mxAgent (MxAgentId name) ["first"] [
126 s <- mxAgent (MxAgentId name) ["first"] [
123 mxSink (\(s :: String) -> do
127 mxSink (\(s :: String) -> do
124− mxUpdateLocal ((s:))
128+ mxUpdateLocal (s:)
125 st <- mxGetLocal
129 st <- mxGetLocal
126 case length st of
130 case length st of
127− n | n == 5 -> do liftMX $ sendChan sp st
131+ n | n == 5 -> do liftMX $ sendChan sp (sort st)
128 mxDeactivate "finished"
132 mxDeactivate "finished"
129 _ -> mxReceive -- go to the mailbox
133 _ -> mxReceive -- go to the mailbox
@@ -135,7 +139,7 @@ testAgentPrioritisation result = do
135 mxNotify "fourth"
139 mxNotify "fourth"
136 nsend name "fifth"
140 nsend name "fifth"
138− stash result . sort =<< receiveChan rp
142+ stash result . fromMaybe [] =<< receiveChanTimeout 10000000 rp
139 awaitExit s
143 awaitExit s
141testAgentMailboxHandling :: TestResult (Maybe ()) -> Process ()
145testAgentMailboxHandling :: TestResult (Maybe ()) -> Process ()
@@ -148,12 +152,19 @@ testAgentMailboxHandling result = do
148 nsend "mailbox-agent" ()
152 nsend "mailbox-agent" ()
150 stash result =<< receiveChanTimeout 1000000 rp
154 stash result =<< receiveChanTimeout 1000000 rp
151− kill agent "finished" >> awaitExit agent
155+ kill agent "finished"
153testAgentEventHandling :: TestResult Bool -> Process ()
157testAgentEventHandling :: TestResult Bool -> Process ()
154testAgentEventHandling result = do
158testAgentEventHandling result = do
155− let initState = [] :: [MxEvent]
159+ us <- getSelfPid
160+ -- because this test is a bit racy, let's ensure it can't run indefinitely
161+ timer <- spawnLocal $ do
162+ pause (1000000 * 60 * 5)
163+ -- okay we've waited 5 mins, let's kill the test off if it's stuck...
165+ kill us "Test Timed Out"
167+ let initState = [] :: [MxEvent]
157 (rc, rs) <- newChan
168 (rc, rs) <- newChan
158 agentPid <- mxAgent (MxAgentId "lifecycle-listener-agent") initState [
169 agentPid <- mxAgent (MxAgentId "lifecycle-listener-agent") initState [
159 (mxSink $ \ev -> do
170 (mxSink $ \ev -> do
@@ -186,8 +197,7 @@ testAgentEventHandling result = do
186 -- TODO: yes, this is racy, but we're at the mercy of the scheduler here...
197 -- TODO: yes, this is racy, but we're at the mercy of the scheduler here...
187 faff 2000000 rs
198 faff 2000000 rs
189− _ <- monitor agentPid
190− (sp, rp) <- newChan
200+ (sp, rp) <- newChan :: Process (SendPort (), ReceivePort ())
192 pid <- spawnLocal $ expect >>= sendChan sp
202 pid <- spawnLocal $ expect >>= sendChan sp
@@ -196,9 +206,11 @@ testAgentEventHandling result = do
196 monitor pid
206 monitor pid
198 send pid ()
208 send pid ()
199− () <- receiveChan rp
209+ rct <- receiveChanTimeout 10000000 rp
210+ unless (isJust rct) $ die "No response on channel"
201− receiveWait [ match (\(ProcessMonitorNotification _ _ _) -> return ()) ]
212+ pmn <- receiveTimeout 2000000 [ match (\ProcessMonitorNotification{} -> return ()) ]
213+ unless (isJust pmn) $ die "No monitor notification arrived"
203 -- TODO: yes, this is racy, but we're at the mercy of the scheduler here...
215 -- TODO: yes, this is racy, but we're at the mercy of the scheduler here...
204 faff 2000000 rs
216 faff 2000000 rs
@@ -207,17 +219,16 @@ testAgentEventHandling result = do
207 mxNotify (MxSpawned pid, replyTo)
219 mxNotify (MxSpawned pid, replyTo)
208 mxNotify (MxProcessDied pid DiedNormal, replyTo)
220 mxNotify (MxProcessDied pid DiedNormal, replyTo)
210− seenAlive <- receiveChan reply
222+ seenAlive <- receiveChanTimeout 10000000 reply
211− seenDead <- receiveChan reply
223+ seenDead <- receiveChanTimeout 10000000 reply
213− stash result $ seenAlive && seenDead
225+ stash result $ foldr (&&) True $ catMaybes [seenAlive, seenDead]
214− kill agentPid "test-complete" >> awaitExit agentPid
226+ kill timer "test-complete"
227+ kill agentPid "test-complete"
216 faff delay port = do
229 faff delay port = do
217 res <- receiveChanTimeout delay port
230 res <- receiveChanTimeout delay port
218− unless (isNothing res) $ do
231+ unless (isNothing res) $ pause delay
222testMxRegEvents :: TestResult () -> Process ()
233testMxRegEvents :: TestResult () -> Process ()
223testMxRegEvents result = do
234testMxRegEvents result = do
@@ -264,7 +275,6 @@ testMxRegEvents result = do
264 reg3 `shouldBe` equalTo (Just (label, p1))
275 reg3 `shouldBe` equalTo (Just (label, p1))
266 mapM_ (flip kill $ "test-complete") [agent, p1, p2]
277 mapM_ (flip kill $ "test-complete") [agent, p1, p2]
269testMxRegMon :: LocalNode -> TestResult () -> Process ()
279testMxRegMon :: LocalNode -> TestResult () -> Process ()
270testMxRegMon remoteNode result = do
280testMxRegMon remoteNode result = do
@@ -322,70 +332,70 @@ testMxRegMon remoteNode result = do
322 evts `shouldContain` (Just (label1, p1))
332 evts `shouldContain` (Just (label1, p1))
323 evts `shouldContain` (Just (label2, p1))
333 evts `shouldContain` (Just (label2, p1))
325− kill agent "test-complete" >> awaitExit agent
335+ kill agent "test-complete"
327ensure :: Process () -> Process () -> Process ()
337ensure :: Process () -> Process () -> Process ()
328ensure = flip finally
338ensure = flip finally
330testNSend :: (String -> () -> Process ())
340testNSend :: (String -> () -> Process ())
331 -> Maybe LocalNode
341 -> Maybe LocalNode
333 -> Process ()
342 -> Process ()
334−testNSend op n r = testMxSend n r $ \p1 sink -> do
343+testNSend op n = do
335 let delay = 5000000
345 let delay = 5000000
336− let label = "testMxSend"
346+ let label = "testMxSend" ++ (show us)
337 let isValid = isValidLabel n label
347 let isValid = isValidLabel n label
349+ testMxSend n label $ \p1 sink -> do
339− register label p1
350+ register label p1
340− reg1 <- receiveChanTimeout delay sink
351+ reg1 <- receiveChanTimeout delay sink
341− case reg1 of
352+ case reg1 of
342− Just (MxRegistered pd lb)
353+ Just (MxRegistered pd lb)
343− | pd == p1 && isValid lb -> return ()
354+ | pd == p1 && isValid lb -> return ()
344− _ -> die $ "Reg-Failed: " ++ show reg1
355+ _ -> die $ "Reg-Failed: " ++ show reg1
346− op label ()
357+ op label ()
349− sent <- receiveChanTimeout delay sink
359+ sent <- receiveChanTimeout delay sink
350− case sent of
360+ case sent of
351− Just (MxSentToName lb by _)
361+ Just (MxSentToName lb by _)
352− | by == us && isValid lb -> return True
362+ | by == us && isValid lb -> return True
353− _ -> die $ "Send-Failed: " ++ show sent
363+ _ -> die $ "Send-Failed: " ++ show sent
356− isValidLabel n l1 l2
366+ isValidLabel nd l1 l2
357 | l2 == l2 = True
367 | l2 == l2 = True
358− | isJust n = l2 == l1 ++ "@" ++ show (localNodeId $ fromJust n)
368+ | isJust nd = l2 == l1 ++ "@" ++ show (localNodeId $ fromJust nd)
359 | otherwise = False
369 | otherwise = False
361testSend :: (ProcessId -> () -> Process ())
371testSend :: (ProcessId -> () -> Process ())
362 -> Maybe LocalNode
372 -> Maybe LocalNode
364 -> Process ()
373 -> Process ()
365−testSend op n r = testMxSend n r $ \p1 sink -> do
374+testSend op n = do
369− -- verify the management event
370 us <- getSelfPid
375 us <- getSelfPid
376+ let label = "testMxSend" ++ (show us)
377+ testMxSend n label $ \p1 sink -> do
381+ -- verify the management event
371− sent <- receiveChanTimeout 5000000 sink
382+ sent <- receiveChanTimeout 5000000 sink
372− case sent of
383+ case sent of
373− Just (MxSent pidTo pidFrom _)
384+ Just (MxSent pidTo pidFrom _)
374− | pidTo == p1 && pidFrom == us -> return True
385+ | pidTo == p1 && pidFrom == us -> return True
375− _ -> return False
386+ _ -> return False
377testChan :: (SendPort () -> () -> Process ())
388testChan :: (SendPort () -> () -> Process ())
378 -> Maybe LocalNode
389 -> Maybe LocalNode
380 -> Process ()
390 -> Process ()
381−testChan op n r = testMxSend n r $ \p1 sink -> do
391+testChan op n = testMxSend n "" $ \p1 sink -> do
383 us <- getSelfPid
393 us <- getSelfPid
384 send p1 us
394 send p1 us
386− cleared <- receiveChan sink
396+ cleared <- receiveChanTimeout 2000000 sink
387 case cleared of
397 case cleared of
388− (MxSent pidTo pidFrom _)
398+ Just (MxSent pidTo pidFrom _)
389 | pidTo == p1 && pidFrom == us -> return ()
399 | pidTo == p1 && pidFrom == us -> return ()
390 _ -> die "Received uncleared Mx Event"
400 _ -> die "Received uncleared Mx Event"
@@ -404,8 +414,8 @@ testChan op n r = testMxSend n r $ \p1 sink -> do
405type SendTest = ProcessId -> ReceivePort MxEvent -> Process Bool
415type SendTest = ProcessId -> ReceivePort MxEvent -> Process Bool
407−testMxSend :: Maybe LocalNode -> TestResult Bool -> SendTest -> Process ()
417+testMxSend :: Maybe LocalNode -> String -> SendTest -> Process ()
408−testMxSend mNode result test = do
418+testMxSend mNode label test = do
409 us <- getSelfPid
419 us <- getSelfPid
410 (sp, rp) <- newChan
420 (sp, rp) <- newChan
411 (chan, sink) <- newChan
421 (chan, sink) <- newChan
@@ -429,16 +439,19 @@ testMxSend mNode result test = do
429 Nothing -> void $ spawnLocal (proc sp)
439 Nothing -> void $ spawnLocal (proc sp)
430 Just remoteNode -> void $ liftIO $ forkProcess remoteNode $ proc sp
440 Just remoteNode -> void $ liftIO $ forkProcess remoteNode $ proc sp
432− p1 <- receiveChan rp
442+ p1 <- receiveChanTimeout 2000000 rp
443+ unless (isJust p1) $ die "Timed out waiting for ProcessId"
433− res <- try (test p1 sink)
444+ res <- try $ test (fromJust p1) sink
435− Left (ProcessExitException _ m) -> (liftIO $ putStrLn $ "SomeException-" ++ show m) >> stash result False
436− Right tr -> stash result tr
437 kill agent "bye"
446 kill agent "bye"
438− kill p1 "bye"
447+ kill (fromJust p1) "bye"
450+ Left (ProcessExitException _ m) -> (liftIO $ putStrLn $ "SomeException-" ++ show m) >> die m
451+ Right tr -> tr `shouldBe` equalTo True
441− label = "testMxSend"
442 agentLabel s = "mx-unsafe-check-agent-" ++ show s
455 agentLabel s = "mx-unsafe-check-agent-" ++ show s
443 proc sp' = getSelfPid >>= sendChan sp' >> go Nothing
456 proc sp' = getSelfPid >>= sendChan sp' >> go Nothing
@@ -464,7 +477,7 @@ tests TestTransport{..} = do
464 , testCase "InterAgentBroadcast"
477 , testCase "InterAgentBroadcast"
465 (delayedAssertion
478 (delayedAssertion
466 "expected (), but no broadcast was received"
479 "expected (), but no broadcast was received"
467− node1 () testAgentBroadcast)
480+ node1 (Just ()) testAgentBroadcast)
468 , testCase "AgentMailboxHandling"
481 , testCase "AgentMailboxHandling"
469 (delayedAssertion
482 (delayedAssertion
470 "expected (Just ()), but no regular (mailbox) input was handled"
483 "expected (Just ()), but no regular (mailbox) input was handled"
@@ -493,8 +506,7 @@ tests TestTransport{..} = do
496− buildTestCases n1 n2 =
497− let nid = localNodeId n2 in build n2 [
509+ buildTestCases n1 n2 = let nid = localNodeId n2 in build n1 n2 [
498 ("NSend", [
510 ("NSend", [
499 ("nsend", testNSend nsend)
511 ("nsend", testNSend nsend)
500 , ("Unsafe.nsend", testNSend Unsafe.nsend)
512 , ("Unsafe.nsend", testNSend Unsafe.nsend)
@@ -516,13 +528,13 @@ tests TestTransport{..} = do
518 build :: LocalNode
530 build :: LocalNode
519− -> [(String, [(String, (Maybe LocalNode -> TestResult Bool -> Process ()))])]
532+ -> [(String, [(String, (Maybe LocalNode -> Process ()))])]
520 -> [Test]
533 -> [Test]
521− build ln specs =
534+ build n ln specs =
522 [ testGroup (intercalate "-" [groupName, caseSuffix]) [
535 [ testGroup (intercalate "-" [groupName, caseSuffix]) [
523 testCase (intercalate "-" [caseName, caseSuffix])
536 testCase (intercalate "-" [caseName, caseSuffix])
524− (delayedAssertion "expected mx events failed"
525− ln True (caseImpl caseNode))
537+ (runProcess n (caseImpl caseNode))
526 | (caseName, caseImpl) <- groupCases
538 | (caseName, caseImpl) <- groupCases
528 | (groupName, groupCases) <- specs
540 | (groupName, groupCases) <- specs