@@ -25,18 +25,13 @@ import Control.Concurrent.MVar
26import Control.Monad (replicateM_, replicateM, forever, void, unless, join)
26import Control.Monad (replicateM_, replicateM, forever, void, unless, join)
27import Control.Exception (SomeException, throwIO, ErrorCall(..))
27import Control.Exception (SomeException, throwIO, ErrorCall(..))
28−import Control.Monad.Catch (try, catch, finally, mask, onException)
28+import qualified Control.Exception as Ex (catch)
29−import Control.Applicative ((<|>))
29+import Control.Applicative ((<$>), (<*>), pure, (<|>))
30import qualified Network.Transport as NT (closeEndPoint, EndPointAddress)
30import qualified Network.Transport as NT (closeEndPoint, EndPointAddress)
31−import Control.Distributed.Process hiding
31+import Control.Distributed.Process
38import Control.Distributed.Process.Internal.Types
32import Control.Distributed.Process.Internal.Types
33+ ( NodeId(nodeAddress)
39− ( LocalNode(localEndPoint)
34+ , LocalNode(localEndPoint)
40 , ProcessExitException(..)
35 , ProcessExitException(..)
41 , nullProcessId
36 , nullProcessId
42 , createUnencodedMessage
37 , createUnencodedMessage
@@ -44,13 +39,13 @@ import Control.Distributed.Process.Internal.Types
44import Control.Distributed.Process.Node
39import Control.Distributed.Process.Node
45import Control.Distributed.Process.Debug
40import Control.Distributed.Process.Debug
46import Control.Distributed.Process.Management.Internal.Types
41import Control.Distributed.Process.Management.Internal.Types
47−import Control.Distributed.Process.Tests.Internal.Utils (shouldBe, pause)
42+import Control.Distributed.Process.Tests.Internal.Utils (shouldBe)
48import Control.Distributed.Process.Serializable (Serializable)
43import Control.Distributed.Process.Serializable (Serializable)
49−import Data.Maybe (isNothing, isJust)
44+
50−import Test.HUnit (Assertion, assertBool, assertFailure)
45+import Test.HUnit (Assertion, assertFailure, assertBool)
51import Test.Framework (Test, testGroup)
46import Test.Framework (Test, testGroup)
52import Test.Framework.Providers.HUnit (testCase)
47import Test.Framework.Providers.HUnit (testCase)
53−import Control.Rematch hiding (match, isNothing, isJust)
48+import Control.Rematch hiding (match)
54import Control.Rematch.Run (Match(..))
49import Control.Rematch.Run (Match(..))
56newtype Ping = Ping ProcessId
51newtype Ping = Ping ProcessId
@@ -73,7 +68,7 @@ expectThat a matcher = case res of
73forkTry :: IO () -> IO ThreadId
68forkTry :: IO () -> IO ThreadId
74forkTry p = do
69forkTry p = do
75 tid <- myThreadId
70 tid <- myThreadId
76− forkIO $ catch p (\e -> throwTo tid (e :: SomeException))
71+ forkIO $ Ex.catch p (\e -> throwTo tid (e :: SomeException))
78-- | The ping server from the paper
73-- | The ping server from the paper
79ping :: Process ()
74ping :: Process ()
@@ -83,46 +78,12 @@ ping = do
83 send partner (Ping self)
78 send partner (Ping self)
86−verifyClient :: String -> MVar Bool -> IO ()
87−verifyClient s b = takeMVar b >>= assertBool s
89−expectPing :: MVar Bool -> Process ()
90−expectPing mv = expect >>= liftIO . putMVar mv . checkPing
92− checkPing (Ping _) = True
94-- | Quick and dirty synchronous version of whereisRemoteAsync
81-- | Quick and dirty synchronous version of whereisRemoteAsync
95whereisRemote :: NodeId -> String -> Process (Maybe ProcessId)
82whereisRemote :: NodeId -> String -> Process (Maybe ProcessId)
96whereisRemote nid string = do
83whereisRemote nid string = do
97 whereisRemoteAsync nid string
84 whereisRemoteAsync nid string
99− match (\(WhereIsReply _ mPid) -> return mPid)
85+ WhereIsReply _ mPid <- expect
102−verifyWhereIsRemote :: NodeId -> String -> Process ProcessId
103−verifyWhereIsRemote n s = whereisRemote n s >>= maybe (die "remote name not found") return
105−waitForExit :: ProcessId -> Process DiedReason
106−waitForExit pid = monitor pid >>= waitForDown
108−waitForDown :: MonitorRef -> Process DiedReason
110− receiveWait [ matchIf (\(ProcessMonitorNotification ref' _ _) -> ref == ref')
111− (\(ProcessMonitorNotification _ _ dr) -> return dr) ]
113−syncBreakConnection :: (NT.EndPointAddress -> NT.EndPointAddress -> IO ()) -> LocalNode -> LocalNode -> IO ()
114−syncBreakConnection breakConnection nid0 nid1 = do
116− _ <- forkProcess nid1 $ getSelfPid >>= liftIO . putMVar m
117− runProcess nid0 $ do
118− them <- liftIO $ takeMVar m
119− pinger <- spawnLocal $ forever $ send them ()
120− _ <- monitorNode (localNodeId nid1)
121− liftIO $ breakConnection (nodeAddress $ localNodeId nid0)
122− (nodeAddress $ localNodeId nid1)
123− NodeMonitorNotification _ _ _ <- expect
124− kill pinger "finished"
125− return ()
86+ return mPid
127data Add = Add ProcessId Double Double deriving (Typeable)
88data Add = Add ProcessId Double Double deriving (Typeable)
128data Divide = Divide ProcessId Double Double deriving (Typeable)
89data Divide = Divide ProcessId Double Double deriving (Typeable)
@@ -197,18 +158,12 @@ monitorTestProcess theirAddr mOrL un reason monitorSetup done =
197 unmonitor ref
158 unmonitor ref
198 liftIO $ putMVar done ()
159 liftIO $ putMVar done ()
199 (False, ref) -> do
160 (False, ref) -> do
201− match (\(ProcessMonitorNotification ref' pid reason') -> do
161+ ProcessMonitorNotification ref' pid reason' <- expect
203− assertBool "Bad Monitor Signal"
204− (Just ref' == ref && pid == theirAddr &&
162+ True <- return $ Just ref' == ref && pid == theirAddr && mOrL && reason == reason'
205− mOrL && reason == reason')
206− putMVar done ())
163+ liftIO $ putMVar done ()
209 (\(ProcessLinkException pid reason') -> do
165 (\(ProcessLinkException pid reason') -> do
210− (liftIO $ assertBool "link exception unmatched" $
211− pid == theirAddr && not mOrL && not un && reason == reason')
166+ True <- return $ pid == theirAddr && not mOrL && not un && reason == reason'
212 liftIO $ putMVar done ()
167 liftIO $ putMVar done ()
@@ -239,10 +194,8 @@ testPing TestTransport{..} = do
239 pid <- getSelfPid
194 pid <- getSelfPid
240 replicateM_ numPings $ do
195 replicateM_ numPings $ do
241 send pingServer (Pong pid)
196 send pingServer (Pong pid)
242− p <- expectTimeout 3000000
197+ Ping _ <- expect
244− Just (Ping _) -> return ()
198+ return ()
245− Nothing -> die "Failed to receive Ping"
247 putMVar clientDone ()
200 putMVar clientDone ()
@@ -329,7 +282,7 @@ testMonitorLocalDeadProcess TestTransport{..} mOrL un = do
329 runProcess localNode $ do
282 runProcess localNode $ do
330 monitor theirAddr
283 monitor theirAddr
331 -- wait for the process to die
284 -- wait for the process to die
332− expect :: Process ProcessMonitorNotification
285+ ProcessMonitorNotification _ _ _ <- expect
333 monitorTestProcess theirAddr mOrL un DiedUnknownId Nothing done
286 monitorTestProcess theirAddr mOrL un DiedUnknownId Nothing done
335 takeMVar done
288 takeMVar done
@@ -403,17 +356,14 @@ testMath TestTransport{..} = do
403 runProcess localNode $ do
356 runProcess localNode $ do
404 pid <- getSelfPid
357 pid <- getSelfPid
405 send mathServer (Add pid 1 2)
358 send mathServer (Add pid 1 2)
406− three <- expect :: Process Double
359+ 3 <- expect :: Process Double
407 send mathServer (Divide pid 8 2)
360 send mathServer (Divide pid 8 2)
408− four <- expect :: Process Double
361+ 4 <- expect :: Process Double
409 send mathServer (Divide pid 8 0)
362 send mathServer (Divide pid 8 0)
410− divByZ <- expect
363+ DivByZero <- expect
411− liftIO $ putMVar clientDone (three, four, divByZ)
364+ liftIO $ putMVar clientDone ()
413− res <- takeMVar clientDone
366+ takeMVar clientDone
415− (3, 4, DivByZero) -> return ()
416− _ -> error $ "Something went horribly wrong"
418-- | Send first message (i.e. connect) to an already terminated process
368-- | Send first message (i.e. connect) to an already terminated process
419-- (without monitoring); then send another message to a second process on
369-- (without monitoring); then send another message to a second process on
@@ -441,9 +391,11 @@ testSendToTerminated TestTransport{..} = do
441 pid <- getSelfPid
391 pid <- getSelfPid
442 send server1 "Hi"
392 send server1 "Hi"
443 send server2 (Pong pid)
393 send server2 (Pong pid)
395+ True <- return $ pid' == server2
444− expectPing clientDone
396+ liftIO $ putMVar clientDone ()
446− verifyClient "Expected Ping from server" clientDone
398+ takeMVar clientDone
448-- | Test (non-zero) timeout
400-- | Test (non-zero) timeout
449testTimeout :: TestTransport -> Assertion
401testTimeout :: TestTransport -> Assertion
@@ -452,10 +404,10 @@ testTimeout TestTransport{..} = do
452 done <- newEmptyMVar
404 done <- newEmptyMVar
454 runProcess localNode $ do
406 runProcess localNode $ do
455− res <- receiveTimeout 1000000 [match (\Add{} -> return ())]
407+ Nothing <- receiveTimeout 1000000 [match (\(Add _ _ _) -> return ())]
456− liftIO $ putMVar done $ res == Nothing
408+ liftIO $ putMVar done ()
458− verifyClient "Expected receiveTimeout to timeout..." done
410+ takeMVar done
460-- | Test zero timeout
412-- | Test zero timeout
461testTimeout0 :: TestTransport -> Assertion
413testTimeout0 :: TestTransport -> Assertion
@@ -483,9 +435,10 @@ testTimeout0 TestTransport{..} = do
483 -- is not interested in, and then a single message that it wants
435 -- is not interested in, and then a single message that it wants
484 replicateM_ 10000 $ send server "Irrelevant message"
436 replicateM_ 10000 $ send server "Irrelevant message"
485 send server (Pong pid)
437 send server (Pong pid)
486− expectPing clientDone
439+ liftIO $ putMVar clientDone ()
488− verifyClient "Expected Ping from server" clientDone
441+ takeMVar clientDone
490-- | Test typed channels
443-- | Test typed channels
491testTypedChannels :: TestTransport -> Assertion
444testTypedChannels :: TestTransport -> Assertion
@@ -508,10 +461,10 @@ testTypedChannels TestTransport{..} = do
508 runProcess localNode $ do
461 runProcess localNode $ do
509 (clientSendPort, rport) <- newChan
462 (clientSendPort, rport) <- newChan
510 sendChan serverSendPort (clientSendPort, 5)
463 sendChan serverSendPort (clientSendPort, 5)
511− ch <- receiveChan rport
464+ False <- receiveChan rport
512− liftIO $ putMVar clientDone $ ch == False
465+ liftIO $ putMVar clientDone ()
514− verifyClient "Expected channel to send 'False'" clientDone
467+ takeMVar clientDone
516-- | Test merging receive ports
469-- | Test merging receive ports
517testMergeChannels :: TestTransport -> Assertion
470testMergeChannels :: TestTransport -> Assertion
@@ -534,8 +487,9 @@ testMergeChannels TestTransport{..} = do
534 rs <- mapM charChannel "abc"
487 rs <- mapM charChannel "abc"
535 m <- mergePorts biased rs
488 m <- mergePorts biased rs
536 xs <- replicateM 9 $ receiveChan m
489 xs <- replicateM 9 $ receiveChan m
537− liftIO $ putMVar done $ xs == expected
490+ True <- return $ xs == expected
538− verifyClient "Expected single layer merge to match expected ordering" done
491+ liftIO $ putMVar done ()
540 -- Two layers of merging
494 -- Two layers of merging
541 testNested :: LocalNode -> Bool -> Bool -> String -> IO ()
495 testNested :: LocalNode -> Bool -> Bool -> String -> IO ()
@@ -546,8 +500,9 @@ testMergeChannels TestTransport{..} = do
546 ms <- mapM (mergePorts biasedInner) rss
500 ms <- mapM (mergePorts biasedInner) rss
547 m <- mergePorts biasedOuter ms
501 m <- mergePorts biasedOuter ms
548 xs <- replicateM (9 * 3) $ receiveChan m
502 xs <- replicateM (9 * 3) $ receiveChan m
549− liftIO $ putMVar done $ xs == expected
503+ True <- return $ xs == expected
550− verifyClient "Expected nested channels to match expeted ordering" done
504+ liftIO $ putMVar done ()
552 -- Test that if no messages are (immediately) available, the scheduler makes no difference
507 -- Test that if no messages are (immediately) available, the scheduler makes no difference
553 testBlocked :: LocalNode -> Bool -> IO ()
508 testBlocked :: LocalNode -> Bool -> IO ()
@@ -556,45 +511,43 @@ testMergeChannels TestTransport{..} = do
556 done <- newEmptyMVar
511 done <- newEmptyMVar
558 forkProcess localNode $ do
513 forkProcess localNode $ do
559− ss <- liftIO $ mapM readMVar vs
514+ [sa, sb, sc] <- liftIO $ mapM readMVar vs
562− mapM_ ((>> pause 10000) . uncurry sendChan)
515+ mapM_ ((>> liftIO (threadDelay 10000)) . uncurry sendChan)
563− [ -- a, b, c
516+ [ -- a, b, c
564− (sa, 'a')
517+ (sa, 'a')
565− , (sb, 'b')
518+ , (sb, 'b')
566− , (sc, 'c')
519+ , (sc, 'c')
567− -- a, c, b
520+ -- a, c, b
568− , (sa, 'a')
521+ , (sa, 'a')
569− , (sc, 'c')
522+ , (sc, 'c')
570− , (sb, 'b')
523+ , (sb, 'b')
571− -- b, a, c
524+ -- b, a, c
572− , (sb, 'b')
525+ , (sb, 'b')
573− , (sa, 'a')
526+ , (sa, 'a')
574− , (sc, 'c')
527+ , (sc, 'c')
575− -- b, c, a
528+ -- b, c, a
576− , (sb, 'b')
529+ , (sb, 'b')
577− , (sc, 'c')
530+ , (sc, 'c')
578− , (sa, 'a')
531+ , (sa, 'a')
579− -- c, a, b
532+ -- c, a, b
580− , (sc, 'c')
533+ , (sc, 'c')
581− , (sa, 'a')
534+ , (sa, 'a')
582− , (sb, 'b')
535+ , (sb, 'b')
583− -- c, b, a
536+ -- c, b, a
584− , (sc, 'c')
537+ , (sc, 'c')
585− , (sb, 'b')
538+ , (sb, 'b')
586− , (sa, 'a')
539+ , (sa, 'a')
588− _ -> die "Something went horribly wrong"
590 forkProcess localNode $ do
542 forkProcess localNode $ do
591 (ss, rs) <- unzip <$> replicateM 3 newChan
543 (ss, rs) <- unzip <$> replicateM 3 newChan
592 liftIO $ mapM_ (uncurry putMVar) $ zip vs ss
544 liftIO $ mapM_ (uncurry putMVar) $ zip vs ss
593 m <- mergePorts biased rs
545 m <- mergePorts biased rs
594 xs <- replicateM (6 * 3) $ receiveChan m
546 xs <- replicateM (6 * 3) $ receiveChan m
595− liftIO $ putMVar done $ xs == "abcacbbacbcacabcba"
547+ True <- return $ xs == "abcacbbacbcacabcba"
548+ liftIO $ putMVar done ()
597− verifyClient "Expected merged ports to match expected ordering" done
550+ takeMVar done
599 mergePorts :: Serializable a => Bool -> [ReceivePort a] -> Process (ReceivePort a)
552 mergePorts :: Serializable a => Bool -> [ReceivePort a] -> Process (ReceivePort a)
600 mergePorts True = mergePortsBiased
553 mergePorts True = mergePortsBiased
@@ -612,9 +565,8 @@ testTerminate TestTransport{..} = do
612 localNode <- newLocalNode testTransport initRemoteTable
565 localNode <- newLocalNode testTransport initRemoteTable
613 runProcess localNode $ do
566 runProcess localNode $ do
614 e <- try terminate :: Process (Either ProcessTerminationException ())
567 e <- try terminate :: Process (Either ProcessTerminationException ())
615− if either show show e == show ProcessTerminationException
568+ True <- return $ either show show e == show ProcessTerminationException
616− then return ()
569+ return ()
617− else die "Unexpected result from terminate"
619testMonitorNode :: TestTransport -> Assertion
571testMonitorNode :: TestTransport -> Assertion
620testMonitorNode TestTransport{..} = do
572testMonitorNode TestTransport{..} = do
@@ -625,12 +577,11 @@ testMonitorNode TestTransport{..} = do
626 runProcess node2 $ do
578 runProcess node2 $ do
627 ref <- monitorNode (localNodeId node1)
579 ref <- monitorNode (localNodeId node1)
629− match (\(NodeMonitorNotification ref' nid DiedDisconnect) ->
580+ NodeMonitorNotification ref' nid DiedDisconnect <- expect
630− return $ ref == ref' && nid == localNodeId node1)
581+ True <- return $ ref == ref' && nid == localNodeId node1
631− ] >>= liftIO . putMVar done
582+ liftIO $ putMVar done ()
633− verifyClient "Expected NodeMonitorNotification with matching ref & nodeId" done
584+ takeMVar done
635testMonitorLiveNode :: TestTransport -> Assertion
586testMonitorLiveNode :: TestTransport -> Assertion
636testMonitorLiveNode TestTransport{..} = do
587testMonitorLiveNode TestTransport{..} = do
@@ -645,16 +596,15 @@ testMonitorLiveNode TestTransport{..} = do
645 liftIO $ putMVar ready ()
596 liftIO $ putMVar ready ()
646 liftIO $ takeMVar readyr
597 liftIO $ takeMVar readyr
647 send p ()
598 send p ()
649− match (\(NodeMonitorNotification ref' nid _) ->
599+ NodeMonitorNotification ref' nid _ <- expect
650− (return $ ref == ref' && nid == localNodeId node1))
600+ True <- return $ ref == ref' && nid == localNodeId node1
651− ] >>= liftIO . putMVar done
601+ liftIO $ putMVar done ()
653 takeMVar ready
603 takeMVar ready
654 closeLocalNode node1
604 closeLocalNode node1
655 putMVar readyr ()
605 putMVar readyr ()
657− verifyClient "Expected NodeMonitorNotification for LIVE node" done
607+ takeMVar done
659testMonitorChannel :: TestTransport -> Assertion
609testMonitorChannel :: TestTransport -> Assertion
660testMonitorChannel TestTransport{..} = do
610testMonitorChannel TestTransport{..} = do
@@ -664,20 +614,18 @@ testMonitorChannel TestTransport{..} = do
664 pid <- forkProcess node1 $ do
614 pid <- forkProcess node1 $ do
665 sport <- expect :: Process (SendPort ())
615 sport <- expect :: Process (SendPort ())
666 ref <- monitorPort sport
616 ref <- monitorPort sport
667− receiveWait [
617+ PortMonitorNotification ref' port' reason <- expect
668− -- reason might be DiedUnknownId if the receive port is GCed before the
618+ -- reason might be DiedUnknownId if the receive port is GCed before the
669− -- monitor is established (TODO: not sure that this is reasonable)
619+ -- monitor is established (TODO: not sure that this is reasonable)
670− match (\(PortMonitorNotification ref' port' reason) ->
671− return $ ref' == ref && port' == sendPortId sport &&
672− (reason == DiedNormal || reason == DiedUnknownId))
620+ return $ ref' == ref && port' == sendPortId sport && (reason == DiedNormal || reason == DiedUnknownId)
673− ] >>= liftIO . putMVar gotNotification
621+ liftIO $ putMVar gotNotification ()
675 runProcess node2 $ do
623 runProcess node2 $ do
676 (sport, _) <- newChan :: Process (SendPort (), ReceivePort ())
624 (sport, _) <- newChan :: Process (SendPort (), ReceivePort ())
677 send pid sport
625 send pid sport
678 liftIO $ threadDelay 100000
626 liftIO $ threadDelay 100000
680− verifyClient "Expected PortMonitorNotification" gotNotification
628+ takeMVar gotNotification
682testRegistry :: TestTransport -> Assertion
630testRegistry :: TestTransport -> Assertion
683testRegistry TestTransport{..} = do
631testRegistry TestTransport{..} = do
@@ -689,28 +637,20 @@ testRegistry TestTransport{..} = do
690 runProcess node $ do
638 runProcess node $ do
691 register "ping" pingServer
639 register "ping" pingServer
692− whereis "ping" >>= liftIO . assertBool "Unexpected ping" . (== Just pingServer)
640+ Just pid <- whereis "ping"
641+ True <- return $ pingServer == pid
693 us <- getSelfPid
642 us <- getSelfPid
694 nsend "ping" (Pong us)
643 nsend "ping" (Pong us)
695− receiveWait [
644+ Ping pid' <- expect
696− matchIf (\(Ping pid') -> pingServer == pid') (const $ return ())
645+ True <- return $ pingServer == pid'
697− ]
646+ Left (ProcessRegistrationException "dead" Nothing) <- try $ register "dead" deadProcess
698− checkRegException "dead" Nothing deadProcess
647+ Left (ProcessRegistrationException "ping" (Just x)) <- try $ register "ping" deadProcess
699− checkRegException "ping" (Just pingServer) deadProcess
648+ True <- return $ x == pingServer
700− try (unregister "dead") >>= checkReg "dead" Nothing
649+ Left (ProcessRegistrationException "dead" Nothing) <- try $ unregister "dead"
701 liftIO $ putMVar done ()
650 liftIO $ putMVar done ()
703 takeMVar done
652 takeMVar done
706− checkRegException name pid dead =
707− try (register name dead) >>= checkReg name pid
709− checkReg name pid res =
711− Left (ProcessRegistrationException name pid) -> return ()
712− _ -> die $ "Unexpected Registration" ++ show res
714testRegistryRemoteProcess :: TestTransport -> Assertion
654testRegistryRemoteProcess :: TestTransport -> Assertion
715testRegistryRemoteProcess TestTransport{..} = do
655testRegistryRemoteProcess TestTransport{..} = do
716 node1 <- newLocalNode testTransport initRemoteTable
656 node1 <- newLocalNode testTransport initRemoteTable
@@ -721,13 +661,13 @@ testRegistryRemoteProcess TestTransport{..} = do
722 runProcess node2 $ do
662 runProcess node2 $ do
723 register "ping" pingServer
663 register "ping" pingServer
724− whereis "ping" >>= liftIO . assertBool "Unexpected ping" . (== Just pingServer)
664+ Just pid <- whereis "ping"
665+ True <- return $ pingServer == pid
725 us <- getSelfPid
666 us <- getSelfPid
726 nsend "ping" (Pong us)
667 nsend "ping" (Pong us)
727− receiveWait [
668+ Ping pid' <- expect
728− matchIf (\(Ping pid') -> pingServer == pid')
669+ True <- return $ pingServer == pid'
729− (const $ liftIO $ putMVar done ())
670+ liftIO $ putMVar done ()
732 takeMVar done
672 takeMVar done
@@ -735,6 +675,7 @@ testRemoteRegistry :: TestTransport -> Assertion
735testRemoteRegistry TestTransport{..} = do
675testRemoteRegistry TestTransport{..} = do
736 node1 <- newLocalNode testTransport initRemoteTable
676 node1 <- newLocalNode testTransport initRemoteTable
737 node2 <- newLocalNode testTransport initRemoteTable
677 node2 <- newLocalNode testTransport initRemoteTable
678+ done <- newEmptyMVar
739 pingServer <- forkProcess node1 ping
680 pingServer <- forkProcess node1 ping
740 deadProcess <- forkProcess node1 (return ())
681 deadProcess <- forkProcess node1 (return ())
@@ -747,34 +688,32 @@ testRemoteRegistry TestTransport{..} = do
747 "ping" == label' && pid == pingServer)
688 "ping" == label' && pid == pingServer)
748 (\(RegisterReply _ _ _) -> return ()) ]
689 (\(RegisterReply _ _ _) -> return ()) ]
750− pid <- verifyWhereIsRemote nid1 "ping"
691+ Just pid <- whereisRemote nid1 "ping"
751− liftIO $ assertBool "Expected pindServer to match pid" $ pingServer == pid
692+ True <- return $ pingServer == pid
753 us <- getSelfPid
693 us <- getSelfPid
754 nsendRemote nid1 "ping" (Pong us)
694 nsendRemote nid1 "ping" (Pong us)
755− receiveWait [
695+ Ping pid' <- expect
756− match (\(Ping pid') -> return $ pingServer == pid')
696+ True <- return $ pingServer == pid'
757− ] >>= liftIO . assertBool "Expected Ping with ping server's ProcessId"
759 -- test that if process was not registered Nothing is returned
698 -- test that if process was not registered Nothing is returned
760 -- in owner field.
699 -- in owner field.
761 registerRemoteAsync nid1 "dead" deadProcess
700 registerRemoteAsync nid1 "dead" deadProcess
762− receiveWait [ matchIf (\(RegisterReply label' f mPid) -> "dead" == label')
702+ matchIf (\(RegisterReply label' False Nothing) -> "dead" == label')
763− (\(RegisterReply _ f mPid) -> return (not f && isNothing mPid))
703+ (\(RegisterReply _ _ _) -> return ()) ]
764− ] >>= liftIO . assertBool "Expected False Nothing in RegisterReply"
766 registerRemoteAsync nid1 "ping" deadProcess
704 registerRemoteAsync nid1 "ping" deadProcess
767 receiveWait [
705 receiveWait [
768− matchIf (\(RegisterReply label' False mPid) ->
706+ matchIf (\(RegisterReply label' False (Just pid)) ->
769− "ping" == label' && isJust mPid)
707+ "ping" == label' && pid == pingServer)
770− (\(RegisterReply _ f (Just pid'')) -> return (not f && pid'' == pingServer))
708+ (\(RegisterReply _ _ _) -> return ()) ]
771− ] >>= liftIO . assertBool "Expected False and (Just alreadyRegisteredPid) in RegisterReply"
773 unregisterRemoteAsync nid1 "dead"
709 unregisterRemoteAsync nid1 "dead"
774 receiveWait [
710 receiveWait [
775− matchIf (\(RegisterReply label' _ _) -> "dead" == label')
711+ matchIf (\(RegisterReply label' False Nothing) ->
712+ "dead" == label' && pid == pingServer)
776− (\(RegisterReply _ f mPid) -> return (not f && isNothing mPid))
713+ (\(RegisterReply _ _ _) -> return ()) ]
777− ] >>= liftIO . assertBool "Expected False and Nothing in RegisterReply"
714+ liftIO $ putMVar done ()
779testRemoteRegistryRemoteProcess :: TestTransport -> Assertion
718testRemoteRegistryRemoteProcess :: TestTransport -> Assertion
780testRemoteRegistryRemoteProcess TestTransport{..} = do
719testRemoteRegistryRemoteProcess TestTransport{..} = do
@@ -790,15 +729,15 @@ testRemoteRegistryRemoteProcess TestTransport{..} = do
790 receiveWait [
729 receiveWait [
791 matchIf (\(RegisterReply label' _ _) -> "ping" == label')
730 matchIf (\(RegisterReply label' _ _) -> "ping" == label')
792 (\(RegisterReply _ _ _) -> return ()) ]
731 (\(RegisterReply _ _ _) -> return ()) ]
793− pid <- verifyWhereIsRemote nid1 "ping"
732+ Just pid <- whereisRemote nid1 "ping"
794− liftIO $ assertBool "Expected pingServer to match remote name" $ pingServer == pid
733+ True <- return $ pingServer == pid
795 us <- getSelfPid
734 us <- getSelfPid
796 nsendRemote nid1 "ping" (Pong us)
735 nsendRemote nid1 "ping" (Pong us)
797− receiveWait [
736+ Ping pid' <- expect
798− match (\(Ping pid') -> return $ pingServer == pid')
737+ True <- return $ pingServer == pid'
799− ] >>= liftIO . putMVar done
738+ liftIO $ putMVar done ()
801− verifyClient "Expected Ping with ping server's ProcessId" done
740+ takeMVar done
803testSpawnLocal :: TestTransport -> Assertion
742testSpawnLocal :: TestTransport -> Assertion
804testSpawnLocal TestTransport{..} = do
743testSpawnLocal TestTransport{..} = do
@@ -812,14 +751,15 @@ testSpawnLocal TestTransport{..} = do
812 sport <- expect
751 sport <- expect
813 sendChan sport (1234 :: Int)
752 sendChan sport (1234 :: Int)
815− sport <- spawnChannelLocal $
754+ sport <- spawnChannelLocal $ \rport -> do
816− \rport -> (receiveChan rport :: Process Int) >>= send us
755+ (1234 :: Int) <- receiveChan rport
818 send pid sport
758 send pid sport
819− expect >>= liftIO . putMVar done
760+ liftIO $ putMVar done ()
821− res <- takeMVar done
762+ takeMVar done
822− assertBool "Expected 1234 :: Int" $ res == (1234 :: Int)
824testSpawnAsyncStrictness :: TestTransport -> Assertion
764testSpawnAsyncStrictness :: TestTransport -> Assertion
825testSpawnAsyncStrictness TestTransport{..} = do
765testSpawnAsyncStrictness TestTransport{..} = do
@@ -848,9 +788,8 @@ testReconnect TestTransport{..} = do
848 liftIO $ putMVar processA us
788 liftIO $ putMVar processA us
849 msg1 <- expect
789 msg1 <- expect
850 msg2 <- expect
790 msg2 <- expect
852− assertBool "messages did not match" $ msg1 == "message 1" && msg2 == "message 3"
791+ True <- return $ msg1 == "message 1" && msg2 == "message 3"
853− putMVar sendTestOk ()
792+ liftIO $ putMVar sendTestOk ()
855 forkProcess node2 $ do
794 forkProcess node2 $ do
@@ -883,7 +822,7 @@ testReconnect TestTransport{..} = do
883 matchIf (\(RegisterReply label' _ _) -> "a" == label')
822 matchIf (\(RegisterReply label' _ _) -> "a" == label')
884 (\(RegisterReply _ _ _) -> return ()) ]
823 (\(RegisterReply _ _ _) -> return ()) ]
886− _ <- whereisRemote nid1 "a"
825+ Just _ <- whereisRemote nid1 "a"
889 -- Simulate network failure
828 -- Simulate network failure
@@ -902,10 +841,9 @@ testReconnect TestTransport{..} = do
902 (\(RegisterReply _ _ _) -> return ()) ]
841 (\(RegisterReply _ _ _) -> return ()) ]
905− mPid <- whereisRemote nid1 "a" -- this will fail because the name is removed when the node is disconnected
844+ Nothing <- whereisRemote nid1 "a" -- this will fail because the name is removed when the node is disconnected
906− liftIO $ assertBool "Expected remote name to be lost" $ mPid == Nothing
907− verifyWhereIsRemote nid1 "b" -- this will suceed because the value is set after thereconnect
845+ Just _ <- whereisRemote nid1 "b" -- this will suceed because the value is set after thereconnect
908− verifyWhereIsRemote nid1 "c"
846+ Just _ <- whereisRemote nid1 "c"
910 liftIO $ putMVar registerTestOk ()
848 liftIO $ putMVar registerTestOk ()
@@ -946,19 +884,19 @@ testUSend usendPrim TestTransport{..} numMessages = do
946 isSorted _ = True
884 isSorted _ = True
947 -- The list can't be null since there are no failures after sending
885 -- The list can't be null since there are no failures after sending
948 -- the last message.
886 -- the last message.
949− liftIO $ putMVar usendTestOk $ isSorted msgs && not (null msgs)
887+ True <- return $ isSorted msgs && not (null msgs)
888+ liftIO $ putMVar usendTestOk ()
951 forkProcess node2 $ do
890 forkProcess node2 $ do
952 them <- liftIO $ readMVar processA
891 them <- liftIO $ readMVar processA
953 getSelfPid >>= send them
892 getSelfPid >>= send them
954− expect :: Process ()
893+ () <- expect
955 forM_ [1..numMessages] $ \i -> do
894 forM_ [1..numMessages] $ \i -> do
956 liftIO $ testBreakConnection (nodeAddress nid1) (nodeAddress nid2)
895 liftIO $ testBreakConnection (nodeAddress nid1) (nodeAddress nid2)
957 usendPrim them i
896 usendPrim them i
958 liftIO (threadDelay 30000)
897 liftIO (threadDelay 30000)
960− res <- takeMVar usendTestOk
899+ takeMVar usendTestOk
961− assertBool "Unexpected failure after sending last msg" res
963-- | Test 'matchAny'. This repeats the 'testMath' but with a proxy server
901-- | Test 'matchAny'. This repeats the 'testMath' but with a proxy server
964-- in between
902-- in between
@@ -984,17 +922,14 @@ testMatchAny TestTransport{..} = do
984 runProcess localNode $ do
922 runProcess localNode $ do
985 pid <- getSelfPid
923 pid <- getSelfPid
986 send mathServer (Add pid 1 2)
924 send mathServer (Add pid 1 2)
987− three <- expect :: Process Double
925+ 3 <- expect :: Process Double
988 send mathServer (Divide pid 8 2)
926 send mathServer (Divide pid 8 2)
989− four <- expect :: Process Double
927+ 4 <- expect :: Process Double
990 send mathServer (Divide pid 8 0)
928 send mathServer (Divide pid 8 0)
991− divByZ <- expect
929+ DivByZero <- expect
992− liftIO $ putMVar clientDone (three, four, divByZ)
930+ liftIO $ putMVar clientDone ()
994− res <- takeMVar clientDone
932+ takeMVar clientDone
996− (3, 4, DivByZero) -> return ()
997− _ -> error "Unexpected result"
999-- | Test 'matchAny'. This repeats the 'testMath' but with a proxy server
934-- | Test 'matchAny'. This repeats the 'testMath' but with a proxy server
1000-- in between, however we block 'Divide' requests ....
935-- in between, however we block 'Divide' requests ....
@@ -1021,13 +956,12 @@ testMatchAnyHandle TestTransport{..} = do
1021 runProcess localNode $ do
956 runProcess localNode $ do
1022 pid <- getSelfPid
957 pid <- getSelfPid
1023 send mathServer (Add pid 1 2)
958 send mathServer (Add pid 1 2)
1024− three <- expect :: Process Double
959+ 3 <- expect :: Process Double
1025 send mathServer (Divide pid 8 2)
960 send mathServer (Divide pid 8 2)
1026− res <- (expectTimeout 100000) :: Process (Maybe Double)
961+ Nothing <- (expectTimeout 100000) :: Process (Maybe Double)
1027− liftIO $ putMVar clientDone $ three == 3 && res == Nothing
962+ liftIO $ putMVar clientDone ()
1029− verifyClient "Expected Nothing (i.e. timeout)" clientDone
1031 where maybeForward :: ProcessId -> Message -> Process (Maybe ())
965 where maybeForward :: ProcessId -> Message -> Process (Maybe ())
1032 maybeForward s msg =
966 maybeForward s msg =
1033 handleMessage msg (\m@(Add _ _ _) -> send s m)
967 handleMessage msg (\m@(Add _ _ _) -> send s m)
@@ -1055,10 +989,8 @@ testMatchAnyNoHandle TestTransport{..} = do
1055 Just _ -> die "NONSENSE")
989 Just _ -> die "NONSENSE")
1057 -- we *must* have removed the message from our mailbox though!!!
991 -- we *must* have removed the message from our mailbox though!!!
1058− res <- receiveTimeout 100000 [ match (\(Add _ _ _) -> return ()) ]
992+ Nothing <- receiveTimeout 100000 [ match (\(Add _ _ _) -> return ()) ]
1060− assertBool "Expected timeout!" $ res == Nothing
1061− putMVar serverDone ()
993+ liftIO $ putMVar serverDone ()
1062 putMVar addr server
994 putMVar addr server
1064 -- Client
996 -- Client
@@ -1101,21 +1033,14 @@ testMatchAnyIf TestTransport{..} = do
1101 runProcess localNode $ do
1033 runProcess localNode $ do
1102 pid <- getSelfPid
1034 pid <- getSelfPid
1103 send server (pid, "foo")
1035 send server (pid, "foo")
1104− foo <- expect
1036+ "foo" <- expect
1105− -- provoking what would be the wrong ordering is informative here...
1107− send server (pid, "bar")
1108− bar <- (expectTimeout 100000) :: Process (Maybe String) -- was Double o_O !?
1110 send server (pid, "baz")
1037 send server (pid, "baz")
1111− baz <- expect
1038+ "baz" <- expect
1112−
1039+ send server (pid, "bar")
1040+ Nothing <- (expectTimeout 100000) :: Process (Maybe Double)
1113− liftIO $ putMVar clientDone (foo, bar, baz)
1041+ liftIO $ putMVar clientDone ()
1115− res <- takeMVar clientDone
1116− let res' = res == ("foo", Nothing, "baz")
1117− assertBool "Expected timeout due to type mismatch" res'
1043+ takeMVar clientDone
1119 where tryHandleMessage :: Message -> Process (Maybe ())
1044 where tryHandleMessage :: Message -> Process (Maybe ())
1120 tryHandleMessage msg =
1045 tryHandleMessage msg =
1121 handleMessage msg (\(pid :: ProcessId, (m :: String))
1046 handleMessage msg (\(pid :: ProcessId, (m :: String))
@@ -1148,13 +1073,12 @@ testMatchMessageWithUnwrap TestTransport{..} = do
1148 runProcess localNode $ do
1073 runProcess localNode $ do
1149 pid <- getSelfPid
1074 pid <- getSelfPid
1150 send server (pid, wrapMessage ("foo" :: String))
1075 send server (pid, wrapMessage ("foo" :: String))
1151− foo <- expect
1076+ "foo" <- expect
1152 send server (pid, wrapMessage ("baz" :: String))
1077 send server (pid, wrapMessage ("baz" :: String))
1153− baz <- expect
1078+ "baz" <- expect
1154− liftIO $ putMVar clientDone (foo, baz)
1079+ liftIO $ putMVar clientDone ()
1156− res <- takeMVar clientDone
1081+ takeMVar clientDone
1157− assertBool "Unexpected unwrapped results" $ res == ("foo", "baz")
1159-- Test 'receiveChanTimeout'
1083-- Test 'receiveChanTimeout'
1160testReceiveChanTimeout :: TestTransport -> Assertion
1084testReceiveChanTimeout :: TestTransport -> Assertion
@@ -1172,19 +1096,18 @@ testReceiveChanTimeout TestTransport{..} = do
1173 -- Wait for a message with a delay. No message arrives, we should get
1097 -- Wait for a message with a delay. No message arrives, we should get
1174 -- Nothing after the delay.
1098 -- Nothing after the delay.
1175− receiveChanTimeout 100000 rp >>= maybe (return ()) (const $ die "Expected Timeout")
1099+ Nothing <- receiveChanTimeout 100000 rp
1177 -- Let the sender know that it can send a message.
1101 -- Let the sender know that it can send a message.
1178 liftIO $ putMVar mvSender ()
1102 liftIO $ putMVar mvSender ()
1180 -- Wait for a message with a delay again. Now a message arrives after
1104 -- Wait for a message with a delay again. Now a message arrives after
1181 -- 0.1 seconds
1105 -- 0.1 seconds
1182− res <- receiveChanTimeout 20000000 rp >>= maybe (die "Timeout") return
1106+ Just True <- receiveChanTimeout 20000000 rp
1183− liftIO $ assertBool "Expected result to be 'True'" res
1185 -- Wait for a message with zero timeout: non-blocking check. No message is
1108 -- Wait for a message with zero timeout: non-blocking check. No message is
1186 -- available, we get Nothing
1109 -- available, we get Nothing
1187− receiveChanTimeout 0 rp >>= maybe (return ()) (const $ die "Expected Timeout")
1110+ Nothing <- receiveChanTimeout 0 rp
1189 -- Let the sender know that it can send a message.
1112 -- Let the sender know that it can send a message.
1190 liftIO $ putMVar mvSender ()
1113 liftIO $ putMVar mvSender ()
@@ -1194,7 +1117,7 @@ testReceiveChanTimeout TestTransport{..} = do
1194 liftIO $ threadDelay 100000
1117 liftIO $ threadDelay 100000
1195 mb <- receiveChanTimeout 0 rp
1118 mb <- receiveChanTimeout 0 rp
1196 case mb of
1119 case mb of
1197− Just b -> do liftIO $ assertBool "Unexpected Message" $ not b
1120+ Just b -> do False <- return b; return ()
1198 _ -> loop
1121 _ -> loop
1200 liftIO $ putMVar done ()
1123 liftIO $ putMVar done ()
@@ -1231,8 +1154,8 @@ testReceiveChanFeatures TestTransport{..} = do
1232 rp1 <- mergePortsBiased [even <$> rpInt, rpBool]
1155 rp1 <- mergePortsBiased [even <$> rpInt, rpBool]
1234− receiveChan rp1 >>= liftIO . assertBool "Expected True"
1157+ True <- receiveChan rp1
1235− receiveChan rp1 >>= liftIO . assertBool "Expected False" . not
1158+ False <- receiveChan rp1
1237 -- Test Applicative instance
1160 -- Test Applicative instance
@@ -1241,7 +1164,7 @@ testReceiveChanFeatures TestTransport{..} = do
1242 let rp2 = pure (+) <*> rpInt <*> rpInt
1165 let rp2 = pure (+) <*> rpInt <*> rpInt
1244− receiveChan rp2 >>= liftIO . assertBool "Expected 7" . (== 7)
1167+ 7 <- receiveChan rp2
1246 -- Test Alternative instance
1169 -- Test Alternative instance
@@ -1250,8 +1173,8 @@ testReceiveChanFeatures TestTransport{..} = do
1251 let rp3 = (even <$> rpInt) <|> rpBool
1174 let rp3 = (even <$> rpInt) <|> rpBool
1253− receiveChan rp3 >>= liftIO . assertBool "Expected False" . not
1176+ False <- receiveChan rp3
1254− receiveChan rp3 >>= liftIO . assertBool "Expected True"
1177+ True <- receiveChan rp3
1256 -- Test Monad instance
1179 -- Test Monad instance
@@ -1265,86 +1188,17 @@ testReceiveChanFeatures TestTransport{..} = do
1265 then rpInt
1188 then rpInt
1266 else return 7
1189 else return 7
1268− receiveChan rp4 >>= liftIO . assertBool "Expected 5" . (== 5)
1191+ 5 <- receiveChan rp4
1269− receiveChan rp4 >>= liftIO . assertBool "Expected 7" . (== 7)
1192+ 7 <- receiveChan rp4
1271 liftIO $ putMVar done ()
1194 liftIO $ putMVar done ()
1273 takeMVar done
1196 takeMVar done
1275−testChanLifecycle :: TestTransport -> Assertion
1276−testChanLifecycle TestTransport{..} = let delay = 3000000 in do
1277− result <- newEmptyMVar
1278− tchMV <- newEmptyMVar
1279− localNode <- newLocalNode testTransport initRemoteTable
1280− runProcess localNode $ do
1282− pid <- spawnLocal $ do tCh <- newChan :: Process (SendPort (), ReceivePort ())
1283− liftIO $ putMVar tchMV tCh
1284− expect :: Process ()
1287− expect :: Process ()
1289− mRefPid <- monitor pid
1291− cPid <- spawnLocal $ do
1292− (sp', rp) <- liftIO $ takeMVar tchMV
1293− -- say "picked up our test channel"
1295− -- say "told pid to continue"
1296− res <- receiveChanTimeout delay rp
1298− Nothing -> say "initial chan () missing!" >> (liftIO $ putMVar result False)
1299− Just () -> do mr <- monitor pid
1301− -- say "sending pid a second () will cause it to exit"
1304− -- say "make sure we see a DOWN notification for pid having stopped"
1305− receiveWait [ match (\(_ :: ProcessMonitorNotification) -> return ()) ]
1307− -- now that pid has died, the send port should be useless...
1308− liftIO $ putMVar tchMV (sp', rp)
1310− -- let's verify that we do not see the message from our
1311− -- parent process on the channel, once pid has died...
1312− recv <- receiveChanTimeout delay rp
1313− -- say $ "finished waiting for second (), writing result" ++ (show recv)
1314− liftIO $ putMVar result $ isNothing recv
1316− mRefCPid <- monitor cPid
1319− [ matchIf (\(ProcessMonitorNotification r _ _) -> r == mRefPid)
1323− -- say "seen first pid die..."
1325− (sendPort, _) <- liftIO $ takeMVar tchMV
1326− sendChan sendPort ()
1327− -- say "sent () after owning pid died"
1329− -- let cPid know we've written to the channel...
1333− [ matchIf (\(ProcessMonitorNotification r _ _) -> r == mRefCPid)
1337− -- say "seen both pids die now..."
1339− -- and wait on the result back in IO land...
1340− testRes <- takeMVar result
1341− -- runProcess localNode $ say "got result..."
1342− assertBool "Expected sending on the channel to fail, but received data!" testRes
1345testKillLocal :: TestTransport -> Assertion
1198testKillLocal :: TestTransport -> Assertion
1346testKillLocal TestTransport{..} = do
1199testKillLocal TestTransport{..} = do
1347 localNode <- newLocalNode testTransport initRemoteTable
1200 localNode <- newLocalNode testTransport initRemoteTable
1201+ done <- newEmptyMVar
1349 pid <- forkProcess localNode $ do
1203 pid <- forkProcess localNode $ do
1350 liftIO $ threadDelay 1000000
1204 liftIO $ threadDelay 1000000
@@ -1353,18 +1207,17 @@ testKillLocal TestTransport{..} = do
1353 ref <- monitor pid
1207 ref <- monitor pid
1354 us <- getSelfPid
1208 us <- getSelfPid
1355 kill pid "TestKill"
1209 kill pid "TestKill"
1356− mn <- expect
1210+ ProcessMonitorNotification ref' pid' (DiedException ex) <- expect
1358− ProcessMonitorNotification ref' pid' (DiedException ex) ->
1359− case ref == ref' && pid == pid' && ex == "killed-by=" ++ show us ++ ",reason=TestKill" of
1211+ True <- return $ ref == ref' && pid == pid' && ex == "killed-by=" ++ show us ++ ",reason=TestKill"
1360− True -> return ()
1212+ liftIO $ putMVar done ()
1361− False -> die "Invalid ProcessMonitorNotification received"
1213+
1362− _ -> die "Something went horribly wrong"
1214+ takeMVar done
1364testKillRemote :: TestTransport -> Assertion
1216testKillRemote :: TestTransport -> Assertion
1365testKillRemote TestTransport{..} = do
1217testKillRemote TestTransport{..} = do
1366 node1 <- newLocalNode testTransport initRemoteTable
1218 node1 <- newLocalNode testTransport initRemoteTable
1367 node2 <- newLocalNode testTransport initRemoteTable
1219 node2 <- newLocalNode testTransport initRemoteTable
1220+ done <- newEmptyMVar
1369 pid <- forkProcess node1 $ do
1222 pid <- forkProcess node1 $ do
1370 liftIO $ threadDelay 1000000
1223 liftIO $ threadDelay 1000000
@@ -1373,17 +1226,11 @@ testKillRemote TestTransport{..} = do
1373 ref <- monitor pid
1226 ref <- monitor pid
1374 us <- getSelfPid
1227 us <- getSelfPid
1375 kill pid "TestKill"
1228 kill pid "TestKill"
1378− ProcessMonitorNotification ref' pid' (DiedException reason) ->
1229+ ProcessMonitorNotification ref' pid' (DiedException reason) <- expect
1379− case (ref == ref', pid == pid', reason == "killed-by=" ++ show us ++ ",reason=TestKill") of
1230+ True <- return $ ref == ref' && pid == pid' && reason == "killed-by=" ++ show us ++ ",reason=TestKill"
1380− (True, True, True) -> return ()
1231+ liftIO $ putMVar done ()
1381− (a, b, c) -> do
1232+
1382− let a' = if a then "" else "Invalid ref"
1233+ takeMVar done
1383− let b' = if b then "" else "Invalid pid"
1384− let c' = if c then "" else "Invalid message"
1385− die $ unwords [a', b', c']
1386− _ -> die "Received unexpected message"
1388testCatchesExit :: TestTransport -> Assertion
1235testCatchesExit :: TestTransport -> Assertion
1389testCatchesExit TestTransport{..} = do
1236testCatchesExit TestTransport{..} = do
@@ -1409,10 +1256,7 @@ testHandleMessageIf TestTransport{..} = do
1409 self <- getSelfPid
1256 self <- getSelfPid
1410 send self (5 :: Integer, 10 :: Integer)
1257 send self (5 :: Integer, 10 :: Integer)
1411 msg <- receiveWait [ matchMessage return ]
1258 msg <- receiveWait [ matchMessage return ]
1412− handleMessageIf msg
1259+ Nothing <- handleMessageIf msg (\() -> True) (\() -> die $ "whoops")
1414− (\() -> die "whoops") >>= maybe (return ())
1415− (const $ die "Expected Mismatch")
1416 handleMessageIf msg (\(x :: Integer, y :: Integer) -> x == 5 && y == 10)
1260 handleMessageIf msg (\(x :: Integer, y :: Integer) -> x == 5 && y == 10)
1417 (\input -> liftIO $ putMVar done input)
1261 (\input -> liftIO $ putMVar done input)
1418 return ()
1262 return ()
@@ -1457,11 +1301,8 @@ testDie TestTransport{..} = do
1457 (die ("foobar", 123 :: Int))
1301 (die ("foobar", 123 :: Int))
1458 `catchExit` \_from reason -> do
1302 `catchExit` \_from reason -> do
1459 -- TODO: should verify that 'from' has the right value
1303 -- TODO: should verify that 'from' has the right value
1460− let res = reason == ("foobar", 123 :: Int)
1304+ True <- return $ reason == ("foobar", 123 :: Int)
1461 liftIO $ putMVar done ()
1305 liftIO $ putMVar done ()
1464− else die "Something went horribly wrong"
1466 takeMVar done
1307 takeMVar done
@@ -1475,11 +1316,8 @@ testPrettyExit TestTransport{..} = do
1475 `catch` \ex@(ProcessExitException from _) ->
1316 `catch` \ex@(ProcessExitException from _) ->
1476 let expected = "exit-from=" ++ (show from)
1317 let expected = "exit-from=" ++ (show from)
1478− let res = (show ex) == expected
1319+ True <- return $ (show ex) == expected
1479 liftIO $ putMVar done ()
1320 liftIO $ putMVar done ()
1482− else die "Something went horribly wrong"
1484 takeMVar done
1322 takeMVar done
@@ -1495,26 +1333,17 @@ testExitLocal TestTransport{..} = do
1495 pid <- forkProcess localNode $ do
1333 pid <- forkProcess localNode $ do
1496 (liftIO (putMVar handlerSetUp ()) >> expect) `catchExit` \_from reason -> do
1334 (liftIO (putMVar handlerSetUp ()) >> expect) `catchExit` \_from reason -> do
1497 -- TODO: should verify that 'from' has the right value
1335 -- TODO: should verify that 'from' has the right value
1498− res <- return $ reason == "TestExit"
1336+ True <- return $ reason == "TestExit"
1499 liftIO $ putMVar supervisedDone ()
1337 liftIO $ putMVar supervisedDone ()
1502− else die "Something went horribly wrong"
1504 runProcess localNode $ do
1339 runProcess localNode $ do
1505 liftIO $ takeMVar handlerSetUp
1340 liftIO $ takeMVar handlerSetUp
1506 ref <- monitor pid
1341 ref <- monitor pid
1507 exit pid "TestExit"
1342 exit pid "TestExit"
1508 -- This time the client catches the exception, so it dies normally
1343 -- This time the client catches the exception, so it dies normally
1511− ProcessMonitorNotification ref' pid' DiedNormal -> do
1344+ ProcessMonitorNotification ref' pid' DiedNormal <- expect
1512− let res = ref == ref' && pid == pid'
1345+ True <- return $ ref == ref' && pid == pid'
1513− liftIO $ putMVar supervisorDone ()
1346+ liftIO $ putMVar supervisorDone ()
1516− else die "Something went horribly wrong"
1517− _ -> die "Something went horribly wrong"
1519 takeMVar supervisedDone
1348 takeMVar supervisedDone
1520 takeMVar supervisorDone
1349 takeMVar supervisorDone
@@ -1530,97 +1359,128 @@ testExitRemote TestTransport{..} = do
1530 (receiveWait [] :: Process ()) -- block forever
1359 (receiveWait [] :: Process ()) -- block forever
1531 `catchExit` \_from reason -> do
1360 `catchExit` \_from reason -> do
1532 -- TODO: should verify that 'from' has the right value
1361 -- TODO: should verify that 'from' has the right value
1533− res <- return $ reason == "TestExit"
1362+ True <- return $ reason == "TestExit"
1534 liftIO $ putMVar supervisedDone ()
1363 liftIO $ putMVar supervisedDone ()
1537− else die "Something went horribly wrong"
1539 runProcess node2 $ do
1365 runProcess node2 $ do
1540 ref <- monitor pid
1366 ref <- monitor pid
1541 exit pid "TestExit"
1367 exit pid "TestExit"
1544− ProcessMonitorNotification ref' pid' DiedNormal -> do
1368+ ProcessMonitorNotification ref' pid' DiedNormal <- expect
1545− res' <- return $ ref == ref' && pid == pid'
1369+ True <- return $ ref == ref' && pid == pid'
1546− liftIO $ putMVar supervisorDone ()
1370+ liftIO $ putMVar supervisorDone ()
1549− else die "Something went horribly wrong"
1550− _ -> die "Something went horribly wrong"
1552 takeMVar supervisedDone
1372 takeMVar supervisedDone
1553 takeMVar supervisorDone
1373 takeMVar supervisorDone
1555testRegistryMonitoring :: TestTransport -> Assertion
1375testRegistryMonitoring :: TestTransport -> Assertion
1556testRegistryMonitoring TestTransport{..} = do
1376testRegistryMonitoring TestTransport{..} = do
1557− node1 <- newLocalNode testTransport initRemoteTable
1377+ localNode <- newLocalNode testTransport initRemoteTable
1558− node2 <- newLocalNode testTransport initRemoteTable
1378+ remoteNode <- newLocalNode testTransport initRemoteTable
1560− let nid = localNodeId node2
1561− pid <- forkProcess node1 $ do
1563− runUntilRegistered nid self
1564− say $ (show self) ++ " registered as " ++ regName
1565− expect :: Process ()
1566− say $ (show self) ++ " exiting normally"
1568− runProcess node2 $ do
1381+ -- Local process. Test if local process will be removed from
1569− register regName pid
1382+ -- registry when it dies.
1570− say $ regName ++ " registered to " ++ show pid
1383+ box <- newEmptyMVar
1571− res <- whereis regName
1384+ runProcess localNode $ do
1572− send pid ()
1385+ pid <- spawnLocal $ do
1573− say $ " sent finish signal to " ++ show pid
1386+ expect
1574− us <- getSelfPid
1387+ register "test" pid
1575− liftIO $ assertBool "expected (Just pid)" $ res == (Just pid)
1388+ tpid <- whereis "test"
1576−
1389+ if tpid == Just pid
1577−
1390+ then do _ <- monitor pid
1578− -- This delay isn't essential!
1391+ send pid ()
1579− -- The test case passes perfectly fine without it (feel free to comment out
1392+ ProcessMonitorNotification{} <- expect
1580− -- and see), however waiting a few seconds here, makes it much more likely
1393+ tpid1 <- whereis "test"
1581− -- that in delayUntilMaybeUnregistered we will hit the match case right
1394+ liftIO $ putMVar box (Nothing == tpid1)
1582− -- away, and thus not be subjected to a 20 second delay. The value of 4
1395+ else liftIO $ putMVar box False
1583− -- seconds appears to work optimally on osx and across several linux distros
1396+
1584− -- running in virtual machines (which is essentially what we do in CI)
1397+ takeMVar box >>= assertBool "expected local process to not be registered"
1585− void $ receiveTimeout 4000000 [ matchAny return ]
1398+ return ()
1587− -- This delay doesn't serve much purpose in the happy path, however if some
1400+ -- Remote process. Test if remote process entry is removed
1588− -- future patch breaks the cooperative behaviour of node controllers viz
1401+ -- from registry when process dies.
1589− -- remote process registration and notification taking place via ncEffectDied,
1402+ remote1 <- testRemote remoteNode
1590− -- there would be the possibility of a race in the test case should we attempt
1403+ runProcess localNode $
1591− -- to evaluate `whereis regName` on node2 right away. In case the name is still
1404+ let waitpoll = do
1592− -- erroneously registered, observing the 20 second delay (or lack of), could at
1405+ w <- whereis "test" :: Process (Maybe ProcessId)
1593− -- least give a hint that something is wrong, and we give up our time slice
1406+ forM_ w (const waitpoll)
1594− -- so that there's a higher change the registrations have been cleaned up
1407+ in do register "test" remote1
1595− -- in either case.
1408+ -- [race-condition] invalid test if we force exit before waitpoll runs
1596− runProcess node2 $ delayUntilMaybeUnregistered nid pid
1409+ registered <- whereis "test"
1597−
1410+ registered `shouldBe` (equalTo (Just remote1))
1598− regHere <- newEmptyMVar
1411+ send remote1 ()
1599− runProcess node2 $ whereis regName >>= liftIO . putMVar regHere
1412+ waitpoll
1600− res <- takeMVar regHere
1413+ return ()
1601− case res of
1414+ return ()
1602− Nothing -> return ()
1415+
1603− Just pid -> assertBool ("expected Nothing, but got " ++ show pid) False
1416+ -- Many labels. Test if all labels associated with process
1417+ -- are removed from registry when it dies.
1418+ remote2 <- testRemote remoteNode
1419+ runProcess localNode $
1421+ w1 <- whereis "test-3" :: Process (Maybe ProcessId)
1422+ w2 <- whereis "test-4" :: Process (Maybe ProcessId)
1423+ forM_ (w1 <|> w2) (const waitpoll)
1424+ in do register "test-3" remote2
1425+ register "test-4" remote2
1430+{- XXX: waiting including patch for nsend for remote process
1431+ remote3 <- testRemote remoteNode
1432+ remote4 <- testRemote remoteNode
1433+ -- test many labels
1434+ runProcess localNode $ do
1435+ register "test-3" remote3
1436+ reregister "test-3" remote4
1438+ liftIO $ threadDelay 50000 -- XXX: racy
1441+ ProcessMonitorNotification{} <- expect
1445+ -- Test registerRemoteAsync properties. Add a local process to
1446+ -- remote registry and checks that it is removed
1447+ -- when the process dies.
1448+ remote5 <- testRemote remoteNode
1449+ runProcess localNode $ do
1450+ registerRemoteAsync (localNodeId remoteNode) "test" remote5
1452+ match (\(RegisterReply _ True _) -> return ())
1455+ whereisRemoteAsync (localNodeId remoteNode) "test"
1457+ match (\(WhereIsReply _ mr) -> forM_ mr (const waitpoll))
1461+ -- Add remote process to remote registry and checks if
1462+ -- entry is removed then process is dead.
1463+ remote6 <- testRemote localNode
1464+ runProcess localNode $ do
1465+ registerRemoteAsync (localNodeId remoteNode) "test" remote6
1467+ match (\(RegisterReply _ True _) -> return ())
1470+ whereisRemoteAsync (localNodeId remoteNode) "test"
1472+ match (\(WhereIsReply _ mr) -> forM_ mr (const waitpoll))
1606− runUntilRegistered nid us = do
1476+ testRemote node = do
1607− whereisRemoteAsync nid regName
1477+ -- test many labels
1608− receiveWait [
1478+ pidBox <- newEmptyMVar
1609− matchIf (\(WhereIsReply n (Just p)) -> n == regName && p == us)
1479+ forkProcess node $ do
1610− (const $ return ())
1480+ us <- getSelfPid
1611− ]
1481+ liftIO $ putMVar pidBox us
1612−
1482+ expect :: Process ()
1613− delayUntilMaybeUnregistered nid p = do
1483+ takeMVar pidBox
1614− whereisRemoteAsync nid regName
1615− res <- receiveTimeout 20000000 {- 20 sec delay -} [
1616− matchIf (\(WhereIsReply n p) -> n == regName && isNothing p)
1617− (const $ return ())
1620− Just () -> return ()
1621− Nothing -> delayUntilMaybeUnregistered nid p
1623− regName = "testRegisterRemote"
1625testUnsafeSend :: TestTransport -> Assertion
1485testUnsafeSend :: TestTransport -> Assertion
1626testUnsafeSend TestTransport{..} = do
1486testUnsafeSend TestTransport{..} = do
@@ -1637,7 +1497,8 @@ testUnsafeSend TestTransport{..} = do
1637 void $ forkProcess localNode $ do
1497 void $ forkProcess localNode $ do
1638 serverPid <- liftIO $ takeMVar serverAddr
1498 serverPid <- liftIO $ takeMVar serverAddr
1639 getSelfPid >>= unsafeSend serverPid
1499 getSelfPid >>= unsafeSend serverPid
1640− expect >>= liftIO . putMVar clientDone
1501+ liftIO $ putMVar clientDone ()
1642 takeMVar clientDone
1503 takeMVar clientDone
@@ -1656,7 +1517,8 @@ testUnsafeUSend TestTransport{..} = do
1656 void $ forkProcess localNode $ do
1517 void $ forkProcess localNode $ do
1657 serverPid <- liftIO $ takeMVar serverAddr
1518 serverPid <- liftIO $ takeMVar serverAddr
1658 getSelfPid >>= unsafeUSend serverPid
1519 getSelfPid >>= unsafeUSend serverPid
1659− expect >>= liftIO . putMVar clientDone
1521+ liftIO $ putMVar clientDone ()
1661 takeMVar clientDone
1523 takeMVar clientDone
@@ -1667,7 +1529,8 @@ testUnsafeNSend TestTransport{..} = do
1667 localNode <- newLocalNode testTransport initRemoteTable
1529 localNode <- newLocalNode testTransport initRemoteTable
1669 pid <- forkProcess localNode $ do
1531 pid <- forkProcess localNode $ do
1670− expect >>= liftIO . putMVar clientDone
1533+ liftIO $ putMVar clientDone ()
1672 void $ runProcess localNode $ do
1535 void $ runProcess localNode $ do
1673 register "foobar" pid
1536 register "foobar" pid
@@ -1685,7 +1548,8 @@ testUnsafeNSendRemote TestTransport{..} = do
1685 _ <- forkProcess localNode1 $ do
1548 _ <- forkProcess localNode1 $ do
1686 getSelfPid >>= register "foobar"
1549 getSelfPid >>= register "foobar"
1687 liftIO $ putMVar clientDone ()
1550 liftIO $ putMVar clientDone ()
1688− expect >>= liftIO . putMVar clientDone
1552+ liftIO $ putMVar clientDone ()
1690 takeMVar clientDone
1554 takeMVar clientDone
1691 void $ runProcess localNode2 $ do
1555 void $ runProcess localNode2 $ do
@@ -1709,7 +1573,7 @@ testUnsafeSendChan TestTransport{..} = do
1709 serverPid <- liftIO $ takeMVar serverAddr
1573 serverPid <- liftIO $ takeMVar serverAddr
1710 (sp, rp) <- newChan
1574 (sp, rp) <- newChan
1711 unsafeSend serverPid sp
1575 unsafeSend serverPid sp
1712− receiveChan rp :: Process ()
1576+ () <- receiveChan rp
1713 liftIO $ putMVar clientDone ()
1577 liftIO $ putMVar clientDone ()
1715 takeMVar clientDone
1579 takeMVar clientDone
@@ -1723,8 +1587,8 @@ testCallLocal TestTransport{..} = do
1723 runProcess node $ do
1587 runProcess node $ do
1724 r <- (/=) <$> getSelfPid <*> callLocal getSelfPid
1588 r <- (/=) <$> getSelfPid <*> callLocal getSelfPid
1725 liftIO $ putMVar result r
1589 liftIO $ putMVar result r
1727− takeMVar result >>= assertBool "Expected 'True'"
1590+ True <- takeMVar result
1729 -- Testing that when callLocal is interrupted, the worker is interrupted.
1593 -- Testing that when callLocal is interrupted, the worker is interrupted.
1730 ibox <- newIORef False
1594 ibox <- newIORef False
@@ -1741,9 +1605,10 @@ testCallLocal TestTransport{..} = do
1741 (send keeper ())
1605 (send keeper ())
1742 caller <- expect
1606 caller <- expect
1743 exit caller "test"
1607 exit caller "test"
1744− expect :: Process ()
1608+ () <- expect
1746− readIORef ibox >>= assertBool "Expected 'True'"
1610+ True <- readIORef ibox
1748 -- Testing that when the worker raises an exception, the exception is propagated to the parent.
1613 -- Testing that when the worker raises an exception, the exception is propagated to the parent.
1749 ibox2 <- newIORef False
1614 ibox2 <- newIORef False
@@ -1752,8 +1617,8 @@ testCallLocal TestTransport{..} = do
1752 liftIO $ writeIORef ibox2 $ case r of
1617 liftIO $ writeIORef ibox2 $ case r of
1753 Left (ErrorCall "e") -> True
1618 Left (ErrorCall "e") -> True
1754 _ -> False
1619 _ -> False
1756− readIORef ibox >>= assertBool "Expected 'True'"
1620+ True <- readIORef ibox
1758 -- Test that caller waits for the worker in correct situation
1623 -- Test that caller waits for the worker in correct situation
1759 ibox3 <- newIORef False
1624 ibox3 <- newIORef False
@@ -1770,8 +1635,8 @@ testCallLocal TestTransport{..} = do
1770 liftIO $ putMVar result3 =<< readIORef ibox3
1635 liftIO $ putMVar result3 =<< readIORef ibox3
1771 worker <- expect
1636 worker <- expect
1772 send worker ()
1637 send worker ()
1774− takeMVar result3 >>= assertBool "Expected 'True'"
1638+ True <- takeMVar result3
1776 -- Test that caller waits for the worker in case when caller gets an exception
1641 -- Test that caller waits for the worker in case when caller gets an exception
1777 ibox4 <- newIORef False
1642 ibox4 <- newIORef False
@@ -1787,10 +1652,14 @@ testCallLocal TestTransport{..} = do
1787 `finally` (liftIO $ putMVar result4 =<< readIORef ibox4)
1652 `finally` (liftIO $ putMVar result4 =<< readIORef ibox4)
1788 caller <- expect
1653 caller <- expect
1789 exit caller "hi!"
1654 exit caller "hi!"
1791− takeMVar result4 >>= assertBool "Expected 'True'"
1655+ True <- takeMVar result4
1792 -- XXX: Testing that when mask_ $ callLocal p runs p in masked state.
1657 -- XXX: Testing that when mask_ $ callLocal p runs p in masked state.
1794tests :: TestTransport -> IO [Test]
1663tests :: TestTransport -> IO [Test]
1795tests testtrans = return [
1664tests testtrans = return [
1796 testGroup "Basic features" [
1665 testGroup "Basic features" [
@@ -1814,7 +1683,6 @@ tests testtrans = return [
1814 , testCase "MatchMessageUnwrap" (testMatchMessageWithUnwrap testtrans)
1683 , testCase "MatchMessageUnwrap" (testMatchMessageWithUnwrap testtrans)
1815 , testCase "ReceiveChanTimeout" (testReceiveChanTimeout testtrans)
1684 , testCase "ReceiveChanTimeout" (testReceiveChanTimeout testtrans)
1816 , testCase "ReceiveChanFeatures" (testReceiveChanFeatures testtrans)
1685 , testCase "ReceiveChanFeatures" (testReceiveChanFeatures testtrans)
1817− , testCase "ChanLifecycle" (testChanLifecycle testtrans)
1818 , testCase "KillLocal" (testKillLocal testtrans)
1686 , testCase "KillLocal" (testKillLocal testtrans)
1819 , testCase "KillRemote" (testKillRemote testtrans)
1687 , testCase "KillRemote" (testKillRemote testtrans)
1820 , testCase "Die" (testDie testtrans)
1688 , testCase "Die" (testDie testtrans)
@@ -1824,7 +1692,7 @@ tests testtrans = return [
1824 , testCase "MaskRestoreScope" (testMaskRestoreScope testtrans)
1692 , testCase "MaskRestoreScope" (testMaskRestoreScope testtrans)
1825 , testCase "ExitLocal" (testExitLocal testtrans)
1693 , testCase "ExitLocal" (testExitLocal testtrans)
1826 , testCase "ExitRemote" (testExitRemote testtrans)
1694 , testCase "ExitRemote" (testExitRemote testtrans)
1827− , testCase "RegistryMonitoring" (testRegistryMonitoring testtrans)
1695+ , testCase "TestRegistryMonitor" (testRegistryMonitoring testtrans)
1828 , testCase "TextCallLocal" (testCallLocal testtrans)
1696 , testCase "TextCallLocal" (testCallLocal testtrans)
1829 -- Unsafe Primitives
1697 -- Unsafe Primitives
1830 , testCase "TestUnsafeSend" (testUnsafeSend testtrans)
1698 , testCase "TestUnsafeSend" (testUnsafeSend testtrans)
@@ -1877,3 +1745,17 @@ tests testtrans = return [
1877 , testCase "MonitorUnreachable" (testMonitorUnreachable testtrans True False)
1745 , testCase "MonitorUnreachable" (testMonitorUnreachable testtrans True False)
1749+syncBreakConnection :: (NT.EndPointAddress -> NT.EndPointAddress -> IO ()) -> LocalNode -> LocalNode -> IO ()
1750+syncBreakConnection breakConnection nid0 nid1 = do
1752+ _ <- forkProcess nid1 $ getSelfPid >>= liftIO . putMVar m
1753+ runProcess nid0 $ do
1754+ them <- liftIO $ takeMVar m
1755+ pinger <- spawnLocal $ forever $ send them ()
1756+ _ <- monitorNode (localNodeId nid1)
1757+ liftIO $ breakConnection (nodeAddress $ localNodeId nid0)
1758+ (nodeAddress $ localNodeId nid1)
1759+ NodeMonitorNotification _ _ _ <- expect
1760+ kill pinger "finished"