rls fixes

migra/changes.py

@@ -167,6 +167,9 @@ def get_table_changes(tables_from, tables_target, enums_from, enums_target):
         statements.append(v.drop_statement)
     for t, v in added.items():
         statements.append(v.create_statement)
+        if v.rowsecurity:
+            rls_alter = v.alter_rls_statement
+            statements.append(rls_alter)
     statements += get_enum_modifications(
         tables_from, tables_target, enums_from, enums_target
     )
@@ -217,7 +220,7 @@ def get_table_changes(tables_from, tables_target, enums_from, enums_target):
 
         if v.rowsecurity != before.rowsecurity:
             rls_alter = v.alter_rls_statement
-            statements += [rls_alter]
+            statements.append(rls_alter)
 
     return statements
 

pyproject.toml

@@ -14,7 +14,7 @@ python = "*"
 sqlbag = "*"
 six = "*"
 # schemainspect = {path="../schemainspect"}
-schemainspect = ">=0.1.1592273867"
+schemainspect = ">=0.1.1592300770"
 psycopg2-binary = { version="*", optional = true }
 
 [tool.poetry.dev-dependencies]

tests/FIXTURES/rls/expected.sql

@@ -7,4 +7,4 @@ on "public"."accounts"
 as restrictive
 for all
 to schemainspect_test_role
-using (manager = CURRENT_USER);
+using ((manager = CURRENT_USER));

tests/FIXTURES/rls2/a.sql

@@ -0,0 +1 @@
+create table t();

tests/FIXTURES/rls2/b.sql

@@ -0,0 +1,7 @@
+CREATE TABLE example (
+  id SERIAL PRIMARY KEY,
+  name text NOT NULL
+);
+ALTER TABLE example ENABLE ROW LEVEL SECURITY;
+CREATE POLICY example_all ON example FOR ALL
+   USING (true);

tests/FIXTURES/rls2/expected.sql

@@ -0,0 +1,22 @@
+create sequence "public"."example_id_seq";
+
+drop table "public"."t";
+
+create table "public"."example" (
+    "id" integer not null default nextval('example_id_seq'::regclass),
+    "name" text not null
+);
+
+
+alter table "public"."example" enable row level security;
+
+CREATE UNIQUE INDEX example_pkey ON public.example USING btree (id);
+
+alter table "public"."example" add constraint "example_pkey" PRIMARY KEY using index "example_pkey";
+
+create policy "example_all"
+on "public"."example"
+as permissive
+for all
+to public
+using (true);

tests/test_migra.py

@@ -111,7 +111,7 @@ SELECT 1 FROM pg_roles WHERE rolname=:rolename
 
 
 def test_rls():
-    for FIXTURE_NAME in ["rls"]:
+    for FIXTURE_NAME in ["rls", "rls2"]:
         do_fixture_test(FIXTURE_NAME, with_privileges=True)