on master help sign in
WIP fixed listing containers
commitd7e30423b4bb48428774d7cede213709ed736b2a authorDeni Bertovic <deni@denibertovic.com> dateThu 14 Dec 2017, 16:34 (9 years ago) parente78f625
4 files changed+35−25
Makefile+1−1 src/Docker/Client/Internal.hs+3−2 src/Docker/Client/Types.hs+20−18 tests/tests.hs+11−4
Makefile+1−1
@@ -18,7 +18,7 @@ repl:
1818
1919## Run tests. Example RUN_INTEGRATION_TESTS=1 make test
2020test:
21− @stack test
21+ @RUN_INTEGRATION_TESTS=1 stack test
2222
2323## Cut new release
2424release:
src/Docker/Client/Internal.hs+3−2
@@ -5,12 +5,13 @@ import qualified Data.Aeson as JSON
55import Data.ByteString (ByteString)
66import qualified Data.ByteString.Char8 as BSC
77import qualified Data.Conduit.Binary as CB
8−import Data.Text as T
8+import qualified Data.Text as T
99import Data.Text.Encoding (decodeUtf8, encodeUtf8)
1010import qualified Network.HTTP.Client as HTTP
1111import Network.HTTP.Conduit (requestBodySourceChunked)
1212import Network.HTTP.Types (Query, encodePath,
1313 encodePathSegments)
14+import Prelude hiding (all)
1415
1516import Docker.Client.Types
1617
@@ -26,7 +27,7 @@ encodeQ = encodeUtf8 . T.pack
2627
2728getEndpoint :: ApiVersion -> Endpoint -> T.Text
2829getEndpoint v VersionEndpoint = encodeURL [v, "version"]
29−getEndpoint v (ListContainersEndpoint _) = encodeURL [v, "containers", "json"] -- Make use of lsOpts here
30+getEndpoint v (ListContainersEndpoint (ListOpts all)) = encodeURLWithQuery [v, "containers", "json"] [("all", Just (encodeQ $ show all))]
3031getEndpoint v (ListImagesEndpoint _) = encodeURL [v, "images", "json"] -- Make use of lsOpts here
3132getEndpoint v (CreateContainerEndpoint _ cn) = case cn of
3233 Just cn -> encodeURLWithQuery [v, "containers", "create"] [("name", Just (encodeQ $ T.unpack cn))]
src/Docker/Client/Types.hs+20−18
@@ -246,11 +246,11 @@ data ContainerDetails = ContainerDetails {
246246-- | Data type used for parsing the mount information from a container
247247-- list.
248248data Mount = Mount {
249− mountName :: Text
249+ mountName :: Maybe Text
250250 , mountSource :: FilePath
251251 , mountDestination :: FilePath
252− , mountDriver :: Text
253− , mountMode :: Maybe VolumePermission -- apparently this can be null
252+ , mountDriver :: Maybe Text
253+ -- , mountMode :: Maybe VolumePermission -- apparently this can be null
254254 , mountRW :: Bool
255255 , mountPropogation :: Text
256256 }
@@ -258,14 +258,14 @@ data Mount = Mount {
258258
259259instance FromJSON Mount where
260260 parseJSON (JSON.Object o) = do
261− name <- o .: "Name"
261+ name <- o .:? "Name"
262262 src <- o .: "Source"
263263 dest <- o .: "Destination"
264− driver <- o .: "Driver"
265− mode <- o .: "Mode"
264+ driver <- o .:? "Driver"
265+ -- mode <- o .: "Mode"
266266 rw <- o .: "RW"
267267 prop <- o .: "Propagation"
268− return $ Mount name src dest driver mode rw prop
268+ return $ Mount name src dest driver rw prop
269269 parseJSON _ = fail "Mount is not an object"
270270
271271-- | Data type used for parsing the container state from a list of
@@ -520,11 +520,11 @@ data Container = Container
520520
521521instance FromJSON Container where
522522 parseJSON o@(JSON.Object v) =
523− Container <$> (parseJSON o)
523+ Container <$> parseJSON o
524524 <*> (v .: "Names")
525525 <*> (v .: "Image")
526− <*> (v .: "ImageID")
527− <*> (v .: "Command")
526+ <*> (v .: "ImageID") -- Doesn't exist anymore
527+ <*> (v .: "Command") -- Doesn't exist anymore
528528 <*> (v .: "Created")
529529 <*> (v .: "Status")
530530 <*> (v .: "Ports")
@@ -538,17 +538,17 @@ instance FromJSON Container where
538538 parseJSON _ = fail "Container: Not a JSON object."
539539
540540-- | Represents the status of the container life cycle.
541−data Status = Created | Restarting | Running | Paused | Exited | Dead
541+data Status = ContainerStatus T.Text
542542 deriving (Eq, Show, Generic)
543543
544544instance FromJSON Status where
545− parseJSON (JSON.String "running") = return Running
546− parseJSON (JSON.String "created") = return Created -- Note: Guessing on the string values of these.
547− parseJSON (JSON.String "restarting") = return Restarting
548− parseJSON (JSON.String "paused") = return Paused
549− parseJSON (JSON.String "exited") = return Exited
550− parseJSON (JSON.String "dead") = return Dead
551− parseJSON _ = fail "Unknown Status"
545+ parseJSON (JSON.String s) = return $ ContainerStatus s
546+ -- parseJSON (JSON.String "Created") = return Created
547+ -- parseJSON (JSON.String "Restarting") = return Restarting
548+ -- parseJSON (JSON.String "Paused") = return Paused
549+ -- parseJSON (JSON.String "Exited") = parseExited s
550+ -- parseJSON (JSON.String "Dead") = return Dead
551+ parseJSON _ = fail "Failed to parse Status. Unknown Status."
552552
553553-- | Alias for representing a RepoDigest. We could newtype this and add
554554-- some validation.
@@ -788,6 +788,8 @@ instance ToJSON VolumePermission where
788788instance FromJSON VolumePermission where
789789 parseJSON "rw" = return ReadWrite
790790 parseJSON "ro" = return ReadOnly
791+ parseJSON "RW" = return ReadWrite
792+ parseJSON "RO" = return ReadOnly
791793 parseJSON _ = fail "Failed to parse VolumePermission"
792794
793795-- | Used for marking a directory in the container as "exposed" hence
tests/tests.hs+11−4
@@ -2,6 +2,7 @@
22
33module Main where
44
5+import Prelude hiding (all)
56import qualified Test.QuickCheck.Monadic as QCM
67import Test.Tasty
78import Test.Tasty.HUnit
@@ -9,6 +10,7 @@ import Test.Tasty.QuickCheck (testProperty)
910
1011import Control.Concurrent (threadDelay)
1112import Control.Lens ((^.), (^?))
13+import Control.Monad (forM_)
1214import Control.Monad.IO.Class
1315import Control.Monad.Trans.Class (lift)
1416import qualified Data.Aeson as JSON
@@ -71,10 +73,15 @@ testFindImage =
7173
7274testListContainers :: IO ()
7375testListContainers =
74− runDocker $
75− do res <- listContainers defaultListOpts
76− liftIO $ print res
77− lift $ assert $ isRight res
76+ runDocker $ do
77+ res <- listContainers $ ListOpts { all=True }
78+ case res of
79+ Right cs -> do
80+ forM_ cs $ \r -> do
81+ lift $ print (containerNetworks r)
82+ lift $ print (containerStatus r)
83+ Left e -> lift $ print e
84+ lift $ assert $ isRight res
7885
7986testBuildFromDockerfile :: IO ()
8087testBuildFromDockerfile = do