on master help sign in
21 files changed+679−176
since splitsnapshots
unifiedsplit
.gitignore+1 .travis.yml+25−3 CHANGELOG.md+71 CONTRIBUTING.md+12−2 LICENSE+1−1 Makefile+21−2 README.md+26−9 docker.cabal+26−12 src/Docker/Client.hs+1−1 src/Docker/Client/Api.hs+21−3 src/Docker/Client/Http.hs+40−7 src/Docker/Client/Internal.hs+11−3 src/Docker/Client/Types.hs+170−45 stack-7.10.yaml+5−5 stack-8.0.2.yaml+4 stack-8.0.yaml+2−1 stack-8.6.4.yaml+4 stack-8.8.2.yaml+5 stack.yaml+1−1 tests/Dockerfile+1−1 tests/tests.hs+231−80
.gitignore+1
@@ -4,3 +4,4 @@
44*~
55.stack-work/
66dist-newstyle
7+/cabal.project.local
.travis.yml+25−3
@@ -22,8 +22,30 @@ services:
2222 - docker
2323
2424env:
25− - GHCVER=7.10 STACK_ARGS=""
26− - GHCVER=8.0 STACK_ARGS=""
25+ global:
26+ - RUN_INTEGRATION_TESTS=1
27+ - STACK_ARGS=""
28+
29+ matrix:
30+ - DOCKER_VERSION="1.12.3-0~trusty" GHCVER=7.10
31+ - DOCKER_VERSION="1.13.1-0~ubuntu-trusty" GHCVER=7.10
32+ - DOCKER_VERSION="17.05.0~ce-0~ubuntu-trusty" GHCVER=7.10
33+
34+ - DOCKER_VERSION="1.12.3-0~trusty" GHCVER=8.0
35+ - DOCKER_VERSION="1.13.1-0~ubuntu-trusty" GHCVER=8.0
36+ - DOCKER_VERSION="17.05.0~ce-0~ubuntu-trusty" GHCVER=8.0
37+
38+ - DOCKER_VERSION="1.12.3-0~trusty" GHCVER=8.0.2
39+ - DOCKER_VERSION="1.13.1-0~ubuntu-trusty" GHCVER=8.0.2
40+ - DOCKER_VERSION="17.05.0~ce-0~ubuntu-trusty" GHCVER=8.0.2
41+
42+ - DOCKER_VERSION="1.12.3-0~trusty" GHCVER=8.6.4
43+ - DOCKER_VERSION="1.13.1-0~ubuntu-trusty" GHCVER=8.6.4
44+ - DOCKER_VERSION="17.05.0~ce-0~ubuntu-trusty" GHCVER=8.6.4
45+
46+ - DOCKER_VERSION="1.12.3-0~trusty" GHCVER=8.8.2
47+ - DOCKER_VERSION="1.13.1-0~ubuntu-trusty" GHCVER=8.8.2
48+ - DOCKER_VERSION="17.05.0~ce-0~ubuntu-trusty" GHCVER=8.8.2
2749
2850addons:
2951 apt:
@@ -35,7 +57,7 @@ before_install:
3557 - sudo sh -c 'echo "deb https://apt.dockerproject.org/repo ubuntu-trusty main" > /etc/apt/sources.list.d/docker.list'
3658 - sudo apt-key adv --keyserver hkp://p80.pool.sks-keyservers.net:80 --recv-keys 58118E89F3A912897C070ADBF76221572C52609D
3759 - sudo apt-get update
38− - sudo apt-get -qqy -o Dpkg::Options::="--force-confdef" -o Dpkg::Options::="--force-confold" install docker-engine=1.12.3-0~trusty
60+ - sudo apt-get -qqy -o Dpkg::Options::="--force-confdef" -o Dpkg::Options::="--force-confold" install docker-engine=$DOCKER_VERSION
3961
4062install:
4163 - mkdir -p "$HOME"/.local/bin
CHANGELOG.md+71
@@ -1,5 +1,76 @@
11# CHANGELOG
22
3+## 0.6.0.3 (2020-02-17)
4+
5+- Support for ghc 8.8.2.
6+- Bump dependency version.
7+- Use MonadFail for later versions.
8+
9+## 0.6.0.1 (2019-05-23)
10+
11+- Support ghc 8.6.4.
12+- Bump containers version.
13+
14+## 0.6.0.0 (2018-06-28)
15+
16+- Rename DeleteOpts to ContainerDeleteOpts.
17+- Implement image deletion.
18+- Bump aeson version.
19+- Implement network aliases.
20+- Implement creating/deleting networks.
21+
22+## 0.5.1.1 (2018-03-09)
23+
24+- Bump aeson version.
25+
26+## 0.5.1.0 (2018-02-23)
27+
28+- Support http-conduit-2.3.0.
29+- Bump http-types versions.
30+
31+## 0.5.0.1 (2018-01-26)
32+
33+- Bumps upper bound for http-types (properly this time).
34+
35+## 0.5.0.0 (2018-01-24)
36+
37+- Added (some) contribution and general docs
38+- Fix case when stopping non-existent container
39+- Added more integration tests
40+- Fixed error while parsing list container endpoint output
41+- Changed State/Status data type (related to the above fix)
42+- Added tests against different docker version to travis CIA
43+- Fixed EnvVar JSON encoding
44+- Fixed NetworkMode parsing
45+- Allow http-types 0.11
46+
47+## 0.4.1.1 (2017-10-16)
48+
49+- Small change to add env var for skipping integration tests.
50+ This is mostly to avoid running those on stackage.
51+
52+## 0.4.1.0 (2017-10-04)
53+
54+- Relaxed aeson, tls and time upper bounds
55+
56+
57+## 0.4.0.2 (2017-09-19)
58+
59+- Support LTS 9.4
60+
61+## 0.4.0.1 (2017-06-29)
62+
63+- fixes omKillDisable parsing from json
64+- adds Entrypoint data type and tests edge cases
65+- more tests
66+- small comsmetic changes
67+
68+## 0.4.0.0 (2017-03-20)
69+
70+- Adds streaming support via conduits (changes API a bit hence the major version release)
71+- Added support for streaming log output
72+- Added support for pulling images from the hub (and streaming the output)
73+
374## 0.3.0.1 (2016-09-07)
475
576- Small cosmetic changes and marking OVERLAPPING instance
CONTRIBUTING.md+12−2
@@ -1,4 +1,14 @@
1−# TODO
1+# Contributing
22
3−Add basic guidelines here, things like style guide (using .configuration files from the repo) etc etc.
3+If you wish to contribute please see [any issue on GitHub tagged with "help
4+wanted"](https://github.com/denibertovic/docker-hs/issues?q=is%3Aopen+is%3Aissue+label%3A%22help+wanted%22).
5+Before starting to work, consider commenting on the issue you want to resolve or
6+open a new issue to discuss design decisions and implementation details. This is
7+so that no development cycles go to waste on implementing a feature that might
8+not get merged either because of implementation details or other reasons.
49
10+Make sure to submit your PR's against the `master` branch.
11+
12+## Project Setup
13+
14+See the `README.md` file on how to setup the project on your development machine.
LICENSE+1−1
@@ -1,4 +1,4 @@
1−Copyright (c) 2016, Deni Bertovic
1+Copyright (c) 2014, Deni Bertovic
22
33All rights reserved.
44
Makefile+21−2
@@ -1,4 +1,6 @@
1−.PHONY: build repl test release
1+.PHONY: build repl test release help
2+
3+.DEFAULT_GOAL = help
24
35PROJECT_NAME ?= $(shell grep "^name" docker.cabal | cut -d " " -f17)
46VERSION ?= $(shell grep "^version:" docker.cabal | cut -d " " -f14)
@@ -6,18 +8,35 @@ RESOLVER ?= $(shell grep "^resolver:" stack.yaml | cut -d " " -f2)
68GHC_VERSION ?= $(shell stack ghc -- --version | cut -d " " -f8)
79ARCH=$(shell uname -m)
810
11+## Run build
912build:
1013 @stack build
1114
15+## Run repl
1216repl:
1317 @stack repl
1418
19+## Run tests. Example RUN_INTEGRATION_TESTS=1 make test
1520test:
16− @stack test
21+ @RUN_INTEGRATION_TESTS=1 stack test
1722
23+## Cut new release
1824release:
1925 @stack build --haddock
2026 @stack sdist
2127 @echo "\n\nDone. Now run: \n\nstack upload <path_to_tarball>\n"
2228 @echo "\nAnd: \n\ngit tag ${VERSION} && git push --tags\n"
2329
30+## Show help screen.
31+help:
32+ @echo "Please use \`make <target>' where <target> is one of\n\n"
33+ @awk '/^[a-zA-Z\-\_0-9]+:/ { \
34+ helpMessage = match(lastLine, /^## (.*)/); \
35+ if (helpMessage) { \
36+ helpCommand = substr($$1, 0, index($$1, ":")-1); \
37+ helpMessage = substr(lastLine, RSTART + 3, RLENGTH); \
38+ printf "%-30s %s\n", helpCommand, helpMessage; \
39+ } \
40+ } \
41+ { lastLine = $$0 }' $(MAKEFILE_LIST)
42+
README.md+26−9
@@ -7,25 +7,42 @@
77
88## Current state
99
10−**API is still not stable.**
11−
12−Supported Docker Engine Api version: `v1.24`
10+Supported Docker Engine Api version: `v1.24` and onwards.
1311
1412Anything upward of that should work since Docker versions their API.
1513Older docker version and engine api versions are not supported at the moment.
1614
15+## Documentation
16+
17+The API-documentation is available at
18+[Hackage](https://hackage.haskell.org/package/docker). There are also some
19+usage-examples in the main library source file,
20+[`Client.hs`](https://hackage.haskell.org/package/docker/docs/Docker-Client.html).
21+
1722## Contributing
1823
19−If you wish to contribute please see any issue tagged with "help wanted".
20−Make sure to submit your PR's against the `master` branch.
24+Please see [CONTRIBUTING.md](CONTRIBUTING.md).
25+
26+### Project Setup
2127
22−Please consider filling an Issue first and discuss design decisions and implementation details before
23−writing any code. This is so that no development cycles go to waste on implementing a feature that
24−might not get merged either because of implementation details or other reasons.
28+For working on the library, you need the Haskell Tool Stack installed (see [the
29+Haskell Tool Stack
30+website](https://docs.haskellstack.org/en/stable/install_and_upgrade/)). You
31+also need `make` to use the `Makefile` included in the project. Run `make help`
32+to see the available commands (for building, running the tests and releasing).
2533
34+### Tests
35+
36+Tests are located in the `tests` directory and can be run with `make test`. This
37+only runs the unit tests.
38+
39+To run integration tests, you need Docker installed and listening on Port `2375`
40+of `localhost` (docker only listens to a Unix socket by default, see the [Docker
41+documentation](https://docs.docker.com/engine/reference/commandline/dockerd/#daemon-socket-option)
42+for details). Set the environment variable `RUN_INTEGRATION_TESTS`, i.e.
43+`RUN_INTEGRATION_TESTS=1 make test`.
2644
2745## IRC
2846
2947If you have any questions or suggestions you can find the maintainers in `#docker-haskell`
3048on freenode.
31−
docker.cabal+26−12
@@ -1,5 +1,5 @@
11name: docker
2−version: 0.4.0.0
2+version: 0.6.0.3
33synopsis: An API client for docker written in Haskell
44description: See API documentation below.
55homepage: https://github.com/denibertovic/docker-hs
@@ -14,24 +14,29 @@ extra-source-files: README.md
1414cabal-version: >=1.10
1515stability: experimental
1616
17+-- Flag small-http-conduit
18+-- Description: Resolve whether http-conduit < 2.3.0.
19+-- Manual: False
20+-- Default: True
21+
1722library
18− default-extensions: DeriveGeneric, OverloadedStrings, ScopedTypeVariables, ExplicitForAll, MultiParamTypeClasses, FlexibleContexts, GeneralizedNewtypeDeriving, RankNTypes, DeriveFunctor, FlexibleInstances
23+ default-extensions: DeriveGeneric, OverloadedStrings, ScopedTypeVariables, ExplicitForAll, MultiParamTypeClasses, FlexibleContexts, GeneralizedNewtypeDeriving, RankNTypes, DeriveFunctor, FlexibleInstances, CPP
1924 hs-source-dirs: src
2025 exposed-modules: Docker.Client, Docker.Client.Api, Docker.Client.Types, Docker.Client.Internal, Docker.Client.Http, Docker.Client.Utils
2126 -- other-modules: Docker.Internal
2227 build-depends: base >= 4.7 && < 5
23− , aeson >= 0.9.0 && < 1.1.0
28+ , aeson >= 0.9.0 && < 2.0.0
2429 , blaze-builder >= 0.4.0 && < 0.5.0
2530 , bytestring >= 0.10.0 && < 0.11.0
26− , containers >= 0.5.0 && < 0.6.0
31+ , containers >= 0.5.0 && < 0.7.0
2732 , data-default-class >= 0.0.1 && < 0.2.0
28− , http-client >= 0.4.0 && < 0.5.0
29− , http-types >= 0.9 && < 0.10.0
33+ , http-client >= 0.4.0 && < 0.7.0
34+ , http-types >= 0.9 && < 0.13
35+ , vector
3036 , conduit
3137 , conduit-combinators
3238 , conduit-extra
3339 , exceptions
34− , http-conduit
3540 , monad-control
3641 , resourcet
3742 , transformers
@@ -46,13 +51,20 @@ library
4651 , mtl >= 2.0.0 && < 3.0.0
4752 , network >= 2.6.0
4853 , text >= 1.0.0 && < 2.0.0
49− , time >= 1.5.0 && < 1.7.0
54+ , time >= 1.5.0 && < 2.0.0
5055 , scientific >= 0.3.0 && < 0.4.0
51− , tls >= 1.3.7 && < 1.4.0
56+ , tls >= 1.3.7 && < 1.6.0
5257 , unordered-containers >= 0.2.0 && < 0.3.0
53− , x509 >= 1.6.0 && < 1.7.0
54− , x509-store >= 1.6.0 && < 1.7.0
55− , x509-system >= 1.6.0 && < 1.7.0
58+ , x509 >= 1.6.0 && < 1.8.0
59+ , x509-store >= 1.6.0 && < 1.8.0
60+ , x509-system >= 1.6.0 && < 1.8.0
61+ , http-conduit
62+ , unliftio-core >= 0.1.0.0 && < 0.2.0
63+ -- if flag(small-http-conduit)
64+ -- build-depends: http-conduit < 2.3.0
65+ -- else
66+ -- build-depends: http-conduit >= 2.3.0
67+ -- , unliftio-core
5668 default-language: Haskell2010
5769 ghc-options: -Wall -fno-warn-name-shadowing
5870
@@ -61,6 +73,7 @@ test-suite docker-hs-tests
6173 , bytestring
6274 , connection
6375 , docker
76+ , directory
6477 , aeson
6578 , containers
6679 , unordered-containers
@@ -76,6 +89,7 @@ test-suite docker-hs-tests
7689 , transformers
7790 , QuickCheck
7891 , process
92+ , vector
7993 type: exitcode-stdio-1.0
8094 main-is: tests.hs
8195 hs-source-dirs: tests
src/Docker/Client.hs+1−1
@@ -3,7 +3,7 @@
33
44{-|
55Module : Docker.Client
6−Copyright : (c) Deni Bertovic, 2016
6+Copyright : (c) Deni Bertovic, 2014
77License : BSD3
88Maintainer : deni@denibertovic.com
99Stability : experimental
src/Docker/Client/Api.hs+21−3
@@ -18,8 +18,12 @@ module Docker.Client.Api (
1818 , getContainerLogsStream
1919 -- * Images
2020 , listImages
21+ , deleteImage
2122 , buildImageFromDockerfile
2223 , pullImage
24+ -- * Network
25+ , createNetwork
26+ , removeNetwork
2327 -- * Other
2428 , getDockerVersion
2529 ) where
@@ -43,7 +47,7 @@ import Docker.Client.Types
4347import Docker.Client.Utils
4448
4549requestUnit :: (MonadIO m, MonadMask m) => HttpVerb -> Endpoint -> DockerT m (Either DockerError ())
46−requestUnit verb endpoint = const (Right ()) <$> requestHelper verb endpoint
50+requestUnit verb endpoint = fmap (const ()) <$> requestHelper verb endpoint
4751
4852requestHelper :: (MonadIO m, MonadMask m) => HttpVerb -> Endpoint -> DockerT m (Either DockerError BSL.ByteString)
4953requestHelper verb endpoint = requestHelper' verb endpoint Conduit.sinkLbs
@@ -90,6 +94,12 @@ listContainers opts = requestHelper GET (ListContainersEndpoint opts) >>= parseR
9094listImages :: forall m. (MonadIO m, MonadMask m) => ListOpts -> DockerT m (Either DockerError [Image])
9195listImages opts = requestHelper GET (ListImagesEndpoint opts) >>= parseResponse
9296
97+-- | Deletes an image with the given 'ImageID'.
98+-- See "ImageDeleteOpts" for options and use 'defaultImageDeleteOpts' for sane
99+-- defaults.
100+deleteImage :: forall m. (MonadIO m, MonadMask m) => ImageDeleteOpts -> ImageID -> DockerT m (Either DockerError ())
101+deleteImage dopts iid = requestUnit DELETE $ DeleteImageEndpoint dopts iid
102+
93103-- | Creates a docker container but does __not__ start it. See
94104-- 'CreateOpts' for a list of options and you can use 'defaultCreateOpts'
95105-- for some sane defaults.
@@ -135,9 +145,9 @@ unpauseContainer :: forall m. (MonadIO m, MonadMask m) => ContainerID -> DockerT
135145unpauseContainer cid = requestUnit GET $ UnpauseContainerEndpoint cid
136146
137147-- | Deletes a container with the given 'ContainerID'.
138−-- See "DeleteOpts" for options and use 'defaultDeleteOpts' for sane
148+-- See "ContainerDeleteOpts" for options and use 'defaultContainerDeleteOpts' for sane
139149-- defaults.
140−deleteContainer :: forall m. (MonadIO m, MonadMask m) => DeleteOpts -> ContainerID -> DockerT m (Either DockerError ())
150+deleteContainer :: forall m. (MonadIO m, MonadMask m) => ContainerDeleteOpts -> ContainerID -> DockerT m (Either DockerError ())
141151deleteContainer dopts cid = requestUnit DELETE $ DeleteContainerEndpoint dopts cid
142152
143153-- | Gets 'ContainerDetails' for a given 'ContainerID'.
@@ -207,3 +217,11 @@ buildImageFromDockerfile opts base = do
207217pullImage :: forall m b . (MonadIO m, MonadMask m) => T.Text -> Tag -> Sink BS.ByteString m b -> DockerT m (Either DockerError b)
208218pullImage name tag = requestHelper' POST (CreateImageEndpoint name tag Nothing)
209219
220+-- | Creates network
221+createNetwork :: forall m. (MonadIO m, MonadMask m) => CreateNetworkOpts -> DockerT m (Either DockerError NetworkID)
222+createNetwork opts = requestHelper POST (CreateNetworkEndpoint opts) >>= parseResponse
223+
224+-- | Removes a network
225+removeNetwork :: forall m. (MonadIO m, MonadMask m) => NetworkID -> DockerT m (Either DockerError ())
226+removeNetwork nid = requestUnit DELETE $ RemoveNetworkEndpoint nid
227+
src/Docker/Client/Http.hs+40−7
@@ -5,6 +5,9 @@ module Docker.Client.Http where
55
66-- import Control.Monad.Base (MonadBase(..), liftBaseDefault)
77import Control.Monad.Catch (MonadMask (..))
8+#if MIN_VERSION_http_conduit(2,3,0)
9+import Control.Monad.IO.Unlift (MonadUnliftIO)
10+#endif
811import Control.Monad.Reader (ReaderT (..), runReaderT)
912import qualified Data.ByteString.Char8 as BSC
1013import qualified Data.ByteString.Lazy as BL
@@ -17,7 +20,7 @@ import Data.X509.CertificateStore (makeCertificateStore)
1720import Data.X509.File (readKeyFile, readSignedObject)
1821import Network.HTTP.Client (defaultManagerSettings,
1922 managerRawConnection, method,
20− newManager, parseUrl,
23+ newManager, parseRequest,
2124 requestBody, requestHeaders)
2225import qualified Network.HTTP.Client as HTTP
2326import Network.HTTP.Client.Internal (makeConnection)
@@ -94,7 +97,7 @@ runDockerT (opts, h) r = runReaderT (unDockerT r) (opts, h)
9497mkHttpRequest :: HttpVerb -> Endpoint -> DockerClientOpts -> Maybe Request
9598mkHttpRequest verb e opts = request
9699 where fullE = T.unpack (baseUrl opts) ++ T.unpack (getEndpoint (apiVer opts) e)
97− initialR = parseUrl fullE
100+ initialR = parseRequest fullE
98101 request' = case initialR of
99102 Just ir ->
100103 return $ ir {method = (encodeUtf8 . T.pack $ show verb),
@@ -104,18 +107,30 @@ mkHttpRequest verb e opts = request
104107 requestHeaders = [("Content-Type", "application/json; charset=utf-8")]}) $ getEndpointRequestBody e) <$> request'
105108 -- Note: Do we need to set length header?
106109
107−defaultHttpHandler :: (MonadIO m, MonadMask m) => m (HttpHandler m)
110+defaultHttpHandler :: (
111+#if MIN_VERSION_http_conduit(2,3,0)
112+ MonadUnliftIO m,
113+#endif
114+ MonadIO m, MonadMask m) => m (HttpHandler m)
108115defaultHttpHandler = do
109116 manager <- liftIO $ newManager defaultManagerSettings
110117 return $ httpHandler manager
111118
112−httpHandler :: (MonadIO m, MonadMask m) => HTTP.Manager -> HttpHandler m
119+httpHandler :: (
120+#if MIN_VERSION_http_conduit(2,3,0)
121+ MonadUnliftIO m,
122+#endif
123+ MonadIO m, MonadMask m) => HTTP.Manager -> HttpHandler m
113124httpHandler manager = HttpHandler $ \request' sink -> do -- runResourceT ..
114125 let request = NHS.setRequestManager manager request'
115126 try (NHS.httpSink request sink) >>= \res -> case res of
116127 Right res -> return res
128+#if MIN_VERSION_http_client(0,5,0)
129+ Left e@(HTTP.HttpExceptionRequest _ HTTP.ConnectionFailure{}) -> return $ Left $ DockerConnectionError e
130+#else
117131 Left e@HTTP.FailedConnectionException{} -> return $ Left $ DockerConnectionError e
118132 Left e@HTTP.FailedConnectionException2{} -> return $ Left $ DockerConnectionError e
133+#endif
119134 Left e -> return $ Left $ GenericDockerError (T.pack $ show e)
120135
121136-- | Connect to a unix domain socket (the default docker socket is
@@ -123,7 +138,11 @@ httpHandler manager = HttpHandler $ \request' sink -> do -- runResourceT ..
123138--
124139-- Docker seems to ignore the hostname in requests sent over unix domain
125140-- sockets (and the port obviously doesn't matter either)
126−unixHttpHandler :: (MonadIO m, MonadMask m) => FilePath -- ^ The socket to connect to
141+unixHttpHandler :: (
142+#if MIN_VERSION_http_conduit(2,3,0)
143+ MonadUnliftIO m,
144+#endif
145+ MonadIO m, MonadMask m) => FilePath -- ^ The socket to connect to
127146 -> m (HttpHandler m)
128147unixHttpHandler fp = do
129148 let mSettings = defaultManagerSettings
@@ -137,7 +156,7 @@ unixHttpHandler fp = do
137156 S.connect s (S.SockAddrUnix filePath)
138157 makeConnection (SBS.recv s 8096)
139158 (SBS.sendAll s)
140− (S.sClose s)
159+ (S.close s)
141160
142161-- TODO:
143162-- Move this to http-client-tls or network?
@@ -254,4 +273,18 @@ statusCodeToError (CreateImageEndpoint _ _ _) st =
254273 Nothing
255274 else
256275 Just $ DockerInvalidStatusCode st
257−
276+statusCodeToError (DeleteImageEndpoint _ _) st =
277+ if st == status200 then
278+ Nothing
279+ else
280+ Just $ DockerInvalidStatusCode st
281+statusCodeToError (CreateNetworkEndpoint _) st =
282+ if st == status201 then
283+ Nothing
284+ else
285+ Just $ DockerInvalidStatusCode st
286+statusCodeToError (RemoveNetworkEndpoint _) st =
287+ if st == status204 then
288+ Nothing
289+ else
290+ Just $ DockerInvalidStatusCode st
src/Docker/Client/Internal.hs+11−3
@@ -5,12 +5,13 @@ import qualified Data.Aeson as JSON
55import Data.ByteString (ByteString)
66import qualified Data.ByteString.Char8 as BSC
77import qualified Data.Conduit.Binary as CB
8−import Data.Text as T
8+import qualified Data.Text as T
99import Data.Text.Encoding (decodeUtf8, encodeUtf8)
1010import qualified Network.HTTP.Client as HTTP
1111import Network.HTTP.Conduit (requestBodySourceChunked)
1212import Network.HTTP.Types (Query, encodePath,
1313 encodePathSegments)
14+import Prelude hiding (all)
1415
1516import Docker.Client.Types
1617
@@ -26,7 +27,7 @@ encodeQ = encodeUtf8 . T.pack
2627
2728getEndpoint :: ApiVersion -> Endpoint -> T.Text
2829getEndpoint v VersionEndpoint = encodeURL [v, "version"]
29−getEndpoint v (ListContainersEndpoint _) = encodeURL [v, "containers", "json"] -- Make use of lsOpts here
30+getEndpoint v (ListContainersEndpoint (ListOpts all)) = encodeURLWithQuery [v, "containers", "json"] [("all", Just (encodeQ $ show all))]
3031getEndpoint v (ListImagesEndpoint _) = encodeURL [v, "images", "json"] -- Make use of lsOpts here
3132getEndpoint v (CreateContainerEndpoint _ cn) = case cn of
3233 Just cn -> encodeURLWithQuery [v, "containers", "create"] [("name", Just (encodeQ $ T.unpack cn))]
@@ -56,7 +57,7 @@ getEndpoint v (UnpauseContainerEndpoint cid) = encodeURL [v, "containers", fromC
5657getEndpoint v (ContainerLogsEndpoint (LogOpts stdout stderr _ _ _) follow cid) =
5758 encodeURLWithQuery [v, "containers", fromContainerID cid, "logs"] query
5859 where query = [("stdout", Just (encodeQ $ show stdout)), ("stderr", Just (encodeQ $ show stderr)), ("follow", Just (encodeQ $ show follow))]
59−getEndpoint v (DeleteContainerEndpoint (DeleteOpts removeVolumes force) cid) =
60+getEndpoint v (DeleteContainerEndpoint (ContainerDeleteOpts removeVolumes force) cid) =
6061 encodeURLWithQuery [v, "containers", fromContainerID cid] query
6162 where query = [("v", Just (encodeQ $ show removeVolumes)), ("force", Just (encodeQ $ show force))]
6263getEndpoint v (InspectContainerEndpoint cid) =
@@ -74,6 +75,9 @@ getEndpoint v (CreateImageEndpoint name tag _) = encodeURLWithQuery [v, "images"
7475 where query = [("fromImage", Just n), ("tag", Just t)]
7576 n = encodeQ $ T.unpack name
7677 t = encodeQ $ T.unpack tag
78+getEndpoint v (DeleteImageEndpoint _ cid) = encodeURL [v, "images", fromImageID cid]
79+getEndpoint v (CreateNetworkEndpoint _) = encodeURL [v, "networks", "create"]
80+getEndpoint v (RemoveNetworkEndpoint nid) = encodeURL [v, "networks", fromNetworkID nid]
7781
7882getEndpointRequestBody :: Endpoint -> Maybe HTTP.RequestBody
7983getEndpointRequestBody VersionEndpoint = Nothing
@@ -93,6 +97,10 @@ getEndpointRequestBody (InspectContainerEndpoint _) = Nothing
9397
9498getEndpointRequestBody (BuildImageEndpoint _ fp) = Just $ requestBodySourceChunked $ CB.sourceFile fp
9599getEndpointRequestBody (CreateImageEndpoint _ _ _) = Nothing
100+getEndpointRequestBody (DeleteImageEndpoint _ _) = Nothing
101+
102+getEndpointRequestBody (CreateNetworkEndpoint opts) = Just $ HTTP.RequestBodyLBS (JSON.encode opts)
103+getEndpointRequestBody (RemoveNetworkEndpoint _) = Nothing
96104
97105getEndpointContentType :: Endpoint -> BSC.ByteString
98106getEndpointContentType (BuildImageEndpoint _ _) = BSC.pack "application/tar"
src/Docker/Client/Types.hs+170−45
@@ -11,6 +11,9 @@ module Docker.Client.Types (
1111 , ImageID
1212 , fromImageID
1313 , toImageID
14+ , NetworkID
15+ , fromNetworkID
16+ , toNetworkID
1417 , Timeout(..)
1518 , StatusCode(..)
1619 , Signal(..)
@@ -23,11 +26,12 @@ module Docker.Client.Types (
2326 , ContainerPortInfo(..)
2427 , Container(..)
2528 , ContainerState(..)
26− , Status(..)
29+ , State(..)
2730 , Digest
2831 , Label(..)
2932 , Tag
3033 , Image(..)
34+ , Entrypoint(..)
3135 , dropImagePrefix
3236 , CreateOpts(..)
3337 , BuildOpts(..)
@@ -36,12 +40,16 @@ module Docker.Client.Types (
3640 , DetachKeys(..)
3741 , StartOpts(..)
3842 , defaultStartOpts
39− , DeleteOpts(..)
40− , defaultDeleteOpts
43+ , ContainerDeleteOpts(..)
44+ , defaultContainerDeleteOpts
45+ , ImageDeleteOpts(..)
46+ , defaultImageDeleteOpts
4147 , Timestamp
4248 , TailLogOpt(..)
4349 , LogOpts(..)
4450 , defaultLogOpts
51+ , CreateNetworkOpts(..)
52+ , defaultCreateNetworkOpts
4553 , VolumePermission(..)
4654 , Bind(..)
4755 , Volume(..)
@@ -67,6 +75,8 @@ module Docker.Client.Types (
6775 , UTSMode(..)
6876 , HostConfig(..)
6977 , defaultHostConfig
78+ , NetworkingConfig(..)
79+ , EndpointConfig(..)
7080 , Ulimit(..)
7181 , ContainerResources(..)
7282 , defaultContainerResources
@@ -102,6 +112,7 @@ import Data.Scientific (floatingOrInteger)
102112import Data.Text (Text)
103113import qualified Data.Text as T
104114import Data.Time.Clock (UTCTime)
115+import qualified Data.Vector as V
105116import GHC.Generics (Generic)
106117import Prelude hiding (all, tail)
107118import Text.Read (readMaybe)
@@ -121,10 +132,13 @@ data Endpoint =
121132 | UnpauseContainerEndpoint ContainerID
122133 | ContainerLogsEndpoint LogOpts Bool ContainerID -- ^ Second argument (Bool) is whether to follow which is currently hardcoded to False.
123134 -- See note in 'Docker.Client.Api.getContainerLogs' for explanation why.
124− | DeleteContainerEndpoint DeleteOpts ContainerID
135+ | DeleteContainerEndpoint ContainerDeleteOpts ContainerID
125136 | InspectContainerEndpoint ContainerID
126137 | BuildImageEndpoint BuildOpts FilePath
127138 | CreateImageEndpoint T.Text Tag (Maybe T.Text) -- ^ Either pull an image from docker hub or imports an image from a tarball (or URL)
139+ | DeleteImageEndpoint ImageDeleteOpts ImageID
140+ | CreateNetworkEndpoint CreateNetworkOpts
141+ | RemoveNetworkEndpoint NetworkID
128142 deriving (Eq, Show)
129143
130144-- | We should newtype this
@@ -236,7 +250,7 @@ data ContainerDetails = ContainerDetails {
236250 , processLabel :: Text
237251 , resolveConfPath :: FilePath
238252 , restartCount :: Int
239− , state :: ContainerState
253+ , containerDetailsState :: ContainerState
240254 , mounts :: [Mount]
241255 }
242256 deriving (Eq, Show, Generic)
@@ -244,11 +258,11 @@ data ContainerDetails = ContainerDetails {
244258-- | Data type used for parsing the mount information from a container
245259-- list.
246260data Mount = Mount {
247− mountName :: Text
261+ mountName :: Maybe Text -- this is optional
248262 , mountSource :: FilePath
249263 , mountDestination :: FilePath
250− , mountDriver :: Text
251− , mountMode :: Maybe VolumePermission -- apparently this can be null
264+ , mountDriver :: Maybe Text
265+ -- , mountMode :: Maybe VolumePermission -- apparently this can be null
252266 , mountRW :: Bool
253267 , mountPropogation :: Text
254268 }
@@ -256,14 +270,14 @@ data Mount = Mount {
256270
257271instance FromJSON Mount where
258272 parseJSON (JSON.Object o) = do
259− name <- o .: "Name"
273+ name <- o .:? "Name"
260274 src <- o .: "Source"
261275 dest <- o .: "Destination"
262− driver <- o .: "Driver"
263− mode <- o .: "Mode"
276+ driver <- o .:? "Driver"
277+ -- mode <- o .: "Mode"
264278 rw <- o .: "RW"
265279 prop <- o .: "Propagation"
266− return $ Mount name src dest driver mode rw prop
280+ return $ Mount name src dest driver rw prop
267281 parseJSON _ = fail "Mount is not an object"
268282
269283-- | Data type used for parsing the container state from a list of
@@ -279,7 +293,7 @@ data ContainerState = ContainerState {
279293 , restarting :: Bool
280294 , running :: Bool
281295 , startedAt :: UTCTime
282− , status :: Status
296+ , state :: State
283297 }
284298 deriving (Eq, Show, Generic)
285299
@@ -509,7 +523,8 @@ data Container = Container
509523 , containerImageId :: ImageID
510524 , containerCommand :: Text
511525 , containerCreatedAt :: Int
512− , containerStatus :: Status
526+ , containerState :: State
527+ , containerStatus :: Maybe Text
513528 , containerPorts :: [ContainerPortInfo]
514529 , containerLabels :: [Label]
515530 , containerNetworks :: [Network]
@@ -517,13 +532,14 @@ data Container = Container
517532 } deriving (Show, Eq)
518533
519534instance FromJSON Container where
520− parseJSON (JSON.Object v) =
521− Container <$> (v .: "Id")
535+ parseJSON o@(JSON.Object v) =
536+ Container <$> parseJSON o
522537 <*> (v .: "Names")
523538 <*> (v .: "Image")
524− <*> (v .: "ImageID")
525− <*> (v .: "Command")
539+ <*> (v .: "ImageID") -- Doesn't exist anymore
540+ <*> (v .: "Command") -- Doesn't exist anymore
526541 <*> (v .: "Created")
542+ <*> (v .: "State")
527543 <*> (v .: "Status")
528544 <*> (v .: "Ports")
529545 <*> (v .: "Labels")
@@ -533,21 +549,20 @@ instance FromJSON Container where
533549 parseNetworks (JSON.Object v) =
534550 (v .: "Networks") >>= parseJSON
535551 parseNetworks _ = fail "Container NetworkSettings: Not a JSON object."
536−
537552 parseJSON _ = fail "Container: Not a JSON object."
538553
539−-- | Represents the status of the container life cycle.
540−data Status = Created | Restarting | Running | Paused | Exited | Dead
554+-- | Represents the state of the container life cycle.
555+data State = Created | Restarting | Running | Paused | Exited | Dead
541556 deriving (Eq, Show, Generic)
542557
543−instance FromJSON Status where
558+instance FromJSON State where
544559 parseJSON (JSON.String "running") = return Running
545560 parseJSON (JSON.String "created") = return Created -- Note: Guessing on the string values of these.
546561 parseJSON (JSON.String "restarting") = return Restarting
547562 parseJSON (JSON.String "paused") = return Paused
548563 parseJSON (JSON.String "exited") = return Exited
549564 parseJSON (JSON.String "dead") = return Dead
550− parseJSON _ = fail "Unknown Status"
565+ parseJSON s = fail $ "Unknown Status: " ++ show s
551566
552567-- | Alias for representing a RepoDigest. We could newtype this and add
553568-- some validation.
@@ -608,20 +623,46 @@ instance FromJSON Image where
608623 return $ DockerImage imageId imageCreated imageParentId imageRepoTags imageRepoDigests imageSize imageVirtualSize imageLabels
609624 parseJSON _ = fail "Failed to parse DockerImage."
610625
626+-- | Alias for Aliases.
627+type Alias = Text
628+
629+-- | EndpointsConfig is container configuration for a specific network
630+newtype EndpointConfig = EndpointConfig [Alias] deriving (Eq, Show)
631+
632+instance ToJSON EndpointConfig where
633+ toJSON (EndpointConfig aliases) = JSON.object
634+ [ "Aliases" .= aliases
635+ ]
636+
637+-- | Alias for endpoint name
638+type EndpointName = Text
639+
640+-- | Data type for the NetworkingConfig section of the container settings
641+newtype NetworkingConfig = NetworkingConfig
642+ { endpointsConfig :: HM.HashMap EndpointName EndpointConfig
643+ } deriving (Eq, Show)
644+
645+instance ToJSON NetworkingConfig where
646+ toJSON (NetworkingConfig endpointsConfig) = JSON.object
647+ [ "EndpointsConfig" .= endpointsConfig
648+ ]
611649
612650-- | Options used for creating a Container.
613651data CreateOpts = CreateOpts {
614− containerConfig :: ContainerConfig
615− , hostConfig :: HostConfig
652+ containerConfig :: ContainerConfig
653+ , hostConfig :: HostConfig
654+ , networkingConfig :: NetworkingConfig
616655 } deriving (Eq, Show)
617656
618657instance ToJSON CreateOpts where
619− toJSON (CreateOpts cc hc) = do
658+ toJSON (CreateOpts cc hc nc) = do
620659 let ccJSON = toJSON cc
621660 let hcJSON = toJSON hc
622661 case ccJSON of
623662 JSON.Object (o :: HM.HashMap T.Text JSON.Value) -> do
624− JSON.Object $ HM.insert "HostConfig" hcJSON o
663+ let o1 = HM.insert "HostConfig" hcJSON o
664+ let o2 = HM.insert "NetworkingConfig" (toJSON nc) o1
665+ JSON.Object o2
625666 _ -> error "ContainerConfig is not an object." -- This should never happen.
626667
627668-- | Container configuration used for creating a container with sensible
@@ -643,7 +684,7 @@ defaultContainerConfig imageName = ContainerConfig {
643684 , cmd=[]
644685 , volumes=[]
645686 , workingDir=Nothing
646− , entrypoint=Nothing
687+ , entrypoint=Entrypoint []
647688 , networkDisabled=Nothing
648689 , macAddress=Nothing
649690 , labels=[]
@@ -656,7 +697,7 @@ defaultHostConfig = HostConfig {
656697 binds=[]
657698 , containerIDFile=Nothing
658699 , logConfig=LogDriverConfig JsonFile []
659− , networkMode=Bridge
700+ , networkMode=NetworkBridge
660701 , portBindings=[]
661702 , restartPolicy=RestartOff
662703 , volumeDriver=Nothing
@@ -696,14 +737,18 @@ defaultContainerResources = ContainerResources {
696737 , memory=Nothing
697738 , memoryReservation=Nothing
698739 , memorySwap=Nothing
699− , oomKillDisable=False
740+ , oomKillDisable=Just False
700741 , ulimits=[]
701742 }
702743
703744-- | Default create options when creating a container. You only need to
704745-- specify an image name and the rest is all sensible defaults.
705746defaultCreateOpts :: T.Text -> CreateOpts
706−defaultCreateOpts imageName = CreateOpts { containerConfig = defaultContainerConfig imageName, hostConfig = defaultHostConfig }
747+defaultCreateOpts imageName = CreateOpts
748+ { containerConfig = defaultContainerConfig imageName
749+ , hostConfig = defaultHostConfig
750+ , networkingConfig = NetworkingConfig HM.empty
751+ }
707752
708753-- | Override the key sequence for detaching a container.
709754-- Format is a single character [a-Z] or ctrl-<value> where <value> is one of: a-z, @, ^, [, , or _.
@@ -717,7 +762,7 @@ defaultStartOpts :: StartOpts
717762defaultStartOpts = StartOpts { detachKeys = DefaultDetachKey }
718763
719764-- | Options for deleting a container.
720−data DeleteOpts = DeleteOpts {
765+data ContainerDeleteOpts = ContainerDeleteOpts {
721766 deleteVolumes :: Bool -- ^ Automatically cleanup volumes that the container created as well.
722767 , force :: Bool -- ^ If the container is still running force deletion anyway.
723768 } deriving (Eq, Show)
@@ -747,8 +792,15 @@ defaultBuildOpts nameTag = BuildOpts { buildImageName = nameTag
747792-- | Default options for deleting a container. Most of the time we DON'T
748793-- want to delete the container's volumes or force delete it if it's
749794-- running.
750−defaultDeleteOpts :: DeleteOpts
751−defaultDeleteOpts = DeleteOpts { deleteVolumes = False, force = False }
795+defaultContainerDeleteOpts :: ContainerDeleteOpts
796+defaultContainerDeleteOpts = ContainerDeleteOpts { deleteVolumes = False, force = False }
797+
798+-- | Image delete opts
799+data ImageDeleteOpts = ImageDeleteOpts deriving (Eq, Show)
800+
801+-- | Sane image deletion defaults
802+defaultImageDeleteOpts :: ImageDeleteOpts
803+defaultImageDeleteOpts = ImageDeleteOpts
752804
753805-- | Timestamp alias.
754806type Timestamp = Integer
@@ -776,6 +828,36 @@ defaultLogOpts = LogOpts { stdout = True
776828 , tail = All
777829 }
778830
831+-- | Options for creating a network
832+data CreateNetworkOpts = CreateNetworkOpts
833+ { createNetworkName :: Text -- ^ The network's name
834+ , createNetworkCheckDuplicate :: Bool -- ^ Check for networks with duplicate names.
835+ , createNetworkDriver :: Text -- ^ Name of the network driver plugin to use.
836+ , createNetworkInternal :: Bool -- ^ Restrict external access to the network.
837+ , createNetworkEnableIPv6 :: Bool -- ^ Enable IPv6 on the network.
838+ } deriving (Eq, Show)
839+
840+-- | Sensible defalut for create network options
841+defaultCreateNetworkOpts :: Text -> CreateNetworkOpts
842+defaultCreateNetworkOpts name =
843+ CreateNetworkOpts
844+ { createNetworkName = name
845+ , createNetworkCheckDuplicate = False
846+ , createNetworkDriver = "bridge"
847+ , createNetworkInternal = True
848+ , createNetworkEnableIPv6 = False
849+ }
850+
851+instance ToJSON CreateNetworkOpts where
852+ toJSON opts =
853+ object
854+ [ "Name" .= createNetworkName opts
855+ , "CheckDuplicate" .= createNetworkCheckDuplicate opts
856+ , "Driver" .= createNetworkDriver opts
857+ , "Internal" .= createNetworkInternal opts
858+ , "EnableIPv6" .= createNetworkEnableIPv6 opts
859+ ]
860+
779861-- TOOD: Add support for SELinux Volume labels (eg. "ro,z" or "ro/Z")
780862-- | Set permissions on volumes that you mount in the container.
781863data VolumePermission = ReadWrite | ReadOnly deriving (Eq, Show, Generic)
@@ -787,6 +869,8 @@ instance ToJSON VolumePermission where
787869instance FromJSON VolumePermission where
788870 parseJSON "rw" = return ReadWrite
789871 parseJSON "ro" = return ReadOnly
872+ parseJSON "RW" = return ReadWrite
873+ parseJSON "RO" = return ReadOnly
790874 parseJSON _ = fail "Failed to parse VolumePermission"
791875
792876-- | Used for marking a directory in the container as "exposed" hence
@@ -933,19 +1017,41 @@ instance FromJSON LogDriverConfig where
9331017 parseJSON _ = fail "LogDriverConfig is not an object"
9341018
9351019-- TODO: Add container:<name|id> mode
936−data NetworkMode = Bridge | Host | NetworkDisabled
1020+data NetworkMode = NetworkBridge | NetworkHost | NetworkDisabled | NetworkNamed Text
9371021 deriving (Eq, Show, Ord)
9381022
9391023instance FromJSON NetworkMode where
940− parseJSON (JSON.String "bridge") = return Bridge
941− parseJSON (JSON.String "host") = return Host -- Note: Guessing on these.
1024+ parseJSON (JSON.String "bridge") = return NetworkBridge
1025+ parseJSON (JSON.String "host") = return NetworkHost -- Note: Guessing on these.
9421026 parseJSON (JSON.String "none") = return NetworkDisabled
1027+ parseJSON (JSON.String n) = return $ NetworkNamed n
9431028 parseJSON _ = fail "Unknown NetworkMode"
9441029
9451030instance ToJSON NetworkMode where
946− toJSON Bridge = JSON.String "bridge"
947− toJSON Host = JSON.String "host"
948− toJSON NetworkDisabled = JSON.String "none"
1031+ toJSON NetworkBridge = JSON.String "bridge"
1032+ toJSON NetworkHost = JSON.String "host"
1033+ toJSON NetworkDisabled = JSON.String "none"
1034+ toJSON (NetworkNamed n) = JSON.String n
1035+
1036+newtype NetworkID = NetworkID Text
1037+ deriving (Eq, Show)
1038+
1039+-- | Used for extracting the id of the container from the newtype
1040+fromNetworkID :: NetworkID -> Text
1041+fromNetworkID (NetworkID t) = t
1042+
1043+-- | Used for parsing a Text value into a NetworkID.
1044+toNetworkID :: Text -> Maybe NetworkID
1045+toNetworkID t = Just $ NetworkID t
1046+
1047+instance FromJSON NetworkID where
1048+ parseJSON (JSON.Object o) = do
1049+ nid <- o .: "Id"
1050+ return $ NetworkID nid
1051+ parseJSON _ = fail "NetworkID is not an object."
1052+
1053+instance ToJSON NetworkID where
1054+ toJSON (NetworkID nid) = object ["Id" .= nid]
9491055
9501056data PortType = TCP | UDP deriving (Eq, Generic, Read, Ord)
9511057
@@ -1308,7 +1414,7 @@ data ContainerResources = ContainerResources {
13081414 , memoryReservation :: Maybe MemoryConstraint
13091415 , memorySwap :: Maybe MemoryConstraint
13101416 -- , memorySwappiness :: Integer -- 1.24: Missing from inspecting container details... Going to omit for now.
1311− , oomKillDisable :: Bool
1417+ , oomKillDisable :: Maybe Bool
13121418 -- , pidsLimit :: Integer -- 1.24: Missing from inspecting container details... Going to omit for now.
13131419 , ulimits :: [Ulimit]
13141420 -- TODO: Missing from 1.24
@@ -1346,7 +1452,7 @@ instance FromJSON EnvVar where
13461452 parseJSON _ = fail "EnvVar is not a string"
13471453
13481454instance ToJSON EnvVar where
1349− toJSON (EnvVar n v) = object [n .= v]
1455+ toJSON (EnvVar n v) = JSON.String $ n <> T.pack "=" <> v
13501456
13511457-- | ExposedPort represents a port (and it's type)
13521458-- that a container should expose to other containers or the host system.
@@ -1386,6 +1492,21 @@ instance {-# OVERLAPPING #-} ToJSON [ExposedPort] where
13861492 where key (ExposedPort p t) = show p <> slash <> show t
13871493 slash = T.unpack "/"
13881494
1495+data Entrypoint = Entrypoint [T.Text] deriving (Eq, Show, Generic)
1496+
1497+instance ToJSON Entrypoint where
1498+ toJSON (Entrypoint (e:es)) = toJSON (e:es)
1499+ toJSON (Entrypoint []) = JSON.Null
1500+
1501+instance FromJSON Entrypoint where
1502+ parseJSON (JSON.String e) = return $ Entrypoint [e]
1503+ parseJSON (JSON.Array ar) = do
1504+ arr <- mapM parseJSON (V.toList ar)
1505+ return $ Entrypoint arr
1506+ parseJSON JSON.Null = return $ Entrypoint []
1507+ parseJSON _ = fail "Failed to parse Entrypoint"
1508+
1509+
13891510data ContainerConfig = ContainerConfig {
13901511 hostname :: Maybe Text
13911512 , domainname :: Maybe Text
@@ -1404,7 +1525,7 @@ data ContainerConfig = ContainerConfig {
14041525 , image :: Text
14051526 , volumes :: [Volume]
14061527 , workingDir :: Maybe FilePath
1407− , entrypoint :: Maybe Text -- Can be null?
1528+ , entrypoint :: Entrypoint
14081529 , networkDisabled :: Maybe Bool -- Note: Should we expand the JSON instance and take away the Maybe? Null is False?
14091530 , macAddress :: Maybe Text
14101531 -- , onBuild :: Maybe Text -- For 1.24, only see this in the inspect response.
@@ -1412,6 +1533,7 @@ data ContainerConfig = ContainerConfig {
14121533 , stopSignal :: Signal
14131534 } deriving (Eq, Show, Generic)
14141535
1536+
14151537instance ToJSON ContainerConfig where
14161538 toJSON = genericToJSON defaultOptions {
14171539 fieldLabelModifier = (\(x:xs) -> toUpper x : xs)}
@@ -1433,7 +1555,7 @@ instance FromJSON ContainerConfig where
14331555 image <- o .: "Image"
14341556 volumes <- o .: "Volumes"
14351557 workingDir <- o .:? "WorkingDir"
1436− entrypoint <- o .:? "Entrypoint"
1558+ entrypoint <- o .: "Entrypoint"
14371559 networkDisabled <- o .:? "networkDisabled"
14381560 macAddress <- o .:? "MacAddress"
14391561 labels <- o .:? "Labels" .!= []
@@ -1442,7 +1564,11 @@ instance FromJSON ContainerConfig where
14421564 macAddress labels stopSignal
14431565 parseJSON _ = fail "NetworkSettings is not an object."
14441566
1567+#if MIN_VERSION_base(4,13,0)
1568+parseIntegerText :: (MonadFail m) => Text -> m Integer
1569+#else
14451570parseIntegerText :: (Monad m) => Text -> m Integer
1571+#endif
14461572parseIntegerText t = case readMaybe $ T.unpack t of
14471573 Nothing ->
14481574 fail "Could not parse Integer"
@@ -1464,4 +1590,3 @@ toJsonKeyVal vs getKey getVal = JSON.Object $ foldl f HM.empty vs
14641590-- | Helper function that return an empty dictionary "{}"
14651591emptyJsonObject :: JSON.Value
14661592emptyJsonObject = JSON.Object HM.empty
1467−
stack-7.10.yaml+5−5
@@ -1,20 +1,20 @@
11# For more information, see: https://github.com/commercialhaskell/stack/blob/release/doc/yaml_configuration.md
22
33# Specifies the GHC version and set of packages available (e.g., lts-3.5, nightly-2015-09-21, ghc-7.10.2)
4−resolver: lts-5.18
4+resolver: lts-6.30
55
66# Local packages, usually specified by relative directory name
77packages:
88- '.'
99
10−# Packages to be pulled from upstream that are not in the resolver (e.g., acme-missiles-0.3)
11−extra-deps: [directory-1.2.7.0]
12−
1310# Override default flag values for local packages and extra-deps
1411flags: {}
1512
1613# Extra package databases containing global packages
17−extra-package-dbs: []
14+extra-deps:
15+- directory-1.2.7.0
16+- unliftio-core-0.1.1.0
17+- process-1.6.5.1
1818
1919# Control whether we use the GHC we find on the path
2020# system-ghc: true
stack-8.0.2.yamlnew file+4
@@ -0,0 +1,4 @@
1+resolver: lts-9.4
2+packages:
3+- '.'
4+extra-deps: []
stack-8.0.yaml+2−1
@@ -1,4 +1,5 @@
11resolver: lts-7.12
22packages:
33- '.'
4−extra-deps: []
4+extra-deps:
5+- unliftio-core-0.1.1.0
stack-8.6.4.yamlnew file+4
@@ -0,0 +1,4 @@
1+resolver: lts-13.19
2+packages:
3+- '.'
4+extra-deps: []
stack-8.8.2.yamlnew file+5
@@ -0,0 +1,5 @@
1+resolver: lts-15.0
2+packages:
3+- '.'
4+extra-deps: []
5+
stack.yaml+1−1
@@ -1 +1 @@
1−stack-7.10.yaml
1+stack-8.6.4.yaml
tests/Dockerfile+1−1
@@ -1,4 +1,4 @@
11FROM debian:jessie
22
3−CMD ["/bin/bash", "-c", "echo 123"]
3+CMD ["/bin/bash", "-c", "echo $TEST"]
44
tests/tests.hs+231−80
@@ -2,6 +2,8 @@
22
33module Main where
44
5+import Data.Either (rights)
6+import Prelude hiding (all)
57import qualified Test.QuickCheck.Monadic as QCM
68import Test.Tasty
79import Test.Tasty.HUnit
@@ -9,135 +11,284 @@ import Test.Tasty.QuickCheck (testProperty)
911
1012import Control.Concurrent (threadDelay)
1113import Control.Lens ((^.), (^?))
14+import Control.Monad (forM_)
1215import Control.Monad.IO.Class
1316import Control.Monad.Trans.Class (lift)
1417import qualified Data.Aeson as JSON
15−import Data.Aeson.Lens (key, _Object, _String, _Value)
18+import Data.Aeson ((.=))
19+import Data.Aeson.Lens (key, _Array, _Null, _Object,
20+ _String, _Value)
1621import qualified Data.ByteString as B
1722import qualified Data.ByteString.Char8 as C
1823import qualified Data.ByteString.Lazy as BL
1924import qualified Data.HashMap.Strict as HM
2025import Data.Int (Int)
2126import qualified Data.Map as M
22−import Data.Maybe (fromJust, isJust)
27+import Data.Maybe (fromJust, isJust, isNothing, listToMaybe)
2328import Data.Monoid
2429import Data.Text (Text, unpack)
30+import qualified Data.Vector as V
2531import Network.Connection (TLSSettings (..))
2632import Network.HTTP.Client (newManager)
2733import Network.HTTP.Client.TLS
2834import Network.HTTP.Types.Status
35+import System.Directory (getCurrentDirectory)
36+import System.Environment (lookupEnv)
2937import System.Process (system)
3038
3139import Docker.Client
3240
3341-- opts = defaultClientOpts
34−
35−testImageName = "docker-hs-test"
42+testImageName = "docker-hs/test"
43+imageToDeleteFullName = "hello-world:latest"
3644
3745toStrict1 = B.concat . BL.toChunks
3846
39−runDocker f = do
40− -- let opts = defaultClientOpts {baseUrl = "https://127.0.0.1:2376/"}
41− -- params' <- clientParamsWithClientAuthentication "127.0.0.1" 2376 "~/.docker/test-client-key.pem" "~/.docker/test-client-cert.pem" >>= fromRight
42− -- params <- clientParamsSetCA params' "~/.docker/test-ca.pem"
43− -- let settings = mkManagerSettings (TLSSettings params) Nothing
44− -- mgr <- newManager settings
45− h <- defaultHttpHandler
46− runDockerT (defaultClientOpts, h) f
47+runDocker f
48+ -- let opts = defaultClientOpts {baseUrl = "https://127.0.0.1:2376/"}
49+ -- params' <- clientParamsWithClientAuthentication "127.0.0.1" 2376 "~/.docker/test-client-key.pem" "~/.docker/test-client-cert.pem" >>= fromRight
50+ -- params <- clientParamsSetCA params' "~/.docker/test-ca.pem"
51+ -- let settings = mkManagerSettings (TLSSettings params) Nothing
52+ -- mgr <- newManager settings
53+ = do
54+ h <- defaultHttpHandler
55+ runDockerT (defaultClientOpts, h) f
4756
4857testDockerVersion :: IO ()
49−testDockerVersion = runDocker $ do
50− v <- getDockerVersion
51− lift $ assert $ isRight v
58+testDockerVersion =
59+ runDocker $
60+ do v <- getDockerVersion
61+ lift $ assert $ isRight v
62+
63+testStopNonexisting :: IO ()
64+testStopNonexisting = runDocker $ do
65+ res <- stopContainer DefaultTimeout $ fromJust $ toContainerID "thisshouldnotexist"
66+ lift $ assert $ isLeft res
5267
5368testFindImage :: IO ()
54−testFindImage = runDocker $ do
69+testFindImage =
70+ runDocker $
71+ do images <- listImages defaultListOpts >>= fromRight
72+ let xs = filter (elem imageFullName . imageRepoTags) images
73+ lift $ assert $ length xs == 1
74+ where
75+ imageFullName = testImageName <> ":latest"
76+
77+testDeleteImage :: IO ()
78+testDeleteImage = runDocker $ do
79+ img <- fmap fromJust findTestImage
80+ result <- deleteImage defaultImageDeleteOpts (imageId img)
81+ lift $ assert $ isRight result
82+ maybeTestImageAfter <- findTestImage
83+ lift $ assert $ isNothing maybeTestImageAfter
84+ where
85+ findTestImage =
86+ do
5587 images <- listImages defaultListOpts >>= fromRight
56− let xs = filter ((== [imageFullName]) . imageRepoTags) images
57− lift $ assert $ length xs == 1
58− where imageFullName = testImageName <> ":latest"
88+ return $ listToMaybe
89+ $ filter (elem imageToDeleteFullName . imageRepoTags) images
90+
91+testListContainers :: IO ()
92+testListContainers =
93+ runDocker $
94+ do containerId <- createContainer (defaultCreateOpts (testImageName <> ":latest")) Nothing
95+ c <- fromRight containerId
96+ res <- listContainers $ ListOpts { all=True }
97+ deleteContainer (ContainerDeleteOpts True True) c
98+ lift $ assert $ isRight res
99+
100+testBuildFromDockerfile :: IO ()
101+testBuildFromDockerfile = do
102+ cur <- getCurrentDirectory
103+ let ctxDir = cur ++ "/tests"
104+ runDocker $ do
105+ r <- buildImageFromDockerfile (defaultBuildOpts "docker-hs/dockerfile-test") ctxDir
106+ lift $ assert $ isRight r
107+
59108
60109testRunAndReadLog :: IO ()
61−testRunAndReadLog = runDocker $ do
62− containerId <- createContainer (defaultCreateOpts (testImageName <> ":latest")) Nothing
63− c <- fromRight containerId
64− status1 <- startContainer defaultStartOpts c
65− _ <- inspectContainer c >>= fromRight
66− lift $ threadDelay 300000 -- give 300ms for the application to finish
67− lift $ assert $ isRightUnit status1
68− status2 <- killContainer SIGTERM c
69− logs <- getContainerLogs defaultLogOpts c >>= fromRight
70− lift $ assert $ isRightUnit status2
71− lift $ assert $ (C.pack "123") `C.isInfixOf` (toStrict1 logs)
72− status3 <- deleteContainer (DeleteOpts True True) c
73− lift $ assert $ isRightUnit status3
74−
75− where
76− isRightUnit (Right ()) = True
77− isRightUnit _ = False
110+testRunAndReadLog = testRunAndReadLogHelper $ NetworkingConfig HM.empty
111+
112+testRunAndReadLogWithNetworking :: IO ()
113+testRunAndReadLogWithNetworking = testRunAndReadLogHelper $ NetworkingConfig $ HM.fromList [("test-network", EndpointConfig ["cellar-door"])]
114+
115+testRunAndReadLogHelper :: NetworkingConfig -> IO ()
116+testRunAndReadLogHelper networkingConfig =
117+ runDocker $
118+ do let containerConfig = (defaultContainerConfig (testImageName <> ":latest")) {env = [EnvVar "TEST" "123"]}
119+ createdNetworks <- rights <$> mapM createNetworkWithName networkNames
120+ containerId <- createContainer (CreateOpts containerConfig defaultHostConfig networkingConfig) Nothing
121+ c <- fromRight containerId
122+ status1 <- startContainer defaultStartOpts c
123+ _ <- inspectContainer c >>= fromRight
124+ lift $ threadDelay 300000 -- give 300ms for the application to finish
125+ lift $ assertBool ("starting the container, unexpected status: " ++ show status1) $ isRightUnit status1
126+ logs <- getContainerLogs defaultLogOpts c >>= fromRight
127+ lift $ assert $ (C.pack "123") `C.isInfixOf` (toStrict1 logs)
128+ status3 <- deleteContainer (ContainerDeleteOpts True True) c
129+ lift $ assertBool ("deleting container, unexpected status: " ++ show status3) $ isRightUnit status3
130+ mapM_ removeNetwork createdNetworks
131+ where
132+ isRightUnit (Right ()) = True
133+ isRightUnit _ = False
134+ networkNames = HM.keys $ endpointsConfig networkingConfig
135+ createNetworkWithName name = createNetwork $
136+ (defaultCreateNetworkOpts name) { createNetworkCheckDuplicate = True }
137+
138+testCreateRemoveNetwork :: IO ()
139+testCreateRemoveNetwork = do
140+ runDocker $ do
141+ createStatus <- createNetwork $ defaultCreateNetworkOpts "test-network"
142+ lift $ assertBool ("creating a network, unexpected status: " ++ show createStatus) $ isRight createStatus
143+ nid <- fromRight createStatus
144+ removeStatus <- removeNetwork nid
145+ lift $ assertBool ("removing a network, unexpected status: " ++ show removeStatus) $ isRight removeStatus
78146
79147testLogDriverOptionsJson :: TestTree
80−testLogDriverOptionsJson = testGroup "Testing LogDriverOptions JSON" [ test1, test2, test3 ]
81− where
82− test1 = testCase "Driver option 1" $ assert $ JSON.toJSON sample ^. key key1 . _String == val1
83− test2 = testCase "Driver option 2" $ assert $ JSON.toJSON sample ^. key key2 . _String == val2
84− test3 = testCase "Test override" $ assert $ JSON.toJSON sample2 ^. key key1 . _String == "override"
85− sample = [LogDriverOption key1 val1, LogDriverOption key2 val2]
86− sample2 = [LogDriverOption key1 val1, LogDriverOption key1 "override"]
87− key1 = "some-key"
88− val1 = "some-val"
89− key2 = "some-key2"
90− val2 = "some-key2"
148+testLogDriverOptionsJson = testGroup "Testing LogDriverOptions JSON" [test1, test2, test3]
149+ where
150+ test1 = testCase "Driver option 1" $ assert $ JSON.toJSON sample ^. key key1 . _String == val1
151+ test2 = testCase "Driver option 2" $ assert $ JSON.toJSON sample ^. key key2 . _String == val2
152+ test3 =
153+ testCase "Test override" $ assert $ JSON.toJSON sample2 ^. key key1 . _String == "override"
154+ sample = [LogDriverOption key1 val1, LogDriverOption key2 val2]
155+ sample2 = [LogDriverOption key1 val1, LogDriverOption key1 "override"]
156+ key1 = "some-key"
157+ val1 = "some-val"
158+ key2 = "some-key2"
159+ val2 = "some-key2"
91160
92161testExposedPortsJson :: TestTree
93−testExposedPortsJson = testGroup "Testing ExposedPorts JSON" [ testTCP, testUDP ]
94− where
95− testTCP = testCase "tcp port" $ assert $ JSON.toJSON sampleEP ^. key "80/tcp" . _Object == HM.empty
96− testUDP = testCase "udp port" $ assert $ JSON.toJSON sampleEP ^. key "1337/tcp" . _Object == HM.empty
97− sampleEP = [ExposedPort 80 TCP, ExposedPort 1337 UDP]
162+testExposedPortsJson = testGroup "Testing ExposedPorts JSON" [testTCP, testUDP]
163+ where
164+ testTCP = testCase "tcp port" $ assert $ JSON.toJSON sampleEP ^. key "80/tcp" . _Object == HM.empty
165+ testUDP =
166+ testCase "udp port" $ assert $ JSON.toJSON sampleEP ^. key "1337/tcp" . _Object == HM.empty
167+ sampleEP = [ExposedPort 80 TCP, ExposedPort 1337 UDP]
98168
99169testLabelsJson :: TestTree
100−testLabelsJson = testGroup "Testing Labels JSON" [ testLS1, testLS2, testOverride ]
101− where
102− testLS1 = testCase "test label key1" $ assert $ JSON.toJSON sampleLS ^. key key1 . _String == val1
103− testLS2 = testCase "test label key2" $ assert $ JSON.toJSON sampleLS ^. key key2 . _String == val2
104− testOverride = testCase "test label override" $ assert $ JSON.toJSON [Label key1 val1, Label key1 "override"] ^. key key1 . _String == "override"
105− sampleLS = [Label key1 val1, Label key2 val2]
106− key1 = "com.example.some-label"
107− val1 = "some-value"
108− key2 = "something"
109− val2 = "value"
170+testLabelsJson = testGroup "Testing Labels JSON" [testLS1, testLS2, testOverride]
171+ where
172+ testLS1 = testCase "test label key1" $ assert $ JSON.toJSON sampleLS ^. key key1 . _String == val1
173+ testLS2 = testCase "test label key2" $ assert $ JSON.toJSON sampleLS ^. key key2 . _String == val2
174+ testOverride =
175+ testCase "test label override" $ assert $ JSON.toJSON [Label key1 val1, Label key1 "override"] ^.
176+ key key1 .
177+ _String ==
178+ "override"
179+ sampleLS = [Label key1 val1, Label key2 val2]
180+ key1 = "com.example.some-label"
181+ val1 = "some-value"
182+ key2 = "something"
183+ val2 = "value"
110184
111185testVolumesJson :: TestTree
112−testVolumesJson = testGroup "Testing Volumes JSON" [ testSample1, testSample2 ]
113− where
114− testSample1 = testCase "Test exposing volume: /tmp" $ assert $ JSON.toJSON sampleVolumes ^. key "/tmp" . _Object == HM.empty
115− testSample2 = testCase "Test exposing volume: /opt" $ assert $ JSON.toJSON sampleVolumes ^. key "/opt" . _Object == HM.empty
116− sampleVolumes = [Volume "/tmp", Volume "/opt"]
186+testVolumesJson = testGroup "Testing Volumes JSON" [testSample1, testSample2]
187+ where
188+ testSample1 =
189+ testCase "Test exposing volume: /tmp" $ assert $ JSON.toJSON sampleVolumes ^. key "/tmp" . _Object ==
190+ HM.empty
191+ testSample2 =
192+ testCase "Test exposing volume: /opt" $ assert $ JSON.toJSON sampleVolumes ^. key "/opt" . _Object ==
193+ HM.empty
194+ sampleVolumes = [Volume "/tmp", Volume "/opt"]
195+
196+testEntrypointJson :: TestTree
197+testEntrypointJson = testGroup "Testing ContainerConfig JSON" [testSample1, testSample2, testSample3, testSample4, testSample5]
198+ where
199+ testSample1 =
200+ testCase "Test toJSON with empty entrypoint (null)" $ assert $ JSON.toJSON (Entrypoint []) ^. _Null == ()
201+ testSample2 =
202+ testCase "Test toJSON with entrypoint as Array" $ assert $
203+ JSON.toJSON (Entrypoint sampleEntrypointArr) ==
204+ JSON.toJSON sampleEntrypointArr
205+ testSample3 =
206+ testCase "Test decoding entrypoint as string" $ assert $ (JSON.decode "\"cmd\"") ==
207+ Just (Entrypoint ["cmd"])
208+ testSample4 =
209+ testCase "Test decoding as null" $ assert $ (JSON.decode "null" :: Maybe Entrypoint) ==
210+ Just (Entrypoint [])
211+ testSample5 =
212+ testCase "Test decoding as array" $ assert $ (JSON.decode (JSON.encode sampleEntrypointArr) :: Maybe Entrypoint) ==
213+ Just (Entrypoint sampleEntrypointArr)
214+ sampleEntrypointArr = ["cmd", "--some-flag", "--some-flag2"]
215+
216+testEnvVarJson :: TestTree
217+testEnvVarJson = testGroup "Testing EnvVar JSON" [testSampleEncode, testSampleDecode]
218+ where
219+ testSampleEncode =
220+ testCase "Test toJSON" $ assert $ JSON.toJSON (EnvVar "cellar" "door") == JSON.String "cellar=door"
221+ testSampleDecode =
222+ testCase "Test fromJSON" $ assert $ (JSON.decode "\"cellar=door\"" :: Maybe EnvVar) ==
223+ Just (EnvVar "cellar" "door")
224+
225+testNetworkingConfigJson :: TestTree
226+testNetworkingConfigJson = testGroup "Testing NetworkingConfig JSON" [testSampleEncode]
227+ where
228+ testSampleEncode =
229+ let networkingConfig = NetworkingConfig $ HM.fromList [("custom-network", EndpointConfig ["cellar", "door"])]
230+ in testCase "Test toJSON" $ assert $ JSON.toJSON networkingConfig ==
231+ JSON.object
232+ [ "EndpointsConfig" .= JSON.object
233+ [ "custom-network" .= JSON.object
234+ [ "Aliases" .= (["cellar", "door"] :: [Text])
235+ ]
236+ ]
237+ ]
117238
118239integrationTests :: TestTree
119−integrationTests = testGroup "Integration Tests" [
120− testCase "Get docker version" testDockerVersion,
121− testCase "Find image by name" testFindImage,
122− testCase "Run a dummy container and read its log" testRunAndReadLog]
240+integrationTests =
241+ testGroup
242+ "Integration Tests"
243+ [ testCase "Get docker version" testDockerVersion
244+ , testCase "Build image from Dockerfile" testBuildFromDockerfile
245+ , testCase "Find image by name" testFindImage
246+ , testCase "Delete image" testDeleteImage
247+ , testCase "List containers" testListContainers
248+ , testCase "Run a dummy container and read its log" testRunAndReadLog
249+ , testCase "Run a dummy container with networking and read its log" testRunAndReadLogWithNetworking
250+ , testCase "Try to stop a container that doesn't exist" testStopNonexisting
251+ , testCase "Create and remove a network" testCreateRemoveNetwork
252+ ]
123253
124254jsonTests :: TestTree
125−jsonTests = testGroup "JSON Tests" [testExposedPortsJson, testVolumesJson, testLabelsJson, testLogDriverOptionsJson]
255+jsonTests =
256+ testGroup
257+ "JSON Tests"
258+ [ testExposedPortsJson
259+ , testVolumesJson
260+ , testLabelsJson
261+ , testLogDriverOptionsJson
262+ , testEntrypointJson
263+ , testEnvVarJson
264+ , testNetworkingConfigJson
265+ ]
126266
127267setup :: IO ()
128−setup = system ("docker build -t "++unpack testImageName++" tests") >> return ()
268+setup =
269+ mapM_ system
270+ [ "docker pull " ++ unpack imageToDeleteFullName
271+ , "docker build -t " ++ unpack testImageName ++ " tests"
272+ ]
273+
274+isLeft = not . isRight
129275
130−isRight (Left _) = False
276+isRight (Left _) = False
131277isRight (Right _) = True
132278
133−fromRight :: (MonadIO m, Show l) => Either l r -> m r
279+fromRight
280+ :: (MonadIO m, Show l)
281+ => Either l r -> m r
134282fromRight (Left l) = do
135− liftIO $ assertFailure $ "Left: " ++ show l
136− undefined
283+ liftIO $ assertFailure $ "Left: " ++ show l
284+ undefined
137285fromRight (Right r) = return r
138286
139287main :: IO ()
140288main = do
141− setup
142− defaultMain $ testGroup "Tests" [jsonTests, integrationTests]
143−
289+ stackage <- lookupEnv "RUN_INTEGRATION_TESTS"
290+ case stackage of
291+ Nothing -> defaultMain $ testGroup "Tests" [jsonTests]
292+ Just _ -> do
293+ setup
294+ defaultMain $ testGroup "Tests" [jsonTests, integrationTests]