on master help sign in
15 files changed+394−69
since splitsnapshots
unifiedsplit
.travis.yml+25−4 CHANGELOG.md+44 Makefile+1−1 docker.cabal+19−8 src/Docker/Client/Api.hs+20−2 src/Docker/Client/Http.hs+33−4 src/Docker/Client/Internal.hs+11−3 src/Docker/Client/Types.hs+146−38 stack-7.10.yaml+4−1 stack-8.0.yaml+2−1 stack-8.6.4.yaml+4 stack-8.8.2.yaml+5 stack.yaml+1−1 tests/Dockerfile+1−1 tests/tests.hs+78−5
.travis.yml+25−4
@@ -22,9 +22,30 @@ services:
2222 - docker
2323
2424env:
25− - RUN_INTEGRATION_TESTS=1 GHCVER=7.10 STACK_ARGS=""
26− - RUN_INTEGRATION_TESTS=1 GHCVER=8.0 STACK_ARGS=""
27− - RUN_INTEGRATION_TESTS=1 GHCVER=8.0.2 STACK_ARGS=""
25+ global:
26+ - RUN_INTEGRATION_TESTS=1
27+ - STACK_ARGS=""
28+
29+ matrix:
30+ - DOCKER_VERSION="1.12.3-0~trusty" GHCVER=7.10
31+ - DOCKER_VERSION="1.13.1-0~ubuntu-trusty" GHCVER=7.10
32+ - DOCKER_VERSION="17.05.0~ce-0~ubuntu-trusty" GHCVER=7.10
33+
34+ - DOCKER_VERSION="1.12.3-0~trusty" GHCVER=8.0
35+ - DOCKER_VERSION="1.13.1-0~ubuntu-trusty" GHCVER=8.0
36+ - DOCKER_VERSION="17.05.0~ce-0~ubuntu-trusty" GHCVER=8.0
37+
38+ - DOCKER_VERSION="1.12.3-0~trusty" GHCVER=8.0.2
39+ - DOCKER_VERSION="1.13.1-0~ubuntu-trusty" GHCVER=8.0.2
40+ - DOCKER_VERSION="17.05.0~ce-0~ubuntu-trusty" GHCVER=8.0.2
41+
42+ - DOCKER_VERSION="1.12.3-0~trusty" GHCVER=8.6.4
43+ - DOCKER_VERSION="1.13.1-0~ubuntu-trusty" GHCVER=8.6.4
44+ - DOCKER_VERSION="17.05.0~ce-0~ubuntu-trusty" GHCVER=8.6.4
45+
46+ - DOCKER_VERSION="1.12.3-0~trusty" GHCVER=8.8.2
47+ - DOCKER_VERSION="1.13.1-0~ubuntu-trusty" GHCVER=8.8.2
48+ - DOCKER_VERSION="17.05.0~ce-0~ubuntu-trusty" GHCVER=8.8.2
2849
2950addons:
3051 apt:
@@ -36,7 +57,7 @@ before_install:
3657 - sudo sh -c 'echo "deb https://apt.dockerproject.org/repo ubuntu-trusty main" > /etc/apt/sources.list.d/docker.list'
3758 - sudo apt-key adv --keyserver hkp://p80.pool.sks-keyservers.net:80 --recv-keys 58118E89F3A912897C070ADBF76221572C52609D
3859 - sudo apt-get update
39− - sudo apt-get -qqy -o Dpkg::Options::="--force-confdef" -o Dpkg::Options::="--force-confold" install docker-engine=1.12.3-0~trusty
60+ - sudo apt-get -qqy -o Dpkg::Options::="--force-confdef" -o Dpkg::Options::="--force-confold" install docker-engine=$DOCKER_VERSION
4061
4162install:
4263 - mkdir -p "$HOME"/.local/bin
CHANGELOG.md+44
@@ -1,5 +1,49 @@
11# CHANGELOG
22
3+## 0.6.0.3 (2020-02-17)
4+
5+- Support for ghc 8.8.2.
6+- Bump dependency version.
7+- Use MonadFail for later versions.
8+
9+## 0.6.0.1 (2019-05-23)
10+
11+- Support ghc 8.6.4.
12+- Bump containers version.
13+
14+## 0.6.0.0 (2018-06-28)
15+
16+- Rename DeleteOpts to ContainerDeleteOpts.
17+- Implement image deletion.
18+- Bump aeson version.
19+- Implement network aliases.
20+- Implement creating/deleting networks.
21+
22+## 0.5.1.1 (2018-03-09)
23+
24+- Bump aeson version.
25+
26+## 0.5.1.0 (2018-02-23)
27+
28+- Support http-conduit-2.3.0.
29+- Bump http-types versions.
30+
31+## 0.5.0.1 (2018-01-26)
32+
33+- Bumps upper bound for http-types (properly this time).
34+
35+## 0.5.0.0 (2018-01-24)
36+
37+- Added (some) contribution and general docs
38+- Fix case when stopping non-existent container
39+- Added more integration tests
40+- Fixed error while parsing list container endpoint output
41+- Changed State/Status data type (related to the above fix)
42+- Added tests against different docker version to travis CIA
43+- Fixed EnvVar JSON encoding
44+- Fixed NetworkMode parsing
45+- Allow http-types 0.11
46+
347## 0.4.1.1 (2017-10-16)
448
549- Small change to add env var for skipping integration tests.
Makefile+1−1
@@ -18,7 +18,7 @@ repl:
1818
1919## Run tests. Example RUN_INTEGRATION_TESTS=1 make test
2020test:
21− @stack test
21+ @RUN_INTEGRATION_TESTS=1 stack test
2222
2323## Cut new release
2424release:
docker.cabal+19−8
@@ -1,5 +1,5 @@
11name: docker
2−version: 0.4.1.1
2+version: 0.6.0.3
33synopsis: An API client for docker written in Haskell
44description: See API documentation below.
55homepage: https://github.com/denibertovic/docker-hs
@@ -14,25 +14,29 @@ extra-source-files: README.md
1414cabal-version: >=1.10
1515stability: experimental
1616
17+-- Flag small-http-conduit
18+-- Description: Resolve whether http-conduit < 2.3.0.
19+-- Manual: False
20+-- Default: True
21+
1722library
1823 default-extensions: DeriveGeneric, OverloadedStrings, ScopedTypeVariables, ExplicitForAll, MultiParamTypeClasses, FlexibleContexts, GeneralizedNewtypeDeriving, RankNTypes, DeriveFunctor, FlexibleInstances, CPP
1924 hs-source-dirs: src
2025 exposed-modules: Docker.Client, Docker.Client.Api, Docker.Client.Types, Docker.Client.Internal, Docker.Client.Http, Docker.Client.Utils
2126 -- other-modules: Docker.Internal
2227 build-depends: base >= 4.7 && < 5
23− , aeson >= 0.9.0 && < 1.3.0
28+ , aeson >= 0.9.0 && < 2.0.0
2429 , blaze-builder >= 0.4.0 && < 0.5.0
2530 , bytestring >= 0.10.0 && < 0.11.0
26− , containers >= 0.5.0 && < 0.6.0
31+ , containers >= 0.5.0 && < 0.7.0
2732 , data-default-class >= 0.0.1 && < 0.2.0
28− , http-client >= 0.4.0 && < 0.6.0
29− , http-types >= 0.9 && < 0.10.0
33+ , http-client >= 0.4.0 && < 0.7.0
34+ , http-types >= 0.9 && < 0.13
3035 , vector
3136 , conduit
3237 , conduit-combinators
3338 , conduit-extra
3439 , exceptions
35− , http-conduit
3640 , monad-control
3741 , resourcet
3842 , transformers
@@ -47,13 +51,20 @@ library
4751 , mtl >= 2.0.0 && < 3.0.0
4852 , network >= 2.6.0
4953 , text >= 1.0.0 && < 2.0.0
50− , time >= 1.5.0 && < 1.9.0
54+ , time >= 1.5.0 && < 2.0.0
5155 , scientific >= 0.3.0 && < 0.4.0
52− , tls >= 1.3.7 && < 1.5.0
56+ , tls >= 1.3.7 && < 1.6.0
5357 , unordered-containers >= 0.2.0 && < 0.3.0
5458 , x509 >= 1.6.0 && < 1.8.0
5559 , x509-store >= 1.6.0 && < 1.8.0
5660 , x509-system >= 1.6.0 && < 1.8.0
61+ , http-conduit
62+ , unliftio-core >= 0.1.0.0 && < 0.2.0
63+ -- if flag(small-http-conduit)
64+ -- build-depends: http-conduit < 2.3.0
65+ -- else
66+ -- build-depends: http-conduit >= 2.3.0
67+ -- , unliftio-core
5768 default-language: Haskell2010
5869 ghc-options: -Wall -fno-warn-name-shadowing
5970
src/Docker/Client/Api.hs+20−2
@@ -18,8 +18,12 @@ module Docker.Client.Api (
1818 , getContainerLogsStream
1919 -- * Images
2020 , listImages
21+ , deleteImage
2122 , buildImageFromDockerfile
2223 , pullImage
24+ -- * Network
25+ , createNetwork
26+ , removeNetwork
2327 -- * Other
2428 , getDockerVersion
2529 ) where
@@ -90,6 +94,12 @@ listContainers opts = requestHelper GET (ListContainersEndpoint opts) >>= parseR
9094listImages :: forall m. (MonadIO m, MonadMask m) => ListOpts -> DockerT m (Either DockerError [Image])
9195listImages opts = requestHelper GET (ListImagesEndpoint opts) >>= parseResponse
9296
97+-- | Deletes an image with the given 'ImageID'.
98+-- See "ImageDeleteOpts" for options and use 'defaultImageDeleteOpts' for sane
99+-- defaults.
100+deleteImage :: forall m. (MonadIO m, MonadMask m) => ImageDeleteOpts -> ImageID -> DockerT m (Either DockerError ())
101+deleteImage dopts iid = requestUnit DELETE $ DeleteImageEndpoint dopts iid
102+
93103-- | Creates a docker container but does __not__ start it. See
94104-- 'CreateOpts' for a list of options and you can use 'defaultCreateOpts'
95105-- for some sane defaults.
@@ -135,9 +145,9 @@ unpauseContainer :: forall m. (MonadIO m, MonadMask m) => ContainerID -> DockerT
135145unpauseContainer cid = requestUnit GET $ UnpauseContainerEndpoint cid
136146
137147-- | Deletes a container with the given 'ContainerID'.
138−-- See "DeleteOpts" for options and use 'defaultDeleteOpts' for sane
148+-- See "ContainerDeleteOpts" for options and use 'defaultContainerDeleteOpts' for sane
139149-- defaults.
140−deleteContainer :: forall m. (MonadIO m, MonadMask m) => DeleteOpts -> ContainerID -> DockerT m (Either DockerError ())
150+deleteContainer :: forall m. (MonadIO m, MonadMask m) => ContainerDeleteOpts -> ContainerID -> DockerT m (Either DockerError ())
141151deleteContainer dopts cid = requestUnit DELETE $ DeleteContainerEndpoint dopts cid
142152
143153-- | Gets 'ContainerDetails' for a given 'ContainerID'.
@@ -207,3 +217,11 @@ buildImageFromDockerfile opts base = do
207217pullImage :: forall m b . (MonadIO m, MonadMask m) => T.Text -> Tag -> Sink BS.ByteString m b -> DockerT m (Either DockerError b)
208218pullImage name tag = requestHelper' POST (CreateImageEndpoint name tag Nothing)
209219
220+-- | Creates network
221+createNetwork :: forall m. (MonadIO m, MonadMask m) => CreateNetworkOpts -> DockerT m (Either DockerError NetworkID)
222+createNetwork opts = requestHelper POST (CreateNetworkEndpoint opts) >>= parseResponse
223+
224+-- | Removes a network
225+removeNetwork :: forall m. (MonadIO m, MonadMask m) => NetworkID -> DockerT m (Either DockerError ())
226+removeNetwork nid = requestUnit DELETE $ RemoveNetworkEndpoint nid
227+
src/Docker/Client/Http.hs+33−4
@@ -5,6 +5,9 @@ module Docker.Client.Http where
55
66-- import Control.Monad.Base (MonadBase(..), liftBaseDefault)
77import Control.Monad.Catch (MonadMask (..))
8+#if MIN_VERSION_http_conduit(2,3,0)
9+import Control.Monad.IO.Unlift (MonadUnliftIO)
10+#endif
811import Control.Monad.Reader (ReaderT (..), runReaderT)
912import qualified Data.ByteString.Char8 as BSC
1013import qualified Data.ByteString.Lazy as BL
@@ -104,12 +107,20 @@ mkHttpRequest verb e opts = request
104107 requestHeaders = [("Content-Type", "application/json; charset=utf-8")]}) $ getEndpointRequestBody e) <$> request'
105108 -- Note: Do we need to set length header?
106109
107−defaultHttpHandler :: (MonadIO m, MonadMask m) => m (HttpHandler m)
110+defaultHttpHandler :: (
111+#if MIN_VERSION_http_conduit(2,3,0)
112+ MonadUnliftIO m,
113+#endif
114+ MonadIO m, MonadMask m) => m (HttpHandler m)
108115defaultHttpHandler = do
109116 manager <- liftIO $ newManager defaultManagerSettings
110117 return $ httpHandler manager
111118
112−httpHandler :: (MonadIO m, MonadMask m) => HTTP.Manager -> HttpHandler m
119+httpHandler :: (
120+#if MIN_VERSION_http_conduit(2,3,0)
121+ MonadUnliftIO m,
122+#endif
123+ MonadIO m, MonadMask m) => HTTP.Manager -> HttpHandler m
113124httpHandler manager = HttpHandler $ \request' sink -> do -- runResourceT ..
114125 let request = NHS.setRequestManager manager request'
115126 try (NHS.httpSink request sink) >>= \res -> case res of
@@ -127,7 +138,11 @@ httpHandler manager = HttpHandler $ \request' sink -> do -- runResourceT ..
127138--
128139-- Docker seems to ignore the hostname in requests sent over unix domain
129140-- sockets (and the port obviously doesn't matter either)
130−unixHttpHandler :: (MonadIO m, MonadMask m) => FilePath -- ^ The socket to connect to
141+unixHttpHandler :: (
142+#if MIN_VERSION_http_conduit(2,3,0)
143+ MonadUnliftIO m,
144+#endif
145+ MonadIO m, MonadMask m) => FilePath -- ^ The socket to connect to
131146 -> m (HttpHandler m)
132147unixHttpHandler fp = do
133148 let mSettings = defaultManagerSettings
@@ -258,4 +273,18 @@ statusCodeToError (CreateImageEndpoint _ _ _) st =
258273 Nothing
259274 else
260275 Just $ DockerInvalidStatusCode st
261−
276+statusCodeToError (DeleteImageEndpoint _ _) st =
277+ if st == status200 then
278+ Nothing
279+ else
280+ Just $ DockerInvalidStatusCode st
281+statusCodeToError (CreateNetworkEndpoint _) st =
282+ if st == status201 then
283+ Nothing
284+ else
285+ Just $ DockerInvalidStatusCode st
286+statusCodeToError (RemoveNetworkEndpoint _) st =
287+ if st == status204 then
288+ Nothing
289+ else
290+ Just $ DockerInvalidStatusCode st
src/Docker/Client/Internal.hs+11−3
@@ -5,12 +5,13 @@ import qualified Data.Aeson as JSON
55import Data.ByteString (ByteString)
66import qualified Data.ByteString.Char8 as BSC
77import qualified Data.Conduit.Binary as CB
8−import Data.Text as T
8+import qualified Data.Text as T
99import Data.Text.Encoding (decodeUtf8, encodeUtf8)
1010import qualified Network.HTTP.Client as HTTP
1111import Network.HTTP.Conduit (requestBodySourceChunked)
1212import Network.HTTP.Types (Query, encodePath,
1313 encodePathSegments)
14+import Prelude hiding (all)
1415
1516import Docker.Client.Types
1617
@@ -26,7 +27,7 @@ encodeQ = encodeUtf8 . T.pack
2627
2728getEndpoint :: ApiVersion -> Endpoint -> T.Text
2829getEndpoint v VersionEndpoint = encodeURL [v, "version"]
29−getEndpoint v (ListContainersEndpoint _) = encodeURL [v, "containers", "json"] -- Make use of lsOpts here
30+getEndpoint v (ListContainersEndpoint (ListOpts all)) = encodeURLWithQuery [v, "containers", "json"] [("all", Just (encodeQ $ show all))]
3031getEndpoint v (ListImagesEndpoint _) = encodeURL [v, "images", "json"] -- Make use of lsOpts here
3132getEndpoint v (CreateContainerEndpoint _ cn) = case cn of
3233 Just cn -> encodeURLWithQuery [v, "containers", "create"] [("name", Just (encodeQ $ T.unpack cn))]
@@ -56,7 +57,7 @@ getEndpoint v (UnpauseContainerEndpoint cid) = encodeURL [v, "containers", fromC
5657getEndpoint v (ContainerLogsEndpoint (LogOpts stdout stderr _ _ _) follow cid) =
5758 encodeURLWithQuery [v, "containers", fromContainerID cid, "logs"] query
5859 where query = [("stdout", Just (encodeQ $ show stdout)), ("stderr", Just (encodeQ $ show stderr)), ("follow", Just (encodeQ $ show follow))]
59−getEndpoint v (DeleteContainerEndpoint (DeleteOpts removeVolumes force) cid) =
60+getEndpoint v (DeleteContainerEndpoint (ContainerDeleteOpts removeVolumes force) cid) =
6061 encodeURLWithQuery [v, "containers", fromContainerID cid] query
6162 where query = [("v", Just (encodeQ $ show removeVolumes)), ("force", Just (encodeQ $ show force))]
6263getEndpoint v (InspectContainerEndpoint cid) =
@@ -74,6 +75,9 @@ getEndpoint v (CreateImageEndpoint name tag _) = encodeURLWithQuery [v, "images"
7475 where query = [("fromImage", Just n), ("tag", Just t)]
7576 n = encodeQ $ T.unpack name
7677 t = encodeQ $ T.unpack tag
78+getEndpoint v (DeleteImageEndpoint _ cid) = encodeURL [v, "images", fromImageID cid]
79+getEndpoint v (CreateNetworkEndpoint _) = encodeURL [v, "networks", "create"]
80+getEndpoint v (RemoveNetworkEndpoint nid) = encodeURL [v, "networks", fromNetworkID nid]
7781
7882getEndpointRequestBody :: Endpoint -> Maybe HTTP.RequestBody
7983getEndpointRequestBody VersionEndpoint = Nothing
@@ -93,6 +97,10 @@ getEndpointRequestBody (InspectContainerEndpoint _) = Nothing
9397
9498getEndpointRequestBody (BuildImageEndpoint _ fp) = Just $ requestBodySourceChunked $ CB.sourceFile fp
9599getEndpointRequestBody (CreateImageEndpoint _ _ _) = Nothing
100+getEndpointRequestBody (DeleteImageEndpoint _ _) = Nothing
101+
102+getEndpointRequestBody (CreateNetworkEndpoint opts) = Just $ HTTP.RequestBodyLBS (JSON.encode opts)
103+getEndpointRequestBody (RemoveNetworkEndpoint _) = Nothing
96104
97105getEndpointContentType :: Endpoint -> BSC.ByteString
98106getEndpointContentType (BuildImageEndpoint _ _) = BSC.pack "application/tar"
src/Docker/Client/Types.hs+146−38
@@ -11,6 +11,9 @@ module Docker.Client.Types (
1111 , ImageID
1212 , fromImageID
1313 , toImageID
14+ , NetworkID
15+ , fromNetworkID
16+ , toNetworkID
1417 , Timeout(..)
1518 , StatusCode(..)
1619 , Signal(..)
@@ -23,7 +26,7 @@ module Docker.Client.Types (
2326 , ContainerPortInfo(..)
2427 , Container(..)
2528 , ContainerState(..)
26− , Status(..)
29+ , State(..)
2730 , Digest
2831 , Label(..)
2932 , Tag
@@ -37,12 +40,16 @@ module Docker.Client.Types (
3740 , DetachKeys(..)
3841 , StartOpts(..)
3942 , defaultStartOpts
40− , DeleteOpts(..)
41− , defaultDeleteOpts
43+ , ContainerDeleteOpts(..)
44+ , defaultContainerDeleteOpts
45+ , ImageDeleteOpts(..)
46+ , defaultImageDeleteOpts
4247 , Timestamp
4348 , TailLogOpt(..)
4449 , LogOpts(..)
4550 , defaultLogOpts
51+ , CreateNetworkOpts(..)
52+ , defaultCreateNetworkOpts
4653 , VolumePermission(..)
4754 , Bind(..)
4855 , Volume(..)
@@ -68,6 +75,8 @@ module Docker.Client.Types (
6875 , UTSMode(..)
6976 , HostConfig(..)
7077 , defaultHostConfig
78+ , NetworkingConfig(..)
79+ , EndpointConfig(..)
7180 , Ulimit(..)
7281 , ContainerResources(..)
7382 , defaultContainerResources
@@ -123,10 +132,13 @@ data Endpoint =
123132 | UnpauseContainerEndpoint ContainerID
124133 | ContainerLogsEndpoint LogOpts Bool ContainerID -- ^ Second argument (Bool) is whether to follow which is currently hardcoded to False.
125134 -- See note in 'Docker.Client.Api.getContainerLogs' for explanation why.
126− | DeleteContainerEndpoint DeleteOpts ContainerID
135+ | DeleteContainerEndpoint ContainerDeleteOpts ContainerID
127136 | InspectContainerEndpoint ContainerID
128137 | BuildImageEndpoint BuildOpts FilePath
129138 | CreateImageEndpoint T.Text Tag (Maybe T.Text) -- ^ Either pull an image from docker hub or imports an image from a tarball (or URL)
139+ | DeleteImageEndpoint ImageDeleteOpts ImageID
140+ | CreateNetworkEndpoint CreateNetworkOpts
141+ | RemoveNetworkEndpoint NetworkID
130142 deriving (Eq, Show)
131143
132144-- | We should newtype this
@@ -238,7 +250,7 @@ data ContainerDetails = ContainerDetails {
238250 , processLabel :: Text
239251 , resolveConfPath :: FilePath
240252 , restartCount :: Int
241− , state :: ContainerState
253+ , containerDetailsState :: ContainerState
242254 , mounts :: [Mount]
243255 }
244256 deriving (Eq, Show, Generic)
@@ -246,11 +258,11 @@ data ContainerDetails = ContainerDetails {
246258-- | Data type used for parsing the mount information from a container
247259-- list.
248260data Mount = Mount {
249− mountName :: Text
261+ mountName :: Maybe Text -- this is optional
250262 , mountSource :: FilePath
251263 , mountDestination :: FilePath
252− , mountDriver :: Text
253− , mountMode :: Maybe VolumePermission -- apparently this can be null
264+ , mountDriver :: Maybe Text
265+ -- , mountMode :: Maybe VolumePermission -- apparently this can be null
254266 , mountRW :: Bool
255267 , mountPropogation :: Text
256268 }
@@ -258,14 +270,14 @@ data Mount = Mount {
258270
259271instance FromJSON Mount where
260272 parseJSON (JSON.Object o) = do
261− name <- o .: "Name"
273+ name <- o .:? "Name"
262274 src <- o .: "Source"
263275 dest <- o .: "Destination"
264− driver <- o .: "Driver"
265− mode <- o .: "Mode"
276+ driver <- o .:? "Driver"
277+ -- mode <- o .: "Mode"
266278 rw <- o .: "RW"
267279 prop <- o .: "Propagation"
268− return $ Mount name src dest driver mode rw prop
280+ return $ Mount name src dest driver rw prop
269281 parseJSON _ = fail "Mount is not an object"
270282
271283-- | Data type used for parsing the container state from a list of
@@ -281,7 +293,7 @@ data ContainerState = ContainerState {
281293 , restarting :: Bool
282294 , running :: Bool
283295 , startedAt :: UTCTime
284− , status :: Status
296+ , state :: State
285297 }
286298 deriving (Eq, Show, Generic)
287299
@@ -511,7 +523,8 @@ data Container = Container
511523 , containerImageId :: ImageID
512524 , containerCommand :: Text
513525 , containerCreatedAt :: Int
514− , containerStatus :: Status
526+ , containerState :: State
527+ , containerStatus :: Maybe Text
515528 , containerPorts :: [ContainerPortInfo]
516529 , containerLabels :: [Label]
517530 , containerNetworks :: [Network]
@@ -519,13 +532,14 @@ data Container = Container
519532 } deriving (Show, Eq)
520533
521534instance FromJSON Container where
522− parseJSON (JSON.Object v) =
523− Container <$> (v .: "Id")
535+ parseJSON o@(JSON.Object v) =
536+ Container <$> parseJSON o
524537 <*> (v .: "Names")
525538 <*> (v .: "Image")
526− <*> (v .: "ImageID")
527− <*> (v .: "Command")
539+ <*> (v .: "ImageID") -- Doesn't exist anymore
540+ <*> (v .: "Command") -- Doesn't exist anymore
528541 <*> (v .: "Created")
542+ <*> (v .: "State")
529543 <*> (v .: "Status")
530544 <*> (v .: "Ports")
531545 <*> (v .: "Labels")
@@ -535,21 +549,20 @@ instance FromJSON Container where
535549 parseNetworks (JSON.Object v) =
536550 (v .: "Networks") >>= parseJSON
537551 parseNetworks _ = fail "Container NetworkSettings: Not a JSON object."
538−
539552 parseJSON _ = fail "Container: Not a JSON object."
540553
541−-- | Represents the status of the container life cycle.
542−data Status = Created | Restarting | Running | Paused | Exited | Dead
554+-- | Represents the state of the container life cycle.
555+data State = Created | Restarting | Running | Paused | Exited | Dead
543556 deriving (Eq, Show, Generic)
544557
545−instance FromJSON Status where
558+instance FromJSON State where
546559 parseJSON (JSON.String "running") = return Running
547560 parseJSON (JSON.String "created") = return Created -- Note: Guessing on the string values of these.
548561 parseJSON (JSON.String "restarting") = return Restarting
549562 parseJSON (JSON.String "paused") = return Paused
550563 parseJSON (JSON.String "exited") = return Exited
551564 parseJSON (JSON.String "dead") = return Dead
552− parseJSON _ = fail "Unknown Status"
565+ parseJSON s = fail $ "Unknown Status: " ++ show s
553566
554567-- | Alias for representing a RepoDigest. We could newtype this and add
555568-- some validation.
@@ -610,20 +623,46 @@ instance FromJSON Image where
610623 return $ DockerImage imageId imageCreated imageParentId imageRepoTags imageRepoDigests imageSize imageVirtualSize imageLabels
611624 parseJSON _ = fail "Failed to parse DockerImage."
612625
626+-- | Alias for Aliases.
627+type Alias = Text
628+
629+-- | EndpointsConfig is container configuration for a specific network
630+newtype EndpointConfig = EndpointConfig [Alias] deriving (Eq, Show)
631+
632+instance ToJSON EndpointConfig where
633+ toJSON (EndpointConfig aliases) = JSON.object
634+ [ "Aliases" .= aliases
635+ ]
636+
637+-- | Alias for endpoint name
638+type EndpointName = Text
639+
640+-- | Data type for the NetworkingConfig section of the container settings
641+newtype NetworkingConfig = NetworkingConfig
642+ { endpointsConfig :: HM.HashMap EndpointName EndpointConfig
643+ } deriving (Eq, Show)
644+
645+instance ToJSON NetworkingConfig where
646+ toJSON (NetworkingConfig endpointsConfig) = JSON.object
647+ [ "EndpointsConfig" .= endpointsConfig
648+ ]
613649
614650-- | Options used for creating a Container.
615651data CreateOpts = CreateOpts {
616− containerConfig :: ContainerConfig
617− , hostConfig :: HostConfig
652+ containerConfig :: ContainerConfig
653+ , hostConfig :: HostConfig
654+ , networkingConfig :: NetworkingConfig
618655 } deriving (Eq, Show)
619656
620657instance ToJSON CreateOpts where
621− toJSON (CreateOpts cc hc) = do
658+ toJSON (CreateOpts cc hc nc) = do
622659 let ccJSON = toJSON cc
623660 let hcJSON = toJSON hc
624661 case ccJSON of
625662 JSON.Object (o :: HM.HashMap T.Text JSON.Value) -> do
626− JSON.Object $ HM.insert "HostConfig" hcJSON o
663+ let o1 = HM.insert "HostConfig" hcJSON o
664+ let o2 = HM.insert "NetworkingConfig" (toJSON nc) o1
665+ JSON.Object o2
627666 _ -> error "ContainerConfig is not an object." -- This should never happen.
628667
629668-- | Container configuration used for creating a container with sensible
@@ -658,7 +697,7 @@ defaultHostConfig = HostConfig {
658697 binds=[]
659698 , containerIDFile=Nothing
660699 , logConfig=LogDriverConfig JsonFile []
661− , networkMode=Bridge
700+ , networkMode=NetworkBridge
662701 , portBindings=[]
663702 , restartPolicy=RestartOff
664703 , volumeDriver=Nothing
@@ -705,7 +744,11 @@ defaultContainerResources = ContainerResources {
705744-- | Default create options when creating a container. You only need to
706745-- specify an image name and the rest is all sensible defaults.
707746defaultCreateOpts :: T.Text -> CreateOpts
708−defaultCreateOpts imageName = CreateOpts { containerConfig = defaultContainerConfig imageName, hostConfig = defaultHostConfig }
747+defaultCreateOpts imageName = CreateOpts
748+ { containerConfig = defaultContainerConfig imageName
749+ , hostConfig = defaultHostConfig
750+ , networkingConfig = NetworkingConfig HM.empty
751+ }
709752
710753-- | Override the key sequence for detaching a container.
711754-- Format is a single character [a-Z] or ctrl-<value> where <value> is one of: a-z, @, ^, [, , or _.
@@ -719,7 +762,7 @@ defaultStartOpts :: StartOpts
719762defaultStartOpts = StartOpts { detachKeys = DefaultDetachKey }
720763
721764-- | Options for deleting a container.
722−data DeleteOpts = DeleteOpts {
765+data ContainerDeleteOpts = ContainerDeleteOpts {
723766 deleteVolumes :: Bool -- ^ Automatically cleanup volumes that the container created as well.
724767 , force :: Bool -- ^ If the container is still running force deletion anyway.
725768 } deriving (Eq, Show)
@@ -749,8 +792,15 @@ defaultBuildOpts nameTag = BuildOpts { buildImageName = nameTag
749792-- | Default options for deleting a container. Most of the time we DON'T
750793-- want to delete the container's volumes or force delete it if it's
751794-- running.
752−defaultDeleteOpts :: DeleteOpts
753−defaultDeleteOpts = DeleteOpts { deleteVolumes = False, force = False }
795+defaultContainerDeleteOpts :: ContainerDeleteOpts
796+defaultContainerDeleteOpts = ContainerDeleteOpts { deleteVolumes = False, force = False }
797+
798+-- | Image delete opts
799+data ImageDeleteOpts = ImageDeleteOpts deriving (Eq, Show)
800+
801+-- | Sane image deletion defaults
802+defaultImageDeleteOpts :: ImageDeleteOpts
803+defaultImageDeleteOpts = ImageDeleteOpts
754804
755805-- | Timestamp alias.
756806type Timestamp = Integer
@@ -778,6 +828,36 @@ defaultLogOpts = LogOpts { stdout = True
778828 , tail = All
779829 }
780830
831+-- | Options for creating a network
832+data CreateNetworkOpts = CreateNetworkOpts
833+ { createNetworkName :: Text -- ^ The network's name
834+ , createNetworkCheckDuplicate :: Bool -- ^ Check for networks with duplicate names.
835+ , createNetworkDriver :: Text -- ^ Name of the network driver plugin to use.
836+ , createNetworkInternal :: Bool -- ^ Restrict external access to the network.
837+ , createNetworkEnableIPv6 :: Bool -- ^ Enable IPv6 on the network.
838+ } deriving (Eq, Show)
839+
840+-- | Sensible defalut for create network options
841+defaultCreateNetworkOpts :: Text -> CreateNetworkOpts
842+defaultCreateNetworkOpts name =
843+ CreateNetworkOpts
844+ { createNetworkName = name
845+ , createNetworkCheckDuplicate = False
846+ , createNetworkDriver = "bridge"
847+ , createNetworkInternal = True
848+ , createNetworkEnableIPv6 = False
849+ }
850+
851+instance ToJSON CreateNetworkOpts where
852+ toJSON opts =
853+ object
854+ [ "Name" .= createNetworkName opts
855+ , "CheckDuplicate" .= createNetworkCheckDuplicate opts
856+ , "Driver" .= createNetworkDriver opts
857+ , "Internal" .= createNetworkInternal opts
858+ , "EnableIPv6" .= createNetworkEnableIPv6 opts
859+ ]
860+
781861-- TOOD: Add support for SELinux Volume labels (eg. "ro,z" or "ro/Z")
782862-- | Set permissions on volumes that you mount in the container.
783863data VolumePermission = ReadWrite | ReadOnly deriving (Eq, Show, Generic)
@@ -789,6 +869,8 @@ instance ToJSON VolumePermission where
789869instance FromJSON VolumePermission where
790870 parseJSON "rw" = return ReadWrite
791871 parseJSON "ro" = return ReadOnly
872+ parseJSON "RW" = return ReadWrite
873+ parseJSON "RO" = return ReadOnly
792874 parseJSON _ = fail "Failed to parse VolumePermission"
793875
794876-- | Used for marking a directory in the container as "exposed" hence
@@ -935,19 +1017,41 @@ instance FromJSON LogDriverConfig where
9351017 parseJSON _ = fail "LogDriverConfig is not an object"
9361018
9371019-- TODO: Add container:<name|id> mode
938−data NetworkMode = Bridge | Host | NetworkDisabled
1020+data NetworkMode = NetworkBridge | NetworkHost | NetworkDisabled | NetworkNamed Text
9391021 deriving (Eq, Show, Ord)
9401022
9411023instance FromJSON NetworkMode where
942− parseJSON (JSON.String "bridge") = return Bridge
943− parseJSON (JSON.String "host") = return Host -- Note: Guessing on these.
1024+ parseJSON (JSON.String "bridge") = return NetworkBridge
1025+ parseJSON (JSON.String "host") = return NetworkHost -- Note: Guessing on these.
9441026 parseJSON (JSON.String "none") = return NetworkDisabled
1027+ parseJSON (JSON.String n) = return $ NetworkNamed n
9451028 parseJSON _ = fail "Unknown NetworkMode"
9461029
9471030instance ToJSON NetworkMode where
948− toJSON Bridge = JSON.String "bridge"
949− toJSON Host = JSON.String "host"
950− toJSON NetworkDisabled = JSON.String "none"
1031+ toJSON NetworkBridge = JSON.String "bridge"
1032+ toJSON NetworkHost = JSON.String "host"
1033+ toJSON NetworkDisabled = JSON.String "none"
1034+ toJSON (NetworkNamed n) = JSON.String n
1035+
1036+newtype NetworkID = NetworkID Text
1037+ deriving (Eq, Show)
1038+
1039+-- | Used for extracting the id of the container from the newtype
1040+fromNetworkID :: NetworkID -> Text
1041+fromNetworkID (NetworkID t) = t
1042+
1043+-- | Used for parsing a Text value into a NetworkID.
1044+toNetworkID :: Text -> Maybe NetworkID
1045+toNetworkID t = Just $ NetworkID t
1046+
1047+instance FromJSON NetworkID where
1048+ parseJSON (JSON.Object o) = do
1049+ nid <- o .: "Id"
1050+ return $ NetworkID nid
1051+ parseJSON _ = fail "NetworkID is not an object."
1052+
1053+instance ToJSON NetworkID where
1054+ toJSON (NetworkID nid) = object ["Id" .= nid]
9511055
9521056data PortType = TCP | UDP deriving (Eq, Generic, Read, Ord)
9531057
@@ -1460,7 +1564,11 @@ instance FromJSON ContainerConfig where
14601564 macAddress labels stopSignal
14611565 parseJSON _ = fail "NetworkSettings is not an object."
14621566
1567+#if MIN_VERSION_base(4,13,0)
1568+parseIntegerText :: (MonadFail m) => Text -> m Integer
1569+#else
14631570parseIntegerText :: (Monad m) => Text -> m Integer
1571+#endif
14641572parseIntegerText t = case readMaybe $ T.unpack t of
14651573 Nothing ->
14661574 fail "Could not parse Integer"
stack-7.10.yaml+4−1
@@ -11,7 +11,10 @@ packages:
1111flags: {}
1212
1313# Extra package databases containing global packages
14−extra-deps: [directory-1.2.7.0]
14+extra-deps:
15+- directory-1.2.7.0
16+- unliftio-core-0.1.1.0
17+- process-1.6.5.1
1518
1619# Control whether we use the GHC we find on the path
1720# system-ghc: true
stack-8.0.yaml+2−1
@@ -1,4 +1,5 @@
11resolver: lts-7.12
22packages:
33- '.'
4−extra-deps: []
4+extra-deps:
5+- unliftio-core-0.1.1.0
stack-8.6.4.yamlnew file+4
@@ -0,0 +1,4 @@
1+resolver: lts-13.19
2+packages:
3+- '.'
4+extra-deps: []
stack-8.8.2.yamlnew file+5
@@ -0,0 +1,5 @@
1+resolver: lts-15.0
2+packages:
3+- '.'
4+extra-deps: []
5+
stack.yaml+1−1
@@ -1 +1 @@
1−stack-7.10.yaml
1+stack-8.6.4.yaml
tests/Dockerfile+1−1
@@ -1,4 +1,4 @@
11FROM debian:jessie
22
3−CMD ["/bin/bash", "-c", "echo 123"]
3+CMD ["/bin/bash", "-c", "echo $TEST"]
44
tests/tests.hs+78−5
@@ -2,6 +2,8 @@
22
33module Main where
44
5+import Data.Either (rights)
6+import Prelude hiding (all)
57import qualified Test.QuickCheck.Monadic as QCM
68import Test.Tasty
79import Test.Tasty.HUnit
@@ -9,9 +11,11 @@ import Test.Tasty.QuickCheck (testProperty)
911
1012import Control.Concurrent (threadDelay)
1113import Control.Lens ((^.), (^?))
14+import Control.Monad (forM_)
1215import Control.Monad.IO.Class
1316import Control.Monad.Trans.Class (lift)
1417import qualified Data.Aeson as JSON
18+import Data.Aeson ((.=))
1519import Data.Aeson.Lens (key, _Array, _Null, _Object,
1620 _String, _Value)
1721import qualified Data.ByteString as B
@@ -20,7 +24,7 @@ import qualified Data.ByteString.Lazy as BL
2024import qualified Data.HashMap.Strict as HM
2125import Data.Int (Int)
2226import qualified Data.Map as M
23−import Data.Maybe (fromJust, isJust)
27+import Data.Maybe (fromJust, isJust, isNothing, listToMaybe)
2428import Data.Monoid
2529import Data.Text (Text, unpack)
2630import qualified Data.Vector as V
@@ -36,6 +40,7 @@ import Docker.Client
3640
3741-- opts = defaultClientOpts
3842testImageName = "docker-hs/test"
43+imageToDeleteFullName = "hello-world:latest"
3944
4045toStrict1 = B.concat . BL.toChunks
4146
@@ -69,6 +74,29 @@ testFindImage =
6974 where
7075 imageFullName = testImageName <> ":latest"
7176
77+testDeleteImage :: IO ()
78+testDeleteImage = runDocker $ do
79+ img <- fmap fromJust findTestImage
80+ result <- deleteImage defaultImageDeleteOpts (imageId img)
81+ lift $ assert $ isRight result
82+ maybeTestImageAfter <- findTestImage
83+ lift $ assert $ isNothing maybeTestImageAfter
84+ where
85+ findTestImage =
86+ do
87+ images <- listImages defaultListOpts >>= fromRight
88+ return $ listToMaybe
89+ $ filter (elem imageToDeleteFullName . imageRepoTags) images
90+
91+testListContainers :: IO ()
92+testListContainers =
93+ runDocker $
94+ do containerId <- createContainer (defaultCreateOpts (testImageName <> ":latest")) Nothing
95+ c <- fromRight containerId
96+ res <- listContainers $ ListOpts { all=True }
97+ deleteContainer (ContainerDeleteOpts True True) c
98+ lift $ assert $ isRight res
99+
72100testBuildFromDockerfile :: IO ()
73101testBuildFromDockerfile = do
74102 cur <- getCurrentDirectory
@@ -77,10 +105,19 @@ testBuildFromDockerfile = do
77105 r <- buildImageFromDockerfile (defaultBuildOpts "docker-hs/dockerfile-test") ctxDir
78106 lift $ assert $ isRight r
79107
108+
80109testRunAndReadLog :: IO ()
81−testRunAndReadLog =
110+testRunAndReadLog = testRunAndReadLogHelper $ NetworkingConfig HM.empty
111+
112+testRunAndReadLogWithNetworking :: IO ()
113+testRunAndReadLogWithNetworking = testRunAndReadLogHelper $ NetworkingConfig $ HM.fromList [("test-network", EndpointConfig ["cellar-door"])]
114+
115+testRunAndReadLogHelper :: NetworkingConfig -> IO ()
116+testRunAndReadLogHelper networkingConfig =
82117 runDocker $
83− do containerId <- createContainer (defaultCreateOpts (testImageName <> ":latest")) Nothing
118+ do let containerConfig = (defaultContainerConfig (testImageName <> ":latest")) {env = [EnvVar "TEST" "123"]}
119+ createdNetworks <- rights <$> mapM createNetworkWithName networkNames
120+ containerId <- createContainer (CreateOpts containerConfig defaultHostConfig networkingConfig) Nothing
84121 c <- fromRight containerId
85122 status1 <- startContainer defaultStartOpts c
86123 _ <- inspectContainer c >>= fromRight
@@ -88,11 +125,24 @@ testRunAndReadLog =
88125 lift $ assertBool ("starting the container, unexpected status: " ++ show status1) $ isRightUnit status1
89126 logs <- getContainerLogs defaultLogOpts c >>= fromRight
90127 lift $ assert $ (C.pack "123") `C.isInfixOf` (toStrict1 logs)
91− status3 <- deleteContainer (DeleteOpts True True) c
128+ status3 <- deleteContainer (ContainerDeleteOpts True True) c
92129 lift $ assertBool ("deleting container, unexpected status: " ++ show status3) $ isRightUnit status3
130+ mapM_ removeNetwork createdNetworks
93131 where
94132 isRightUnit (Right ()) = True
95133 isRightUnit _ = False
134+ networkNames = HM.keys $ endpointsConfig networkingConfig
135+ createNetworkWithName name = createNetwork $
136+ (defaultCreateNetworkOpts name) { createNetworkCheckDuplicate = True }
137+
138+testCreateRemoveNetwork :: IO ()
139+testCreateRemoveNetwork = do
140+ runDocker $ do
141+ createStatus <- createNetwork $ defaultCreateNetworkOpts "test-network"
142+ lift $ assertBool ("creating a network, unexpected status: " ++ show createStatus) $ isRight createStatus
143+ nid <- fromRight createStatus
144+ removeStatus <- removeNetwork nid
145+ lift $ assertBool ("removing a network, unexpected status: " ++ show removeStatus) $ isRight removeStatus
96146
97147testLogDriverOptionsJson :: TestTree
98148testLogDriverOptionsJson = testGroup "Testing LogDriverOptions JSON" [test1, test2, test3]
@@ -172,6 +222,20 @@ testEnvVarJson = testGroup "Testing EnvVar JSON" [testSampleEncode, testSampleDe
172222 testCase "Test fromJSON" $ assert $ (JSON.decode "\"cellar=door\"" :: Maybe EnvVar) ==
173223 Just (EnvVar "cellar" "door")
174224
225+testNetworkingConfigJson :: TestTree
226+testNetworkingConfigJson = testGroup "Testing NetworkingConfig JSON" [testSampleEncode]
227+ where
228+ testSampleEncode =
229+ let networkingConfig = NetworkingConfig $ HM.fromList [("custom-network", EndpointConfig ["cellar", "door"])]
230+ in testCase "Test toJSON" $ assert $ JSON.toJSON networkingConfig ==
231+ JSON.object
232+ [ "EndpointsConfig" .= JSON.object
233+ [ "custom-network" .= JSON.object
234+ [ "Aliases" .= (["cellar", "door"] :: [Text])
235+ ]
236+ ]
237+ ]
238+
175239integrationTests :: TestTree
176240integrationTests =
177241 testGroup
@@ -179,8 +243,12 @@ integrationTests =
179243 [ testCase "Get docker version" testDockerVersion
180244 , testCase "Build image from Dockerfile" testBuildFromDockerfile
181245 , testCase "Find image by name" testFindImage
246+ , testCase "Delete image" testDeleteImage
247+ , testCase "List containers" testListContainers
182248 , testCase "Run a dummy container and read its log" testRunAndReadLog
249+ , testCase "Run a dummy container with networking and read its log" testRunAndReadLogWithNetworking
183250 , testCase "Try to stop a container that doesn't exist" testStopNonexisting
251+ , testCase "Create and remove a network" testCreateRemoveNetwork
184252 ]
185253
186254jsonTests :: TestTree
@@ -193,10 +261,15 @@ jsonTests =
193261 , testLogDriverOptionsJson
194262 , testEntrypointJson
195263 , testEnvVarJson
264+ , testNetworkingConfigJson
196265 ]
197266
198267setup :: IO ()
199−setup = system ("docker build -t " ++ unpack testImageName ++ " tests") >> return ()
268+setup =
269+ mapM_ system
270+ [ "docker pull " ++ unpack imageToDeleteFullName
271+ , "docker build -t " ++ unpack testImageName ++ " tests"
272+ ]
200273
201274isLeft = not . isRight
202275