on accb336 help sign in
20 files changed+97−529
since splitsnapshots
unifiedsplit
.travis.yml+3−25 CHANGELOG.md+1−65 CONTRIBUTING.md+2−12 LICENSE+1−1 Makefile+2−21 README.md+9−26 docker.cabal+12−24 src/Docker/Client.hs+1−1 src/Docker/Client/Api.hs+3−21 src/Docker/Client/Http.hs+4−37 src/Docker/Client/Internal.hs+3−11 src/Docker/Client/Types.hs+39−147 stack-7.10.yaml+1−4 stack-8.0.2.yaml−4 stack-8.0.yaml+1−2 stack-8.6.4.yaml−4 stack-8.8.2.yaml−5 stack.yaml+1−1 tests/Dockerfile+1−1 tests/tests.hs+13−117
.travis.yml+3−25
@@ -22,30 +22,8 @@ services:
2222 - docker
2323
2424env:
25− global:
26− - RUN_INTEGRATION_TESTS=1
27− - STACK_ARGS=""
28−
29− matrix:
30− - DOCKER_VERSION="1.12.3-0~trusty" GHCVER=7.10
31− - DOCKER_VERSION="1.13.1-0~ubuntu-trusty" GHCVER=7.10
32− - DOCKER_VERSION="17.05.0~ce-0~ubuntu-trusty" GHCVER=7.10
33−
34− - DOCKER_VERSION="1.12.3-0~trusty" GHCVER=8.0
35− - DOCKER_VERSION="1.13.1-0~ubuntu-trusty" GHCVER=8.0
36− - DOCKER_VERSION="17.05.0~ce-0~ubuntu-trusty" GHCVER=8.0
37−
38− - DOCKER_VERSION="1.12.3-0~trusty" GHCVER=8.0.2
39− - DOCKER_VERSION="1.13.1-0~ubuntu-trusty" GHCVER=8.0.2
40− - DOCKER_VERSION="17.05.0~ce-0~ubuntu-trusty" GHCVER=8.0.2
41−
42− - DOCKER_VERSION="1.12.3-0~trusty" GHCVER=8.6.4
43− - DOCKER_VERSION="1.13.1-0~ubuntu-trusty" GHCVER=8.6.4
44− - DOCKER_VERSION="17.05.0~ce-0~ubuntu-trusty" GHCVER=8.6.4
45−
46− - DOCKER_VERSION="1.12.3-0~trusty" GHCVER=8.8.2
47− - DOCKER_VERSION="1.13.1-0~ubuntu-trusty" GHCVER=8.8.2
48− - DOCKER_VERSION="17.05.0~ce-0~ubuntu-trusty" GHCVER=8.8.2
25+ - GHCVER=7.10 STACK_ARGS=""
26+ - GHCVER=8.0 STACK_ARGS=""
4927
5028addons:
5129 apt:
@@ -57,7 +35,7 @@ before_install:
5735 - sudo sh -c 'echo "deb https://apt.dockerproject.org/repo ubuntu-trusty main" > /etc/apt/sources.list.d/docker.list'
5836 - sudo apt-key adv --keyserver hkp://p80.pool.sks-keyservers.net:80 --recv-keys 58118E89F3A912897C070ADBF76221572C52609D
5937 - sudo apt-get update
60− - sudo apt-get -qqy -o Dpkg::Options::="--force-confdef" -o Dpkg::Options::="--force-confold" install docker-engine=$DOCKER_VERSION
38+ - sudo apt-get -qqy -o Dpkg::Options::="--force-confdef" -o Dpkg::Options::="--force-confold" install docker-engine=1.12.3-0~trusty
6139
6240install:
6341 - mkdir -p "$HOME"/.local/bin
CHANGELOG.md+1−65
@@ -1,76 +1,12 @@
11# CHANGELOG
22
3−## 0.6.0.3 (2020-02-17)
4−
5−- Support for ghc 8.8.2.
6−- Bump dependency version.
7−- Use MonadFail for later versions.
8−
9−## 0.6.0.1 (2019-05-23)
10−
11−- Support ghc 8.6.4.
12−- Bump containers version.
13−
14−## 0.6.0.0 (2018-06-28)
15−
16−- Rename DeleteOpts to ContainerDeleteOpts.
17−- Implement image deletion.
18−- Bump aeson version.
19−- Implement network aliases.
20−- Implement creating/deleting networks.
21−
22−## 0.5.1.1 (2018-03-09)
23−
24−- Bump aeson version.
25−
26−## 0.5.1.0 (2018-02-23)
27−
28−- Support http-conduit-2.3.0.
29−- Bump http-types versions.
30−
31−## 0.5.0.1 (2018-01-26)
32−
33−- Bumps upper bound for http-types (properly this time).
34−
35−## 0.5.0.0 (2018-01-24)
36−
37−- Added (some) contribution and general docs
38−- Fix case when stopping non-existent container
39−- Added more integration tests
40−- Fixed error while parsing list container endpoint output
41−- Changed State/Status data type (related to the above fix)
42−- Added tests against different docker version to travis CIA
43−- Fixed EnvVar JSON encoding
44−- Fixed NetworkMode parsing
45−- Allow http-types 0.11
46−
47−## 0.4.1.1 (2017-10-16)
48−
49−- Small change to add env var for skipping integration tests.
50− This is mostly to avoid running those on stackage.
51−
52−## 0.4.1.0 (2017-10-04)
53−
54−- Relaxed aeson, tls and time upper bounds
55−
56−
57−## 0.4.0.2 (2017-09-19)
58−
59−- Support LTS 9.4
60−
61−## 0.4.0.1 (2017-06-29)
62−
63−- fixes omKillDisable parsing from json
64−- adds Entrypoint data type and tests edge cases
65−- more tests
66−- small comsmetic changes
67−
683## 0.4.0.0 (2017-03-20)
694
705- Adds streaming support via conduits (changes API a bit hence the major version release)
716- Added support for streaming log output
727- Added support for pulling images from the hub (and streaming the output)
738
9+
7410## 0.3.0.1 (2016-09-07)
7511
7612- Small cosmetic changes and marking OVERLAPPING instance
CONTRIBUTING.md+2−12
@@ -1,14 +1,4 @@
1−# Contributing
1+# TODO
22
3−If you wish to contribute please see [any issue on GitHub tagged with "help
4−wanted"](https://github.com/denibertovic/docker-hs/issues?q=is%3Aopen+is%3Aissue+label%3A%22help+wanted%22).
5−Before starting to work, consider commenting on the issue you want to resolve or
6−open a new issue to discuss design decisions and implementation details. This is
7−so that no development cycles go to waste on implementing a feature that might
8−not get merged either because of implementation details or other reasons.
3+Add basic guidelines here, things like style guide (using .configuration files from the repo) etc etc.
94
10−Make sure to submit your PR's against the `master` branch.
11−
12−## Project Setup
13−
14−See the `README.md` file on how to setup the project on your development machine.
LICENSE+1−1
@@ -1,4 +1,4 @@
1−Copyright (c) 2014, Deni Bertovic
1+Copyright (c) 2016, Deni Bertovic
22
33All rights reserved.
44
Makefile+2−21
@@ -1,6 +1,4 @@
1−.PHONY: build repl test release help
2−
3−.DEFAULT_GOAL = help
1+.PHONY: build repl test release
42
53PROJECT_NAME ?= $(shell grep "^name" docker.cabal | cut -d " " -f17)
64VERSION ?= $(shell grep "^version:" docker.cabal | cut -d " " -f14)
@@ -8,35 +6,18 @@ RESOLVER ?= $(shell grep "^resolver:" stack.yaml | cut -d " " -f2)
86GHC_VERSION ?= $(shell stack ghc -- --version | cut -d " " -f8)
97ARCH=$(shell uname -m)
108
11−## Run build
129build:
1310 @stack build
1411
15−## Run repl
1612repl:
1713 @stack repl
1814
19−## Run tests. Example RUN_INTEGRATION_TESTS=1 make test
2015test:
21− @RUN_INTEGRATION_TESTS=1 stack test
16+ @stack test
2217
23−## Cut new release
2418release:
2519 @stack build --haddock
2620 @stack sdist
2721 @echo "\n\nDone. Now run: \n\nstack upload <path_to_tarball>\n"
2822 @echo "\nAnd: \n\ngit tag ${VERSION} && git push --tags\n"
2923
30−## Show help screen.
31−help:
32− @echo "Please use \`make <target>' where <target> is one of\n\n"
33− @awk '/^[a-zA-Z\-\_0-9]+:/ { \
34− helpMessage = match(lastLine, /^## (.*)/); \
35− if (helpMessage) { \
36− helpCommand = substr($$1, 0, index($$1, ":")-1); \
37− helpMessage = substr(lastLine, RSTART + 3, RLENGTH); \
38− printf "%-30s %s\n", helpCommand, helpMessage; \
39− } \
40− } \
41− { lastLine = $$0 }' $(MAKEFILE_LIST)
42−
README.md+9−26
@@ -7,42 +7,25 @@
77
88## Current state
99
10−Supported Docker Engine Api version: `v1.24` and onwards.
10+**API is still not stable.**
11+
12+Supported Docker Engine Api version: `v1.24`
1113
1214Anything upward of that should work since Docker versions their API.
1315Older docker version and engine api versions are not supported at the moment.
1416
15−## Documentation
16−
17−The API-documentation is available at
18−[Hackage](https://hackage.haskell.org/package/docker). There are also some
19−usage-examples in the main library source file,
20−[`Client.hs`](https://hackage.haskell.org/package/docker/docs/Docker-Client.html).
21−
2217## Contributing
2318
24−Please see [CONTRIBUTING.md](CONTRIBUTING.md).
25−
26−### Project Setup
19+If you wish to contribute please see any issue tagged with "help wanted".
20+Make sure to submit your PR's against the `master` branch.
2721
28−For working on the library, you need the Haskell Tool Stack installed (see [the
29−Haskell Tool Stack
30−website](https://docs.haskellstack.org/en/stable/install_and_upgrade/)). You
31−also need `make` to use the `Makefile` included in the project. Run `make help`
32−to see the available commands (for building, running the tests and releasing).
22+Please consider filling an Issue first and discuss design decisions and implementation details before
23+writing any code. This is so that no development cycles go to waste on implementing a feature that
24+might not get merged either because of implementation details or other reasons.
3325
34−### Tests
35−
36−Tests are located in the `tests` directory and can be run with `make test`. This
37−only runs the unit tests.
38−
39−To run integration tests, you need Docker installed and listening on Port `2375`
40−of `localhost` (docker only listens to a Unix socket by default, see the [Docker
41−documentation](https://docs.docker.com/engine/reference/commandline/dockerd/#daemon-socket-option)
42−for details). Set the environment variable `RUN_INTEGRATION_TESTS`, i.e.
43−`RUN_INTEGRATION_TESTS=1 make test`.
4426
4527## IRC
4628
4729If you have any questions or suggestions you can find the maintainers in `#docker-haskell`
4830on freenode.
31+
docker.cabal+12−24
@@ -1,5 +1,5 @@
11name: docker
2−version: 0.6.0.3
2+version: 0.4.0.1
33synopsis: An API client for docker written in Haskell
44description: See API documentation below.
55homepage: https://github.com/denibertovic/docker-hs
@@ -14,29 +14,25 @@ extra-source-files: README.md
1414cabal-version: >=1.10
1515stability: experimental
1616
17−-- Flag small-http-conduit
18−-- Description: Resolve whether http-conduit < 2.3.0.
19−-- Manual: False
20−-- Default: True
21−
2217library
23− default-extensions: DeriveGeneric, OverloadedStrings, ScopedTypeVariables, ExplicitForAll, MultiParamTypeClasses, FlexibleContexts, GeneralizedNewtypeDeriving, RankNTypes, DeriveFunctor, FlexibleInstances, CPP
18+ default-extensions: DeriveGeneric, OverloadedStrings, ScopedTypeVariables, ExplicitForAll, MultiParamTypeClasses, FlexibleContexts, GeneralizedNewtypeDeriving, RankNTypes, DeriveFunctor, FlexibleInstances
2419 hs-source-dirs: src
2520 exposed-modules: Docker.Client, Docker.Client.Api, Docker.Client.Types, Docker.Client.Internal, Docker.Client.Http, Docker.Client.Utils
2621 -- other-modules: Docker.Internal
2722 build-depends: base >= 4.7 && < 5
28− , aeson >= 0.9.0 && < 2.0.0
23+ , aeson >= 0.9.0 && < 1.1.0
2924 , blaze-builder >= 0.4.0 && < 0.5.0
3025 , bytestring >= 0.10.0 && < 0.11.0
31− , containers >= 0.5.0 && < 0.7.0
26+ , containers >= 0.5.0 && < 0.6.0
3227 , data-default-class >= 0.0.1 && < 0.2.0
33− , http-client >= 0.4.0 && < 0.7.0
34− , http-types >= 0.9 && < 0.13
28+ , http-client >= 0.4.0 && < 0.5.0
29+ , http-types >= 0.9 && < 0.10.0
3530 , vector
3631 , conduit
3732 , conduit-combinators
3833 , conduit-extra
3934 , exceptions
35+ , http-conduit
4036 , monad-control
4137 , resourcet
4238 , transformers
@@ -51,20 +47,13 @@ library
5147 , mtl >= 2.0.0 && < 3.0.0
5248 , network >= 2.6.0
5349 , text >= 1.0.0 && < 2.0.0
54− , time >= 1.5.0 && < 2.0.0
50+ , time >= 1.5.0 && < 1.7.0
5551 , scientific >= 0.3.0 && < 0.4.0
56− , tls >= 1.3.7 && < 1.6.0
52+ , tls >= 1.3.7 && < 1.4.0
5753 , unordered-containers >= 0.2.0 && < 0.3.0
58− , x509 >= 1.6.0 && < 1.8.0
59− , x509-store >= 1.6.0 && < 1.8.0
60− , x509-system >= 1.6.0 && < 1.8.0
61− , http-conduit
62− , unliftio-core >= 0.1.0.0 && < 0.2.0
63− -- if flag(small-http-conduit)
64− -- build-depends: http-conduit < 2.3.0
65− -- else
66− -- build-depends: http-conduit >= 2.3.0
67− -- , unliftio-core
54+ , x509 >= 1.6.0 && < 1.7.0
55+ , x509-store >= 1.6.0 && < 1.7.0
56+ , x509-system >= 1.6.0 && < 1.7.0
6857 default-language: Haskell2010
6958 ghc-options: -Wall -fno-warn-name-shadowing
7059
@@ -73,7 +62,6 @@ test-suite docker-hs-tests
7362 , bytestring
7463 , connection
7564 , docker
76− , directory
7765 , aeson
7866 , containers
7967 , unordered-containers
src/Docker/Client.hs+1−1
@@ -3,7 +3,7 @@
33
44{-|
55Module : Docker.Client
6−Copyright : (c) Deni Bertovic, 2014
6+Copyright : (c) Deni Bertovic, 2016
77License : BSD3
88Maintainer : deni@denibertovic.com
99Stability : experimental
src/Docker/Client/Api.hs+3−21
@@ -18,12 +18,8 @@ module Docker.Client.Api (
1818 , getContainerLogsStream
1919 -- * Images
2020 , listImages
21− , deleteImage
2221 , buildImageFromDockerfile
2322 , pullImage
24− -- * Network
25− , createNetwork
26− , removeNetwork
2723 -- * Other
2824 , getDockerVersion
2925 ) where
@@ -47,7 +43,7 @@ import Docker.Client.Types
4743import Docker.Client.Utils
4844
4945requestUnit :: (MonadIO m, MonadMask m) => HttpVerb -> Endpoint -> DockerT m (Either DockerError ())
50−requestUnit verb endpoint = fmap (const ()) <$> requestHelper verb endpoint
46+requestUnit verb endpoint = const (Right ()) <$> requestHelper verb endpoint
5147
5248requestHelper :: (MonadIO m, MonadMask m) => HttpVerb -> Endpoint -> DockerT m (Either DockerError BSL.ByteString)
5349requestHelper verb endpoint = requestHelper' verb endpoint Conduit.sinkLbs
@@ -94,12 +90,6 @@ listContainers opts = requestHelper GET (ListContainersEndpoint opts) >>= parseR
9490listImages :: forall m. (MonadIO m, MonadMask m) => ListOpts -> DockerT m (Either DockerError [Image])
9591listImages opts = requestHelper GET (ListImagesEndpoint opts) >>= parseResponse
9692
97−-- | Deletes an image with the given 'ImageID'.
98−-- See "ImageDeleteOpts" for options and use 'defaultImageDeleteOpts' for sane
99−-- defaults.
100−deleteImage :: forall m. (MonadIO m, MonadMask m) => ImageDeleteOpts -> ImageID -> DockerT m (Either DockerError ())
101−deleteImage dopts iid = requestUnit DELETE $ DeleteImageEndpoint dopts iid
102−
10393-- | Creates a docker container but does __not__ start it. See
10494-- 'CreateOpts' for a list of options and you can use 'defaultCreateOpts'
10595-- for some sane defaults.
@@ -145,9 +135,9 @@ unpauseContainer :: forall m. (MonadIO m, MonadMask m) => ContainerID -> DockerT
145135unpauseContainer cid = requestUnit GET $ UnpauseContainerEndpoint cid
146136
147137-- | Deletes a container with the given 'ContainerID'.
148−-- See "ContainerDeleteOpts" for options and use 'defaultContainerDeleteOpts' for sane
138+-- See "DeleteOpts" for options and use 'defaultDeleteOpts' for sane
149139-- defaults.
150−deleteContainer :: forall m. (MonadIO m, MonadMask m) => ContainerDeleteOpts -> ContainerID -> DockerT m (Either DockerError ())
140+deleteContainer :: forall m. (MonadIO m, MonadMask m) => DeleteOpts -> ContainerID -> DockerT m (Either DockerError ())
151141deleteContainer dopts cid = requestUnit DELETE $ DeleteContainerEndpoint dopts cid
152142
153143-- | Gets 'ContainerDetails' for a given 'ContainerID'.
@@ -217,11 +207,3 @@ buildImageFromDockerfile opts base = do
217207pullImage :: forall m b . (MonadIO m, MonadMask m) => T.Text -> Tag -> Sink BS.ByteString m b -> DockerT m (Either DockerError b)
218208pullImage name tag = requestHelper' POST (CreateImageEndpoint name tag Nothing)
219209
220−-- | Creates network
221−createNetwork :: forall m. (MonadIO m, MonadMask m) => CreateNetworkOpts -> DockerT m (Either DockerError NetworkID)
222−createNetwork opts = requestHelper POST (CreateNetworkEndpoint opts) >>= parseResponse
223−
224−-- | Removes a network
225−removeNetwork :: forall m. (MonadIO m, MonadMask m) => NetworkID -> DockerT m (Either DockerError ())
226−removeNetwork nid = requestUnit DELETE $ RemoveNetworkEndpoint nid
227−
src/Docker/Client/Http.hs+4−37
@@ -5,9 +5,6 @@ module Docker.Client.Http where
55
66-- import Control.Monad.Base (MonadBase(..), liftBaseDefault)
77import Control.Monad.Catch (MonadMask (..))
8−#if MIN_VERSION_http_conduit(2,3,0)
9−import Control.Monad.IO.Unlift (MonadUnliftIO)
10−#endif
118import Control.Monad.Reader (ReaderT (..), runReaderT)
129import qualified Data.ByteString.Char8 as BSC
1310import qualified Data.ByteString.Lazy as BL
@@ -107,30 +104,18 @@ mkHttpRequest verb e opts = request
107104 requestHeaders = [("Content-Type", "application/json; charset=utf-8")]}) $ getEndpointRequestBody e) <$> request'
108105 -- Note: Do we need to set length header?
109106
110−defaultHttpHandler :: (
111−#if MIN_VERSION_http_conduit(2,3,0)
112− MonadUnliftIO m,
113−#endif
114− MonadIO m, MonadMask m) => m (HttpHandler m)
107+defaultHttpHandler :: (MonadIO m, MonadMask m) => m (HttpHandler m)
115108defaultHttpHandler = do
116109 manager <- liftIO $ newManager defaultManagerSettings
117110 return $ httpHandler manager
118111
119−httpHandler :: (
120−#if MIN_VERSION_http_conduit(2,3,0)
121− MonadUnliftIO m,
122−#endif
123− MonadIO m, MonadMask m) => HTTP.Manager -> HttpHandler m
112+httpHandler :: (MonadIO m, MonadMask m) => HTTP.Manager -> HttpHandler m
124113httpHandler manager = HttpHandler $ \request' sink -> do -- runResourceT ..
125114 let request = NHS.setRequestManager manager request'
126115 try (NHS.httpSink request sink) >>= \res -> case res of
127116 Right res -> return res
128−#if MIN_VERSION_http_client(0,5,0)
129− Left e@(HTTP.HttpExceptionRequest _ HTTP.ConnectionFailure{}) -> return $ Left $ DockerConnectionError e
130−#else
131117 Left e@HTTP.FailedConnectionException{} -> return $ Left $ DockerConnectionError e
132118 Left e@HTTP.FailedConnectionException2{} -> return $ Left $ DockerConnectionError e
133−#endif
134119 Left e -> return $ Left $ GenericDockerError (T.pack $ show e)
135120
136121-- | Connect to a unix domain socket (the default docker socket is
@@ -138,11 +123,7 @@ httpHandler manager = HttpHandler $ \request' sink -> do -- runResourceT ..
138123--
139124-- Docker seems to ignore the hostname in requests sent over unix domain
140125-- sockets (and the port obviously doesn't matter either)
141−unixHttpHandler :: (
142−#if MIN_VERSION_http_conduit(2,3,0)
143− MonadUnliftIO m,
144−#endif
145− MonadIO m, MonadMask m) => FilePath -- ^ The socket to connect to
126+unixHttpHandler :: (MonadIO m, MonadMask m) => FilePath -- ^ The socket to connect to
146127 -> m (HttpHandler m)
147128unixHttpHandler fp = do
148129 let mSettings = defaultManagerSettings
@@ -273,18 +254,4 @@ statusCodeToError (CreateImageEndpoint _ _ _) st =
273254 Nothing
274255 else
275256 Just $ DockerInvalidStatusCode st
276−statusCodeToError (DeleteImageEndpoint _ _) st =
277− if st == status200 then
278− Nothing
279− else
280− Just $ DockerInvalidStatusCode st
281−statusCodeToError (CreateNetworkEndpoint _) st =
282− if st == status201 then
283− Nothing
284− else
285− Just $ DockerInvalidStatusCode st
286−statusCodeToError (RemoveNetworkEndpoint _) st =
287− if st == status204 then
288− Nothing
289− else
290− Just $ DockerInvalidStatusCode st
257+
src/Docker/Client/Internal.hs+3−11
@@ -5,13 +5,12 @@ import qualified Data.Aeson as JSON
55import Data.ByteString (ByteString)
66import qualified Data.ByteString.Char8 as BSC
77import qualified Data.Conduit.Binary as CB
8−import qualified Data.Text as T
8+import Data.Text as T
99import Data.Text.Encoding (decodeUtf8, encodeUtf8)
1010import qualified Network.HTTP.Client as HTTP
1111import Network.HTTP.Conduit (requestBodySourceChunked)
1212import Network.HTTP.Types (Query, encodePath,
1313 encodePathSegments)
14−import Prelude hiding (all)
1514
1615import Docker.Client.Types
1716
@@ -27,7 +26,7 @@ encodeQ = encodeUtf8 . T.pack
2726
2827getEndpoint :: ApiVersion -> Endpoint -> T.Text
2928getEndpoint v VersionEndpoint = encodeURL [v, "version"]
30−getEndpoint v (ListContainersEndpoint (ListOpts all)) = encodeURLWithQuery [v, "containers", "json"] [("all", Just (encodeQ $ show all))]
29+getEndpoint v (ListContainersEndpoint _) = encodeURL [v, "containers", "json"] -- Make use of lsOpts here
3130getEndpoint v (ListImagesEndpoint _) = encodeURL [v, "images", "json"] -- Make use of lsOpts here
3231getEndpoint v (CreateContainerEndpoint _ cn) = case cn of
3332 Just cn -> encodeURLWithQuery [v, "containers", "create"] [("name", Just (encodeQ $ T.unpack cn))]
@@ -57,7 +56,7 @@ getEndpoint v (UnpauseContainerEndpoint cid) = encodeURL [v, "containers", fromC
5756getEndpoint v (ContainerLogsEndpoint (LogOpts stdout stderr _ _ _) follow cid) =
5857 encodeURLWithQuery [v, "containers", fromContainerID cid, "logs"] query
5958 where query = [("stdout", Just (encodeQ $ show stdout)), ("stderr", Just (encodeQ $ show stderr)), ("follow", Just (encodeQ $ show follow))]
60−getEndpoint v (DeleteContainerEndpoint (ContainerDeleteOpts removeVolumes force) cid) =
59+getEndpoint v (DeleteContainerEndpoint (DeleteOpts removeVolumes force) cid) =
6160 encodeURLWithQuery [v, "containers", fromContainerID cid] query
6261 where query = [("v", Just (encodeQ $ show removeVolumes)), ("force", Just (encodeQ $ show force))]
6362getEndpoint v (InspectContainerEndpoint cid) =
@@ -75,9 +74,6 @@ getEndpoint v (CreateImageEndpoint name tag _) = encodeURLWithQuery [v, "images"
7574 where query = [("fromImage", Just n), ("tag", Just t)]
7675 n = encodeQ $ T.unpack name
7776 t = encodeQ $ T.unpack tag
78−getEndpoint v (DeleteImageEndpoint _ cid) = encodeURL [v, "images", fromImageID cid]
79−getEndpoint v (CreateNetworkEndpoint _) = encodeURL [v, "networks", "create"]
80−getEndpoint v (RemoveNetworkEndpoint nid) = encodeURL [v, "networks", fromNetworkID nid]
8177
8278getEndpointRequestBody :: Endpoint -> Maybe HTTP.RequestBody
8379getEndpointRequestBody VersionEndpoint = Nothing
@@ -97,10 +93,6 @@ getEndpointRequestBody (InspectContainerEndpoint _) = Nothing
9793
9894getEndpointRequestBody (BuildImageEndpoint _ fp) = Just $ requestBodySourceChunked $ CB.sourceFile fp
9995getEndpointRequestBody (CreateImageEndpoint _ _ _) = Nothing
100−getEndpointRequestBody (DeleteImageEndpoint _ _) = Nothing
101−
102−getEndpointRequestBody (CreateNetworkEndpoint opts) = Just $ HTTP.RequestBodyLBS (JSON.encode opts)
103−getEndpointRequestBody (RemoveNetworkEndpoint _) = Nothing
10496
10597getEndpointContentType :: Endpoint -> BSC.ByteString
10698getEndpointContentType (BuildImageEndpoint _ _) = BSC.pack "application/tar"
src/Docker/Client/Types.hs+39−147
@@ -11,9 +11,6 @@ module Docker.Client.Types (
1111 , ImageID
1212 , fromImageID
1313 , toImageID
14− , NetworkID
15− , fromNetworkID
16− , toNetworkID
1714 , Timeout(..)
1815 , StatusCode(..)
1916 , Signal(..)
@@ -26,7 +23,7 @@ module Docker.Client.Types (
2623 , ContainerPortInfo(..)
2724 , Container(..)
2825 , ContainerState(..)
29− , State(..)
26+ , Status(..)
3027 , Digest
3128 , Label(..)
3229 , Tag
@@ -40,16 +37,12 @@ module Docker.Client.Types (
4037 , DetachKeys(..)
4138 , StartOpts(..)
4239 , defaultStartOpts
43− , ContainerDeleteOpts(..)
44− , defaultContainerDeleteOpts
45− , ImageDeleteOpts(..)
46− , defaultImageDeleteOpts
40+ , DeleteOpts(..)
41+ , defaultDeleteOpts
4742 , Timestamp
4843 , TailLogOpt(..)
4944 , LogOpts(..)
5045 , defaultLogOpts
51− , CreateNetworkOpts(..)
52− , defaultCreateNetworkOpts
5346 , VolumePermission(..)
5447 , Bind(..)
5548 , Volume(..)
@@ -75,8 +68,6 @@ module Docker.Client.Types (
7568 , UTSMode(..)
7669 , HostConfig(..)
7770 , defaultHostConfig
78− , NetworkingConfig(..)
79− , EndpointConfig(..)
8071 , Ulimit(..)
8172 , ContainerResources(..)
8273 , defaultContainerResources
@@ -132,13 +123,10 @@ data Endpoint =
132123 | UnpauseContainerEndpoint ContainerID
133124 | ContainerLogsEndpoint LogOpts Bool ContainerID -- ^ Second argument (Bool) is whether to follow which is currently hardcoded to False.
134125 -- See note in 'Docker.Client.Api.getContainerLogs' for explanation why.
135− | DeleteContainerEndpoint ContainerDeleteOpts ContainerID
126+ | DeleteContainerEndpoint DeleteOpts ContainerID
136127 | InspectContainerEndpoint ContainerID
137128 | BuildImageEndpoint BuildOpts FilePath
138129 | CreateImageEndpoint T.Text Tag (Maybe T.Text) -- ^ Either pull an image from docker hub or imports an image from a tarball (or URL)
139− | DeleteImageEndpoint ImageDeleteOpts ImageID
140− | CreateNetworkEndpoint CreateNetworkOpts
141− | RemoveNetworkEndpoint NetworkID
142130 deriving (Eq, Show)
143131
144132-- | We should newtype this
@@ -250,7 +238,7 @@ data ContainerDetails = ContainerDetails {
250238 , processLabel :: Text
251239 , resolveConfPath :: FilePath
252240 , restartCount :: Int
253− , containerDetailsState :: ContainerState
241+ , state :: ContainerState
254242 , mounts :: [Mount]
255243 }
256244 deriving (Eq, Show, Generic)
@@ -258,11 +246,11 @@ data ContainerDetails = ContainerDetails {
258246-- | Data type used for parsing the mount information from a container
259247-- list.
260248data Mount = Mount {
261− mountName :: Maybe Text -- this is optional
249+ mountName :: Text
262250 , mountSource :: FilePath
263251 , mountDestination :: FilePath
264− , mountDriver :: Maybe Text
265− -- , mountMode :: Maybe VolumePermission -- apparently this can be null
252+ , mountDriver :: Text
253+ , mountMode :: Maybe VolumePermission -- apparently this can be null
266254 , mountRW :: Bool
267255 , mountPropogation :: Text
268256 }
@@ -270,14 +258,14 @@ data Mount = Mount {
270258
271259instance FromJSON Mount where
272260 parseJSON (JSON.Object o) = do
273− name <- o .:? "Name"
261+ name <- o .: "Name"
274262 src <- o .: "Source"
275263 dest <- o .: "Destination"
276− driver <- o .:? "Driver"
277− -- mode <- o .: "Mode"
264+ driver <- o .: "Driver"
265+ mode <- o .: "Mode"
278266 rw <- o .: "RW"
279267 prop <- o .: "Propagation"
280− return $ Mount name src dest driver rw prop
268+ return $ Mount name src dest driver mode rw prop
281269 parseJSON _ = fail "Mount is not an object"
282270
283271-- | Data type used for parsing the container state from a list of
@@ -293,7 +281,7 @@ data ContainerState = ContainerState {
293281 , restarting :: Bool
294282 , running :: Bool
295283 , startedAt :: UTCTime
296− , state :: State
284+ , status :: Status
297285 }
298286 deriving (Eq, Show, Generic)
299287
@@ -523,8 +511,7 @@ data Container = Container
523511 , containerImageId :: ImageID
524512 , containerCommand :: Text
525513 , containerCreatedAt :: Int
526− , containerState :: State
527− , containerStatus :: Maybe Text
514+ , containerStatus :: Status
528515 , containerPorts :: [ContainerPortInfo]
529516 , containerLabels :: [Label]
530517 , containerNetworks :: [Network]
@@ -532,14 +519,13 @@ data Container = Container
532519 } deriving (Show, Eq)
533520
534521instance FromJSON Container where
535− parseJSON o@(JSON.Object v) =
536− Container <$> parseJSON o
522+ parseJSON (JSON.Object v) =
523+ Container <$> (v .: "Id")
537524 <*> (v .: "Names")
538525 <*> (v .: "Image")
539− <*> (v .: "ImageID") -- Doesn't exist anymore
540− <*> (v .: "Command") -- Doesn't exist anymore
526+ <*> (v .: "ImageID")
527+ <*> (v .: "Command")
541528 <*> (v .: "Created")
542− <*> (v .: "State")
543529 <*> (v .: "Status")
544530 <*> (v .: "Ports")
545531 <*> (v .: "Labels")
@@ -549,20 +535,21 @@ instance FromJSON Container where
549535 parseNetworks (JSON.Object v) =
550536 (v .: "Networks") >>= parseJSON
551537 parseNetworks _ = fail "Container NetworkSettings: Not a JSON object."
538+
552539 parseJSON _ = fail "Container: Not a JSON object."
553540
554−-- | Represents the state of the container life cycle.
555−data State = Created | Restarting | Running | Paused | Exited | Dead
541+-- | Represents the status of the container life cycle.
542+data Status = Created | Restarting | Running | Paused | Exited | Dead
556543 deriving (Eq, Show, Generic)
557544
558−instance FromJSON State where
545+instance FromJSON Status where
559546 parseJSON (JSON.String "running") = return Running
560547 parseJSON (JSON.String "created") = return Created -- Note: Guessing on the string values of these.
561548 parseJSON (JSON.String "restarting") = return Restarting
562549 parseJSON (JSON.String "paused") = return Paused
563550 parseJSON (JSON.String "exited") = return Exited
564551 parseJSON (JSON.String "dead") = return Dead
565− parseJSON s = fail $ "Unknown Status: " ++ show s
552+ parseJSON _ = fail "Unknown Status"
566553
567554-- | Alias for representing a RepoDigest. We could newtype this and add
568555-- some validation.
@@ -623,46 +610,20 @@ instance FromJSON Image where
623610 return $ DockerImage imageId imageCreated imageParentId imageRepoTags imageRepoDigests imageSize imageVirtualSize imageLabels
624611 parseJSON _ = fail "Failed to parse DockerImage."
625612
626−-- | Alias for Aliases.
627−type Alias = Text
628−
629−-- | EndpointsConfig is container configuration for a specific network
630−newtype EndpointConfig = EndpointConfig [Alias] deriving (Eq, Show)
631−
632−instance ToJSON EndpointConfig where
633− toJSON (EndpointConfig aliases) = JSON.object
634− [ "Aliases" .= aliases
635− ]
636−
637−-- | Alias for endpoint name
638−type EndpointName = Text
639−
640−-- | Data type for the NetworkingConfig section of the container settings
641−newtype NetworkingConfig = NetworkingConfig
642− { endpointsConfig :: HM.HashMap EndpointName EndpointConfig
643− } deriving (Eq, Show)
644−
645−instance ToJSON NetworkingConfig where
646− toJSON (NetworkingConfig endpointsConfig) = JSON.object
647− [ "EndpointsConfig" .= endpointsConfig
648− ]
649613
650614-- | Options used for creating a Container.
651615data CreateOpts = CreateOpts {
652− containerConfig :: ContainerConfig
653− , hostConfig :: HostConfig
654− , networkingConfig :: NetworkingConfig
616+ containerConfig :: ContainerConfig
617+ , hostConfig :: HostConfig
655618 } deriving (Eq, Show)
656619
657620instance ToJSON CreateOpts where
658− toJSON (CreateOpts cc hc nc) = do
621+ toJSON (CreateOpts cc hc) = do
659622 let ccJSON = toJSON cc
660623 let hcJSON = toJSON hc
661624 case ccJSON of
662625 JSON.Object (o :: HM.HashMap T.Text JSON.Value) -> do
663− let o1 = HM.insert "HostConfig" hcJSON o
664− let o2 = HM.insert "NetworkingConfig" (toJSON nc) o1
665− JSON.Object o2
626+ JSON.Object $ HM.insert "HostConfig" hcJSON o
666627 _ -> error "ContainerConfig is not an object." -- This should never happen.
667628
668629-- | Container configuration used for creating a container with sensible
@@ -697,7 +658,7 @@ defaultHostConfig = HostConfig {
697658 binds=[]
698659 , containerIDFile=Nothing
699660 , logConfig=LogDriverConfig JsonFile []
700− , networkMode=NetworkBridge
661+ , networkMode=Bridge
701662 , portBindings=[]
702663 , restartPolicy=RestartOff
703664 , volumeDriver=Nothing
@@ -744,11 +705,7 @@ defaultContainerResources = ContainerResources {
744705-- | Default create options when creating a container. You only need to
745706-- specify an image name and the rest is all sensible defaults.
746707defaultCreateOpts :: T.Text -> CreateOpts
747−defaultCreateOpts imageName = CreateOpts
748− { containerConfig = defaultContainerConfig imageName
749− , hostConfig = defaultHostConfig
750− , networkingConfig = NetworkingConfig HM.empty
751− }
708+defaultCreateOpts imageName = CreateOpts { containerConfig = defaultContainerConfig imageName, hostConfig = defaultHostConfig }
752709
753710-- | Override the key sequence for detaching a container.
754711-- Format is a single character [a-Z] or ctrl-<value> where <value> is one of: a-z, @, ^, [, , or _.
@@ -762,7 +719,7 @@ defaultStartOpts :: StartOpts
762719defaultStartOpts = StartOpts { detachKeys = DefaultDetachKey }
763720
764721-- | Options for deleting a container.
765−data ContainerDeleteOpts = ContainerDeleteOpts {
722+data DeleteOpts = DeleteOpts {
766723 deleteVolumes :: Bool -- ^ Automatically cleanup volumes that the container created as well.
767724 , force :: Bool -- ^ If the container is still running force deletion anyway.
768725 } deriving (Eq, Show)
@@ -792,15 +749,8 @@ defaultBuildOpts nameTag = BuildOpts { buildImageName = nameTag
792749-- | Default options for deleting a container. Most of the time we DON'T
793750-- want to delete the container's volumes or force delete it if it's
794751-- running.
795−defaultContainerDeleteOpts :: ContainerDeleteOpts
796−defaultContainerDeleteOpts = ContainerDeleteOpts { deleteVolumes = False, force = False }
797−
798−-- | Image delete opts
799−data ImageDeleteOpts = ImageDeleteOpts deriving (Eq, Show)
800−
801−-- | Sane image deletion defaults
802−defaultImageDeleteOpts :: ImageDeleteOpts
803−defaultImageDeleteOpts = ImageDeleteOpts
752+defaultDeleteOpts :: DeleteOpts
753+defaultDeleteOpts = DeleteOpts { deleteVolumes = False, force = False }
804754
805755-- | Timestamp alias.
806756type Timestamp = Integer
@@ -828,36 +778,6 @@ defaultLogOpts = LogOpts { stdout = True
828778 , tail = All
829779 }
830780
831−-- | Options for creating a network
832−data CreateNetworkOpts = CreateNetworkOpts
833− { createNetworkName :: Text -- ^ The network's name
834− , createNetworkCheckDuplicate :: Bool -- ^ Check for networks with duplicate names.
835− , createNetworkDriver :: Text -- ^ Name of the network driver plugin to use.
836− , createNetworkInternal :: Bool -- ^ Restrict external access to the network.
837− , createNetworkEnableIPv6 :: Bool -- ^ Enable IPv6 on the network.
838− } deriving (Eq, Show)
839−
840−-- | Sensible defalut for create network options
841−defaultCreateNetworkOpts :: Text -> CreateNetworkOpts
842−defaultCreateNetworkOpts name =
843− CreateNetworkOpts
844− { createNetworkName = name
845− , createNetworkCheckDuplicate = False
846− , createNetworkDriver = "bridge"
847− , createNetworkInternal = True
848− , createNetworkEnableIPv6 = False
849− }
850−
851−instance ToJSON CreateNetworkOpts where
852− toJSON opts =
853− object
854− [ "Name" .= createNetworkName opts
855− , "CheckDuplicate" .= createNetworkCheckDuplicate opts
856− , "Driver" .= createNetworkDriver opts
857− , "Internal" .= createNetworkInternal opts
858− , "EnableIPv6" .= createNetworkEnableIPv6 opts
859− ]
860−
861781-- TOOD: Add support for SELinux Volume labels (eg. "ro,z" or "ro/Z")
862782-- | Set permissions on volumes that you mount in the container.
863783data VolumePermission = ReadWrite | ReadOnly deriving (Eq, Show, Generic)
@@ -869,8 +789,6 @@ instance ToJSON VolumePermission where
869789instance FromJSON VolumePermission where
870790 parseJSON "rw" = return ReadWrite
871791 parseJSON "ro" = return ReadOnly
872− parseJSON "RW" = return ReadWrite
873− parseJSON "RO" = return ReadOnly
874792 parseJSON _ = fail "Failed to parse VolumePermission"
875793
876794-- | Used for marking a directory in the container as "exposed" hence
@@ -1017,41 +935,19 @@ instance FromJSON LogDriverConfig where
1017935 parseJSON _ = fail "LogDriverConfig is not an object"
1018936
1019937-- TODO: Add container:<name|id> mode
1020−data NetworkMode = NetworkBridge | NetworkHost | NetworkDisabled | NetworkNamed Text
938+data NetworkMode = Bridge | Host | NetworkDisabled
1021939 deriving (Eq, Show, Ord)
1022940
1023941instance FromJSON NetworkMode where
1024− parseJSON (JSON.String "bridge") = return NetworkBridge
1025− parseJSON (JSON.String "host") = return NetworkHost -- Note: Guessing on these.
942+ parseJSON (JSON.String "bridge") = return Bridge
943+ parseJSON (JSON.String "host") = return Host -- Note: Guessing on these.
1026944 parseJSON (JSON.String "none") = return NetworkDisabled
1027− parseJSON (JSON.String n) = return $ NetworkNamed n
1028945 parseJSON _ = fail "Unknown NetworkMode"
1029946
1030947instance ToJSON NetworkMode where
1031− toJSON NetworkBridge = JSON.String "bridge"
1032− toJSON NetworkHost = JSON.String "host"
1033− toJSON NetworkDisabled = JSON.String "none"
1034− toJSON (NetworkNamed n) = JSON.String n
1035−
1036−newtype NetworkID = NetworkID Text
1037− deriving (Eq, Show)
1038−
1039−-- | Used for extracting the id of the container from the newtype
1040−fromNetworkID :: NetworkID -> Text
1041−fromNetworkID (NetworkID t) = t
1042−
1043−-- | Used for parsing a Text value into a NetworkID.
1044−toNetworkID :: Text -> Maybe NetworkID
1045−toNetworkID t = Just $ NetworkID t
1046−
1047−instance FromJSON NetworkID where
1048− parseJSON (JSON.Object o) = do
1049− nid <- o .: "Id"
1050− return $ NetworkID nid
1051− parseJSON _ = fail "NetworkID is not an object."
1052−
1053−instance ToJSON NetworkID where
1054− toJSON (NetworkID nid) = object ["Id" .= nid]
948+ toJSON Bridge = JSON.String "bridge"
949+ toJSON Host = JSON.String "host"
950+ toJSON NetworkDisabled = JSON.String "none"
1055951
1056952data PortType = TCP | UDP deriving (Eq, Generic, Read, Ord)
1057953
@@ -1452,7 +1348,7 @@ instance FromJSON EnvVar where
14521348 parseJSON _ = fail "EnvVar is not a string"
14531349
14541350instance ToJSON EnvVar where
1455− toJSON (EnvVar n v) = JSON.String $ n <> T.pack "=" <> v
1351+ toJSON (EnvVar n v) = object [n .= v]
14561352
14571353-- | ExposedPort represents a port (and it's type)
14581354-- that a container should expose to other containers or the host system.
@@ -1564,11 +1460,7 @@ instance FromJSON ContainerConfig where
15641460 macAddress labels stopSignal
15651461 parseJSON _ = fail "NetworkSettings is not an object."
15661462
1567−#if MIN_VERSION_base(4,13,0)
1568−parseIntegerText :: (MonadFail m) => Text -> m Integer
1569−#else
15701463parseIntegerText :: (Monad m) => Text -> m Integer
1571−#endif
15721464parseIntegerText t = case readMaybe $ T.unpack t of
15731465 Nothing ->
15741466 fail "Could not parse Integer"
stack-7.10.yaml+1−4
@@ -11,10 +11,7 @@ packages:
1111flags: {}
1212
1313# Extra package databases containing global packages
14−extra-deps:
15−- directory-1.2.7.0
16−- unliftio-core-0.1.1.0
17−- process-1.6.5.1
14+extra-deps: [directory-1.2.7.0]
1815
1916# Control whether we use the GHC we find on the path
2017# system-ghc: true
stack-8.0.2.yamldeleted−4
@@ -1,4 +0,0 @@
1−resolver: lts-9.4
2−packages:
3−- '.'
4−extra-deps: []
stack-8.0.yaml+1−2
@@ -1,5 +1,4 @@
11resolver: lts-7.12
22packages:
33- '.'
4−extra-deps:
5−- unliftio-core-0.1.1.0
4+extra-deps: []
stack-8.6.4.yamldeleted−4
@@ -1,4 +0,0 @@
1−resolver: lts-13.19
2−packages:
3−- '.'
4−extra-deps: []
stack-8.8.2.yamldeleted−5
@@ -1,5 +0,0 @@
1−resolver: lts-15.0
2−packages:
3−- '.'
4−extra-deps: []
5−
stack.yaml+1−1
@@ -1 +1 @@
1−stack-8.6.4.yaml
1+stack-7.10.yaml
tests/Dockerfile+1−1
@@ -1,4 +1,4 @@
11FROM debian:jessie
22
3−CMD ["/bin/bash", "-c", "echo $TEST"]
3+CMD ["/bin/bash", "-c", "echo 123"]
44
tests/tests.hs+13−117
@@ -2,8 +2,6 @@
22
33module Main where
44
5−import Data.Either (rights)
6−import Prelude hiding (all)
75import qualified Test.QuickCheck.Monadic as QCM
86import Test.Tasty
97import Test.Tasty.HUnit
@@ -11,11 +9,9 @@ import Test.Tasty.QuickCheck (testProperty)
119
1210import Control.Concurrent (threadDelay)
1311import Control.Lens ((^.), (^?))
14−import Control.Monad (forM_)
1512import Control.Monad.IO.Class
1613import Control.Monad.Trans.Class (lift)
1714import qualified Data.Aeson as JSON
18−import Data.Aeson ((.=))
1915import Data.Aeson.Lens (key, _Array, _Null, _Object,
2016 _String, _Value)
2117import qualified Data.ByteString as B
@@ -24,7 +20,7 @@ import qualified Data.ByteString.Lazy as BL
2420import qualified Data.HashMap.Strict as HM
2521import Data.Int (Int)
2622import qualified Data.Map as M
27−import Data.Maybe (fromJust, isJust, isNothing, listToMaybe)
23+import Data.Maybe (fromJust, isJust)
2824import Data.Monoid
2925import Data.Text (Text, unpack)
3026import qualified Data.Vector as V
@@ -32,15 +28,12 @@ import Network.Connection (TLSSettings (..))
3228import Network.HTTP.Client (newManager)
3329import Network.HTTP.Client.TLS
3430import Network.HTTP.Types.Status
35−import System.Directory (getCurrentDirectory)
36−import System.Environment (lookupEnv)
3731import System.Process (system)
3832
3933import Docker.Client
4034
4135-- opts = defaultClientOpts
42−testImageName = "docker-hs/test"
43−imageToDeleteFullName = "hello-world:latest"
36+testImageName = "docker-hs-test"
4437
4538toStrict1 = B.concat . BL.toChunks
4639
@@ -60,89 +53,33 @@ testDockerVersion =
6053 do v <- getDockerVersion
6154 lift $ assert $ isRight v
6255
63−testStopNonexisting :: IO ()
64−testStopNonexisting = runDocker $ do
65− res <- stopContainer DefaultTimeout $ fromJust $ toContainerID "thisshouldnotexist"
66− lift $ assert $ isLeft res
67−
6856testFindImage :: IO ()
6957testFindImage =
7058 runDocker $
7159 do images <- listImages defaultListOpts >>= fromRight
72− let xs = filter (elem imageFullName . imageRepoTags) images
60+ let xs = filter ((== [imageFullName]) . imageRepoTags) images
7361 lift $ assert $ length xs == 1
7462 where
7563 imageFullName = testImageName <> ":latest"
7664
77−testDeleteImage :: IO ()
78−testDeleteImage = runDocker $ do
79− img <- fmap fromJust findTestImage
80− result <- deleteImage defaultImageDeleteOpts (imageId img)
81− lift $ assert $ isRight result
82− maybeTestImageAfter <- findTestImage
83− lift $ assert $ isNothing maybeTestImageAfter
84− where
85− findTestImage =
86− do
87− images <- listImages defaultListOpts >>= fromRight
88− return $ listToMaybe
89− $ filter (elem imageToDeleteFullName . imageRepoTags) images
90−
91−testListContainers :: IO ()
92−testListContainers =
93− runDocker $
94− do containerId <- createContainer (defaultCreateOpts (testImageName <> ":latest")) Nothing
95− c <- fromRight containerId
96− res <- listContainers $ ListOpts { all=True }
97− deleteContainer (ContainerDeleteOpts True True) c
98− lift $ assert $ isRight res
99−
100−testBuildFromDockerfile :: IO ()
101−testBuildFromDockerfile = do
102− cur <- getCurrentDirectory
103− let ctxDir = cur ++ "/tests"
104− runDocker $ do
105− r <- buildImageFromDockerfile (defaultBuildOpts "docker-hs/dockerfile-test") ctxDir
106− lift $ assert $ isRight r
107−
108−
10965testRunAndReadLog :: IO ()
110−testRunAndReadLog = testRunAndReadLogHelper $ NetworkingConfig HM.empty
111−
112−testRunAndReadLogWithNetworking :: IO ()
113−testRunAndReadLogWithNetworking = testRunAndReadLogHelper $ NetworkingConfig $ HM.fromList [("test-network", EndpointConfig ["cellar-door"])]
114−
115−testRunAndReadLogHelper :: NetworkingConfig -> IO ()
116−testRunAndReadLogHelper networkingConfig =
66+testRunAndReadLog =
11767 runDocker $
118− do let containerConfig = (defaultContainerConfig (testImageName <> ":latest")) {env = [EnvVar "TEST" "123"]}
119− createdNetworks <- rights <$> mapM createNetworkWithName networkNames
120− containerId <- createContainer (CreateOpts containerConfig defaultHostConfig networkingConfig) Nothing
68+ do containerId <- createContainer (defaultCreateOpts (testImageName <> ":latest")) Nothing
12169 c <- fromRight containerId
12270 status1 <- startContainer defaultStartOpts c
12371 _ <- inspectContainer c >>= fromRight
12472 lift $ threadDelay 300000 -- give 300ms for the application to finish
125− lift $ assertBool ("starting the container, unexpected status: " ++ show status1) $ isRightUnit status1
73+ lift $ assert $ isRightUnit status1
74+ status2 <- killContainer SIGTERM c
12675 logs <- getContainerLogs defaultLogOpts c >>= fromRight
76+ lift $ assert $ isRightUnit status2
12777 lift $ assert $ (C.pack "123") `C.isInfixOf` (toStrict1 logs)
128− status3 <- deleteContainer (ContainerDeleteOpts True True) c
129− lift $ assertBool ("deleting container, unexpected status: " ++ show status3) $ isRightUnit status3
130− mapM_ removeNetwork createdNetworks
78+ status3 <- deleteContainer (DeleteOpts True True) c
79+ lift $ assert $ isRightUnit status3
13180 where
13281 isRightUnit (Right ()) = True
13382 isRightUnit _ = False
134− networkNames = HM.keys $ endpointsConfig networkingConfig
135− createNetworkWithName name = createNetwork $
136− (defaultCreateNetworkOpts name) { createNetworkCheckDuplicate = True }
137−
138−testCreateRemoveNetwork :: IO ()
139−testCreateRemoveNetwork = do
140− runDocker $ do
141− createStatus <- createNetwork $ defaultCreateNetworkOpts "test-network"
142− lift $ assertBool ("creating a network, unexpected status: " ++ show createStatus) $ isRight createStatus
143− nid <- fromRight createStatus
144− removeStatus <- removeNetwork nid
145− lift $ assertBool ("removing a network, unexpected status: " ++ show removeStatus) $ isRight removeStatus
14683
14784testLogDriverOptionsJson :: TestTree
14885testLogDriverOptionsJson = testGroup "Testing LogDriverOptions JSON" [test1, test2, test3]
@@ -213,42 +150,13 @@ testEntrypointJson = testGroup "Testing ContainerConfig JSON" [testSample1, test
213150 Just (Entrypoint sampleEntrypointArr)
214151 sampleEntrypointArr = ["cmd", "--some-flag", "--some-flag2"]
215152
216−testEnvVarJson :: TestTree
217−testEnvVarJson = testGroup "Testing EnvVar JSON" [testSampleEncode, testSampleDecode]
218− where
219− testSampleEncode =
220− testCase "Test toJSON" $ assert $ JSON.toJSON (EnvVar "cellar" "door") == JSON.String "cellar=door"
221− testSampleDecode =
222− testCase "Test fromJSON" $ assert $ (JSON.decode "\"cellar=door\"" :: Maybe EnvVar) ==
223− Just (EnvVar "cellar" "door")
224−
225−testNetworkingConfigJson :: TestTree
226−testNetworkingConfigJson = testGroup "Testing NetworkingConfig JSON" [testSampleEncode]
227− where
228− testSampleEncode =
229− let networkingConfig = NetworkingConfig $ HM.fromList [("custom-network", EndpointConfig ["cellar", "door"])]
230− in testCase "Test toJSON" $ assert $ JSON.toJSON networkingConfig ==
231− JSON.object
232− [ "EndpointsConfig" .= JSON.object
233− [ "custom-network" .= JSON.object
234− [ "Aliases" .= (["cellar", "door"] :: [Text])
235− ]
236− ]
237− ]
238−
239153integrationTests :: TestTree
240154integrationTests =
241155 testGroup
242156 "Integration Tests"
243157 [ testCase "Get docker version" testDockerVersion
244− , testCase "Build image from Dockerfile" testBuildFromDockerfile
245158 , testCase "Find image by name" testFindImage
246− , testCase "Delete image" testDeleteImage
247− , testCase "List containers" testListContainers
248159 , testCase "Run a dummy container and read its log" testRunAndReadLog
249− , testCase "Run a dummy container with networking and read its log" testRunAndReadLogWithNetworking
250− , testCase "Try to stop a container that doesn't exist" testStopNonexisting
251− , testCase "Create and remove a network" testCreateRemoveNetwork
252160 ]
253161
254162jsonTests :: TestTree
@@ -260,18 +168,10 @@ jsonTests =
260168 , testLabelsJson
261169 , testLogDriverOptionsJson
262170 , testEntrypointJson
263− , testEnvVarJson
264− , testNetworkingConfigJson
265171 ]
266172
267173setup :: IO ()
268−setup =
269− mapM_ system
270− [ "docker pull " ++ unpack imageToDeleteFullName
271− , "docker build -t " ++ unpack testImageName ++ " tests"
272− ]
273−
274−isLeft = not . isRight
174+setup = system ("docker build -t " ++ unpack testImageName ++ " tests") >> return ()
275175
276176isRight (Left _) = False
277177isRight (Right _) = True
@@ -286,9 +186,5 @@ fromRight (Right r) = return r
286186
287187main :: IO ()
288188main = do
289− stackage <- lookupEnv "RUN_INTEGRATION_TESTS"
290− case stackage of
291− Nothing -> defaultMain $ testGroup "Tests" [jsonTests]
292− Just _ -> do
293− setup
294− defaultMain $ testGroup "Tests" [jsonTests, integrationTests]
189+ setup
190+ defaultMain $ testGroup "Tests" [jsonTests, integrationTests]