on master help sign in
Address review feedback
fe72ba2Till Schneidereit
js/change-list.js+6−6
@@ -136,8 +136,8 @@ const OP_TABLE = [
136 const b = mem32[i++];
136 const b = mem32[i++];
137 const el = top(changeList.stack);
137 const el = top(changeList.stack);
138 el.addEventListener(eventType, changeList.eventHandler);
138 el.addEventListener(eventType, changeList.eventHandler);
139− el["dodrio-a-" + eventType] = a;
139+ el[`dodrio-a-${eventType}`] = a;
140− el["dodrio-b-" + eventType] = b;
140+ el[`dodrio-b-${eventType}`] = b;
141 return i;
141 return i;
142 },
142 },
143
143
@@ -146,8 +146,8 @@ const OP_TABLE = [
146 const eventId = mem32[i++];
146 const eventId = mem32[i++];
147 const eventType = changeList.getString(eventId);
147 const eventType = changeList.getString(eventId);
148 const el = top(changeList.stack);
148 const el = top(changeList.stack);
149− el["dodrio-a-" + eventType] = mem32[i++];
149+ el[`dodrio-a-${eventType}`] = mem32[i++];
150− el["dodrio-b-" + eventType] = mem32[i++];
150+ el[`dodrio-b-${eventType}`] = mem32[i++];
151 return i;
151 return i;
152 },
152 },
153
153
@@ -257,8 +257,8 @@ class ChangeList {
257 // to listen for events on, this ensures that we always get the right
257 // to listen for events on, this ensures that we always get the right
258 // values for `a` and `b`.
258 // values for `a` and `b`.
259 const type = event.type;
259 const type = event.type;
260− const a = this["dodrio-a-" + type];
260+ const a = this[`dodrio-a-${type}`];
261− const b = this["dodrio-b-" + type];
261+ const b = this[`dodrio-b-${type}`];
262 trampoline(event, a, b);
262 trampoline(event, a, b);
263 }
263 }
264 }
264 }