From e2c77a1dbb2cb7f06f4d63c9c0230876da5059ca Mon Sep 17 00:00:00 2001 From: noumantahir Date: Mon, 20 Jun 2022 16:33:03 +0500 Subject: [PATCH] added todo tags for application container optimising --- src/redux/reducers/applicationReducer.ts | 2 +- src/screens/application/container/applicationContainer.js | 2 +- src/screens/settings/container/settingsContainer.js | 1 + 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/redux/reducers/applicationReducer.ts b/src/redux/reducers/applicationReducer.ts index 16271a630..e8032bd03 100644 --- a/src/redux/reducers/applicationReducer.ts +++ b/src/redux/reducers/applicationReducer.ts @@ -38,7 +38,7 @@ const initialState = { isActive: false, isConnected: null, // internet connectivity isDarkTheme: false, - isDefaultFooter: true, + isDefaultFooter: true, //TODO: remove present of isDefaultFooter as it's no longer in use isLoggedIn: false, // Has any logged in user. isAnalytics: false, isLoginDone: false, diff --git a/src/screens/application/container/applicationContainer.js b/src/screens/application/container/applicationContainer.js index f334767cd..d7a3911e0 100644 --- a/src/screens/application/container/applicationContainer.js +++ b/src/screens/application/container/applicationContainer.js @@ -235,7 +235,7 @@ class ApplicationContainer extends Component { if (!isIos) BackHandler.removeEventListener('hardwareBackPress', this._onBackPress); - // NetInfo.isConnected.removeEventListener('connectionChange', this._handleConntectionChange); + //TOOD: listen for back press and cancel all pending api requests; Linking.removeEventListener('url', this._handleOpenURL); diff --git a/src/screens/settings/container/settingsContainer.js b/src/screens/settings/container/settingsContainer.js index e3a964da5..ec99731bf 100644 --- a/src/screens/settings/container/settingsContainer.js +++ b/src/screens/settings/container/settingsContainer.js @@ -269,6 +269,7 @@ class SettingsContainer extends Component { type: actionType, }), ); + //TODO: remove setting notification settings setNotificationSettings({ action, type: actionType,