1{-# OPTIONS_GHC -Wall #-}
2module Nitpick.PatternMatches (patternMatches) where
4{- The algorithm used here comes from "Warnings for Pattern Matching"
5by Luc Maranget. Check it out for more information!
7http://moscova.inria.fr/~maranget/papers/warn/warn.pdf
11import Control.Arrow ((***), second)
12import qualified Data.Foldable as F
13import qualified Data.List as List
14import qualified Data.Map as Map
15import qualified Data.Maybe as Maybe
16import qualified Data.Set as Set
18import qualified AST.Expression.Canonical as C
19import qualified AST.Helpers as Help
20import qualified AST.Literal as L
21import qualified AST.Module as Module
22import qualified AST.Module.Name as ModuleName
23import qualified AST.Pattern as Pattern
24import qualified AST.Variable as Var
25import Elm.Utils ((|>))
26import Nitpick.Pattern (Pattern(..), fromCanonicalPattern)
27import qualified Optimize.DecisionTree as DT
28import qualified Reporting.Annotation as A
29import qualified Reporting.Error.Pattern as Error
30import qualified Reporting.Region as Region
31import qualified Reporting.Result as Result
35-- NITPICK PATTERN MATCHES
38type Result warning a =
39 Result.Result () warning Error.Error a
42patternMatches :: Module.Interfaces -> Module.Canonical -> Result wrn DT.VariantDict
43patternMatches interfaces (Module.Module name _ info) =
46 toArityDict interfaces name (Module.unions info)
49 Map.map (Map.map _size) arityDict
52 <* checkExpression arityDict (Module.program info)
55checkExpression :: ArityDict -> C.Expr -> Result wrn ()
56checkExpression arityDict (A.A region expression) =
59 checkExpression arityDict
72 F.traverse_ go listExprs
74 C.Binop _ leftExpr rightExpr ->
75 go2 leftExpr rightExpr
77 C.Lambda pattern@(A.A patRegion _) body ->
78 checkPatterns arityDict patRegion Error.Arg [pattern]
84 C.If branches finally ->
85 F.traverse_ (uncurry go2) branches
90 <* F.traverse_ goDef defs
92 goDef (C.Def _ pattern@(A.A patRegion _) expr _) =
93 checkPatterns arityDict patRegion Error.LetBound [pattern]
96 C.Case expr branches ->
98 <* checkPatterns arityDict region Error.Case (map fst branches)
99 <* F.traverse_ (go . snd) branches
101 C.Ctor _ctor exprs ->
104 C.Access record _field ->
107 C.Update record fields ->
109 <* F.traverse_ (go . snd) fields
112 F.traverse_ (go . snd) fields
120 C.OutgoingPort _ _ ->
123 C.IncomingPort _ _ ->
127 error "DANGER - Program AST nodes should not be in Nitpick.PatternMatches."
140checkPatterns :: ArityDict -> Region.Region -> Error.Origin -> [Pattern.Canonical] -> Result wrn ()
141checkPatterns arityDict region origin patterns =
142 do matrix <- checkRedundant arityDict region [] patterns
143 case isExhaustive arityDict matrix 1 of
148 Result.throw region (Error.Incomplete origin (map head badPatterns))
152-- EXHAUSTIVE PATTERNS
155isExhaustive :: ArityDict -> [[Pattern]] -> Int -> [[Pattern]]
156isExhaustive arityDict matrix n =
159 [replicate n Anything]
167 List.foldl' isCompleteHelp Set.empty matrix
174 <$> isExhaustive arityDict (Maybe.mapMaybe toDefault matrix) (n - 1)
178 (ArityInfo expected info) =
179 getArityInfo (Set.findMin ctorSet) arityDict
181 if actual < expected then
183 <$> Maybe.mapMaybe (isMissing ctorSet) info
184 <*> isExhaustive arityDict (Maybe.mapMaybe toDefault matrix) (n - 1)
188 isExhaustiveHelp (name, arity) =
189 recoverCtor name arity <$>
192 (Maybe.mapMaybe (specialize name arity) matrix)
195 concatMap isExhaustiveHelp info
198isMissing :: Set.Set Var.Canonical -> (Var.Canonical, Int) -> Maybe Pattern
199isMissing ctorSet (name, arity) =
200 if Set.member name ctorSet then
204 Just (Ctor name (replicate arity Anything))
207recoverCtor :: Var.Canonical -> Int -> [Pattern] -> [Pattern]
208recoverCtor name arity patterns =
211 splitAt arity patterns
213 Ctor name args : rest
224 -> [Pattern.Canonical]
225 -> Result wrn [[Pattern]]
226checkRedundant arityDict region checked unchecked =
231 nextPattern@(A.A patRegion _) : rest ->
234 [fromCanonicalPattern nextPattern]
236 if isUseful arityDict checked next then
237 checkRedundant arityDict region (next : checked) rest
239 Result.throw region (Error.Redundant patRegion (length checked + 1))
242isUseful :: ArityDict -> [[Pattern]] -> [Pattern] -> Bool
243isUseful arityDict matrix vector =
244 case (matrix, vector) of
251 (_, firstPattern : patterns) ->
256 Maybe.mapMaybe (specialize name (length args)) matrix
258 isUseful arityDict newMatrix (args ++ patterns)
261 case isComplete arityDict matrix of
263 isUseful arityDict (Maybe.mapMaybe toDefault matrix) patterns
267 isUsefulHelp (ctor, arity) =
270 (Maybe.mapMaybe (specialize ctor arity) matrix)
271 (replicate arity Anything ++ patterns)
273 any isUsefulHelp arityInfo
278 Maybe.mapMaybe (specializeLiteral literal) matrix
280 isUseful arityDict newMatrix patterns
284-- SPECIALIZE MATRICES
287specialize :: Var.Canonical -> Int -> [Pattern] -> Maybe [Pattern]
288specialize ctorName arity row =
291 error "Compiler error! Empty matrices should not get specialized."
293 firstPattern : patterns ->
296 if name == ctorName then Just (args ++ patterns) else Nothing
299 Just (replicate arity Anything ++ patterns)
303 "Compiler bug! After type checking, constructors and literals\
304 \ should never align in pattern match exhaustiveness checks."
307specializeLiteral :: L.Literal -> [Pattern] -> Maybe [Pattern]
308specializeLiteral literal row =
311 error "Compiler error! Empty matrices should not get specialized."
313 firstPattern : patterns ->
316 if lit == literal then Just patterns else Nothing
323 "Compiler bug! After type checking, constructors and literals\
324 \ should never align in pattern match exhaustiveness checks."
327toDefault :: [Pattern] -> Maybe [Pattern]
336 Anything : patterns ->
344-- ALL CONSTRUCTORS ARE PRESENT?
347isComplete :: ArityDict -> [[Pattern]] -> Maybe [(Var.Canonical, Int)]
348isComplete arityDict matrix =
351 List.foldl' isCompleteHelp Set.empty matrix
361 (ArityInfo expected info) =
362 getArityInfo (Set.findMin ctorSet) arityDict
364 if expected == actual then Just info else Nothing
367isCompleteHelp :: Set.Set Var.Canonical -> [Pattern] -> Set.Set Var.Canonical
368isCompleteHelp ctors row =
371 Set.insert name ctors
382 Map.Map Var.Home (Map.Map String ArityInfo)
388 , _info :: [(Var.Canonical, Int)]
392toArityDict :: Module.Interfaces -> ModuleName.Canonical -> Module.Unions -> ArityDict
393toArityDict interfaces localName localUnions =
395 |> Map.mapWithKey (\name iface -> toArityEntry name (Module.iUnions iface))
396 |> Map.mapKeysMonotonic Var.Module
397 |> Map.insert (Var.Module localName) (toArityEntry localName localUnions)
398 |> Map.union builtinDict
401builtinDict :: ArityDict
405 ArityInfo 2 [ (Var.builtin "::", 2), (Var.builtin "[]", 0) ]
408 ArityInfo 2 [ (Var.builtin "True", 0), (Var.builtin "False", 0) ]
410 Map.singleton Var.BuiltIn $ Map.fromList $
414 , ("False", boolInfo)
416 ++ map makeTupleInfo [0..8]
419makeTupleInfo :: Int -> ( String, ArityInfo )
425 ( name, ArityInfo 1 [ (Var.builtin name, n) ] )
428toArityEntry :: ModuleName.Canonical -> Module.Unions -> Map.Map String ArityInfo
429toArityEntry name unions =
430 Map.fromList (concatMap (toArityEntryHelp name) (Map.elems unions))
433toArityEntryHelp :: ModuleName.Canonical -> Module.UnionInfo String -> [(String, ArityInfo)]
434toArityEntryHelp name (_tvars, ctors) =
437 ArityInfo (length ctors) (map (Var.fromModule name *** length) ctors)
439 map (second (\_ -> arityInfo)) ctors
442getArityInfo :: Var.Canonical -> ArityDict -> ArityInfo
443getArityInfo var@(Var.Canonical home name) arityDict =
444 case Map.lookup name =<< Map.lookup home arityDict of
449 if Help.isTuple name then
450 ArityInfo 1 [ (var, read (drop 6 name)) ]
453 "Since the Nitpick phase happens after canonicalization and type\
454 \ inference, it is impossible that a pattern in a case cannot be\
keysesc to close
- j k
- move down, up
- enter
- open
- esc
- back, or up a level
- 1 2 3 4
- readme, files, commits, refs
- /
- filter
- y
- copy the clone command
- c
- compare the chosen commit with another (or shift-click both)
- ?
- show or hide this list