git.iko.soy/elk
on master help sign in
Provide nicer errors when things go wrong with npm installer!
3aed9fcEvan Czaplicki
installers/npm/download.js+22−6
compare with master
unifiedsplit
@@ -35,27 +35,26 @@ function download(destinationPath, url, callback)
35 requestWithRedirects(url, 10,
35 requestWithRedirects(url, 10,
36 function(error) {
36 function(error) {
37 var url = host + '/' + path;
37 var url = host + '/' + path;
38− throw new Error('Error fetching binary from ' + url + ': ' + error);
38+ exitFailure(url, 'Error fetching binary from ' + url + ': ' + error);
39 },
39 },
40 function(response) {
40 function(response) {
41 if (response.statusCode == 404)
41 if (response.statusCode == 404)
42 {
42 {
43− // TODO give specific error message
43+ exitFailure(url, 'I got a "404 Not Found" trying to download from the following URL:\n' + url);
44− throw new Error('Not Found: ' + url);
45 }
44 }
46
45
47 response.on('error', function() {
46 response.on('error', function() {
48− throw new Error('Error receiving ' + url);
47+ exitFailure(url, 'Something went wrong while receiving the following URL:\n\n' + url);
49 });
48 });
50
49
51 var gunzip = zlib.createGunzip().on('error', function(error) {
50 var gunzip = zlib.createGunzip().on('error', function(error) {
52− throw new Error('Error decompressing elm.gz: ' + error);
51+ exitFailure(url, 'I ran into trouble decompressing the downloaded binary. It is saying:\n\n' + error);
53 });
52 });
54 var write = fs.createWriteStream(destinationPath, {
53 var write = fs.createWriteStream(destinationPath, {
55 encoding: 'binary',
54 encoding: 'binary',
56 mode: 0o755
55 mode: 0o755
57 }).on('finish', callback).on('error', function(error) {
56 }).on('finish', callback).on('error', function(error) {
58− throw new Error('Error writing file: ' + error);
57+ exitFailure(url, 'I had some trouble writing file to disk. It is saying:\n\n' + error);
59 });
58 });
60
59
61 response.pipe(gunzip).pipe(write);
60 response.pipe(gunzip).pipe(write);
@@ -93,3 +92,20 @@ function requestWithRedirects(url, maxRedirects, failure, success)
93
92
94 req.end();
93 req.end();
95}
94}
95+
96+
97+
98+// EXIT FAILURE
99+
100+
101+function exitFailure(url, message)
102+{
103+ console.error(
104+ '-- ERROR -----------------------------------------------------------------------\n\n'
105+ + message
106+ + '\n\nNOTE: You can avoid npm entirely by downloading directly from:\n'
107+ + url + '\nAll this package does is download that file and put it somewhere.\n\n'
108+ + '--------------------------------------------------------------------------------\n'
109+ );
110+ process.exit(1);
111+}