git.iko.soy/elk
on master help sign in
Fix #1120, stop trying to guess how exactly the pattern came to be unhanded
b091deaEvan Czaplicki
src/Reporting/Error/Pattern.hs+9−5
compare with master
unifiedsplit
@@ -47,7 +47,7 @@ toReport _localizer err =
47 "MISSING PATTERNS"
47 "MISSING PATTERNS"
48 Nothing
48 Nothing
49 "This `case` does not have branches for all possibilities."
49 "This `case` does not have branches for all possibilities."
50− (text (unhandledError unhandled newTagsMessage))
50+ (text (unhandledError unhandled (missingBranchesMessage (length unhandled))))
51
51
52 Redundant ->
52 Redundant ->
53 Report.report
53 Report.report
@@ -74,7 +74,7 @@ unhandledError unhandledPatterns relevantMessage =
74 ++ "\n"
74 ++ "\n"
75 ++ "If you are seeing this error for the first time, check out these hints:\n"
75 ++ "If you are seeing this error for the first time, check out these hints:\n"
76 ++ Help.hintLink "missing-patterns" ++ "\n"
76 ++ Help.hintLink "missing-patterns" ++ "\n"
77− ++ "The recommendations about `Debug.crash` and wildcard patterns are important!"
77+ ++ "The recommendations about wildcard patterns and `Debug.crash` are important!"
78
78
79
79
80toCaseMessage :: String
80toCaseMessage :: String
@@ -82,7 +82,11 @@ toCaseMessage =
82 "Switch to a `case` expression to handle all possible patterns."
82 "Switch to a `case` expression to handle all possible patterns."
83
83
84
84
85−newTagsMessage :: String
85+missingBranchesMessage :: Int -> String
86−newTagsMessage =
86+missingBranchesMessage numUnhandled =
87− "Did you add a new tag to a union type? Add a branch for it here!"
87+ if numUnhandled == 1 then
88+ "Add a branch to cover this pattern!"
89+
90+ else
91+ "Add branches to cover each of these patterns!"
88
92