git.iko.soy/elk
on master help sign in
add PERF note about unblocking on a couple file writes
commitf39ac587fb0155cc3766d5599e2a40998624940a authorEvan Czaplicki <evancz@users.noreply.github.com> dateFri 28 Jun 2019, 13:39 (7 years ago) parente0d5d29
1 file changed+3−1
compare with master
unifiedsplit
builder/src/Elm/Details.hs+3−1
builder/src/Elm/Details.hs+3−1
@@ -308,7 +308,9 @@ verifyDependencies env@(Env key root _ _ _ _) time outline solution directDeps =
308308 foreigns = Map.map (OneOrMore.destruct Foreign) $ Map.foldrWithKey gatherForeigns Map.empty artifacts
309309 details = Details time outline Map.empty foreigns (ArtifactsFresh ifaces objs)
310310 in
311− do File.writeBinary (Stuff.objects root) objs
311+ do -- PERF fork all three of these writes, but need to make sure
312+ -- they complete before main thread with some MVar check at end
313+ File.writeBinary (Stuff.objects root) objs
312314 File.writeBinary (Stuff.interfaces root) ifaces
313315 File.writeBinary (Stuff.details root) details
314316 return (Right details)