on master help sign in
cosmetic: use a slightly more descriptive names
fd7707eEvan Czaplicki
libraries/Native/Utils.js+11−9
@@ -225,11 +225,13 @@ Elm.Native.Utils.make = function(elm) {
225 }
225 }
226 if (missing.length > 0) {
226 if (missing.length > 0) {
227 throw new Error("Initialization Error: module " + moduleName +
227 throw new Error("Initialization Error: module " + moduleName +
228− " was not given inputs for the following ports: " + missing.join(', '));
228+ " was not given inputs for the following ports: " +
229+ missing.join(', '));
229 }
230 }
230 if (extra.length > 0) {
231 if (extra.length > 0) {
232+ throw new Error(
231− throw new Error("Initialization Error: module " + moduleName +
233+ "Initialization Error: module " + moduleName +
232− " has been given ports that do not exist: " + extra.join(', '));
234+ " has been given ports that do not exist: " + extra.join(', '));
233 }
235 }
234 }
236 }
235
237
@@ -266,17 +268,17 @@ Elm.Native.Utils.make = function(elm) {
266 return signal;
268 return signal;
267 }
269 }
268 function portOut(name, signal) {
270 function portOut(name, signal) {
269− var handlers = []
271+ var subscribers = []
270 function subscribe(handler) {
272 function subscribe(handler) {
271− handlers.push(handler);
273+ subscribers.push(handler);
272 }
274 }
273 function unsubscribe(handler) {
275 function unsubscribe(handler) {
274− handlers.pop(handlers.indexOf(handler));
276+ subscribers.pop(subscribers.indexOf(handler));
275 }
277 }
276− Signal.lift(function(v) {
278+ Signal.lift(function(value) {
277− var len = handlers.length;
279+ var len = subscribers.length;
278 for (var i = 0; i < len; ++i) {
280 for (var i = 0; i < len; ++i) {
279− handlers[i](v);
281+ subscribers[i](value);
280 }
282 }
281 }, signal);
283 }, signal);
282 elm.ports_out[name] = { subscribe:subscribe, unsubscribe:unsubscribe };
284 elm.ports_out[name] = { subscribe:subscribe, unsubscribe:unsubscribe };