@@ -69,6 +69,9 @@ data Error
69 | ModuleNameMismatch ModuleName.Raw (A.Located ModuleName.Raw)
69 | ModuleNameMismatch ModuleName.Raw (A.Located ModuleName.Raw)
70 | UnexpectedPort A.Region
70 | UnexpectedPort A.Region
71 | NoPorts A.Region
71 | NoPorts A.Region
72+ | NoPortsInPackage (A.Located Name.Name)
73+ | NoPortModulesInPackage A.Region
74+ | NoEffectsOutsideKernel A.Region
72 | ParseError Module
75 | ParseError Module
@@ -561,10 +564,84 @@ toReport source err =
567+ NoPortsInPackage (A.At region _) ->
568+ Report.Report "PACKAGES CANNOT HAVE PORTS" region [] $
569+ Code.toSnippet source region Nothing
572+ "Packages cannot declare any ports, so I am getting stuck here:"
576+ "Remove this port declaration."
577+ , noteForPortsInPackage
581+ NoPortModulesInPackage region ->
582+ Report.Report "PACKAGES CANNOT HAVE PORTS" region [] $
583+ Code.toSnippet source region Nothing
586+ "Packages cannot declare any ports, so I am getting stuck here:"
590+ ["Remove","the",D.cyan "port","keyword","and","I"
591+ ,"should","be","able","to","continue."
593+ , noteForPortsInPackage
597+ NoEffectsOutsideKernel region ->
598+ Report.Report "INVALID EFFECT MODULE" region [] $
599+ Code.toSnippet source region Nothing
602+ "It is not possible to declare an `effect module` outside the @elm organization,\
603+ \ so I am getting stuck here:"
607+ "Switch to a normal module declaration."
609+ "Effect modules are designed to allow certain core functionality to be\
610+ \ defined separately from the compiler. So the @elm organization has access to\
611+ \ this so that certain changes, extensions, and fixes can be introduced without\
612+ \ needing to release new Elm binaries. For example, we want to make it possible\
613+ \ to test effects, but this may require changes to the design of effect modules.\
614+ \ By only having them defined in the @elm organization, that kind of design work\
615+ \ can proceed much more smoothly."
564 ParseError modul ->
619 ParseError modul ->
565 toParseErrorReport source modul
620 toParseErrorReport source modul
623+noteForPortsInPackage :: D.Doc
624+noteForPortsInPackage =
627+ "One of the major goals of the package ecosystem is to be completely written\
628+ \ in Elm. This means when you install an Elm package, you can be sure you are safe\
629+ \ from security issues on install and that you are not going to get any runtime\
630+ \ exceptions coming from your new dependency. This design also sets the ecosystem\
631+ \ up to target other platforms more easily (like mobile phones, WebAssembly, etc.)\
632+ \ since no community code explicitly depends on JavaScript even existing."
634+ "Given that overall goal, allowing ports in packages would lead to some pretty\
635+ \ surprising behavior. If ports were allowed in packages, you could install a\
636+ \ package but not realize that it brings in an indirect dependency that defines a\
637+ \ port. Now you have a program that does not work and the fix is to realize that\
638+ \ some JavaScript needs to be added for a dependency you did not even know about.\
639+ \ That would be extremely frustrating! \"So why not allow the package author to\
640+ \ include the necessary JS code as well?\" Now we are back in conflict with our\
641+ \ overall goal to keep all community packages free from runtime exceptions."
568toParseErrorReport :: Code.Source -> Module -> Report.Report
645toParseErrorReport :: Code.Source -> Module -> Report.Report
569toParseErrorReport source modul =
646toParseErrorReport source modul =
570 case modul of
647 case modul of
@@ -572,156 +649,9 @@ toParseErrorReport source modul =
572 toSpaceReport source space row col
649 toSpaceReport source space row col
574 ModuleBadEnd row col ->
651 ModuleBadEnd row col ->
575− case Code.whatIsNext source row col of
652+ if col == 1
576− Code.Keyword keyword ->
653+ then toDeclStartReport source row col
577− let
654+ else toWeirdEndReport source row col
578− region = toKeywordRegion row col keyword
580− Report.Report "RESERVED WORD" region [] $
581− Code.toSnippet source region Nothing
584− "I got stuck on this reserved word:"
587− "The name `" ++ keyword ++ "` is reserved, so try using a different name?"
592− region = toKeywordRegion row col op
594− Report.Report "UNEXPECTED SYMBOL" region [] $
595− Code.toSnippet source region Nothing
598− "I ran into an unexpected symbol:"
601− "I was not expecting to see a " ++ op ++ " here. Try deleting it? Maybe\
602− \ I can give a better hint from there?"
605− Code.Close term bracket ->
607− region = toRegion row col
609− Report.Report ("UNEXPECTED " ++ map Char.toUpper term) region [] $
610− Code.toSnippet source region Nothing
613− "I ran into an unexpected " ++ term ++ ":"
616− "This " ++ bracket : " does not match up with an earlier open " ++ term ++ ". Try deleting it?"
619− Code.Other maybeChar ->
621− region = toRegion row col
625− Report.Report "UNEXPECTED SEMICOLON" region [] $
626− Code.toSnippet source region Nothing
629− "I got stuck on this semicolon:"
632− [ D.reflow $ "Try removing it?"
634− "Some languages require semicolons at the end of each statement. These are\
635− \ often called C-like languages, and they usually share a lot of language design\
636− \ choices. (E.g. side-effects, for loops, etc.) Elm manages effects with commands\
637− \ and subscriptions instead, so there is no special syntax for \"statements\" and\
638− \ therefore no need to use semicolons to separate them. I think this will make\
639− \ more sense as you work through <https://guide.elm-lang.org> though!"
644− Report.Report "UNEXPECTED COMMA" region [] $
645− Code.toSnippet source region Nothing
648− "I got stuck on this comma:"
652− "I do not think I am parsing a list or tuple right now. Try deleting the comma?"
654− "If this is supposed to be part of a list, the problem may be a bit earlier.\
655− \ Perhaps the opening [ is missing? Or perhaps some value in the list has an extra\
656− \ closing ] that is making me think the list ended earlier? The same kinds of\
657− \ things could be going wrong if this is supposed to be a tuple."
662− Report.Report "UNEXPECTED CHARACTER" region [] $
663− Code.toSnippet source region Nothing
666− "I got stuck on this character:"
670− "It is not used for anything in Elm syntax. It is used for multi-line strings in\
671− \ some languages though, so if you want a string that spans multiple lines, you\
672− \ can use Elm's multi-line string syntax like this:"
674− [ D.fillSep [D.green "markdown","=",D.dullyellow "\"\"\""]
676− , D.dullyellow "# Multi-line Strings"
678− , D.dullyellow "- start with triple double quotes"
679− , D.dullyellow "- write whatever you want"
680− , D.dullyellow "- no need to escape newlines or double quotes"
681− , D.dullyellow "- end with triple double quotes"
683− , D.dullyellow "\"\"\""
686− "Otherwise I do not know what is going on! Try removing the character?"
691− Report.Report "UNEXPECTED SYMBOL" region [] $
692− Code.toSnippet source region Nothing
695− "I got stuck on this dollar sign:"
698− "It is not used for anything in Elm syntax. Are you coming from a language where\
699− \ dollar signs can be used in variable names? If so, try a name that (1) starts\
700− \ with a letter and (2) only contains letters, numbers, and underscores."
703− Just c | elem c ['#','@','!','%','~'] ->
704− Report.Report "UNEXPECTED SYMBOL" region [] $
705− Code.toSnippet source region Nothing
708− "I got stuck on this symbol:"
711− "It is not used for anything in Elm syntax. Try removing it?"
715− Report.Report "SYNTAX PROBLEM" region [] $
716− Code.toSnippet source region Nothing
722− "Whatever I am running into is confusing me a lot! Normally I can give fairly\
723− \ specific hints, but something is really tripping me up this time."
726 ModuleProblem row col ->
656 ModuleProblem row col ->
@@ -867,11 +797,11 @@ toParseErrorReport source modul =
867 [ D.reflow $
797 [ D.reflow $
868 "I am not sure what is going on, but I recommend starting an Elm\
798 "I am not sure what is going on, but I recommend starting an Elm\
869 \ file with the following lines:"
799 \ file with the following lines:"
870− , D.vcat
800+ , D.indent 4 $ D.vcat $
871 [ D.fillSep [D.cyan "import","Html"]
801 [ D.fillSep [D.cyan "import","Html"]
873− , D.fillSep [D.green "main","="]
803+ , "main ="
874− , D.indent 2 $ D.fillSep [D.cyan "Html" <> ".text",D.dullyellow "\"Hello!\""]
804+ , " Html.text " <> D.dullyellow "\"Hello!\""
876 , D.reflow $
806 , D.reflow $
877 "You should be able to copy those lines directly into your file. Check out the\
807 "You should be able to copy those lines directly into your file. Check out the\
@@ -900,11 +830,12 @@ toParseErrorReport source modul =
900 , D.indent 4 $ D.vcat $
830 , D.indent 4 $ D.vcat $
901 [ D.fillSep [D.cyan "import","Dict"]
831 [ D.fillSep [D.cyan "import","Dict"]
902 , D.fillSep [D.cyan "import","Maybe"]
832 , D.fillSep [D.cyan "import","Maybe"]
903− , D.fillSep [D.cyan "import","Html.Attributes"]
833+ , D.fillSep [D.cyan "import","Html.Attributes",D.cyan "as","A"]
904− , D.fillSep [D.cyan "import","Json.Decode"]
834+ , D.fillSep [D.cyan "import","Json.Decode",D.cyan "exposing","(..)"]
906 , D.reflow $
836 , D.reflow $
907 "Notice that the module names all start with capital letters. That is required!"
837 "Notice that the module names all start with capital letters. That is required!"
838+ , D.reflowLink "Read" "imports" "to learn more."
@@ -931,6 +862,7 @@ toParseErrorReport source modul =
932 , D.reflow $
863 , D.reflow $
933 "Notice that the alias always starts with a capital letter. That is required!"
864 "Notice that the alias always starts with a capital letter. That is required!"
865+ , D.reflowLink "Read" "imports" "to learn more."
@@ -993,6 +925,192 @@ toParseErrorReport source modul =
931+toWeirdEndReport :: Code.Source -> Row -> Col -> Report.Report
932+toWeirdEndReport source row col =
933+ case Code.whatIsNext source row col of
934+ Code.Keyword keyword ->
936+ region = toKeywordRegion row col keyword
938+ Report.Report "RESERVED WORD" region [] $
939+ Code.toSnippet source region Nothing
942+ "I got stuck on this reserved word:"
945+ "The name `" ++ keyword ++ "` is reserved, so try using a different name?"
950+ region = toKeywordRegion row col op
952+ Report.Report "UNEXPECTED SYMBOL" region [] $
953+ Code.toSnippet source region Nothing
956+ "I ran into an unexpected symbol:"
959+ "I was not expecting to see a " ++ op ++ " here. Try deleting it? Maybe\
960+ \ I can give a better hint from there?"
963+ Code.Close term bracket ->
965+ region = toRegion row col
967+ Report.Report ("UNEXPECTED " ++ map Char.toUpper term) region [] $
968+ Code.toSnippet source region Nothing
971+ "I ran into an unexpected " ++ term ++ ":"
974+ "This " ++ bracket : " does not match up with an earlier open " ++ term ++ ". Try deleting it?"
979+ region = toKeywordRegion row col (c:cs)
981+ Report.Report "UNEXPECTED NAME" region [] $
982+ Code.toSnippet source region Nothing
985+ "I got stuck on this name:"
988+ "It is confusing me a lot! Normally I can give fairly specific hints, but\
989+ \ something is really tripping me up this time."
994+ region = toKeywordRegion row col (c:cs)
996+ Report.Report "UNEXPECTED NAME" region [] $
997+ Code.toSnippet source region Nothing
1000+ "I got stuck on this name:"
1003+ "It is confusing me a lot! Normally I can give fairly specific hints, but\
1004+ \ something is really tripping me up this time."
1007+ Code.Other maybeChar ->
1009+ region = toRegion row col
1013+ Report.Report "UNEXPECTED SEMICOLON" region [] $
1014+ Code.toSnippet source region Nothing
1017+ "I got stuck on this semicolon:"
1020+ [ D.reflow $ "Try removing it?"
1022+ "Some languages require semicolons at the end of each statement. These are\
1023+ \ often called C-like languages, and they usually share a lot of language design\
1024+ \ choices. (E.g. side-effects, for loops, etc.) Elm manages effects with commands\
1025+ \ and subscriptions instead, so there is no special syntax for \"statements\" and\
1026+ \ therefore no need to use semicolons to separate them. I think this will make\
1027+ \ more sense as you work through <https://guide.elm-lang.org> though!"
1032+ Report.Report "UNEXPECTED COMMA" region [] $
1033+ Code.toSnippet source region Nothing
1036+ "I got stuck on this comma:"
1040+ "I do not think I am parsing a list or tuple right now. Try deleting the comma?"
1042+ "If this is supposed to be part of a list, the problem may be a bit earlier.\
1043+ \ Perhaps the opening [ is missing? Or perhaps some value in the list has an extra\
1044+ \ closing ] that is making me think the list ended earlier? The same kinds of\
1045+ \ things could be going wrong if this is supposed to be a tuple."
1050+ Report.Report "UNEXPECTED CHARACTER" region [] $
1051+ Code.toSnippet source region Nothing
1054+ "I got stuck on this character:"
1058+ "It is not used for anything in Elm syntax. It is used for multi-line strings in\
1059+ \ some languages though, so if you want a string that spans multiple lines, you\
1060+ \ can use Elm's multi-line string syntax like this:"
1061+ , D.dullyellow $ D.indent 4 $ D.vcat $
1063+ , "# Multi-line Strings"
1065+ , "- start with triple double quotes"
1066+ , "- write whatever you want"
1067+ , "- no need to escape newlines or double quotes"
1068+ , "- end with triple double quotes"
1072+ "Otherwise I do not know what is going on! Try removing the character?"
1077+ Report.Report "UNEXPECTED SYMBOL" region [] $
1078+ Code.toSnippet source region Nothing
1081+ "I got stuck on this dollar sign:"
1084+ "It is not used for anything in Elm syntax. Are you coming from a language where\
1085+ \ dollar signs can be used in variable names? If so, try a name that (1) starts\
1086+ \ with a letter and (2) only contains letters, numbers, and underscores."
1089+ Just c | elem c ['#','@','!','%','~'] ->
1090+ Report.Report "UNEXPECTED SYMBOL" region [] $
1091+ Code.toSnippet source region Nothing
1094+ "I got stuck on this symbol:"
1097+ "It is not used for anything in Elm syntax. Try removing it?"
1101+ Report.Report "SYNTAX PROBLEM" region [] $
1102+ Code.toSnippet source region Nothing
1105+ "I got stuck here:"
1108+ "Whatever I am running into is confusing me a lot! Normally I can give fairly\
1109+ \ specific hints, but something is really tripping me up this time."
996-- IMPORTS
1114-- IMPORTS
@@ -1018,6 +1136,7 @@ toImportReport source row col =
1019 , D.reflow $
1137 , D.reflow $
1020 "You are probably trying to import a different module, but try to make it look like one of these examples!"
1138 "You are probably trying to import a different module, but try to make it look like one of these examples!"
1139+ , D.reflowLink "Read" "imports" "to learn more."
@@ -1324,106 +1443,7 @@ toDeclarationsReport :: Code.Source -> Decl -> Report.Report
1324toDeclarationsReport source decl =
1443toDeclarationsReport source decl =
1325 case decl of
1444 case decl of
1326 DeclStart row col ->
1445 DeclStart row col ->
1327− case Code.whatIsNext source row col of
1446+ toDeclStartReport source row col
1328− Code.Close term bracket ->
1330− region = toRegion row col
1332− Report.Report ("STRAY " ++ map Char.toUpper term) region [] $
1333− Code.toSnippet source region Nothing
1336− "I was not expecting to see a " ++ term ++ " here:"
1338− "This " ++ bracket : " does not match up with an earlier open " ++ term ++ ". Try deleting it?"
1341− Code.Keyword keyword ->
1343− region = toKeywordRegion row col keyword
1345− Report.Report "RESERVED WORD" region [] $
1346− Code.toSnippet source region Nothing
1349− "I was not expecting to run into the `" ++ keyword ++ "` keyword here:"
1354− "It is reserved for declaring imports at the top of your module. If you want\
1355− \ another import, try moving it up top with the other imports. If you want to\
1356− \ define a value or function, try changing the name to something else!"
1361− "It is reserved for writing `case` expressions. Try using a different name?"
1363− "If you are trying to write a `case` expression, it needs to be part of a\
1364− \ definition. So you could write something like this instead:"
1366− [ D.indent 0 $ D.fillSep [D.green "getWidth","maybeWidth","="]
1367− , D.indent 2 $ D.fillSep [D.cyan "case","maybeWidth",D.cyan "of"]
1368− , D.indent 4 $ D.fillSep [D.blue "Just","width","->"]
1369− , D.indent 6 $ D.fillSep ["width","+",D.dullyellow "200"]
1371− , D.indent 4 $ D.fillSep [D.blue "Nothing","->"]
1372− , D.indent 6 $ D.fillSep [D.dullyellow "400"]
1375− "This defines a `getWidth` function that we can use elsewhere in our program."
1381− "It is reserved for writing `if` expressions. Try using a different name?"
1383− "If you are trying to write an `if` expression, it needs to be part of a\
1384− \ definition. So you could write something like this instead:"
1386− [ D.indent 0 $ D.fillSep [D.green "reviewPowerLevel","powerLevel","="]
1387− , D.indent 2 $ D.fillSep $
1388− [D.cyan "if","powerLevel",">",D.dullyellow "9000"
1389− ,D.cyan "then",D.dullyellow "\"OVER 9000!!!\""
1390− ,D.cyan "else",D.dullyellow "\"not bad\""
1394− "This defines a `reviewPowerLevel` function that we can use elsewhere in our program."
1399− "It is a reserved word. Try changing the name to something else?"
1404− region = toRegion row col
1406− Report.Report "SYNTAX PROBLEM" region [] $
1407− Code.toSnippet source region Nothing
1410− "I was expecting to see a new declaration here:"
1414− "I am not sure what is going wrong exactly, but here are a couple valid\
1415− \ declarations for reference:"
1417− [ D.fillSep [D.green "add",":","Int","->","Int","->","Int"]
1418− , D.fillSep [D.green "add","x","y","="]
1419− , D.fillSep [" ","x","+","y"]
1421− , D.fillSep [D.cyan "type",D.green "User","=","Anonymous","|","LoggedIn String"]
1423− "Note that all declarations start with lower-case letters in Elm. Capitalization\
1424− \ makes a difference, so be conscious of that if you are working from examples!"
1428 DeclSpace space row col ->
1448 DeclSpace space row col ->
1429 toSpaceReport source space row col
1449 toSpaceReport source space row col
@@ -1453,6 +1473,165 @@ toDeclarationsReport source decl =
1476+toDeclStartReport :: Code.Source -> Row -> Col -> Report.Report
1477+toDeclStartReport source row col =
1478+ case Code.whatIsNext source row col of
1479+ Code.Close term bracket ->
1481+ region = toRegion row col
1483+ Report.Report ("STRAY " ++ map Char.toUpper term) region [] $
1484+ Code.toSnippet source region Nothing
1487+ "I was not expecting to see a " ++ term ++ " here:"
1489+ "This " ++ bracket : " does not match up with an earlier open " ++ term ++ ". Try deleting it?"
1492+ Code.Keyword keyword ->
1494+ region = toKeywordRegion row col keyword
1496+ Report.Report "RESERVED WORD" region [] $
1497+ Code.toSnippet source region Nothing
1500+ "I was not expecting to run into the `" ++ keyword ++ "` keyword here:"
1505+ "It is reserved for declaring imports at the top of your module. If you want\
1506+ \ another import, try moving it up top with the other imports. If you want to\
1507+ \ define a value or function, try changing the name to something else!"
1512+ "It is reserved for writing `case` expressions. Try using a different name?"
1514+ "If you are trying to write a `case` expression, it needs to be part of a\
1515+ \ definition. So you could write something like this instead:"
1516+ , D.indent 4 $ D.vcat $
1517+ [ D.indent 0 $ D.fillSep ["getWidth","maybeWidth","="]
1518+ , D.indent 2 $ D.fillSep [D.cyan "case","maybeWidth",D.cyan "of"]
1519+ , D.indent 4 $ D.fillSep [D.blue "Just","width","->"]
1520+ , D.indent 6 $ D.fillSep ["width","+",D.dullyellow "200"]
1522+ , D.indent 4 $ D.fillSep [D.blue "Nothing","->"]
1523+ , D.indent 6 $ D.fillSep [D.dullyellow "400"]
1526+ "This defines a `getWidth` function that you can use elsewhere in your program."
1532+ "It is reserved for writing `if` expressions. Try using a different name?"
1534+ "If you are trying to write an `if` expression, it needs to be part of a\
1535+ \ definition. So you could write something like this instead:"
1536+ , D.indent 4 $ D.vcat $
1540+ ,D.cyan "if","name","==",D.dullyellow "\"Abraham Lincoln\""
1541+ ,D.cyan "then",D.dullyellow "\"Greetings Mr. President.\""
1542+ ,D.cyan "else",D.dullyellow "\"Hey!\""
1546+ "This defines a `reviewPowerLevel` function that you can use elsewhere in your program."
1551+ "It is a reserved word. Try changing the name to something else?"
1556+ region = toRegion row col
1558+ Report.Report "UNEXPECTED CAPITAL LETTER" region [] $
1559+ Code.toSnippet source region Nothing
1562+ "Declarations always start with a lower-case letter, so I am getting stuck here:"
1566+ ["Try","a","name","like"
1567+ ,D.green (D.fromChars (Char.toLower c : cs))
1571+ "Here are a couple valid declarations for reference:"
1572+ , D.indent 4 $ D.vcat $
1573+ [ "greet : String -> String"
1575+ , " " <> D.dullyellow "\"Hello \"" <> " ++ name ++ " <> D.dullyellow "\"!\""
1577+ , D.cyan "type" <> " User = Anonymous | LoggedIn String"
1580+ "Notice that they always start with a lower-case letter. Capitalization matters!"
1584+ Code.Other (Just char) | elem char ['(', '{', '[', '+', '-', '*', '/', '^', '&', '|', '"', '\'', '!', '@', '#', '$', '%'] ->
1586+ region = toRegion row col
1588+ Report.Report "UNEXPECTED SYMBOL" region [] $
1589+ Code.toSnippet source region Nothing
1592+ "I am getting stuck because this line starts with the " ++ [char] ++ " symbol:"
1596+ "When a line has no spaces at the beginning, I expect it to be a declaration like one of these:"
1597+ , D.indent 4 $ D.vcat $
1598+ [ "greet : String -> String"
1600+ , " " <> D.dullyellow "\"Hello \"" <> " ++ name ++ " <> D.dullyellow "\"!\""
1602+ , D.cyan "type" <> " User = Anonymous | LoggedIn String"
1605+ "If this is not supposed to be a declaration, try adding some spaces before it?"
1611+ region = toRegion row col
1613+ Report.Report "WEIRD DECLARATION" region [] $
1614+ Code.toSnippet source region Nothing
1617+ "I am trying to parse a declaration, but I am getting stuck here:"
1621+ "When a line has no spaces at the beginning, I expect it to be a declaration like one of these:"
1622+ , D.indent 4 $ D.vcat $
1623+ [ "greet : String -> String"
1625+ , " " <> D.dullyellow "\"Hello \"" <> " ++ name ++ " <> D.dullyellow "\"!\""
1627+ , D.cyan "type" <> " User = Anonymous | LoggedIn String"
1630+ "Try to make your declaration look like one of those? Or if this is not\
1631+ \ supposed to be a declaration, try adding some spaces before it?"
@@ -1579,7 +1758,7 @@ toPortReport source port_ startRow startCol =
1579 [ D.reflow $
1758 [ D.reflow $
1580 "I was expecting to see a type next. Here are examples of outgoing and\
1759 "I was expecting to see a type next. Here are examples of outgoing and\
1581 \ incoming ports for reference:"
1760 \ incoming ports for reference:"
1582− , D.vcat
1761+ , D.indent 4 $ D.vcat $
1583 [ D.fillSep [D.cyan "port","send",":","String -> Cmd msg"]
1762 [ D.fillSep [D.cyan "port","send",":","String -> Cmd msg"]
1584 , D.fillSep [D.cyan "port","receive",":","(String -> msg) -> Sub msg"]
1763 , D.fillSep [D.cyan "port","receive",":","(String -> msg) -> Sub msg"]
@@ -1598,7 +1777,7 @@ portNote =
1599 [ D.toSimpleNote $
1778 [ D.toSimpleNote $
1600 "Here are some example `port` declarations for reference:"
1779 "Here are some example `port` declarations for reference:"
1601− , D.vcat
1780+ , D.indent 4 $ D.vcat $
1602 [ D.fillSep [D.cyan "port","send",":","String -> Cmd msg"]
1781 [ D.fillSep [D.cyan "port","send",":","String -> Cmd msg"]
1603 , D.fillSep [D.cyan "port","receive",":","(String -> msg) -> Sub msg"]
1782 , D.fillSep [D.cyan "port","receive",":","(String -> msg) -> Sub msg"]
@@ -1781,8 +1960,8 @@ typeAliasNote =
1781 [ D.toSimpleNote $
1960 [ D.toSimpleNote $
1782 "Here is an example of a valid `type alias` for reference:"
1961 "Here is an example of a valid `type alias` for reference:"
1783 , D.vcat $
1962 , D.vcat $
1784− [ D.indent 0 $ D.fillSep [D.cyan "type",D.cyan "alias",D.green "Person","="]
1963+ [ D.indent 4 $ D.fillSep [D.cyan "type",D.cyan "alias","Person","="]
1785− , D.indent 2 $ D.vcat $
1964+ , D.indent 6 $ D.vcat $
1786 ["{ name : String"
1965 ["{ name : String"
1787 ,", age : Int"
1966 ,", age : Int"
1788 ,", height : Float"
1967 ,", height : Float"
@@ -1982,10 +2161,10 @@ customTypeNote =
1982 [ D.toSimpleNote $
2161 [ D.toSimpleNote $
1983 "Here is an example of a valid `type` declaration for reference:"
2162 "Here is an example of a valid `type` declaration for reference:"
1984 , D.vcat $
2163 , D.vcat $
1985− [ D.indent 0 $ D.fillSep [D.cyan "type",D.green "Status"]
2164+ [ D.indent 4 $ D.fillSep [D.cyan "type","Status"]
1986− , D.indent 2 $ D.fillSep ["=","Failure"]
2165+ , D.indent 6 $ D.fillSep ["=","Failure"]
1987− , D.indent 2 $ D.fillSep ["|","Waiting"]
2166+ , D.indent 6 $ D.fillSep ["|","Waiting"]
1988− , D.indent 2 $ D.fillSep ["|","Success","String"]
2167+ , D.indent 6 $ D.fillSep ["|","Success","String"]
1990 , D.reflow $
2169 , D.reflow $
1991 "This defines a new `Status` type with three variants. This could be useful if\
2170 "This defines a new `Status` type with three variants. This could be useful if\
@@ -2057,10 +2236,10 @@ toDeclDefReport source name declDef startRow startCol =
2057 ,"a","type","annotation.","It","could","be","something","else","though,","so"
2236 ,"a","type","annotation.","It","could","be","something","else","though,","so"
2058 ,"here","is","a","valid","definition","for","reference:"
2237 ,"here","is","a","valid","definition","for","reference:"
2060− , D.vcat
2239+ , D.indent 4 $ D.vcat $
2061− [ D.fillSep [D.green "add",":","Int","->","Int","->","Int"]
2240+ [ "greet : String -> String"
2062− , D.fillSep [D.green "add","x","y","="]
2241+ , "greet name ="
2063− , D.fillSep [" ","x","+","y"]
2242+ , " " <> D.dullyellow "\"Hello \"" <> " ++ name ++ " <> D.dullyellow "\"!\""
2065 , D.reflow $
2244 , D.reflow $
2066 "Try to use that format with your `" ++ Name.toChars name ++ "` definition!"
2245 "Try to use that format with your `" ++ Name.toChars name ++ "` definition!"
@@ -2082,10 +2261,10 @@ toDeclDefReport source name declDef startRow startCol =
2082 [ D.reflow $
2261 [ D.reflow $
2083 "I am not sure what is going wrong exactly, so here is a valid\
2262 "I am not sure what is going wrong exactly, so here is a valid\
2084 \ definition (with an optional type annotation) for reference:"
2263 \ definition (with an optional type annotation) for reference:"
2085− , D.vcat
2264+ , D.indent 4 $ D.vcat $
2086− [ D.fillSep [D.green "add",":","Int","->","Int","->","Int"]
2265+ [ "greet : String -> String"
2087− , D.fillSep [D.green "add","x","y","="]
2266+ , "greet name ="
2088− , D.fillSep [" ","x","+","y"]
2267+ , " " <> D.dullyellow "\"Hello \"" <> " ++ name ++ " <> D.dullyellow "\"!\""
2090 , D.reflow $
2269 , D.reflow $
2091 "Try to use that format with your `" ++ Name.toChars name ++ "` definition!"
2270 "Try to use that format with your `" ++ Name.toChars name ++ "` definition!"
@@ -2107,10 +2286,10 @@ toDeclDefReport source name declDef startRow startCol =
2107 [ D.reflow $
2286 [ D.reflow $
2108 "I am not sure what is going wrong exactly, so here is a valid\
2287 "I am not sure what is going wrong exactly, so here is a valid\
2109 \ definition (with an optional type annotation) for reference:"
2288 \ definition (with an optional type annotation) for reference:"
2110− , D.vcat
2289+ , D.indent 4 $ D.vcat $
2111− [ D.fillSep [D.green "add",":","Int","->","Int","->","Int"]
2290+ [ "greet : String -> String"
2112− , D.fillSep [D.green "add","x","y","="]
2291+ , "greet name ="
2113− , D.fillSep [" ","x","+","y"]
2292+ , " " <> D.dullyellow "\"Hello \"" <> " ++ name ++ " <> D.dullyellow "\"!\""
2115 , D.reflow $
2294 , D.reflow $
2116 "Try to use that format!"
2295 "Try to use that format!"
@@ -2225,10 +2404,10 @@ declDefNote =
2226 [ D.reflow $
2405 [ D.reflow $
2227 "Here is a valid definition (with a type annotation) for reference:"
2406 "Here is a valid definition (with a type annotation) for reference:"
2228− , D.vcat
2407+ , D.indent 4 $ D.vcat $
2229− [ D.fillSep [D.green "add",":","Int","->","Int","->","Int"]
2408+ [ "greet : String -> String"
2230− , D.fillSep [D.green "add","x","y","="]
2409+ , "greet name ="
2231− , D.fillSep [" ","x","+","y"]
2410+ , " " <> D.dullyellow "\"Hello \"" <> " ++ name ++ " <> D.dullyellow "\"!\""
2233 , D.reflow $
2412 , D.reflow $
2234 "The top line (called a \"type annotation\") is optional. You can leave it off\
2413 "The top line (called a \"type annotation\") is optional. You can leave it off\
@@ -2340,25 +2519,40 @@ toExprReport source context expr startRow startCol =
2342 OperatorRight op row col ->
2521 OperatorRight op row col ->
2523+ surroundings = A.Region (A.Position startRow startCol) (A.Position row col)
2343− let region = toRegion row col in
2524+ region = toRegion row col
2525+ isMath = elem op ["-","+","*","/","^"]
2344 Report.Report "MISSING EXPRESSION" region [] $
2527 Report.Report "MISSING EXPRESSION" region [] $
2345− Code.toSnippet source region Nothing
2528+ Code.toSnippet source surroundings (Just region)
2347 D.reflow $
2530 D.reflow $
2348− "I was expecting to see an expression after this " ++ Name.toChars op ++ " operator:"
2531+ "I just saw a " ++ Name.toChars op ++ " "
2532+ ++ (if isMath then "sign" else "operator")
2533+ ++ ", so I am getting stuck here:"
2350− D.stack
2535+ if isMath then
2351− [ D.fillSep $
2536+ D.fillSep
2352− ["You","can","just","put","anything","for","now,","like"
2537+ ["I","was","expecting","to","see","an","expression","next."
2353− ,D.dullyellow "42","or",D.dullyellow"\"hello\"" <> "."
2538+ ,"Something","like",D.dullyellow "42","or",D.dullyellow "1000"
2354− ,"Once","there","is","something","there,","I","can","probably"
2539+ ,"that","makes","sense","with","a",D.fromName op,"sign."
2355− ,"give","a","more","specific","hint!"
2540+ ]
2541+ else if op == "&&" || op == "||" then
2543+ ["I","was","expecting","to","see","an","expression","next."
2544+ ,"Something","like",D.dullyellow "True","or",D.dullyellow "False"
2545+ ,"that","makes","sense","with","boolean","logic."
2357− , D.toSimpleNote $
2547+ else if op == "|>" then
2358− "This can also happen if run into reserved words like `let` or `as` unexpectedly.\
2548+ D.reflow $
2359− \ Or if I run into operators in unexpected spots. Point is, there are a\
2549+ "I was expecting to see a function next."
2360− \ couple ways I can get confused and give sort of weird advice!"
2550+ else if op == "<|" then
2552+ "I was expecting to see an argument next."
2555+ "I was expecting to see an expression next."
2364 OperatorReserved operator row col ->
2558 OperatorReserved operator row col ->
@@ -2397,7 +2591,7 @@ toExprReport source context expr startRow startCol =
2397 ,"give","a","more","specific","hint!"
2591 ,"give","a","more","specific","hint!"
2399 , D.toSimpleNote $
2593 , D.toSimpleNote $
2400− "This can also happen if run into reserved words like `let` or `as` unexpectedly.\
2594+ "This can also happen if I run into reserved words like `let` or `as` unexpectedly.\
2401 \ Or if I run into operators in unexpected spots. Point is, there are a\
2595 \ Or if I run into operators in unexpected spots. Point is, there are a\
2402 \ couple ways I can get confused and give sort of weird advice!"
2596 \ couple ways I can get confused and give sort of weird advice!"
@@ -2546,17 +2740,15 @@ toStringReport source string row col =
2546 , D.toSimpleNote $
2740 , D.toSimpleNote $
2547 "For a string that spans multiple lines, you can use the multi-line string\
2741 "For a string that spans multiple lines, you can use the multi-line string\
2548 \ syntax like this:"
2742 \ syntax like this:"
2549− , D.vcat
2743+ , D.dullyellow $ D.indent 4 $ D.vcat $
2550− [ D.fillSep [D.green "markdown","=",D.dullyellow "\"\"\""]
2744+ [ "\"\"\""
2552− , D.dullyellow "# Multi-line Strings"
2745+ , "# Multi-line Strings"
2554− , D.dullyellow "- start with triple double quotes"
2747+ , "- start with triple double quotes"
2555− , D.dullyellow "- write whatever you want"
2748+ , "- write whatever you want"
2556− , D.dullyellow "- no need to escape newlines or double quotes"
2749+ , "- no need to escape newlines or double quotes"
2557− , D.dullyellow "- end with triple double quotes"
2750+ , "- end with triple double quotes"
2559− , D.dullyellow "\"\"\""
2751+ , "\"\"\""
@@ -2575,17 +2767,15 @@ toStringReport source string row col =
2575 [ D.reflow "Add a \"\"\" somewhere after this to end the string."
2767 [ D.reflow "Add a \"\"\" somewhere after this to end the string."
2576 , D.toSimpleNote $
2768 , D.toSimpleNote $
2577 "Here is a valid multi-line string for reference:"
2769 "Here is a valid multi-line string for reference:"
2578− , D.vcat
2770+ , D.dullyellow $ D.indent 4 $ D.vcat $
2579− [ D.fillSep [D.green "markdown","=",D.dullyellow "\"\"\""]
2771+ [ "\"\"\""
2581− , D.dullyellow "# Multi-line Strings"
2772+ , "# Multi-line Strings"
2583− , D.dullyellow "- start with triple double quotes"
2774+ , "- start with triple double quotes"
2584− , D.dullyellow "- write whatever you want"
2775+ , "- write whatever you want"
2585− , D.dullyellow "- no need to escape newlines or double quotes"
2776+ , "- no need to escape newlines or double quotes"
2586− , D.dullyellow "- end with triple double quotes"
2777+ , "- end with triple double quotes"
2588− , D.dullyellow "\"\"\""
2778+ , "\"\"\""
@@ -2845,11 +3035,15 @@ toOperatorReport source context operator row col =
2847 D.reflow $
3037 D.reflow $
2848− "I was not expecting an arrow here:"
3038+ "I was partway through parsing an expression when I got stuck on this arrow:"
2850− D.reflow $
3040+ D.stack
2851− "Arrows should only appear in `case` expressions and anonymous functions. Maybe\
3041+ [ "Arrows should only appear in `case` expressions and anonymous functions.\n\
2852− \ you want > or >= instead?"
3042+ \Maybe it was supposed to be a > sign instead?"
3044+ "The syntax for anonymous functions is (\\x -> x + 1) so the arguments all appear\
3045+ \ after the backslash and before the arrow. Maybe a backslash is missing earlier?"
2855 BadEquals ->
3049 BadEquals ->
@@ -3046,8 +3240,8 @@ toUnfinishLetReport source row col startRow startCol message =
3046 [ message
3240 [ message
3047 , D.toSimpleNote $
3241 , D.toSimpleNote $
3048 "Here is an example with a valid `let` expression for reference:"
3242 "Here is an example with a valid `let` expression for reference:"
3049− , D.vcat $
3243+ , D.indent 4 $ D.vcat $
3050− [ D.indent 0 $ D.fillSep [D.green "viewPerson","person","="]
3244+ [ D.indent 0 $ D.fillSep ["viewPerson","person","="]
3051 , D.indent 2 $ D.fillSep [D.cyan "let"]
3245 , D.indent 2 $ D.fillSep [D.cyan "let"]
3052 , D.indent 4 $ D.fillSep ["fullName","="]
3246 , D.indent 4 $ D.fillSep ["fullName","="]
3053 , D.indent 6 $ D.fillSep ["person.firstName","++",D.dullyellow "\" \"","++","person.lastName"]
3247 , D.indent 6 $ D.fillSep ["person.firstName","++",D.dullyellow "\" \"","++","person.lastName"]
@@ -3165,10 +3359,10 @@ toLetDefReport source name def startRow startCol =
3165 ,"a","type","annotation.","It","could","be","something","else","though,","so"
3359 ,"a","type","annotation.","It","could","be","something","else","though,","so"
3166 ,"here","is","a","valid","definition","for","reference:"
3360 ,"here","is","a","valid","definition","for","reference:"
3168− , D.vcat
3362+ , D.indent 4 $ D.vcat $
3169− [ D.indent 4 $ D.fillSep [D.green "add",":","Int","->","Int","->","Int"]
3363+ [ "greet : String -> String"
3170− , D.indent 4 $ D.fillSep [D.green "add","x","y","="]
3364+ , "greet name ="
3171− , D.indent 6 $ D.fillSep ["x","+","y"]
3365+ , " " <> D.dullyellow "\"Hello \"" <> " ++ name ++ " <> D.dullyellow "\"!\""
3173 , D.reflow $
3367 , D.reflow $
3174 "Try to use that format with your `" ++ Name.toChars name ++ "` definition!"
3368 "Try to use that format with your `" ++ Name.toChars name ++ "` definition!"
@@ -3190,10 +3384,10 @@ toLetDefReport source name def startRow startCol =
3190 [ D.reflow $
3384 [ D.reflow $
3191 "I am not sure what is going wrong exactly, so here is a valid\
3385 "I am not sure what is going wrong exactly, so here is a valid\
3192 \ definition (with an optional type annotation) for reference:"
3386 \ definition (with an optional type annotation) for reference:"
3193− , D.vcat
3387+ , D.indent 4 $ D.vcat $
3194− [ D.indent 4 $ D.fillSep [D.green "add",":","Int","->","Int","->","Int"]
3388+ [ "greet : String -> String"
3195− , D.indent 4 $ D.fillSep [D.green "add","x","y","="]
3389+ , "greet name ="
3196− , D.indent 6 $ D.fillSep ["x","+","y"]
3390+ , " " <> D.dullyellow "\"Hello \"" <> " ++ name ++ " <> D.dullyellow "\"!\""
3198 , D.reflow $
3392 , D.reflow $
3199 "Try to use that format with your `" ++ Name.toChars name ++ "` definition!"
3393 "Try to use that format with your `" ++ Name.toChars name ++ "` definition!"
@@ -3215,10 +3409,10 @@ toLetDefReport source name def startRow startCol =
3215 [ D.reflow $
3409 [ D.reflow $
3216 "I am not sure what is going wrong exactly, so here is a valid\
3410 "I am not sure what is going wrong exactly, so here is a valid\
3217 \ definition (with an optional type annotation) for reference:"
3411 \ definition (with an optional type annotation) for reference:"
3218− , D.vcat
3412+ , D.indent 4 $ D.vcat $
3219− [ D.indent 4 $ D.fillSep [D.green "add",":","Int","->","Int","->","Int"]
3413+ [ "greet : String -> String"
3220− , D.indent 4 $ D.fillSep [D.green "add","x","y","="]
3414+ , "greet name ="
3221− , D.indent 4 $ D.fillSep ["x","+","y"]
3415+ , " " <> D.dullyellow "\"Hello \"" <> " ++ name ++ " <> D.dullyellow "\"!\""
3223 , D.reflow $
3417 , D.reflow $
3224 "Try to use that format!"
3418 "Try to use that format!"
@@ -3308,10 +3502,10 @@ defNote =
3309 [ D.reflow $
3503 [ D.reflow $
3310 "Here is a valid definition (with a type annotation) for reference:"
3504 "Here is a valid definition (with a type annotation) for reference:"
3311− , D.vcat
3505+ , D.indent 4 $ D.vcat $
3312− [ D.indent 4 $ D.fillSep [D.green "add",":","Int","->","Int","->","Int"]
3506+ [ "greet : String -> String"
3313− , D.indent 4 $ D.fillSep [D.green "add","x","y","="]
3507+ , "greet name ="
3314− , D.indent 6 $ D.fillSep ["x","+","y"]
3508+ , " " <> D.dullyellow "\"Hello \"" <> " ++ name ++ " <> D.dullyellow "\"!\""
3316 , D.reflow $
3510 , D.reflow $
3317 "The top line (called a \"type annotation\") is optional. You can leave it off\
3511 "The top line (called a \"type annotation\") is optional. You can leave it off\
@@ -3724,23 +3918,43 @@ toIfReport source context if_ startRow startCol =
3726 IfIndentElse row col ->
3920 IfIndentElse row col ->
3921+ case Code.nextLineStartsWithKeyword "else" source row of
3922+ Just (elseRow, elseCol) ->
3924+ surroundings = A.Region (A.Position startRow startCol) (A.Position elseRow elseCol)
3925+ region = toWiderRegion elseRow elseCol 4
3927+ Report.Report "WEIRD ELSE BRANCH" region [] $
3928+ Code.toSnippet source surroundings (Just region)
3931+ "I was partway through an `if` expression when I got stuck here:"
3934+ ["I","think","this",D.cyan "else","keyword","needs","to","be","indented","more."
3935+ ,"Try","adding","some","spaces","before","it."
3728− surroundings = A.Region (A.Position startRow startCol) (A.Position row col)
3941+ surroundings = A.Region (A.Position startRow startCol) (A.Position row col)
3729− region = toRegion row col
3942+ region = toRegion row col
3731− Report.Report "UNFINISHED IF" region [] $
3944+ Report.Report "UNFINISHED IF" region [] $
3732− Code.toSnippet source surroundings (Just region)
3945+ Code.toSnippet source surroundings (Just region)
3734− D.reflow $
3947+ D.reflow $
3735− "I was expecting to see an `else` branch after this:"
3948+ "I was expecting to see an `else` branch after this:"
3737− D.stack
3950+ D.stack
3738− [ D.reflow $
3951+ [ D.fillSep
3739− "I know what to do when the condition is `True`, but not when it is `False`."
3952+ ["I","know","what","to","do","when","the","condition","is","True,"
3740− , D.fillSep
3953+ ,"but","what","happens","when","it","is","False?"
3741− ["Add","an",D.cyan "else","branch","to","handle","that","scenario!"]
3954+ ,"Add","an",D.cyan "else","branch","to","handle","that","scenario!"
@@ -3773,15 +3987,22 @@ toRecordReport source context record startRow startCol =
3773 surroundings = A.Region (A.Position startRow startCol) (A.Position row col)
3987 surroundings = A.Region (A.Position startRow startCol) (A.Position row col)
3774 region = toRegion row col
3988 region = toRegion row col
3776− Report.Report "UNFINISHED RECORD" region [] $
3990+ Report.Report "PROBLEM IN RECORD" region [] $
3777 Code.toSnippet source surroundings (Just region)
3991 Code.toSnippet source surroundings (Just region)
3779 D.reflow $
3993 D.reflow $
3780 "I just started parsing a record, but I got stuck here:"
3994 "I just started parsing a record, but I got stuck here:"
3782− D.fillSep
3997+ [ D.fillSep
3783− ["Records","look","like",D.dullyellow "{ x = 3, y = 4 },"
3784− ,"so","I","was","expecting","to","see","a","field","name","next."
3998+ ["I","was","expecting","to","see","a","record","field","defined","next,"
3999+ ,"so","I","am","looking","for","a","name","like"
4000+ ,D.dullyellow "userName","or",D.dullyellow "plantHeight" <> "."
4003+ "Field names must start with a lower-case letter. After that, you can use\
4004+ \ any sequence of letters, numbers, and underscores."
4005+ , noteForRecordError
@@ -3790,7 +4011,7 @@ toRecordReport source context record startRow startCol =
3790 surroundings = A.Region (A.Position startRow startCol) (A.Position row col)
4011 surroundings = A.Region (A.Position startRow startCol) (A.Position row col)
3791 region = toRegion row col
4012 region = toRegion row col
3793− Report.Report "UNFINISHED RECORD" region [] $
4014+ Report.Report "PROBLEM IN RECORD" region [] $
3794 Code.toSnippet source surroundings (Just region)
4015 Code.toSnippet source surroundings (Just region)
3796 D.reflow $
4017 D.reflow $
@@ -3825,22 +4046,67 @@ toRecordReport source context record startRow startCol =
3825 \ that is a reserved word. Try using a different name!"
4046 \ that is a reserved word. Try using a different name!"
4049+ Code.Other (Just ',') ->
4051+ surroundings = A.Region (A.Position startRow startCol) (A.Position row col)
4052+ region = toRegion row col
4054+ Report.Report "EXTRA COMMA" region [] $
4055+ Code.toSnippet source surroundings (Just region)
4058+ "I am partway through parsing a record, but I got stuck here:"
4062+ "I am seeing two commas in a row. This is the second one!"
4064+ "Just delete one of the commas and you should be all set!"
4065+ , noteForRecordError
4069+ Code.Close _ '}' ->
4071+ surroundings = A.Region (A.Position startRow startCol) (A.Position row col)
4072+ region = toRegion row col
4074+ Report.Report "EXTRA COMMA" region [] $
4075+ Code.toSnippet source surroundings (Just region)
4078+ "I am partway through parsing a record, but I got stuck here:"
4082+ "Trailing commas are not allowed in records. Try deleting the comma that appears\
4083+ \ before this closing curly brace."
4084+ , noteForRecordError
3830 surroundings = A.Region (A.Position startRow startCol) (A.Position row col)
4090 surroundings = A.Region (A.Position startRow startCol) (A.Position row col)
3831 region = toRegion row col
4091 region = toRegion row col
3833− Report.Report "UNFINISHED RECORD" region [] $
4093+ Report.Report "PROBLEM IN RECORD" region [] $
3834 Code.toSnippet source surroundings (Just region)
4094 Code.toSnippet source surroundings (Just region)
3836 D.reflow $
4096 D.reflow $
3837− "I am partway through parsing a record, but I got stuck after that last comma:"
4097+ "I am partway through parsing a record, but I got stuck here:"
3839− addNoteForRecordError $
4099+ D.stack
3840− D.reflow $
4100+ [ D.fillSep
3841− "Trailing commas are not allowed in records, so I was expecting to see another\
4101+ ["I","was","expecting","to","see","another","record","field","defined","next,"
3842− \ record field defined next. If you are done defining the record, the fix may\
4102+ ,"so","I","am","looking","for","a","name","like"
3843− \ be to delete that last comma?"
4103+ ,D.dullyellow "userName","or",D.dullyellow "plantHeight" <> "."
4106+ "Field names must start with a lower-case letter. After that, you can use\
4107+ \ any sequence of letters, numbers, and underscores."
4108+ , noteForRecordError
3846 RecordEquals row col ->
4112 RecordEquals row col ->
@@ -3848,17 +4114,19 @@ toRecordReport source context record startRow startCol =
3848 surroundings = A.Region (A.Position startRow startCol) (A.Position row col)
4114 surroundings = A.Region (A.Position startRow startCol) (A.Position row col)
3849 region = toRegion row col
4115 region = toRegion row col
3851− Report.Report "UNFINISHED RECORD" region [] $
4117+ Report.Report "PROBLEM IN RECORD" region [] $
3852 Code.toSnippet source surroundings (Just region)
4118 Code.toSnippet source surroundings (Just region)
3854 D.reflow $
4120 D.reflow $
3855 "I am partway through parsing a record, but I got stuck here:"
4121 "I am partway through parsing a record, but I got stuck here:"
3857− addNoteForRecordError $
4123+ D.stack
3858− D.fillSep $
4124+ [ D.fillSep $
3859− ["I","just","saw","a","field","name,","so","I","was","expecting","to","see"
4125+ ["I","just","saw","a","field","name,","so","I","was","expecting","to","see"
3860− ,"an","equals","sign","next.","So","try","putting","an",D.green "=","sign","here?"
4126+ ,"an","equals","sign","next.","So","try","putting","an",D.green "=","sign","here?"
4128+ , noteForRecordError
3864 RecordExpr expr row col ->
4132 RecordExpr expr row col ->
@@ -3878,29 +4146,54 @@ toRecordReport source context record startRow startCol =
3878 D.reflow $
4146 D.reflow $
3879 "I just saw the opening curly brace of a record, but then I got stuck here:"
4147 "I just saw the opening curly brace of a record, but then I got stuck here:"
3881− addNoteForRecordIndentError $
4149+ D.stack
3882− D.fillSep $
4150+ [ D.fillSep $
3883− ["I","am","expecting","a","record","like",D.dullyellow "{ x = 3, y = 4 }","here."
4151+ ["I","am","expecting","a","record","like",D.dullyellow "{ x = 3, y = 4 }","here."
3884− ,"Try","defining","some","fields","of","your","own?"
4152+ ,"Try","defining","some","fields","of","your","own?"
4154+ , noteForRecordIndentError
3888 RecordIndentEnd row col ->
4158 RecordIndentEnd row col ->
4159+ case Code.nextLineStartsWithCloseCurly source row of
4160+ Just (curlyRow, curlyCol) ->
4162+ surroundings = A.Region (A.Position startRow startCol) (A.Position curlyRow curlyCol)
4163+ region = toRegion curlyRow curlyCol
4165+ Report.Report "NEED MORE INDENTATION" region [] $
4166+ Code.toSnippet source surroundings (Just region)
4169+ "I was partway through parsing a record, but I got stuck here:"
4173+ "I need this curly brace to be indented more. Try adding some spaces before it!"
4174+ , noteForRecordError
3890− surroundings = A.Region (A.Position startRow startCol) (A.Position row col)
4180+ surroundings = A.Region (A.Position startRow startCol) (A.Position row col)
3891− region = toRegion row col
4181+ region = toRegion row col
3893− Report.Report "UNFINISHED RECORD" region [] $
4183+ Report.Report "UNFINISHED RECORD" region [] $
3894− Code.toSnippet source surroundings (Just region)
4184+ Code.toSnippet source surroundings (Just region)
3896− D.reflow $
4186+ D.reflow $
4187+ "I was partway through parsing a record, but I got stuck here:"
3897− "I was expecting to see a closing curly brace next:"
4191+ ["I","was","expecting","to","see","a","closing","curly","brace","next."
3899− addNoteForRecordIndentError $
3901− ["Try","putting","an",D.green "}","and","see","if","that","helps?"
4192+ ,"Try","putting","a",D.green "}","next","and","see","if","that","helps?"
4194+ , noteForRecordIndentError
3905 RecordIndentField row col ->
4198 RecordIndentField row col ->
@@ -3913,11 +4206,13 @@ toRecordReport source context record startRow startCol =
3913 D.reflow $
4206 D.reflow $
3914 "I am partway through parsing a record, but I got stuck after that last comma:"
4207 "I am partway through parsing a record, but I got stuck after that last comma:"
3916− addNoteForRecordError $
4209+ D.stack
3917− D.reflow $
4210+ [ D.reflow $
3918− "Trailing commas are not allowed in records, so the fix may be to\
4211+ "Trailing commas are not allowed in records, so the fix may be to\
3919− \ delete that last comma? Or maybe you were in the middle of defining\
4212+ \ delete that last comma? Or maybe you were in the middle of defining\
3920− \ an additional field?"
4213+ \ an additional field?"
4214+ , noteForRecordError
3923 RecordIndentEquals row col ->
4218 RecordIndentEquals row col ->
@@ -3932,10 +4227,12 @@ toRecordReport source context record startRow startCol =
3932 "I am partway through parsing a record. I just saw a record\
4227 "I am partway through parsing a record. I just saw a record\
3933 \ field, so I was expecting to see an equals sign next:"
4228 \ field, so I was expecting to see an equals sign next:"
3935− addNoteForRecordIndentError $
4230+ D.stack
3936− D.fillSep $
4231+ [ D.fillSep $
3937− ["Try","putting","an",D.green "=","followed","by","an","expression?"
4232+ ["Try","putting","an",D.green "=","followed","by","an","expression?"
4234+ , noteForRecordIndentError
3941 RecordIndentExpr row col ->
4238 RecordIndentExpr row col ->
@@ -3949,52 +4246,48 @@ toRecordReport source context record startRow startCol =
3949 D.reflow $
4246 D.reflow $
3950 "I am partway through parsing a record, and I was expecting to run into an expression next:"
4247 "I am partway through parsing a record, and I was expecting to run into an expression next:"
3952− addNoteForRecordIndentError $
4249+ D.stack
3953− D.fillSep $
4250+ [ D.fillSep $
3954− ["Try","putting","something","like"
4251+ ["Try","putting","something","like"
3955− ,D.dullyellow "42","or",D.dullyellow"\"hello\"","for","now?"
4252+ ,D.dullyellow "42","or",D.dullyellow"\"hello\"","for","now?"
4254+ , noteForRecordIndentError
3960−addNoteForRecordError :: D.Doc -> D.Doc
4259+noteForRecordError :: D.Doc
3961−addNoteForRecordError normalRecommendation =
4260+noteForRecordError =
3962 D.stack $
4261 D.stack $
3963− normalRecommendation
3965 [ D.toSimpleNote
4262 [ D.toSimpleNote
3966 "If you are trying to define a record across multiple lines, I recommend using this format:"
4263 "If you are trying to define a record across multiple lines, I recommend using this format:"
3967 , D.indent 4 $ D.vcat $
4264 , D.indent 4 $ D.vcat $
3968− [ "{ name = \"Alice\""
4265+ [ "{ name = " <> D.dullyellow "\"Alice\""
3969− , ", age = 42"
4266+ , ", age = " <> D.dullyellow "42"
3970− , ", height = 1.75"
4267+ , ", height = " <> D.dullyellow "1.75"
3973 , D.reflow $
4270 , D.reflow $
3974− "Notice that each line starts with some indentation. Usually two or four spaces. I\
4271+ "Notice that each line starts with some indentation. Usually two or four spaces.\
3975− \ know this style can be jarring for people coming from C-like syntax, but folks generally\
4272+ \ This is the stylistic convention in the Elm ecosystem."
3976− \ report that they are used to it (and often prefer it!) after a week or two of using Elm."
3980−addNoteForRecordIndentError :: D.Doc -> D.Doc
4276+noteForRecordIndentError :: D.Doc
3981−addNoteForRecordIndentError normalRecommendation =
4277+noteForRecordIndentError =
3982− D.stack $
4278+ D.stack
3983− normalRecommendation
3985 [ D.toSimpleNote
4279 [ D.toSimpleNote
3986 "I may be confused by indentation. For example, if you are trying to define\
4280 "I may be confused by indentation. For example, if you are trying to define\
3987 \ a record across multiple lines, I recommend using this format:"
4281 \ a record across multiple lines, I recommend using this format:"
3988 , D.indent 4 $ D.vcat $
4282 , D.indent 4 $ D.vcat $
3989− [ "{ name = \"Alice\""
4283+ [ "{ name = " <> D.dullyellow "\"Alice\""
3990− , ", age = 42"
4284+ , ", age = " <> D.dullyellow "42"
3991− , ", height = 1.75"
4285+ , ", height = " <> D.dullyellow "1.75"
3994 , D.reflow $
4288 , D.reflow $
3995− "Notice that each line starts with some indentation. Usually two or four spaces. I\
4289+ "Notice that each line starts with some indentation. Usually two or four spaces.\
3996− \ know this style can be jarring for people coming from C-like syntax, but folks generally\
4290+ \ This is the stylistic convention in the Elm ecosystem!"
3997− \ report that they are used to it (and often prefer it!) after a week or two of using Elm."
@@ -4183,15 +4476,14 @@ toListReport source context list startRow startCol =
4183 , D.toSimpleNote
4476 , D.toSimpleNote
4184 "I recommend using the following format for lists that span multiple lines:"
4477 "I recommend using the following format for lists that span multiple lines:"
4185 , D.indent 4 $ D.vcat $
4478 , D.indent 4 $ D.vcat $
4186− [ "[ \"Alice\""
4479+ [ "[ " <> D.dullyellow "\"Alice\""
4187− , ", \"Bob\""
4480+ , ", " <> D.dullyellow "\"Bob\""
4188− , ", \"Chuck\""
4481+ , ", " <> D.dullyellow "\"Chuck\""
4191 , D.reflow $
4484 , D.reflow $
4192− "Notice that nothing comes directly after a newline. Each line starts with some spaces.\
4485+ "Notice that each line starts with some indentation. Usually two or four spaces.\
4193− \ This style can be jarring for people coming from C-like syntax, but folks generally\
4486+ \ This is the stylistic convention in the Elm ecosystem."
4194− \ report that they are used to it (and often prefer it!) after a week or two of using Elm."
@@ -4244,15 +4536,14 @@ toListReport source context list startRow startCol =
4244 "I may be confused by indentation. For example, if you are trying to define\
4536 "I may be confused by indentation. For example, if you are trying to define\
4245 \ a list across multiple lines, I recommend using this format:"
4537 \ a list across multiple lines, I recommend using this format:"
4246 , D.indent 4 $ D.vcat $
4538 , D.indent 4 $ D.vcat $
4247− [ "[ \"Alice\""
4539+ [ "[ " <> D.dullyellow "\"Alice\""
4248− , ", \"Bob\""
4540+ , ", " <> D.dullyellow "\"Bob\""
4249− , ", \"Chuck\""
4541+ , ", " <> D.dullyellow "\"Chuck\""
4252 , D.reflow $
4544 , D.reflow $
4253− "Notice that nothing comes directly after a newline. Each line starts with some spaces.\
4545+ "Notice that each line starts with some indentation. Usually two or four spaces.\
4254− \ This style can be jarring for people coming from C-like syntax, but folks generally\
4546+ \ This is the stylistic convention in the Elm ecosystem."
4255− \ report that they are used to it (and often prefer it!) after a week or two of using Elm."
@@ -4276,15 +4567,14 @@ toListReport source context list startRow startCol =
4276 "I may be confused by indentation. For example, if you are trying to define\
4567 "I may be confused by indentation. For example, if you are trying to define\
4277 \ a list across multiple lines, I recommend using this format:"
4568 \ a list across multiple lines, I recommend using this format:"
4278 , D.indent 4 $ D.vcat $
4569 , D.indent 4 $ D.vcat $
4279− [ "[ \"Alice\""
4570+ [ "[ " <> D.dullyellow "\"Alice\""
4280− , ", \"Bob\""
4571+ , ", " <> D.dullyellow "\"Bob\""
4281− , ", \"Chuck\""
4572+ , ", " <> D.dullyellow "\"Chuck\""
4284 , D.reflow $
4575 , D.reflow $
4285− "Notice that nothing comes directly after a newline. Each line starts with some spaces.\
4576+ "Notice that each line starts with some indentation. Usually two or four spaces.\
4286− \ This style can be jarring for people coming from C-like syntax, but folks generally\
4577+ \ This is the stylistic convention in the Elm ecosystem."
4287− \ report that they are used to it (and often prefer it!) after a week or two of using Elm."
@@ -4305,15 +4595,14 @@ toListReport source context list startRow startCol =
4305 , D.toSimpleNote
4595 , D.toSimpleNote
4306 "I recommend using the following format for lists that span multiple lines:"
4596 "I recommend using the following format for lists that span multiple lines:"
4307 , D.indent 4 $ D.vcat $
4597 , D.indent 4 $ D.vcat $
4308− [ "[ \"Alice\""
4598+ [ "[ " <> D.dullyellow "\"Alice\""
4309− , ", \"Bob\""
4599+ , ", " <> D.dullyellow "\"Bob\""
4310− , ", \"Chuck\""
4600+ , ", " <> D.dullyellow "\"Chuck\""
4313 , D.reflow $
4603 , D.reflow $
4314− "Notice that nothing comes directly after a newline. Each line starts with some spaces.\
4604+ "Notice that each line starts with some indentation. Usually two or four spaces.\
4315− \ This style can be jarring for people coming from C-like syntax, but folks generally\
4605+ \ This is the stylistic convention in the Elm ecosystem."
4316− \ report that they are used to it (and often prefer it!) after a week or two of using Elm."
@@ -5186,22 +5475,64 @@ toTRecordReport source context record startRow startCol =
5186 \ that is a reserved word. Try using a different name!"
5475 \ that is a reserved word. Try using a different name!"
5478+ Code.Other (Just ',') ->
5480+ surroundings = A.Region (A.Position startRow startCol) (A.Position row col)
5481+ region = toRegion row col
5483+ Report.Report "EXTRA COMMA" region [] $
5484+ Code.toSnippet source surroundings (Just region)
5487+ "I am partway through parsing a record type, but I got stuck here:"
5491+ "I am seeing two commas in a row. This is the second one!"
5493+ "Just delete one of the commas and you should be all set!"
5494+ , noteForRecordTypeError
5498+ Code.Close _ '}' ->
5500+ surroundings = A.Region (A.Position startRow startCol) (A.Position row col)
5501+ region = toRegion row col
5503+ Report.Report "EXTRA COMMA" region [] $
5504+ Code.toSnippet source surroundings (Just region)
5507+ "I am partway through parsing a record type, but I got stuck here:"
5511+ "Trailing commas are not allowed in record types. Try deleting the comma that\
5512+ \ appears before this closing curly brace."
5513+ , noteForRecordTypeError
5191 surroundings = A.Region (A.Position startRow startCol) (A.Position row col)
5519 surroundings = A.Region (A.Position startRow startCol) (A.Position row col)
5192 region = toRegion row col
5520 region = toRegion row col
5194− Report.Report "UNFINISHED RECORD TYPE" region [] $
5522+ Report.Report "PROBLEM IN RECORD TYPE" region [] $
5195 Code.toSnippet source surroundings (Just region)
5523 Code.toSnippet source surroundings (Just region)
5197 D.reflow $
5525 D.reflow $
5198− "I am partway through parsing a record type, but I got stuck after that last comma:"
5526+ "I am partway through parsing a record type, but I got stuck here:"
5200− addNoteForRecordTypeError $
5528+ D.stack
5201− D.reflow $
5529+ [ D.fillSep
5202− "Trailing commas are not allowed in records, so I was expecting to see another\
5530+ ["I","was","expecting","to","see","another","record","field","defined","next,"
5203− \ record field defined next. If you are done defining the record, the fix may\
5531+ ,"so","I","am","looking","for","a","name","like"
5204− \ be to delete that last comma?"
5532+ ,D.dullyellow "userName","or",D.dullyellow "plantHeight" <> "."
5534+ , noteForRecordTypeError
5207 TRecordColon row col ->
5538 TRecordColon row col ->
@@ -5215,11 +5546,13 @@ toTRecordReport source context record startRow startCol =
5215 D.reflow $
5546 D.reflow $
5216 "I am partway through parsing a record type, but I got stuck here:"
5547 "I am partway through parsing a record type, but I got stuck here:"
5218− addNoteForRecordTypeError $
5549+ D.stack
5219− D.fillSep $
5550+ [ D.fillSep $
5220− ["I","just","saw","a","field","name,","so","I","was","expecting","to","see"
5551+ ["I","just","saw","a","field","name,","so","I","was","expecting","to","see"
5221− ,"a","colon","next.","So","try","putting","an",D.green ":","sign","here?"
5552+ ,"a","colon","next.","So","try","putting","an",D.green ":","sign","here?"
5554+ , noteForRecordTypeError
5225 TRecordType tipe row col ->
5558 TRecordType tipe row col ->
@@ -5239,29 +5572,54 @@ toTRecordReport source context record startRow startCol =
5239 D.reflow $
5572 D.reflow $
5240 "I just saw the opening curly brace of a record type, but then I got stuck here:"
5573 "I just saw the opening curly brace of a record type, but then I got stuck here:"
5242− addNoteForRecordTypeIndentError $
5575+ D.stack
5243− D.fillSep $
5576+ [ D.fillSep $
5244− ["I","am","expecting","a","record","like",D.dullyellow "{ name : String, age : Int }","here."
5577+ ["I","am","expecting","a","record","like",D.dullyellow "{ name : String, age : Int }","here."
5245− ,"Try","defining","some","fields","of","your","own?"
5578+ ,"Try","defining","some","fields","of","your","own?"
5580+ , noteForRecordTypeIndentError
5249 TRecordIndentEnd row col ->
5584 TRecordIndentEnd row col ->
5585+ case Code.nextLineStartsWithCloseCurly source row of
5586+ Just (curlyRow, curlyCol) ->
5588+ surroundings = A.Region (A.Position startRow startCol) (A.Position curlyRow curlyCol)
5589+ region = toRegion curlyRow curlyCol
5591+ Report.Report "NEED MORE INDENTATION" region [] $
5592+ Code.toSnippet source surroundings (Just region)
5595+ "I was partway through parsing a record type, but I got stuck here:"
5599+ "I need this curly brace to be indented more. Try adding some spaces before it!"
5600+ , noteForRecordTypeError
5251− surroundings = A.Region (A.Position startRow startCol) (A.Position row col)
5606+ surroundings = A.Region (A.Position startRow startCol) (A.Position row col)
5252− region = toRegion row col
5607+ region = toRegion row col
5254− Report.Report "UNFINISHED RECORD TYPE" region [] $
5609+ Report.Report "UNFINISHED RECORD TYPE" region [] $
5255− Code.toSnippet source surroundings (Just region)
5610+ Code.toSnippet source surroundings (Just region)
5257− D.reflow $
5612+ D.reflow $
5613+ "I was partway through parsing a record type, but I got stuck here:"
5258− "I was expecting to see a closing curly brace next:"
5617+ ["I","was","expecting","to","see","a","closing","curly","brace","next."
5260− addNoteForRecordTypeIndentError $
5262− ["Try","putting","an",D.green "}","and","see","if","that","helps?"
5618+ ,"Try","putting","a",D.green "}","next","and","see","if","that","helps?"
5620+ , noteForRecordTypeIndentError
5266 TRecordIndentField row col ->
5624 TRecordIndentField row col ->
@@ -5274,11 +5632,13 @@ toTRecordReport source context record startRow startCol =
5274 D.reflow $
5632 D.reflow $
5275 "I am partway through parsing a record type, but I got stuck after that last comma:"
5633 "I am partway through parsing a record type, but I got stuck after that last comma:"
5277− addNoteForRecordTypeIndentError $
5635+ D.stack
5278− D.reflow $
5636+ [ D.reflow $
5279− "Trailing commas are not allowed in record types, so the fix may be to\
5637+ "Trailing commas are not allowed in record types, so the fix may be to\
5280− \ delete that last comma? Or maybe you were in the middle of defining\
5638+ \ delete that last comma? Or maybe you were in the middle of defining\
5281− \ an additional field?"
5639+ \ an additional field?"
5640+ , noteForRecordTypeIndentError
5284 TRecordIndentColon row col ->
5644 TRecordIndentColon row col ->
@@ -5293,10 +5653,12 @@ toTRecordReport source context record startRow startCol =
5293 "I am partway through parsing a record type. I just saw a record\
5653 "I am partway through parsing a record type. I just saw a record\
5294 \ field, so I was expecting to see a colon next:"
5654 \ field, so I was expecting to see a colon next:"
5296− addNoteForRecordTypeIndentError $
5656+ D.stack
5297− D.fillSep $
5657+ [ D.fillSep $
5298− ["Try","putting","an",D.green ":","followed","by","a","type?"
5658+ ["Try","putting","an",D.green ":","followed","by","a","type?"
5660+ , noteForRecordTypeIndentError
5302 TRecordIndentType row col ->
5664 TRecordIndentType row col ->
@@ -5310,19 +5672,19 @@ toTRecordReport source context record startRow startCol =
5310 D.reflow $
5672 D.reflow $
5311 "I am partway through parsing a record type, and I was expecting to run into a type next:"
5673 "I am partway through parsing a record type, and I was expecting to run into a type next:"
5313− addNoteForRecordTypeIndentError $
5675+ D.stack
5314− D.fillSep $
5676+ [ D.fillSep $
5315− ["Try","putting","something","like"
5677+ ["Try","putting","something","like"
5316− ,D.dullyellow "Int","or",D.dullyellow "String","for","now?"
5678+ ,D.dullyellow "Int","or",D.dullyellow "String","for","now?"
5680+ , noteForRecordTypeIndentError
5321−addNoteForRecordTypeError :: D.Doc -> D.Doc
5685+noteForRecordTypeError :: D.Doc
5322−addNoteForRecordTypeError normalRecommendation =
5686+noteForRecordTypeError =
5323 D.stack $
5687 D.stack $
5324− normalRecommendation
5326 [ D.toSimpleNote
5688 [ D.toSimpleNote
5327 "If you are trying to define a record type across multiple lines, I recommend using this format:"
5689 "If you are trying to define a record type across multiple lines, I recommend using this format:"
5328 , D.indent 4 $ D.vcat $
5690 , D.indent 4 $ D.vcat $
@@ -5332,17 +5694,14 @@ addNoteForRecordTypeError normalRecommendation =
5334 , D.reflow $
5696 , D.reflow $
5335− "Notice that each line starts with some indentation. Usually two or four spaces. I\
5697+ "Notice that each line starts with some indentation. Usually two or four spaces.\
5336− \ know this style can be jarring for people coming from C-like syntax, but folks generally\
5698+ \ This is the stylistic convention in the Elm ecosystem."
5337− \ report that they are used to it (and often prefer it!) after a week or two of using Elm."
5341−addNoteForRecordTypeIndentError :: D.Doc -> D.Doc
5702+noteForRecordTypeIndentError :: D.Doc
5342−addNoteForRecordTypeIndentError normalRecommendation =
5703+noteForRecordTypeIndentError =
5343 D.stack $
5704 D.stack $
5344− normalRecommendation
5346 [ D.toSimpleNote
5705 [ D.toSimpleNote
5347 "I may be confused by indentation. For example, if you are trying to define\
5706 "I may be confused by indentation. For example, if you are trying to define\
5348 \ a record type across multiple lines, I recommend using this format:"
5707 \ a record type across multiple lines, I recommend using this format:"
@@ -5353,9 +5712,8 @@ addNoteForRecordTypeIndentError normalRecommendation =
5355 , D.reflow $
5714 , D.reflow $
5356− "Notice that each line starts with some indentation. Usually two or four spaces. I\
5715+ "Notice that each line starts with some indentation. Usually two or four spaces.\
5357− \ know this style can be jarring for people coming from C-like syntax, but folks generally\
5716+ \ This is the stylistic convention in the Elm ecosystem."
5358− \ report that they are used to it (and often prefer it!) after a week or two of using Elm."