enso-org/enso
1
1
Fork 0
mirror of https://github.com/enso-org/enso.git synced 2024-12-23 11:41:56 +03:00
Code Issues Projects Releases Wiki Activity

Fix infinite callstack while opening a popover (#10391)

Browse Source
This commit is contained in:
Sergei Garin 2024-06-27 23:48:03 +03:00 committed by GitHub
parent 19d5bdb9da
commit 201eec3b84
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
app/ide-desktop/lib/dashboard/src/components/AriaComponents/Dialog/DialogStackProvider.tsx
View File

@ -80,18 +80,22 @@ export function DialogStackRegistrar(props: React.PropsWithChildren<DialogStackI
const idRef = React.useRef(idRaw)
const typeRef = React.useRef(typeRaw)
const ctx = React.useContext(DialogStackContext)
const context = React.useContext(DialogStackContext)
invariant(ctx, 'DialogStackRegistrar must be used within a DialogStackProvider')
invariant(context, 'DialogStackRegistrar must be used within a DialogStackProvider')
const { add, slice } = context
React.useEffect(() => {
const id = idRef.current
const type = typeRef.current
ctx.add({ id, type })
add({ id, type })
return () => {
ctx.slice(id)
slice(id)
}
}, [ctx])
}, [add, slice])
return children
}