diff --git a/app/gui2/src/components/GraphEditor/widgets/WidgetSelection.vue b/app/gui2/src/components/GraphEditor/widgets/WidgetSelection.vue index 77bf6a31a31..2b68f857757 100644 --- a/app/gui2/src/components/GraphEditor/widgets/WidgetSelection.vue +++ b/app/gui2/src/components/GraphEditor/widgets/WidgetSelection.vue @@ -236,8 +236,11 @@ function resolveTagExpression(edit: Ast.MutableModule, tag: ExpressionTag) { if (tag.requiredImports) { const conflicts = graph.addMissingImports(edit, tag.requiredImports) if (conflicts != null && conflicts.length > 0) { - // Is there is a conflict, it would be a single one, because we only ask about a single entry. - return conflicts[0]?.fullyQualified! + // TODO: Substitution does not work, because we interpret imports wrongly. To be fixed in + // https://github.com/enso-org/enso/issues/9356 + // And here it was wrong anyway: we should replace only conflicting name, not entire expression! + // // Is there is a conflict, it would be a single one, because we only ask about a single entry. + // return conflicts[0]?.fullyQualified! } } // Unless a conflict occurs, we use the selected expression as is. diff --git a/app/gui2/src/stores/graph/index.ts b/app/gui2/src/stores/graph/index.ts index 4465c3524e7..1c2f748131c 100644 --- a/app/gui2/src/stores/graph/index.ts +++ b/app/gui2/src/stores/graph/index.ts @@ -284,7 +284,8 @@ export const useGraphStore = defineStore('graph', () => { rhs.setNodeMetadata(metadata) const assignment = Ast.Assignment.new(edit, ident, rhs) for (const _conflict of conflicts) { - // TODO: Sort out issues with FQN with the engine. + // TODO: Substitution does not work, because we interpret imports wrongly. To be fixed in + // https://github.com/enso-org/enso/issues/9356 // substituteQualifiedName(edit, assignment, conflict.pattern, conflict.fullyQualified) } const id = asNodeId(rhs.id) @@ -378,7 +379,8 @@ export const useGraphStore = defineStore('graph', () => { return } for (const _conflict of conflicts) { - // TODO: Sort out issues with FQN with the engine. + // TODO: Substitution does not work, because we interpret imports wrongly. To be fixed in + // https://github.com/enso-org/enso/issues/9356 // substituteQualifiedName(edit, wholeAssignment, conflict.pattern, conflict.fullyQualified) } }