After creating a new project, nodes are not laid out. (#3174)

This commit is contained in:
Adam Obuchowicz 2021-12-01 14:25:48 +01:00 committed by GitHub
parent 850a16cb40
commit 215cd76bce
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
7 changed files with 6 additions and 12 deletions

View File

@ -53,8 +53,6 @@ pub mod prelude {
pub use enso_logger::*;
pub use enso_prelude::*;
pub use enso_logger::DefaultTraceLogger as Logger;
#[cfg(test)]
pub use wasm_bindgen_test::wasm_bindgen_test;
#[cfg(test)]

View File

@ -511,8 +511,6 @@ impl Info {
parser: &parser::Parser,
to_add: &QualifiedName,
) {
let imports = self.iter_imports().collect_vec();
DEBUG!("add_module_import: {to_add} in {imports:?}");
let is_here = to_add == here;
let import = ImportInfo::from_qualified_name(to_add);
let already_imported = self.iter_imports().any(|imp| imp == import);

View File

@ -399,7 +399,7 @@ mod tests {
impl Case {
fn run(&self, parser: &Parser) {
let logger = Logger::new("Collapsing_Test");
let logger = DefaultTraceLogger::new("Collapsing_Test");
let ast = parser.parse_module(self.initial_method_code, default()).unwrap();
let main = module::locate_child(&ast, &self.refactored_name).unwrap();
let graph = graph::GraphInfo::from_definition(main.item.clone());

View File

@ -790,7 +790,7 @@ impl Model {
let base_default_position = default_node_position();
let mut trees = connections_info.trees.clone();
let nodes = self.graph.graph().nodes()?;
let (without_pos, with_pos): (Vec<_>, Vec<_>) =
let (with_pos, without_pos): (Vec<_>, Vec<_>) =
nodes.iter().partition(|n| n.has_position());
let bottommost_node_pos = with_pos
.iter()
@ -1068,7 +1068,7 @@ impl Model {
notification: crate::integration::visualization::Notification,
) {
use crate::integration::visualization::Notification;
warning!(self.logger, "Received update for {which} visualization: {notification:?}");
info!(self.logger, "Received update for {which} visualization: {notification:?}");
match notification {
Notification::ValueUpdate { target, data, .. } => {
if let Ok(view_id) = self.get_displayed_node_id(target) {

View File

@ -58,8 +58,6 @@ pub mod prelude {
pub use ensogl::prelude::*;
pub use wasm_bindgen::prelude::*;
pub use enso_logger::DefaultTraceLogger as Logger;
pub use crate::constants;
pub use crate::controller;
pub use crate::executor;

View File

@ -121,7 +121,7 @@ impl ExecutionContext {
match notification {
Notification::Completed =>
if !self.model.is_ready.replace(true) {
WARNING!("Context {self.id} Became ready");
info!(self.logger, "Context {self.id} Became ready");
},
Notification::ExpressionUpdates(updates) => {
self.model.computed_value_info_registry.apply_updates(updates);

View File

@ -124,7 +124,7 @@ pub mod shape {
#[allow(missing_docs)]
pub struct Model<Shape> {
app: Application,
logger: DefaultTraceLogger,
logger: Logger,
display_object: display::object::Instance,
shape: ShapeView<Shape>,
}
@ -133,7 +133,7 @@ impl<Shape: ButtonShape> Model<Shape> {
/// Construct a button's model.
pub fn new(app: &Application) -> Self {
let app = app.clone_ref();
let logger = DefaultTraceLogger::new(Shape::debug_name());
let logger = Logger::new(Shape::debug_name());
let display_object = display::object::Instance::new(&logger);
let shape = ShapeView::new(&logger);
display_object.add_child(&shape);