enso-org/enso
1
1
Fork 0
mirror of https://github.com/enso-org/enso.git synced 2024-11-22 22:10:15 +03:00
Code Issues Projects Releases Wiki Activity

Fix refactor/renameProject with names containing unsupported characters (#10204)

Browse Source 
related #10073

Changelog:
- fix: rename the project to the name containing unsupported characters
This commit is contained in:
Dmitry Bushev 2024-06-07 13:34:01 +01:00 committed by GitHub
parent 7744e8b464
commit 292d33ccc1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 15 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
engine/runtime-instrument-common/src/main/scala/org/enso/interpreter/instrument/command/RenameProjectCmd.scala
View File

@ -78,12 +78,12 @@ class RenameProjectCmd(
val context = ctx.executionService.getContext val context = ctx.executionService.getContext
context.renameProject( context.renameProject(
request.namespace, request.namespace,
request.oldName, oldConfig.moduleName,
request.newName newConfig.moduleName
) )
ctx.contextManager.getAllContexts.values.foreach { stack => ctx.contextManager.getAllContexts.values.foreach { stack =>
updateMethodPointers(request.newName, stack) updateMethodPointers(newConfig.moduleName, stack)
clearCache(stack) clearCache(stack)
} }

24
engine/runtime-integration-tests/src/test/scala/org/enso/interpreter/test/instrument/RuntimeServerTest.scala
View File

@ -6230,21 +6230,21 @@ class RuntimeServerTest
context.executionComplete(contextId) context.executionComplete(contextId)
) )
// rename Test -> Foo // rename Test -> My Foo
context.pkg.rename("Foo") context.pkg.rename("My Foo")
context.send( context.send(
Api.Request(requestId, Api.RenameProject("Enso_Test", "Test", "Foo")) Api.Request(requestId, Api.RenameProject("Enso_Test", "Test", "My Foo"))
) )
val renameProjectResponses = context.receiveN(6) val renameProjectResponses = context.receiveN(6)
renameProjectResponses should contain allOf ( renameProjectResponses should contain allOf (
Api.Response(requestId, Api.ProjectRenamed("Test", "Foo", "Foo")), Api.Response(requestId, Api.ProjectRenamed("Test", "MyFoo", "My Foo")),
context.Main.Update.mainX(contextId, typeChanged = false), context.Main.Update.mainX(contextId, typeChanged = false),
TestMessages.update( TestMessages.update(
contextId, contextId,
context.Main.idMainY, context.Main.idMainY,
ConstantsGen.INTEGER, ConstantsGen.INTEGER,
Api.MethodCall( Api.MethodCall(
Api.MethodPointer("Enso_Test.Foo.Main", ConstantsGen.NUMBER, "foo") Api.MethodPointer("Enso_Test.MyFoo.Main", ConstantsGen.NUMBER, "foo")
), ),
fromCache = false, fromCache = false,
typeChanged = true typeChanged = true
@ -6299,7 +6299,7 @@ class RuntimeServerTest
context.Main.idMainY, context.Main.idMainY,
ConstantsGen.INTEGER, ConstantsGen.INTEGER,
Api.MethodCall( Api.MethodCall(
Api.MethodPointer("Enso_Test.Foo.Main", ConstantsGen.NUMBER, "foo") Api.MethodPointer("Enso_Test.MyFoo.Main", ConstantsGen.NUMBER, "foo")
), ),
fromCache = false, fromCache = false,
typeChanged = false typeChanged = false
@ -6347,21 +6347,21 @@ class RuntimeServerTest
context.executionComplete(contextId) context.executionComplete(contextId)
) )
// rename Test -> Foo // rename Test -> My Foo
context.pkg.rename("Foo") context.pkg.rename("My Foo")
context.send( context.send(
Api.Request(requestId, Api.RenameProject("Enso_Test", "Test", "Foo")) Api.Request(requestId, Api.RenameProject("Enso_Test", "Test", "My Foo"))
) )
val renameProjectResponses = context.receiveN(6) val renameProjectResponses = context.receiveN(6)
renameProjectResponses should contain allOf ( renameProjectResponses should contain allOf (
Api.Response(requestId, Api.ProjectRenamed("Test", "Foo", "Foo")), Api.Response(requestId, Api.ProjectRenamed("Test", "MyFoo", "My Foo")),
context.Main.Update.mainX(contextId, typeChanged = false), context.Main.Update.mainX(contextId, typeChanged = false),
TestMessages.update( TestMessages.update(
contextId, contextId,
context.Main.idMainY, context.Main.idMainY,
ConstantsGen.INTEGER, ConstantsGen.INTEGER,
Api.MethodCall( Api.MethodCall(
Api.MethodPointer("Enso_Test.Foo.Main", ConstantsGen.NUMBER, "foo") Api.MethodPointer("Enso_Test.MyFoo.Main", ConstantsGen.NUMBER, "foo")
), ),
fromCache = false, fromCache = false,
typeChanged = true typeChanged = true
@ -6401,7 +6401,7 @@ class RuntimeServerTest
context.Main.idMainY, context.Main.idMainY,
ConstantsGen.INTEGER, ConstantsGen.INTEGER,
Api.MethodCall( Api.MethodCall(
Api.MethodPointer("Enso_Test.Foo.Main", ConstantsGen.NUMBER, "foo") Api.MethodPointer("Enso_Test.MyFoo.Main", ConstantsGen.NUMBER, "foo")
), ),
fromCache = true, fromCache = true,
typeChanged = true typeChanged = true