enso-org/enso
1
1
Fork 0
mirror of https://github.com/enso-org/enso.git synced 2024-12-19 15:12:26 +03:00
Code Issues Projects Releases Wiki Activity

Add Missing_Argument error to join right (#11888)

Browse Source
This commit is contained in:
AdRiley 2024-12-17 13:19:07 +00:00 committed by GitHub
parent 269354ebf7
commit 34ddd37301
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/gui/src/project-view/util/callTree.ts
View File

@ -4,7 +4,11 @@ import type { WidgetConfiguration } from '@/providers/widgetRegistry/configurati
import * as widgetCfg from '@/providers/widgetRegistry/configuration'
import { DisplayMode } from '@/providers/widgetRegistry/configuration'
import type { MethodCallInfo } from '@/stores/graph/graphDatabase'
import type { SuggestionEntry, SuggestionEntryArgument } from '@/stores/suggestionDatabase/entry'
import {
isRequiredArgument,
type SuggestionEntry,
type SuggestionEntryArgument,
} from '@/stores/suggestionDatabase/entry'
import { Ast } from '@/util/ast'
import type { AstId } from '@/util/ast/abstract'
import { findLastIndex, tryGetIndex } from '@/util/data/array'
@ -118,7 +122,7 @@ export class ArgumentPlaceholder extends Argument {
/** TODO: Add docs */
override get hideByDefault(): boolean {
return this.argInfo.hasDefault && this.dynamicConfig?.display !== DisplayMode.Always
return !isRequiredArgument(this.argInfo) && this.dynamicConfig?.display !== DisplayMode.Always
}
}

3
distribution/lib/Standard/Database/0.0.0-dev/src/DB_Table.enso
View File

@ -9,6 +9,7 @@ import Standard.Base.Errors.Common.Floating_Point_Equality
import Standard.Base.Errors.Common.Incomparable_Values
import Standard.Base.Errors.Common.Index_Out_Of_Bounds
import Standard.Base.Errors.Common.Type_Error
import Standard.Base.Errors.Common.Missing_Argument
import Standard.Base.Errors.Deprecated.Deprecated
import Standard.Base.Errors.File_Error.File_Error
import Standard.Base.Errors.Illegal_Argument.Illegal_Argument
@ -1495,7 +1496,7 @@ type DB_Table
@join_kind Widget_Helpers.make_join_kind_selector
@on Widget_Helpers.make_join_condition_selector
join : DB_Table -> Join_Kind -> Join_Condition | Text | Vector (Join_Condition | Text) -> Text -> Problem_Behavior -> DB_Table
join self right (join_kind : Join_Kind = ..Left_Outer) (on : Join_Condition | Text | Vector (Join_Condition | Text) = (default_join_condition self join_kind)) (right_prefix:Text="Right ") (on_problems:Problem_Behavior=..Report_Warning) =
join self right=(Missing_Argument.throw "right") (join_kind : Join_Kind = ..Left_Outer) (on : Join_Condition | Text | Vector (Join_Condition | Text) = (default_join_condition self join_kind)) (right_prefix:Text="Right ") (on_problems:Problem_Behavior=..Report_Warning) =
Feature.Join.if_supported_else_throw self.connection.dialect "join" <|
self.join_or_cross_join right join_kind on right_prefix on_problems

3
distribution/lib/Standard/Table/0.0.0-dev/src/Table.enso
View File

@ -8,6 +8,7 @@ import Standard.Base.Errors.Common.Additional_Warnings
import Standard.Base.Errors.Common.Floating_Point_Equality
import Standard.Base.Errors.Common.Incomparable_Values
import Standard.Base.Errors.Common.Index_Out_Of_Bounds
import Standard.Base.Errors.Common.Missing_Argument
import Standard.Base.Errors.Common.No_Such_Method
import Standard.Base.Errors.Common.Out_Of_Memory
import Standard.Base.Errors.Common.Type_Error
@ -2665,7 +2666,7 @@ type Table
@join_kind Widget_Helpers.make_join_kind_selector
@on Widget_Helpers.make_join_condition_selector
join : Table -> Join_Kind -> Vector (Join_Condition | Text) | Text -> Text -> Problem_Behavior -> Table
join self right:Table (join_kind : Join_Kind = ..Left_Outer) on=[Join_Condition.Equals self.column_names.first] right_prefix:Text="Right " on_problems:Problem_Behavior=..Report_Warning = Out_Of_Memory.handle_java_exception "join" <|
join self right:Table=(Missing_Argument.throw "right") (join_kind : Join_Kind = ..Left_Outer) on=[Join_Condition.Equals self.column_names.first] right_prefix:Text="Right " on_problems:Problem_Behavior=..Report_Warning = Out_Of_Memory.handle_java_exception "join" <|
columns_to_keep = case join_kind of
Join_Kind.Left_Exclusive -> [True, False]
Join_Kind.Right_Exclusive -> [False, True]