enso-org/enso
1
1
Fork 0
mirror of https://github.com/enso-org/enso.git synced 2024-11-24 00:27:16 +03:00
Code Issues Projects Releases Wiki Activity

rename tooltip message, sort sorting for truncated data and re introduce the row label (#10533)

Browse Source 
closes #10530

this renames the tooltip from using 'node' to 'component,

<img width="341" alt="image" src="https://github.com/enso-org/enso/assets/170310417/1ee35556-a982-47aa-99ac-544108b11afe">

![row-label](https://github.com/enso-org/enso/assets/170310417/d81482d9-df49-45da-b447-571a8e9171ea)
This commit is contained in:
marthasharkey 2024-07-11 19:28:47 +01:00 committed by GitHub
parent 017cf4f98e
commit 4c0fbf0e19
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
app/gui2/src/components/visualizations/TableVisualization.vue
View File

@ -330,7 +330,7 @@ function toField(name: string, valueType?: ValueType | null | undefined): ColDef
const menu = `<span ref="eMenu" class="ag-header-icon ag-header-cell-menu-button"> </span>` const menu = `<span ref="eMenu" class="ag-header-icon ag-header-cell-menu-button"> </span>`
const sort = ` const sort = `
<span ref="eFilter" class="ag-header-icon ag-header-label-icon ag-filter-icon" aria-hidden="true"></span> <span ref="eFilter" class="ag-header-icon ag-header-label-icon ag-filter-icon" aria-hidden="true"></span>
<span ref="eSortOrder" class="ag-header-icon ag-sort-order" aria-hidden="true">1</span> <span ref="eSortOrder" class="ag-header-icon ag-sort-order" aria-hidden="true"></span>
<span ref="eSortAsc" class="ag-header-icon ag-sort-ascending-icon" aria-hidden="true"></span> <span ref="eSortAsc" class="ag-header-icon ag-sort-ascending-icon" aria-hidden="true"></span>
<span ref="eSortDesc" class="ag-header-icon ag-sort-descending-icon" aria-hidden="true"></span> <span ref="eSortDesc" class="ag-header-icon ag-sort-descending-icon" aria-hidden="true"></span>
<span ref="eSortNone" class="ag-header-icon ag-sort-none-icon" aria-hidden="true"></span> <span ref="eSortNone" class="ag-header-icon ag-sort-none-icon" aria-hidden="true"></span>
@ -343,7 +343,6 @@ function toField(name: string, valueType?: ValueType | null | undefined): ColDef
field: name, field: name,
headerComponentParams: { headerComponentParams: {
template, template,
enableSorting: true,
setAriaSort: () => {}, setAriaSort: () => {},
}, },
headerTooltip: displayValue ? displayValue : '', headerTooltip: displayValue ? displayValue : '',
@ -406,7 +405,7 @@ function toLinkField(fieldName: string): ColDef {
field: fieldName, field: fieldName,
onCellDoubleClicked: (params) => createNode(params), onCellDoubleClicked: (params) => createNode(params),
tooltipValueGetter: () => { tooltipValueGetter: () => {
return `Double click to view this ${newNodeSelectorValues.value.tooltipValue} in a separate node` return `Double click to view this ${newNodeSelectorValues.value.tooltipValue} in a separate component`
}, },
cellRenderer: (params: any) => `<a href='#'> ${params.value} </a>`, cellRenderer: (params: any) => `<a href='#'> ${params.value} </a>`,
} }
@ -657,7 +656,7 @@ onUnmounted(() => {
v-text="limit" v-text="limit"
></option> ></option>
</select> </select>
<div v-if="showRowCount"> <template v-if="showRowCount">
<span <span
v-if="isRowCountSelectorVisible && isTruncated" v-if="isRowCountSelectorVisible && isTruncated"
v-text="` of ${rowCount} rows (Sorting/Filtering disabled).`" v-text="` of ${rowCount} rows (Sorting/Filtering disabled).`"
@ -665,7 +664,7 @@ onUnmounted(() => {
<span v-else-if="isRowCountSelectorVisible" v-text="' rows.'"></span> <span v-else-if="isRowCountSelectorVisible" v-text="' rows.'"></span>
<span v-else-if="rowCount === 1" v-text="'1 row.'"></span> <span v-else-if="rowCount === 1" v-text="'1 row.'"></span>
<span v-else v-text="`${rowCount} rows.`"></span> <span v-else v-text="`${rowCount} rows.`"></span>
</div> </template>
</div> </div>
<div ref="tableNode" class="scrollable ag-theme-alpine"></div> <div ref="tableNode" class="scrollable ag-theme-alpine"></div>
</div> </div>