enso-org/enso
1
1
Fork 0
mirror of https://github.com/enso-org/enso.git synced 2024-12-23 16:32:18 +03:00
Code Issues Projects Releases Wiki Activity

Fix startup performance bug (#7089)

Browse Source 
Remove a leak detector added in #7038, that has a large (~10s) impact on startup performance. I missed the performance impact during QA, but noticed it after merge.
This commit is contained in:
Kaz Wesley 2023-06-22 01:31:47 -07:00 committed by GitHub
parent 0abc2d5023
commit 9ae4b24d85
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
lib/rust/ensogl/core/src/display/scene.rs
View File

@ -891,7 +891,6 @@ pub struct SceneData {
display_mode: Rc<Cell<glsl::codes::DisplayModes>>,
extensions: Extensions,
disable_context_menu: Rc<EventListenerHandle>,
trace: leak_detector::Trace,
}
impl SceneData {
@ -958,7 +957,6 @@ impl SceneData {
initial_shader_compilation,
extensions,
disable_context_menu,
trace: leak_detector::Trace::enabled("SceneData"),
}
.init()
}
@ -1153,7 +1151,6 @@ pub struct Scene {
no_mut_access: Rc<SceneData>,
// Context handlers keep reference to SceneData, thus cannot be put inside it.
context_lost_handler: Rc<RefCell<Option<ContextLostHandler>>>,
trace: leak_detector::Trace,
}
impl Scene {
@ -1164,11 +1161,7 @@ impl Scene {
) -> Self {
let no_mut_access = SceneData::new(stats, on_mut, display_mode);
let context_lost_handler = default();
let this = Self {
no_mut_access: Rc::new(no_mut_access),
context_lost_handler,
trace: leak_detector::Trace::enabled("Scene"),
};
let this = Self { no_mut_access: Rc::new(no_mut_access), context_lost_handler };
this
}