enso-org/enso
1
1
Fork 0
mirror of https://github.com/enso-org/enso.git synced 2024-12-22 18:01:38 +03:00
Code Issues Projects Releases Wiki Activity

Remove unnecessary chrome flags (#10619)

Browse Source 
Fixes #10487

During my tests, these flags were not needed; without them, electron app displays exactly the same cert warnings as with them:
```
Loading the window address 'https://localhost:8080/?engine.projectManagerUrl=ws%3A%2F%2F127.0.0.1%3A30535'.
[30750:0722/121629.281911:ERROR:cert_verify_proc_builtin.cc(1051)] CertVerifyProcBuiltin for localhost failed:
----- Certificate i=0 (CN=127.0.0.1) -----
ERROR: No matching issuer found
```
in CLI and
![Screenshot from 2024-07-22 10-13-12](https://github.com/user-attachments/assets/82a73c9a-ca46-4880-b94e-e979d30ae97c)

in web console.
This commit is contained in:
Adam Obuchowicz 2024-07-29 17:00:50 +02:00 committed by GitHub
parent a638d8e54e
commit a64b2c0a08
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
app/ide-desktop/client/src/index.ts
View File

@ -68,20 +68,6 @@ class App {
}
})
electron.app.commandLine.appendSwitch('allow-insecure-localhost', 'true')
electron.app.commandLine.appendSwitch('ignore-certificate-errors', 'true')
electron.app.commandLine.appendSwitch('ignore-ssl-errors', 'true')
electron.app.commandLine.appendSwitch('ignore-certificate-errors-spki-list', 'true')
electron.app.on(
'certificate-error',
(event, _webContents, _url, _error, _certificate, callback) => {
// Prevent having error
event.preventDefault()
// and continue
callback(true)
},
)
const { windowSize, chromeOptions, fileToOpen, urlToOpen } = this.processArguments()
if (this.args.options.version.value) {
await this.printVersion()
@ -226,10 +212,8 @@ class App {
}
logger.groupMeasured('Setting Chrome options', () => {
const perfOpts = this.args.groups.performance.options
add('ignore-certificate-errors-spki-list')
add('allow-insecure-localhost')
// Needed to accept localhost self-signed cert
add('ignore-certificate-errors')
add('ignore-ssl-errors')
addIf(perfOpts.disableGpuSandbox, 'disable-gpu-sandbox')
addIf(perfOpts.disableGpuVsync, 'disable-gpu-vsync')
addIf(perfOpts.disableSandbox, 'no-sandbox')