From ab5fe1757efe673bffb4038b5da82cfc0843e9fd Mon Sep 17 00:00:00 2001 From: Hubert Plociniczak Date: Tue, 2 Apr 2024 13:46:44 +0200 Subject: [PATCH] Fix expectations in lock manager test (#9592) The test optimistically assumed that threads will mostly execute in order, while ignoring all other possibilities. Changes the order of the report so that we remove the potential non-determinism. As discovered in https://github.com/enso-org/enso/actions/runs/8516468592/job/23325541262?pr=9584#step:8:1530 --- .../scala/org/enso/lockmanager/ConnectedLockManagerTest.scala | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/scala/connected-lock-manager/src/test/scala/org/enso/lockmanager/ConnectedLockManagerTest.scala b/lib/scala/connected-lock-manager/src/test/scala/org/enso/lockmanager/ConnectedLockManagerTest.scala index 8b2228d2df..fba2efa158 100644 --- a/lib/scala/connected-lock-manager/src/test/scala/org/enso/lockmanager/ConnectedLockManagerTest.scala +++ b/lib/scala/connected-lock-manager/src/test/scala/org/enso/lockmanager/ConnectedLockManagerTest.scala @@ -74,8 +74,8 @@ class ConnectedLockManagerTest ) ) ) { _ => - sync.signal("primary-acquired") sync.report("primary-acquired") + sync.signal("primary-acquired") sync.waitFor("connected-is-waiting") sync.report("primary-releasing") } @@ -122,8 +122,8 @@ class ConnectedLockManagerTest ) ) ) { _ => - sync.signal("primary-acquired") sync.report("primary-acquired") + sync.signal("primary-acquired") sync.waitFor("connected-acquired") }