enso-org/enso
1
1
Fork 0
mirror of https://github.com/enso-org/enso.git synced 2024-11-23 16:18:23 +03:00
Code Issues Projects Releases Wiki Activity

CI: Remove Manual Stdlib Compilation (#9033)

Browse Source 
CI currently manually compiles standard library. However, this became redundant since the `buildEngineDistribution` included the very same behavior.
Because of that, we ended up compiling the libraries twice.
This commit is contained in:
Michał Wawrzyniec Urbańczyk 2024-02-13 09:50:07 +01:00 committed by GitHub
parent eb59b475f6
commit cf19115432
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 0 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
build/build/src/engine/context.rs
View File

@ -517,20 +517,6 @@ impl RunContext {
// === Build Distribution === // === Build Distribution ===
debug!("Building distribution"); debug!("Building distribution");
if self.config.build_engine_package() {
let std_libs =
&self.repo_root.built_distribution.enso_engine_triple.engine_package.lib.standard;
// let std_libs = self.paths.engine.dir.join("lib").join("Standard");
// Compile the Standard Libraries (Unix)
debug!("Compiling standard libraries under {}", std_libs.display());
for entry in ide_ci::fs::read_dir(std_libs)? {
let entry = entry?;
let target = entry.path().join(self.paths.version().to_string());
enso.compile_lib(target)?.run_ok().await?;
}
}
if self.config.build_native_runner { if self.config.build_native_runner {
debug!("Building and testing native engine runners"); debug!("Building and testing native engine runners");
runner_sanity_test(&self.repo_root, None).await?; runner_sanity_test(&self.repo_root, None).await?;

10
build/build/src/enso.rs
View File

@ -98,16 +98,6 @@ impl BuiltEnso {
Ok(command) Ok(command)
} }
pub fn compile_lib(&self, target: impl AsRef<Path>) -> Result<Command> {
ide_ci::fs::require_exist(&target)?;
let mut command = self.cmd()?;
command
.arg(IrCaches::Yes)
.args(["--no-compile-dependencies", "--no-global-cache", "--compile"])
.arg(target.as_ref());
Ok(command)
}
pub async fn run_tests( pub async fn run_tests(
&self, &self,
ir_caches: IrCaches, ir_caches: IrCaches,