From f1a283be03e6cdf2561dfa90df651ff69d027850 Mon Sep 17 00:00:00 2001 From: Adam Obuchowicz Date: Wed, 11 Dec 2024 18:34:10 +0100 Subject: [PATCH] Increase timeout of macOS E2E tests (#11837) --- .github/workflows/gui.yml | 2 +- build/build/src/ci_gen/job.rs | 13 ++++++++----- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/.github/workflows/gui.yml b/.github/workflows/gui.yml index d31f764501..c20b8cbca9 100644 --- a/.github/workflows/gui.yml +++ b/.github/workflows/gui.yml @@ -436,7 +436,7 @@ jobs: ENSO_IDE_AG_GRID_LICENSE_KEY: ${{ vars.ENSO_AG_GRID_LICENSE_KEY }} ENSO_IDE_MAPBOX_API_TOKEN: ${{ vars.ENSO_MAPBOX_API_TOKEN }} GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - - run: corepack pnpm -r --filter enso exec playwright test + - run: corepack pnpm -r --filter enso exec playwright test --timeout 300000 env: DEBUG: "pw:browser log:" ENSO_TEST_USER: ${{ secrets.ENSO_CLOUD_TEST_ACCOUNT_USERNAME }} diff --git a/build/build/src/ci_gen/job.rs b/build/build/src/ci_gen/job.rs index ba294a0602..8903b5e0a6 100644 --- a/build/build/src/ci_gen/job.rs +++ b/build/build/src/ci_gen/job.rs @@ -581,12 +581,15 @@ impl JobArchetype for PackageIde { .customize(move |step| { let mut steps = prepare_packaging_steps(target.0, step); const TEST_COMMAND: &str = "corepack pnpm -r --filter enso exec playwright test"; - let test_step = if target.0 == OS::Linux { - shell(format!("xvfb-run {TEST_COMMAND}")) + let test_step = match target.0 { + OS::Linux => shell(format!("xvfb-run {TEST_COMMAND}")) // See https://askubuntu.com/questions/1512287/obsidian-appimage-the-suid-sandbox-helper-binary-was-found-but-is-not-configu - .with_env("ENSO_TEST_APP_ARGS", "--no-sandbox") - } else { - shell(TEST_COMMAND) + .with_env("ENSO_TEST_APP_ARGS", "--no-sandbox"), + + OS::MacOS => + // MacOS CI runners are very slow + shell(format!("{TEST_COMMAND} --timeout 300000")), + _ => shell(TEST_COMMAND), }; let test_step = test_step .with_env("DEBUG", "pw:browser log:")