Commit Graph

5394 Commits

Author SHA1 Message Date
Sergei Garin
55869327d9
Wip/sergeigarin/fix-focus (#11112)
* Fix selecting directory after creating

* Fix focusing
2024-09-18 12:28:05 +03:00
Hubert Plociniczak
862100c7c0
More info when we fail to log AssertError (#11113)
Motivation:
```
Caused by: java.lang.AssertionError: No polyglot context is entered. A language or context reference must not be used if there is no polyglot context entered.
	at org.graalvm.truffle/com.oracle.truffle.polyglot.PolyglotFastThreadLocals.assertValidGet(PolyglotFastThreadLocals.java:481)
	at org.graalvm.truffle/com.oracle.truffle.polyglot.PolyglotFastThreadLocals$ContextReferenceImpl.get(PolyglotFastThreadLocals.java:513)
 	at org.enso.runtime/org.enso.interpreter.runtime.EnsoContext.get(EnsoContext.java:246)
	at org.enso.runtime/org.enso.interpreter.runtime.error.PanicException.computeMessage(PanicException.java:90)
```
2024-09-17 23:20:14 +02:00
Hubert Plociniczak
567910ae14
Try harder to deal with stuck index generation (#11098)
`Process.destroy` sends `SIGTERM` instead of `SIGKILL` meaning that we
have to try harder to deal with stuck index generation.
2024-09-17 23:19:49 +02:00
Dmitry Bushev
9179dff89f
Move execution environment from State to EnsoContext (#11075)
related #10719

Changelog:
- refactor: move execution environment from `State` to `EnsoContext`
2024-09-17 20:50:03 +00:00
Pavel Marek
78597fb74c
Benchmark static site generator does not include so many records (#11115)
Limit the starting date to fetch the benchmarks from to 01-04-2024. As of today, [Upload Benchmarks GH Action](https://github.com/enso-org/enso/actions/workflows/bench-upload.yml) is [failing](https://github.com/enso-org/enso/actions/runs/10896413686/job/30236182995#step:6:6303) because it tries to push a HTML file bigger than 100 MB.
2024-09-17 20:39:11 +00:00
Dmitry Bushev
8e0095e1f8
Stack Overflow Error not shown in GUI (#11064)
close #8648

Changelog:
- update: handle null messages in execution exceptions
2024-09-17 18:43:35 +00:00
dependabot[bot]
343f6830a7
Bump send and express in /tools/simple-library-server (#11072)
Bumps [send](https://github.com/pillarjs/send) to 0.19.0 and updates ancestor dependency [express](https://github.com/expressjs/express). These dependencies need to be updated together.


Updates `send` from 0.18.0 to 0.19.0
- [Release notes](https://github.com/pillarjs/send/releases)
- [Changelog](https://github.com/pillarjs/send/blob/master/HISTORY.md)
- [Commits](https://github.com/pillarjs/send/compare/0.18.0...0.19.0)

Updates `express` from 4.19.2 to 4.21.0
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.0/History.md)
- [Commits](https://github.com/expressjs/express/compare/4.19.2...4.21.0)

---
updated-dependencies:
- dependency-name: send
  dependency-type: indirect
- dependency-name: express
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-17 18:51:29 +01:00
dependabot[bot]
8bb9edab54
Bump path-to-regexp and express in /tools/legal-review-helper (#11074)
Bumps [path-to-regexp](https://github.com/pillarjs/path-to-regexp) to 0.1.10 and updates ancestor dependency [express](https://github.com/expressjs/express). These dependencies need to be updated together.


Updates `path-to-regexp` from 0.1.7 to 0.1.10
- [Release notes](https://github.com/pillarjs/path-to-regexp/releases)
- [Changelog](https://github.com/pillarjs/path-to-regexp/blob/master/History.md)
- [Commits](https://github.com/pillarjs/path-to-regexp/compare/v0.1.7...v0.1.10)

Updates `express` from 4.18.2 to 4.21.0
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.0/History.md)
- [Commits](https://github.com/expressjs/express/compare/4.18.2...4.21.0)

---
updated-dependencies:
- dependency-name: path-to-regexp
  dependency-type: indirect
- dependency-name: express
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-17 16:49:26 +02:00
Hubert Plociniczak
031300dfb3
Don't NPE when Throwable is missing message (#11102)
Looks like `Throwable` thrown by the execution may be missing a message,
which later crashes when we want to send it over the wire.
Added some guards to prevent NPE.
2024-09-17 16:37:38 +02:00
Pavel Marek
3dd0fb95ae
Better error message for unresolved symbol (#11008)
* Add failing tests

* ExtensiomMethod resolution in the current module might be an error in GlobalNames

* Add another successful test

* Fix compilation error test

* Fix compilation of RedShift_Spec - `setup` is provided in compile scope
2024-09-17 15:38:31 +02:00
James Dunkerley
b2545b8b96
Small tweaks from using Process.run (#11110)
* Once more unto the lint dear friends.

* Default the arguments for process run.
Allow delimiter to be used to convert Text to Table.
2024-09-17 14:27:25 +01:00
Adam Obuchowicz
5725e2427d
Allow numbers starting with dot in WidgetNumber (#11108)
[Screencast from 2024-09-17 13-20-40.webm](https://github.com/user-attachments/assets/561adebb-7d93-4939-9dde-5453d5f304be)
2024-09-17 13:07:06 +00:00
Adam Obuchowicz
dfc04f4222
Renaming project: fix invalid state when the name does not change (#11103)
Fixes #11101

I did not add tests for it, because I think we'll remove this rename feature in the future.
2024-09-17 13:26:06 +02:00
Jaroslav Tulach
f2a809c4e1
Avoid dependency on org.graalvm.collections (#11107)
I am trying to compile Enso with GraalVM 24.2.0 snapshot to verify that https://github.com/oracle/graal/pull/8266 changes would work for Enso. Among the problems I am facing is a dependency on `org.graalvm.collections` because of using `Pair`. I don't think we need such dependency. Let's avoid it by using our own `record` with two components.
2024-09-17 11:25:18 +00:00
Adam Obuchowicz
667ce038e7
Fix node removing bug, caused by spurious watchEffect effect. (#11099)
Fixes [#11062](https://github.com/enso-org/enso/issues/11062)

Modified watchEffect to be consistent with Vue behavior + tests. Before the scheduled effects were run even if stopped.

Why it fixes nodes removal? See [this comment](https://github.com/enso-org/enso/issues/11062#issuecomment-2352975474)
2024-09-17 07:12:59 +00:00
Sergei Garin
b14f19f8f7
Fix table dissapear after switching tabs (#11096) 2024-09-16 19:14:09 +00:00
James Dunkerley
0e9821519d
Widget work for AWS (#11095)
- Added `to_display_text` for `S3_File` and `Enso_File`.
- Improved widget for `AWS_Credential` allowing use of Enso secrets.
- Adjust `S3.list_objects` to return `S3_File` objects, allowing easier drill down.
- Fix for merging inherited config with direct config in widgets.
- Add missing constant types to Date.Diff widget.

![image](https://github.com/user-attachments/assets/ea125a09-5067-4dee-bef2-3d7c8d551260)
2024-09-16 18:56:14 +00:00
Sergei Garin
0b91002933
Fix importing conflicting files (#11087)
Closes: enso-org/cloud-v2#1484
2024-09-16 16:16:11 +00:00
James Dunkerley
6ca2c337d0
Disable Invite button for solo/free. (#11089)
Currently shows up in solo mode, enough to just have the Upgrade button.
2024-09-16 15:18:09 +00:00
Adam Obuchowicz
53e101566a
Fix Numeric Input cooperation with Drop Down (#11091)
Fixes #11063

The blur on Numeric Input was removed in https://github.com/enso-org/enso/pull/10337 and then reintroduced in https://github.com/enso-org/enso/pull/10512. I guess it was to handle `tab` properly, so I added another way of handling `tab` and removed blur again (with explanation).
2024-09-16 14:46:58 +00:00
Sergei Garin
bea9d3670a
Follow-up for Remote backend fixes PR (#11080)
This PR is a follow-up for https://github.com/enso-org/enso/pull/11067 that addresses the issues raised in the PR
2024-09-16 12:18:03 +00:00
somebody1234
cad50a5b63
Dashboard fixes (#11059)
- Fix https://github.com/enso-org/cloud-v2/issues/1482
- Fix "clear trash" not doing anything
- Show "shared with" column as "root folder", but only owners (TODO: actually it should only show the first item in the permissions list)
- Fix https://github.com/enso-org/cloud-v2/issues/1480
- Fix importing .enso-projects not doing anything
- Could not repro crash. Also note that we do want to be able to upload files
- Partly address https://github.com/enso-org/cloud-v2/issues/1479
- Remove "invite" and "share" buttons on top right
- Hide "upgrade" button on top right if on Team or Enterprise plan
- Warn when deleting folder (for now warns for all folders otherwise we may need to expand the folder to know whether it is empty)
- Fix importing projects via upload button
- Fix importing projects via drag
- Hide cut on running projects
- Partly address https://github.com/enso-org/cloud-v2/issues/1481
- Fix "edit secret" not showing dialog
- Fix multiple selection context menu in Team space

# Important Notes
None
2024-09-16 09:03:49 +00:00
Jaroslav Tulach
a6fbdb11ce
Avoid using assert in Scala, use assertInJvm to elide it in production (#11027)
Fixes #11022 and in general fixes #5787 by avoiding calls to Scala's `assert` function and using regular one written in Java that uses `assert` keyword and is thus sensitive to `-ea` command line option of the JVM. Use `assertInJvm` in newly written Scala code to get typical JVM behavior on `assert`.
2024-09-16 06:32:47 +00:00
Hubert Plociniczak
d795518a8f
Poor man's hack to deal with stuck index generation (#11065)
* Poor man's hack to stuck index generation

CI has started experiencing instability when generating libraries
indexes. This change ensures that we don't wait 360(!) minutes until it
gives up.

A proper diagnosis is in progress, obviously.

* Get threaddump of the stuck process

* remove deprecation
2024-09-15 10:59:54 +02:00
Hubert Plociniczak
d7e8b083f8
Regenerate workflows after bumping wasm-pack (#11079) 2024-09-15 08:59:23 +00:00
Hubert Plociniczak
742fc5f9ea
Fix invalid version of wasm-pack (#11078)
Long shot to potentially fix wasm-pack/wasm-bindgen generation issues.
Hosted MacOS ARM runner uses `0.12.1` and that one works.
2024-09-14 21:06:13 +02:00
Hubert Plociniczak
8fab4f5ea6
Workaround for Electron sanbox issues on Ubuntu (#11038)
* Workaround for Electron sanbox issues on Ubuntu

Disabling sanbox, while a non-secure option, appears to be currently the
only option to workaround Electron issues on latest Ubuntu (24.04).
When passed to Enso it is treated as a regular argument, preventing the
start of the product.
This change treats `--no-sandbox` specially by ignoring all arguments
that precede it (and including itself).

* address review
2024-09-13 23:25:32 +02:00
somebody1234
066d4ea609
Local dashboard fixes (#11066)
- Fix https://github.com/enso-org/cloud-v2/issues/1479
- See #11059 for rest of fixes.
- When you add a new folder it is now selected and in rename mode
- Double click opening no longer adds (2) to the name when there are no duplicates
- When dragging a file to upload, the "Drop here to upload box" now properly disappears after dropping
- Fix removing folder from favorites list

Other changes:
- Switch "delete user" modal to new "Dialog" and "Form" components instead of old "Modal" and HTML "form" components

# Important Notes
None
2024-09-13 16:49:14 +00:00
Sergei Garin
bdadedbde5
Cloud backend issues (#11067)
Closes: enso-org/cloud-v2#1481
2024-09-13 15:46:30 +00:00
Sergei Garin
b5122348da
MFA (#10875)
* Draft checkbox component

* Fixes in Setup Page

* Invite Users

* Add usergroup setup after subscription

* Fix comments

* Refetch Interval + Feature Toggles

* Fix lint

* Address issues

* Fix Dialog

* Assign users to the user group

* Use transitions to navigate between steps

* Small fixes

* Improve styling for scrollbars

* Fix typescript

* OTP input

* Fix setup logic

* Show Setup dialog only for admins

* Add otp

* OTP input

* 2FA settings section

* Small improvements

* Fixes

* Small fixes

* Remove w-full

* TOTP at login

* Fixes in 2FA

* Fixes in types

* Fix totp

* Merge fixes

* Merge fixes x2

* Merge fixes x2

* Fix types

* Fix types

* Fix cancel button

* Fix reset button

* Fix types

* Fix prettier

* Fix prettier

* Fix lint

* Fix lint

* Fix control

* Address prettier

* Fix MFA mock

* Fix sign in message

* Fix tests

* Address CR

* Fix types
2024-09-13 16:00:31 +03:00
Sergei Garin
3c1db7dbc1
Remove edit name on mod+click (#11058)
Closes: enso-org/cloud-v2#1476
2024-09-13 12:51:35 +00:00
Sergei Garin
16a4466156
Handle 403 for listGroups and getOrganization (#11044)
Closes: enso-org/cloud-v2#1470

This PR handles 403 responses for certain RemoteBackend endpoints
2024-09-13 12:43:02 +00:00
Dmitry Bushev
e77a6067a0
Fix cached method pointers in expression updates (#11060)
close #11028

Changelog:
- update: hide cached method pointer info in expression updates of evaluated values

# Important Notes
https://github.com/user-attachments/assets/861bb2c8-7613-4fcf-a976-0e37acff4ec0
2024-09-13 11:02:30 +00:00
James Dunkerley
8eb9e21e40
Updated feature list (#11061)
Update the list of what is in what...
![image](https://github.com/user-attachments/assets/65abca35-9e39-4a7c-a001-230923ff04d3)
2024-09-12 20:09:00 +00:00
Adam Obuchowicz
8908a73f6a
Fix Vector Drag (#11057) 2024-09-12 11:20:49 +01:00
AdRiley
b8516f7b4a
Make all Common_Spec tests pass for SQLSerever (#10810)
* More SQL tests

* Remove duplicate

* Fix another test

* Temp fix

* More temporay fixes

* More green

* Another green

* Another one

* Fix counts

* Temporary change

* Fix tests

* Auto-commit work in progress before clean build on 2024-09-06 10:53:46

* Another fix

* Green

* Specialise ensure_query_has_no_holes

* cleanup

* Cleanup

* Cleanup

* Clean

* Code review changes
2024-09-12 10:08:55 +01:00
GregoryTravis
f409cb8aac
fix test (#11049)
Repairs a test not run in CI
2024-09-11 16:34:07 +01:00
Sergei Garin
ea0f5a1962
Open a welcome dialog after user signed up (#11029)
Closes: enso-org/cloud-v2#1475
2024-09-11 15:26:14 +00:00
AdRiley
a666585afe
Add update mode to Running (#11045) 2024-09-11 17:41:33 +03:00
GregoryTravis
97a1628017
Add a banker's rounding primitive for Snowflake (#11037)
* log table_builder create

* fix log, 38,12

* fix scale in rounding tests

* shorten some decimals

* fix test

* dialect flags

* revert native bankers

* missing import

* sf builtin

* runs

* works on +/-2/4.5

* remove extreme precision limit tests

* remove another extreme precision test, and restore batching for bankers rounding tests

* cleanup

* cleanup

* cleanup, comment
2024-09-11 10:29:41 -04:00
marthasharkey
4ac59827df
Scatterplot fixes (#11041) 2024-09-11 14:03:40 +00:00
James Dunkerley
a33376c8d7
Better workaround for missing root folder. (#11046)
With the changes for asset directory the auto-creation condition was failing.

This should make it work again.
2024-09-11 13:18:27 +00:00
Ilya Bogdanov
a0a4a2fef3
Add regression e2e test for empty graph (#11031)
Closes #11026
2024-09-11 11:40:24 +00:00
Adam Obuchowicz
497da82b10
Fix file associations on Windows + opening project bug (#11030)
* Fixes [#10983](https://github.com/enso-org/enso/issues/10983) The `ext` field was not set according to the documentation in rust
* Also discovered a regression in opening project by passing argument/clicking the file: we store the file location as `file://` URL, but without caution, it made a havoc with windows paths.

# Important Notes
- [x] **Need to confirm that everything works on macOS** (installation with file associations + opening project when process is running and when not)
2024-09-11 10:44:52 +00:00
Dmitry Bushev
bea9e068b4
Remove pool of FileManager actors (#11036)
close #10970

Changelog:
- remove: FileManager actors pool

Language Server executes IO on a separate thread pool for blocking operations and does not block the actor
2024-09-11 08:15:54 +00:00
Jaroslav Tulach
8b5c6338f7
Log details when to_display_text invocation fails (#11025)
Closes #10770 by dumping out more information when `to_display_text` invocations fails.
2024-09-11 03:18:06 +00:00
Kaz Wesley
1bcbc00004
Update Vue (#11016)
See: https://blog.vuejs.org/posts/vue-3-5
2024-09-10 13:18:35 -04:00
somebody1234
097f5b231d
Fix Datalinks (#11003)
- Fix https://github.com/enso-org/enso/pull/10929#issuecomment-2333467567
- Fix incorrect requests being sent for newly created Datalinks
- Fix Datalinks being created in the root folder instead of the current folder due to clicks on the dialog deselecting the currently selected folder
- Fix auto-scroll caused by Assets Table refreshing

# Important Notes
None
2024-09-10 14:59:04 +00:00
Dmitry Bushev
ab0a5e0c36
Improve the speed of preorder operation on IR (#11019)
close #10537

Changelog:
- add: implement `IR.preorder` method with callback
- update: update `IR.preorder` method usages

# Important Notes
Shows ~10% speed improvement during the compilation
2024-09-10 14:47:50 +00:00
Hubert Plociniczak
62e15696ec
Re-compile module if IdMap is present (#11032)
Loading IR caches and IdMap for a module don't play very well. Rather
than complicating logic and introducing yet another re-compilation
request let's not even attempt to deserialize a module if IdMap is
present. The cost of compiling a single module (right now containing the
project itself) is negligble, compared to a possibility of bugs that
we've encountered so far.
2024-09-10 16:24:57 +02:00