8 Commits

Author	SHA1	Message	Date
Dmitry Bushev	db0582d11c	Metadata should not depend on absolute text spans (#11390) ... close #11304 Changelog: - update: add `ide.snapshot` optional metadata field containing the source code of the file - update: `syncFileContents` method tries to repair the metadata spans when it detects that the source file was edited and the received code does not match the code stored in the `ide.snapshot` metadata field # Important Notes Tested in gui	2024-10-28 09:41:46 +00:00
somebody1234	5faddf52f0	Fix ESLint errors, add some docs (#11339) ... - Fix ESLint errors - Add documentation for *some* functions with blank documentation # Important Notes None	2024-10-21 12:56:39 +00:00
Kaz Wesley	4d4a2990a0	Distinguish assignment/thunk by statement context (#11324) ... Align `Assignment`/`Function` distinction in AST with compiler's implemented semantics: - The ambiguous case `funcOrVar = expression` is now parsed as a `Function` when in a `Type` definition or in the top level of a module. I.e. it is an `Assignment` in contexts where the RHS is evaluated immediately when the binding is evaluated, and a `Function` in contexts where the RHS is evaluated each time the bound name is evaluated. - `Assignment` statements now may only occur in function bodies. Correcting this distinction lays the groundwork for #11302. Other changes: - Fixed incorrect source code locations for negative literals and negated expressions. # Important Notes New APIs: - The parser now exposes a `parse_block` entry point, which allows parsing input lines as if in the body of a function. The previous entry point has been renamed to `parse_module`.	2024-10-18 17:54:55 +00:00
Adam Obuchowicz	4a249688e8	Unify Frontend App (#11287) ... Fixes #10668 Fixes #8484 Summary of changes: * `gui2` and `dashboard` are merged to `gui` directory. Various configs were merged (package.json, playwrigth, TS...). The src and e2e directories are split to `dashboard` and `project-view` for now. * E2E tests run two servers on different ports. The tests are organized in projects. This is also to be changed soon, as we plan to [use better mocking in GUI/ProjectView](#9726) * ESlint configs were merged to central `eslint.config.mjs`, and that file was moved to repository root. We kept the dashboard lints, but they can be relaxed. The dashboard code was changed to meet GUI lints. * Also, the versions of linter plugins were bumped, and code fixed. * The ide-desktop/client no longer has `dashboard` dependency - the only type used there was moved to common package. * `common` package moved to `app`.	2024-10-11 18:23:02 +00:00
Kaz Wesley	582b7f9a2e	Fullscreen improvements (#10876) ... Implements #10686. - Add fullscreen modes to doc editor and code editor - Contain fullscreen view within graph editor tab - Prevent persisting or synchronizing fullscreen state - Animate transition https://github.com/user-attachments/assets/e88801c2-8c56-494b-8500-95fbd76c4322	2024-08-23 13:00:44 +00:00
Adam Obuchowicz	22263e8ff9	Y-docs: Fix write capability recovery (#10851) ... When receiving no write capability in `text/openFile` response, the method returned error without synchronizing, but session state stayed at 'Opening' - this resulted in automatic success on the next retry without actually trying. Added additional state to handle recovery from missing write capability errors. # Important Notes tested by applying the patch below (which simulates problem reported by James): ```diff diff --git a/app/ydoc-shared/src/languageServer.ts b/app/ydoc-shared/src/languageServer.ts index e1403f50420247575b437df8c603e5f1701b5e1d..753bbf9f9f449f6130c79040e44607ce0c308f7f 100644 --- a/app/ydoc-shared/src/languageServer.ts +++ b/app/ydoc-shared/src/languageServer.ts @@ -3,6 +3,7 @@ import { bytesToHex } from '@noble/hashes/utils' import { Client, RequestManager } from '@open-rpc/client-js' import debug from 'debug' import { ObservableV2 } from 'lib0/observable' +import { wait } from 'lib0/promise.js' import { uuidv4 } from 'lib0/random' import { z } from 'zod' import { walkFs } from './languageServer/files' @@ -268,9 +269,25 @@ export class LanguageServer extends ObservableV2<Notifications & TransportEvents return this.request('session/initProtocolConnection', { clientId }, false) } + private openCalls = 0 /** [Documentation](https://github.com/enso-org/enso/blob/develop/docs/language-server/protocol-language-server.md#textopenfile) */ openTextFile(path: Path): Promise<LsRpcResult<response.OpenTextFile>> { - return this.request<response.OpenTextFile>('text/openFile', { path }) + if (this.openCalls === 0) { + this.openCalls = 1 + return wait(1000).then(() => + Err(new LsRpcError('Simluated timeout', 'text/openFile', { path })), + ) + } else if (this.openCalls === 1) { + this.openCalls = 2 + return this.request<response.OpenTextFile>('text/openFile', { path }).then(value => { + if (value.ok) { + value.value.writeCapability = null + } + return value + }) + } else { + return this.request<response.OpenTextFile>('text/openFile', { path }) + } } /** [Documentation](https://github.com/enso-org/enso/blob/develop/docs/language-server/protocol-language-server.md#textclosefile) */ ```	2024-08-20 14:42:25 +00:00
Adam Obuchowicz	09c4b7a993	Fix file open retry in ydocs server (#10787) ... There is a code for exponential back off, but the result with error was lost at one place. Tested by mocking timeouts in our `lanugageServer.ts` Fixes #10606	2024-08-12 09:57:29 +00:00
Paweł Grabarz	b286adaae4	Split ydoc server into separate module (#10735) ... # Important Notes The command to run the gui dev environment has been changed. Invoking the old command will print a message about that. From now on, use `pnpm dev:gui2` in repository root.	2024-08-08 12:12:05 +00:00