1404 Commits

Author	SHA1	Message	Date
Jaroslav Tulach	0cde0e7f96	More detailed No_Such_Method error message for function like objects (#10328)	2024-06-25 11:36:56 +02:00
Jaroslav Tulach	fe2cf49568	Run whole test/Base_Tests in native image runner (#10296)	2024-06-21 06:03:53 +02:00
Hubert Plociniczak	114b3a5c5e	Cleaning up YAML parsing in preparation for circe-yaml removal (#10309) ... The current implementation contains logic that should enable us to make some backward compatibility config changes. At the same time, the logic is tightly integrated with circe's JSON library, which we want to eventually to get rid off. Rather than trying to keep it somehow around and maintain via some hacks this PR proposes to ditch that logic completely as we currently have no use-case for such scenarios. As a result, classes modelling YAML configs now don't have the extra fields and there is 1:1 correspondence. Performance has also improved although that wasn't the main objective, yet. Follow up PR will attempt to replace `circe-yaml` with `snakeyaml` directly. In preparation for #9113. Note that the dependency upgrade is necessary because it brings latest available `snakeyaml` (as part of `circe-yaml`).	2024-06-20 13:07:54 +00:00
Dmitry Bushev	06a73606b9	Async Ydoc initialization (#10290) ... close #10265 Changelog: - add: YdocInitialization component	2024-06-17 08:10:21 +00:00
Dmitry Bushev	04a92ef765	TextEdit with custom IdMap (#10283) ... close #10182 Changelog: - add: IdMap parameter to the `text/applyEdit` request - add: IdMap to the runtime module - update: set IdMap during the interactive compilation - update: set the IR identifiers in the `TreeToIR` parsing step	2024-06-15 18:03:18 +00:00
Jaroslav Tulach	dee9e079d4	Enso language support with parser in VSCode, IGV, etc. (#7054) ... Outline view and completions for Enso code in VSCode. # Important Notes This PR provides the necessary infrastructure for building VSCode extension that includes `enso_parser` library compiled for all supported platforms. VSCode extension can now use libraries from `sbt` that are `publishM2`-ready. To make that possible a documentation must have been provided and fixed for those modules - hence so many changes in `.scala` classes. <img width="862" alt="image" src="https://github.com/enso-org/enso/assets/26887752/7374bf41-bdc6-4322-b562-85a2e761de2a"> Last, but not least. The outline view and completions display something.	2024-06-14 14:01:37 +00:00
Hubert Plociniczak	dc6e3a7031	Soft retries when awaiting runtime responses (#10272) ... A quick and dirty workaround for slow processing in a similar spirit to PR #9858. Long compilation of stdlib holds a write compilation lock, while opening the file needs to set module sources and requires read compilation lock and file lock. The expectation was that setting module sources is instantaneous except not, because of locks. This PR adds soft retries. Partially closes #10231. There are still problems related to https://github.com/enso-org/enso/issues/9993 once this PR is merged. # Important Notes We need to figure out a more fine-grained lock system or, ideally, make it lock free to avoid such hacks.	2024-06-14 09:05:48 +00:00
Radosław Waśko	3b566709f3	Type Inference PoC - iteration 1 - most basic type inference (#8652) ... - Closes #8590	2024-06-13 16:23:56 +00:00
Hubert Plociniczak	d6d370925a	Removing dependencies to speed up startup (#10249) ... Reducing the number of dependencies. Explicit `cats` are almost gone (present in `cli`). `enumeration` is completely gone. `cats` is also still included implicitly via `io.circe` but that's a different kind of beast. Also, really removed `jackson` from dependencies by fixing the dependency on `http-test-helper`. # Important Notes In a number of places importing all cats implicits could be simply replaced with a single or two method calls. Not to mention that this will reduce compilation times due to reduced implicit search space. One example of how the changes affect performance (not only startup): Before:  Now:  (frequently executed)  Also appears to be gone. This PR is by no means finished. The purge will continue in follow up PRs.	2024-06-12 18:15:36 +00:00
Jaroslav Tulach	5339484285	shouldCreateClosureRootNode when valueHasSomeTypeCheck (#10262) ... Fixes #10236.	2024-06-12 14:04:50 +00:00
Jaroslav Tulach	87864bf564	Presence of Any disables type checks (#10248) ... Fixes #10237 by avoiding creation of `ReadArgumentCheckNode` when the requested type allows `Any`.	2024-06-12 11:10:23 +00:00
Radosław Waśko	c4b0ca8f69	Ensure type ascriptions are correctly transformed to facilitate checking of more complex return types (#10229) ... - Fixes #9980 - Adds some tests to ensure types like `|` or `&` (in addition to `!` from the ticket) correctly work in return type check. - Fixes a weird behaviour where we used to avoid processing type related IR transformations inside of type ascriptions. - Adds parentheses to type representations if they are more complex: `A | B & C` is unclear as it can either mean `A | (B & C)` or `(A | B) & C` which have different meanings. If we now have an operation with such nesting, the sub expressions are wrapped in parentheses to disambiguate.	2024-06-11 17:11:03 +00:00
Hubert Plociniczak	4da5e611c9	Replace Jackson serde (#10035) ... JSON serialization setup between Language Server and Runtime is a major contributor to startup time. This PR experiments with an alternative implementation that remedies the problem. The new serializer uses [jsoniter-scala](https://github.com/plokhotnyuk/jsoniter-scala) which by some accounts claims to be really fast. In our case, more importantly, we pay negligible cost of startup setup compared to Jackson which was horribly slow. # Important Notes Before:  After:  Yes. About 0.8sec.	2024-06-11 15:03:12 +00:00
Jaroslav Tulach	aaaebcabf8	Implement and benchmark ArrowOperationPlus node (#10150) ... Prototype of #10056 showing `+` operation implemented in the _Arrow language_.	2024-06-11 12:50:59 +00:00
Pavel Marek	5fa29c51b5	Fix Meta.enso_project (#10192) ... Fixes `Standard.Base.Meta.Enso_Project.enso_project` to return a project descriptor for the *main* project, i.e., the one configured as a *root* for the engine. # Important Notes `enso_project` builtin no longer iterates the stack frames to infer the project descriptor. It derives it from the default package repository.	2024-06-11 08:31:40 +00:00
Radosław Waśko	99a1d052a0	Fixes to Persistance (#10101) ... - Follow-up to #9361 - Enables assertions and fixes `count` check - Tests and fixes null references - Tests and fixes serializing a deserialized structure - by saving the id of the `Persistance` corresponding to the entry - After the change to how we determine which `Persistance` instance to use, the most specific one is now used (based on the saved id). This has an unfortunate consequence that `Seq` which is most of the time represented by a subtype of `List`, is now using `PersistScalaList` which is not lazy. - To alleviate that, we no longer use `Seq` to store some field lazily and instead use a dedicated type for that purpose: `InlineReference`.	2024-06-10 11:49:12 +00:00
James Dunkerley	d938c96c55	Adding type annotations and enabling auto-scoping (#10173) ... - Renamed `Missing_Required_Argument` to `Missing_Argument`, and added `throw` method. - Add default widget to `Case_Sensitivity.Insensitive locale`. - Switch to auto scoping for `parse_type_selector`. - Add type annotation to various simple typed arguments in `Table` and `DB_Table`. - Altered `Filter_Condition` to have `Missing_Argument` for all non-defaulted arguments. - Added resolution of `Column_Ref` passed as auto-scoped to `Table_Ref`. - Altered `Simple_Calculation` to have `Missing_Argument` for all non-defaulted arguments. - Altered `Join_Condition` to have `Missing_Argument` for all non-defaulted arguments. - Altered `Sort_Column` to have `Missing_Argument` for all non-defaulted arguments. - Altered `Aggregate_Column` to have `Missing_Argument` for all non-defaulted arguments. **rename_columns:**  **aggregate:**  **join:**  **set:** 	2024-06-10 07:52:32 +00:00
Dmitry Bushev	292d33ccc1	Fix refactor/renameProject with names containing unsupported characters (#10204) ... related #10073 Changelog: - fix: rename the project to the name containing unsupported characters	2024-06-07 12:34:01 +00:00
Pavel Marek	2ea2a57651	ydoc-server is a separate module (#10156) ... - Remove remnants of deprecated Scala parser - The following projects are now JPMS modules provided on system module-path (in components directory): - `ydoc-server` - `profiling-utils` - `syntax-rust-definition` - The contents of the aforementioned modules are excluded from both `runner.jar` and `runtime.jar` fat jars. - Suggestions are serialized and deserialized with our Persistance framework, rather than via the default Java OutputObjectWriter.	2024-06-07 12:56:42 +02:00
Jaroslav Tulach	396d70ddc0	Execute foreign function and check autoscoped constructor result (#10187) ... Fixes #10151 and also fixes #10180 and fixes #10186.	2024-06-06 13:16:27 +00:00
Hubert Plociniczak	1bc14252df	Extract mutable builder from ModuleScope (#9914) ... Refactored mutable parts of `ModuleScope` into builder to make it easier to reduce unnecessary locks. # Important Notes Elements of ModuleScope (types, imports etc) are used while _building_ of it may still be in progress. In order to make static typing happy, every `ModuleScope.Builder` can be exposed as (unmodifiable) `ModuleScope`.	2024-06-05 16:57:08 +00:00
Jaroslav Tulach	8332118ff4	What's the name of my method? (#10164) ... While working on #10056 I realized the names of method and closure nodes are incomprehensible to anyone. This PR replaces the infamous `<anonymous>` with a name hinting where the method actually is. # Important Notes I assume this change will be visible not only in IGV, but also in _stacktraces_ and we may need to adjust few tests.	2024-06-05 07:49:53 +00:00
GregoryTravis	1c2955655c	Add no_warning_propagation flag to Vector.build and Builder.new (#10079) ... * no_warning_propagation flag * doc * benchmarks * change to propagate_warnings, test * fix java benchmark * add benchmark to main	2024-06-04 09:06:09 -04:00
Dmitry Bushev	d08cb704b0	Record interaction between GUI and LS (#10107) ... close #8328 Changelog: - add: message callbacks to JsonRpc and Binary servers - update: use events log to collect the RPC messages	2024-06-03 06:50:59 +00:00
Jaroslav Tulach	9632f04e9b	Directly allocate warnings asVectorEnsoObjects (#10143)	2024-06-01 06:23:49 +02:00
AdRiley	af4177e61f	Make table default visualisation (#10128) ... Makes table the default vis type. Before:  After:  Closes #10093	2024-05-31 15:02:02 +00:00
Pavel Marek	270f708e4f	Implement private methods (#10060) ... Add support for private methods. Most of the changes are in parser and compiler. The runtime checking of private functions was already present since #9692 # Important Notes - Only top-level methods can be declared `private`. - private method cannot be called from different project - private method cannot be accessed from polyglot code (private method does not exist for polyglot code)	2024-05-31 08:00:20 +00:00
Jaroslav Tulach	c4bf9182aa	Give qualified name of type a location (#10138) ... Tests and fixes #9084.	2024-05-30 19:15:46 +00:00
Dmitry Bushev	f83ae1382e	Temporarily disable Ydoc startup (#10141) ... related #10134	2024-05-30 16:28:16 +00:00
Jaroslav Tulach	b2cf2f75fb	Extract the State from thunk's scope (#10120)	2024-05-30 17:24:06 +02:00
Pavel Marek	56b289ae79	Move common testing functionality to a separate project (#10112) ... Introduce a new `test-utils` project, and moves the `TestBase` there. Moreover, `TestBase` is renamed to `TestUtils` and is no longer an abstract class. # Important Notes `test-utils` project does not depend on junit, so it can be used, for example, by any benchmarks as well.	2024-05-29 11:50:03 +00:00
Jaroslav Tulach	6897f0d30c	Suspended arguments need one more child scope (#10104)	2024-05-28 17:53:08 +02:00
Dmitry Bushev	858e646328	Start Ydoc with the language server (#9862) ... - related #7954 Changelog: - update: Ydoc starts with the language server on the `localhost:1234` by default. The hostname and ports can be configured by setting environment variables `LANGUAGE_SERVER_YDOC_HOSTNAME` and `LANGUAGE_SERVER_YDOC_PORT` - update: by default `npm dev run` uses the node Ydoc server. You can control it with `POLYGLOT_YDOC_SERVER` env variable. For example, ``` env POLYGLOT_YDOC_SERVER='true' npm --workspace=enso-gui2 run dev ``` To connect to the Ydoc server running on the 1234 port (the one started with the language server) ⠀ ``` env POLYGLOT_YDOC_SERVER='ws://127.0.0.1:1235' npm --workspace=enso-gui2 run dev ``` To connect to the provided URL. Can be useful for debugging when you start a separate Ydoc process. - update: run `npm install` before the engine build. It is required to create the Ydoc JS bundle.	2024-05-28 13:51:42 +00:00
Hubert Plociniczak	8f9fc0822c	Avoid out-of-context interrupted lock exceptions (#10095) ... This change is a re-do of old PR https://github.com/enso-org/enso/pull/8270 that has been abandoned a while ago. The change attempts to address to case of random `InterruptedExceptions` that can result when a task is interrupted while waiting on a lock. In comparison to the original PR, this change introduces `withXYZLock` methods with a `Callable` parameter. As a result we ensure correct acquisition/release semantics, logging and handling of interruptions. # Important Notes https://github.com/enso-org/enso/pull/8270 was too much hassle to rebase against latest develop.	2024-05-28 08:50:21 +00:00
Jaroslav Tulach	921870f12b	Reactive RuntimeCache (#10065)	2024-05-27 10:52:58 +02:00
Dmitry Bushev	a269ad3582	Removing last node from main graph makes execution error (#10048) ... close #9172 Changelog: - update: insert `Empty` IR node for the empty method definition bodies - update: generate node resulting in `Nothing` for `Empty` IR nodes - refactor: remove redundant checked exceptions in `EnsoParserTest`	2024-05-24 14:11:06 +00:00
Hubert Plociniczak	495eed45ba	Turn strict errors off for Language Server (#10061) ... Ensure strict errors are off to prevent unrecoverable errors in IDE. Also partially reverted a change that prevented application of changes on errors (errors are still logged, as intended). Closes #10014.	2024-05-23 20:49:08 +00:00
Dmitry Bushev	4ca26c84ef	Filter private constructors from Suggestions Database (#10032) ... close #10011 Changelog: - feat: exclude private constructors from Suggestions database # Important Notes `java_table` field of the `Table` is hidden 	2024-05-23 06:48:29 +00:00
Jaroslav Tulach	16c1b74218	Enso Library Feature to execute (a bit of) Base_Tests (#9997)	2024-05-23 08:20:19 +02:00
Pavel Marek	ba2787c4d2	Ensure disable private check cmd line option disables runtime private access checks (#10034) ... Ensure that `--disable-private-check` cmd line option disables the runtime private access checks as well.	2024-05-22 16:35:24 +02:00
Pavel Marek	202f7e1a49	Conflicting extension methods result in compilation failure (#9844) ... Fixes the non-deterministic method resolution in cases when the method is defined multiple times in imported modules.	2024-05-22 13:49:23 +02:00
Jaroslav Tulach	befd938dbf	Use proper Java class name in error message (#9996) ... Better error message when static method cannot be found on a Java class.	2024-05-20 15:03:04 +00:00
Dmitry Bushev	643b66d0b7	Allow file/read to return the contents of a collaborative buffer (#9994) ... part of #9960 Changelog: - feat: file/read return contents of a collaborative buffer if they are available and fallback to reading the file from disk	2024-05-20 14:01:59 +00:00
Jaroslav Tulach	fe28c23658	Table of Persistance.Reference at the end of the stream (#9972) ... Fixes #9361 by delaying storing of `Persistance.Reference` instances and creating their table at the end of the stream.	2024-05-18 17:33:04 +00:00
GregoryTravis	4d49b00375	Combine builders for Vector.build and Vector.new_builder (#9922) ... We have decided to keep the old new_builder, and to combine the new and old builders into one builder.	2024-05-17 16:18:47 +00:00
Jaroslav Tulach	5c06535c46	Importing (some of) Standard.Base works from NI runner (#9866)	2024-05-17 14:42:35 +02:00
Hubert Plociniczak	a5ca9f9ac2	Reduce ops when setting exisitng execution env (#9967) ... Setting execution environment to the existing one should have no effect. Should (positively) affect startup in #9789. # Important Notes Cancelling jobs and triggering a fresh execute job is expensive and unnecessary, especially on startup, when the result should be the same as before.	2024-05-16 20:59:13 +00:00
Hubert Plociniczak	f1e60e7e44	Use simple type name as Jackson type id (#9961) ... Using a fully qualified name for type identifier does not play well when dealing with different classloaders (classes are not recognized as equal/subtypes). Closes #9876. Likely also affecting #9306. # Important Notes There appears to be a number of cases loosely related issues on that subject. Gave up on adding a test cases to simulate the problem but I could no longer reproduce it with LS/runtime on a live project. ``` [org.enso.languageserver.runtime.RuntimeConnector$Endpoint] Failed to deserialize runtime API envelope com.fasterxml.jackson.databind.exc.InvalidTypeIdException: Could not resolve type id 'org.enso.polyglot.data.Tree$Node' as a subtype of `org.enso.polyglot.data.Tree$Node<org.enso.polyglot.runtime.Runtime$Api$SuggestionUpdate>`: Not a subtype at [Source: (byte[])[6718 bytes]; byte offset: #394] (through reference chain: org.enso.polyglot.runtime.Runtime$Api$Response["payload"]->org.enso.polyglot.runtime.Runtime$Api$SuggestionsDatabaseModuleUpdateNotification["updates"]->org.enso.polyglot.data.Tree$Root["children"]->com.fasterxml.jackson.module.scala.deser.GenericFactoryDeserializerResolver$BuilderWrapper[0]) at org.enso.IsolatedClassLoader//com.fasterxml.jackson.databind.exc.InvalidTypeIdException.from(InvalidTypeIdException.java:43) ``` appears to be gone.	2024-05-16 14:26:26 +00:00
Jaroslav Tulach	a53b2f0b18	Reverse order of stack frames and test the result (#9954) ... Fixes #9934 by reversing the order of `dropInitJava` frames.	2024-05-15 09:09:36 +00:00
Hubert Plociniczak	c67218c1ed	Abort jobs as early as possible (#9927) ... We don't seem to run `abortJobs` under a lock, and especially not under the write compilation lock, in other scenarios. This is causing some major slowdown when there is a long running execution or compilation, as currently experienced in the cloud. This should reduce chances of a timeout. Also added an option to override the global executor. Currently it would always default to the runtime number of available process which may be suboptimal. # Important Notes Pending testing on the impact it will have.	2024-05-13 07:39:29 +00:00
Hubert Plociniczak	f1ddf1b863	Log timings of FS operations (#9908) ... I'm seeing occasional IO timeouts, especially on startup operations, for cloud projects. Adding some logging to make an informed decision if there are some problems there. Related to https://github.com/enso-org/enso/issues/9789 # Important Notes Also added retries when closing the file as I saw a number of times: ``` Session release failed. LsRpcError: Language server request 'text/closeFile' failed. at LanguageServer.request (/tmp/.mount_enso-leMqqdS/resources/app.asar/index.cjs:58291:15) at async Promise.all (index 0) at async _LanguageServerSession.release (/tmp/.mount_enso-leMqqdS/resources/app.asar/index.cjs:59165:5) at async /tmp/.mount_enso-leMqqdS/resources/app.asar/index.cjs:59670:7 { cause: JSONRPCError2: Request timeout request took longer than 15000 ms to resolve at new JSONRPCError2 (/tmp/.mount_enso-leMqqdS/resources/app.asar/index.cjs:26822:30) at Timeout._onTimeout (/tmp/.mount_enso-leMqqdS/resources/app.asar/index.cjs:26985:20) at listOnTimeout (node:internal/timers:569:17) at process.processTimers (node:internal/timers:512:7) { code: 7777, data: undefined }, request: 'text/closeFile', params: { path: { rootId: '00000000-0000-0000-0000-000000000001', segments: [Array] } } } ```	2024-05-09 15:41:50 +00:00
Jaroslav Tulach	78eb7f3efc	Language server needs java.desktop and java.se modules (#9885) ... Fixes regression introduced by #9868 - language server still needs dependency on `java.desktop` and `java.se`.	2024-05-08 07:53:19 +00:00
Jaroslav Tulach	ced7ba2de2	Syntax error shall contain location of the error (#9864) ... Fixes #8735 by making sure compilation errors contain `SourceSection` identifying location where they occurred. This behavior is required by Truffle TCK. The TCK allocates its own `Context` without any other configuration and still requires a syntax error to be reported. Thus changing the default mode to _strict errors_.	2024-05-07 15:15:51 +00:00
Jaroslav Tulach	a69d89b274	Reduce set of JDK modules required by Enso (#9868)	2024-05-07 14:13:21 +02:00
Hubert Plociniczak	930f3c593e	Minor follow up to #9528 (#9841) ... While playing with the implementation addressed some PR comments of mine and applied DRY.	2024-05-07 08:12:43 +00:00
Hubert Plociniczak	459a264ca2	Workaround slow responses with retries (#9858) ... Follow up to #9558, this time to `SetExecutionContextEnvironmentHandler` that was timing out in #9789. Added a base classes that handles the repeatable logic. Maybe it will close #9789.	2024-05-06 19:37:01 +00:00
Jaroslav Tulach	6902f5e0b3	Pretending WithWarnings isException (#9840)	2024-05-06 03:40:44 +02:00
Pavel Marek	2af217c3e6	from conversion propagates dataflow error (#9856) ... Just add a dataflow error sentinel specialization to `InvokeConversionNode`.	2024-05-03 14:48:55 +00:00
Dmitry Bushev	6d605a5926	Autoscoping should not escape True and False (#9797) ... close #9765 Changelog: - fix: do not use autoscope syntax for Boolean constructors	2024-05-03 10:29:02 +00:00
Dmitry Bushev	a4085346f1	Fix polyglot tree serialization (#9852) ... close #9306 Changelog: - fix: `polyglot.data.Tree` Jackson serialization - update: report errors during the deserialization messages between the Runtime and the Language Server	2024-05-03 10:24:26 +00:00
Dmitry Bushev	a44bb2b1b1	Language Server API for AI (#9679) ... close #9656 Changelog: - add: `ai/completion_v2` method - add: `Visualization.AI.print` method for converting the expression to text format - update: The default system prompt was updated to tell AI to use the `Visualization.AI.print` method for printing. # Important Notes The project [New_Project_1.zip](https://github.com/enso-org/enso/files/15152993/New_Project_1.zip) contains the following main file: ```py from Standard.Base import all from Standard.Table import all from Standard.Database import all from Standard.AWS import all import Standard.Visualization import Standard.Visualization.Warnings from Standard.Base.Errors.Common import Dry_Run_Operation type Student Value id region main = operator70395 = 226 operator47321 = 'east' operator76980 = Student.Value operator70395 operator47321 operator31302 = operator47321.words True operator91574 = 1 operator34358 = operator47321.take (Index_Sub_Range.By_Index [0, operator91574]) #### METADATA #### [[{"index":{"value":0},"size":{"value":4}},"4cf8de7f-2014-4dfd-9ceb-0164fe26c8bf"],[{"index":{"value":0},"size":{"value":29}},"389fe7a5-e59b-440a-8801-e0bd86716094"],[{"index":{"value":0},"size":{"value":558}},"a8a81ce3-199e-479e-98dd-5f919425842d"],[{"index":{"value":5},"size":{"value":8}},"c6f0de99-3bd3-459d-a69b-5fc774dd1e3f"],[{"index":{"value":5},"size":{"value":13}},"05827411-7354-478b-99d8-8370dadd560b"],[{"index":{"value":13},"size":{"value":1}},"41de94cc-ccd2-4ccf-b9db-cf686443efa0"],[{"index":{"value":14},"size":{"value":4}},"8abd24ea-b1cb-4c10-ad16-5a190f7ed0c7"],[{"index":{"value":19},"size":{"value":6}},"5c57a62d-ed82-4195-8b78-2ed660556dd0"],[{"index":{"value":26},"size":{"value":3}},"23544334-1117-4dbc-ac7f-bb3f84575264"],[{"index":{"value":30},"size":{"value":4}},"6058ba89-dc1b-45e1-b8f3-d1a4d27975f7"],[{"index":{"value":30},"size":{"value":30}},"bdd4b4cc-9c1e-4554-b0fb-3f73dcd5a590"],[{"index":{"value":35},"size":{"value":8}},"7e7bb9b4-8e9b-4700-9dcd-83c353800da5"],[{"index":{"value":35},"size":{"value":14}},"524bafb6-d3ca-4ee5-b8de-84b5c47ca87b"],[{"index":{"value":43},"size":{"value":1}},"b68b3929-8b63-49ad-977c-b04e058f8ee4"],[{"index":{"value":44},"size":{"value":5}},"7173f374-5f53-462b-ab1b-f7b1845d729b"],[{"index":{"value":50},"size":{"value":6}},"911d381e-1bdb-4e9c-826d-a00495c8fd23"],[{"index":{"value":57},"size":{"value":3}},"2f8fa1ee-9d13-4a73-99b2-bc77d1656387"],[{"index":{"value":61},"size":{"value":4}},"11abd658-4888-476c-afcd-592edaaa53c1"],[{"index":{"value":61},"size":{"value":33}},"9f6ae949-410b-48e6-bb75-84d4ba8a1989"],[{"index":{"value":66},"size":{"value":8}},"f4726e40-dd5b-49a0-aa2a-6cea6df88d5d"],[{"index":{"value":66},"size":{"value":17}},"539b4dcf-4487-49b6-9c90-6ae58d51c2db"],[{"index":{"value":74},"size":{"value":1}},"a34a41a0-5dcf-4c47-a36c-a4f427c87c03"],[{"index":{"value":75},"size":{"value":8}},"8fdf4ee7-2e74-4cac-b9b9-4230183f91c5"],[{"index":{"value":84},"size":{"value":6}},"7ff7efdc-fed6-4cb6-bed6-392d110ff991"],[{"index":{"value":91},"size":{"value":3}},"eacff407-dc6d-4f17-a28b-329f7a0582e1"],[{"index":{"value":95},"size":{"value":4}},"f2feac9f-ea02-4070-879a-f1d493473993"],[{"index":{"value":95},"size":{"value":28}},"f9b37b67-fb54-4e47-8281-e922edb4c5d3"],[{"index":{"value":100},"size":{"value":8}},"6cf398f8-d0c9-42fa-a6e6-e740de11562f"],[{"index":{"value":100},"size":{"value":12}},"28e4d0e3-7da4-4ee2-94c7-d9a7c692f8de"],[{"index":{"value":108},"size":{"value":1}},"955e8788-816c-4eb7-b5ec-020b4863536a"],[{"index":{"value":109},"size":{"value":3}},"bdc65807-0438-4296-8b1f-1fab3a885c17"],[{"index":{"value":113},"size":{"value":6}},"fe3dd265-1855-4d66-8a2d-51153b21e699"],[{"index":{"value":120},"size":{"value":3}},"3b7a14ac-3224-4b9a-b474-f6136a658f8b"],[{"index":{"value":124},"size":{"value":6}},"7f7f18a4-06ef-46e0-bddd-b9fe60878855"],[{"index":{"value":124},"size":{"value":29}},"d49e0fe3-a638-4d7e-ba58-12db7abad20f"],[{"index":{"value":131},"size":{"value":8}},"c9411433-5e73-4927-9175-15d3b1ccb0ef"],[{"index":{"value":131},"size":{"value":22}},"b53ad817-ea4c-491e-aaf8-49967e22aff6"],[{"index":{"value":139},"size":{"value":1}},"837a4d65-8af6-4860-ae0e-ad9172af6ad2"],[{"index":{"value":140},"size":{"value":13}},"3b662906-1887-4dd6-a0e2-a222ace135ce"],[{"index":{"value":154},"size":{"value":6}},"548ca873-544f-48c9-b7ab-6aa1e7f03d72"],[{"index":{"value":154},"size":{"value":38}},"7c45872c-22b4-4f37-bcd7-b3791408f737"],[{"index":{"value":161},"size":{"value":8}},"21152f0d-4222-48e4-9376-a2a28f8f6be6"],[{"index":{"value":161},"size":{"value":22}},"1cb71d49-a06d-4dd9-bc1b-54603b416601"],[{"index":{"value":161},"size":{"value":31}},"faa46cf2-3e90-44ed-9d9e-77b7f874b338"],[{"index":{"value":169},"size":{"value":1}},"6d5fdcd5-0ddf-4c83-aafe-a446ac5ce461"],[{"index":{"value":170},"size":{"value":13}},"830d73c2-1898-41a9-8046-22d86f159ef0"],[{"index":{"value":183},"size":{"value":1}},"ab897380-c596-4182-a2c5-b7b23cf59893"],[{"index":{"value":184},"size":{"value":8}},"29f35cf2-d79d-44d0-96d0-79b11589726c"],[{"index":{"value":193},"size":{"value":4}},"45bf8220-52f2-49f4-bbcf-9566d1f1b1c4"],[{"index":{"value":193},"size":{"value":57}},"478005ac-f0ca-497a-b298-554bd64946a9"],[{"index":{"value":198},"size":{"value":8}},"c11511ce-252c-4b84-9f61-dfa5544d4916"],[{"index":{"value":198},"size":{"value":13}},"dbae65a1-bdca-44b0-a497-7934d1e42616"],[{"index":{"value":198},"size":{"value":20}},"355392ad-8c81-4304-a6d0-2bbf3690da0c"],[{"index":{"value":198},"size":{"value":27}},"0720ccb5-ebd3-4c29-8113-0aa1f251e873"],[{"index":{"value":206},"size":{"value":1}},"f5a8d310-1f58-456e-84a3-78490f05ff13"],[{"index":{"value":207},"size":{"value":4}},"10046e78-5164-407c-adef-2ab11ce77b4c"],[{"index":{"value":211},"size":{"value":1}},"ed23da0c-9193-4eea-ab9c-fee90ba8f924"],[{"index":{"value":212},"size":{"value":6}},"7a09de10-35e2-45e0-9eb8-f79fa054b733"],[{"index":{"value":218},"size":{"value":1}},"b85a0981-9d82-4204-a03a-cd3a4720c72d"],[{"index":{"value":219},"size":{"value":6}},"1b04c19d-cdf0-4661-8f4e-d980cf12c996"],[{"index":{"value":226},"size":{"value":6}},"87d57f2c-e009-48a7-98bb-0e1612905564"],[{"index":{"value":233},"size":{"value":17}},"60fd6a1c-7ada-4546-ae20-e1f8b432b4fd"],[{"index":{"value":252},"size":{"value":4}},"9558affa-b913-4576-8ee3-6af22985e0f6"],[{"index":{"value":252},"size":{"value":32}},"8479091c-9232-49d6-b375-32f89693c389"],[{"index":{"value":257},"size":{"value":7}},"3d1f13f5-e22a-4cb6-9e75-9c717e016922"],[{"index":{"value":264},"size":{"value":1}},"aa429f07-973a-4c69-8e3f-74aa4780f85a"],[{"index":{"value":269},"size":{"value":5}},"5b304cf6-5ec4-4b23-ad0d-20e38b41cdcd"],[{"index":{"value":269},"size":{"value":15}},"e3315ef2-d0ec-43b1-b8f6-5b436054aaee"],[{"index":{"value":275},"size":{"value":2}},"bc7205c4-68bf-461e-a1ba-31400b9337ff"],[{"index":{"value":278},"size":{"value":6}},"78870c05-9117-4e24-bf77-a72e7aef9c18"],[{"index":{"value":286},"size":{"value":4}},"517c743f-c775-4031-8f87-222d0f0a365f"],[{"index":{"value":286},"size":{"value":271}},"d0d107bc-4997-41d6-9c20-32295590eaac"],[{"index":{"value":291},"size":{"value":1}},"91174930-f18b-4322-84cc-deb88637d012"],[{"index":{"value":292},"size":{"value":265}},"f09a4372-3231-4f2e-99f4-84aa751f9b60"],[{"index":{"value":297},"size":{"value":13}},"613df8c9-0a40-4c94-886f-9668c2c360c2"],[{"index":{"value":297},"size":{"value":19}},"5b88a4d4-6840-4a25-a862-8b5d0b75303d"],[{"index":{"value":311},"size":{"value":1}},"6bfe1dea-09df-4358-9613-74d8326bc680"],[{"index":{"value":313},"size":{"value":3}},"e3b7fac7-0c08-4f20-8a0c-a58f1b118097"],[{"index":{"value":321},"size":{"value":13}},"37d007fe-9cb6-4f2e-a8b7-30842eac60b2"],[{"index":{"value":321},"size":{"value":22}},"4233204a-543d-437a-a9fc-9f79853a9540"],[{"index":{"value":335},"size":{"value":1}},"6c01783b-27ba-413c-84a4-6a94a37d714a"],[{"index":{"value":337},"size":{"value":1}},"34bc865a-58b5-4c49-bf85-a8cfedaf9b54"],[{"index":{"value":337},"size":{"value":6}},"bb556514-570d-4a87-8b2a-6e7f198a975f"],[{"index":{"value":338},"size":{"value":4}},"87c2cedc-898e-43c3-be3d-24e15689c373"],[{"index":{"value":342},"size":{"value":1}},"13387ff5-ec5e-453a-86f2-deae721b5549"],[{"index":{"value":348},"size":{"value":13}},"6280a86b-5469-43f3-94d5-1e1726028a54"],[{"index":{"value":348},"size":{"value":57}},"a17c5e55-5e99-4e4f-961d-9b4072ecd6e4"],[{"index":{"value":362},"size":{"value":1}},"c0720382-9ce4-451a-a04b-f248143d2528"],[{"index":{"value":364},"size":{"value":7}},"9cd51399-d9d2-4898-9bcb-be2f540999ff"],[{"index":{"value":364},"size":{"value":13}},"b4980bfc-13cc-429f-bc43-9edfc07d2406"],[{"index":{"value":364},"size":{"value":27}},"1a3f6a8c-ab27-43dd-a494-bf413334fd9a"],[{"index":{"value":364},"size":{"value":41}},"71a97e88-9b19-4ec9-b3c8-ffd2940c4cb8"],[{"index":{"value":371},"size":{"value":1}},"99f38c61-3ea7-4b02-be71-f293fbecb7d7"],[{"index":{"value":372},"size":{"value":5}},"08820818-ddb9-408a-b913-e9382e5b6dc7"],[{"index":{"value":378},"size":{"value":13}},"2cf06b4e-af9f-492e-ac13-5723a896a508"],[{"index":{"value":392},"size":{"value":13}},"6c887279-5998-45ce-81ab-c37fdeb03144"],[{"index":{"value":410},"size":{"value":13}},"6c126d22-c018-46cc-bdae-cf8b89104173"],[{"index":{"value":410},"size":{"value":40}},"a65c1fa8-9fce-4c30-bef7-d85ff1b428eb"],[{"index":{"value":424},"size":{"value":1}},"208c049e-e221-49ce-99d7-96142f2d1b1c"],[{"index":{"value":426},"size":{"value":13}},"0adf4ddd-1402-4b96-bfb0-1917cc275063"],[{"index":{"value":426},"size":{"value":19}},"f2158ac6-2dd5-482d-9f3d-0bf4812d6d6e"],[{"index":{"value":426},"size":{"value":24}},"c7bbc3e7-1377-429e-b60a-0c2d2cd4ea74"],[{"index":{"value":439},"size":{"value":1}},"1a17a7ee-31d7-4885-84ce-c902bff4ea4a"],[{"index":{"value":440},"size":{"value":5}},"47016cac-40a0-45f6-8057-2b81edb052a5"],[{"index":{"value":446},"size":{"value":4}},"ce4fa4cd-5064-4752-9dbc-5fcf4e92138a"],[{"index":{"value":455},"size":{"value":13}},"3300001d-13ea-45f4-acbe-959813bcf85b"],[{"index":{"value":455},"size":{"value":17}},"b8f5900b-2370-4b21-8a0c-06d3bbb45068"],[{"index":{"value":469},"size":{"value":1}},"19ea3187-83d6-47d1-994c-64cf0ce9af3b"],[{"index":{"value":471},"size":{"value":1}},"9457c3f8-c878-4f01-a5c7-39336f163a28"],[{"index":{"value":477},"size":{"value":13}},"a5139627-05a8-4838-b171-02666c62c348"],[{"index":{"value":477},"size":{"value":80}},"8b5c864c-055d-4d11-a470-2679328fc131"],[{"index":{"value":491},"size":{"value":1}},"eb01b0af-06cf-4d75-81ad-d0bf7664b2d7"],[{"index":{"value":493},"size":{"value":13}},"6c042eb7-e895-473d-b456-6e0eec23e958"],[{"index":{"value":493},"size":{"value":18}},"f40730ff-ac6c-45db-8970-534f3becda2a"],[{"index":{"value":493},"size":{"value":64}},"b2df8ba8-683c-45c2-9932-8e1c970c799a"],[{"index":{"value":506},"size":{"value":1}},"2289bf31-74dd-431c-97f1-3ac179715453"],[{"index":{"value":507},"size":{"value":4}},"6db4523a-0bcd-4ba5-b6c2-7720db57d93c"],[{"index":{"value":512},"size":{"value":1}},"b6faea17-664d-470a-9641-999b6a2be5bd"],[{"index":{"value":512},"size":{"value":45}},"98aea277-bc44-4ceb-85a6-24ee453b7f72"],[{"index":{"value":513},"size":{"value":15}},"c0ae1c05-026d-4712-a571-979ce260b310"],[{"index":{"value":513},"size":{"value":24}},"502e8e4d-5105-4abe-8dba-4d7293cbe80b"],[{"index":{"value":513},"size":{"value":43}},"71cee748-378b-4817-be0e-b87bc1d3d847"],[{"index":{"value":528},"size":{"value":1}},"fcaad3ac-e080-4170-9d63-b2c01295447d"],[{"index":{"value":529},"size":{"value":8}},"a053e05a-4862-4407-abe8-2746784bdfc3"],[{"index":{"value":538},"size":{"value":1}},"9adae78d-7667-4865-83e9-b64464b13696"],[{"index":{"value":538},"size":{"value":18}},"92f153e3-da05-439e-bb4f-596ec8cfa9c8"],[{"index":{"value":539},"size":{"value":1}},"dddedc5e-415d-4f5d-ab1b-19468aa079a9"],[{"index":{"value":540},"size":{"value":1}},"4adce2e5-1e60-4a63-9ff3-5781d967b704"],[{"index":{"value":542},"size":{"value":13}},"ef06ed1e-246f-4106-a4c0-1e648b8ad5e7"],[{"index":{"value":555},"size":{"value":1}},"7bd1cc5f-20b1-4dd2-8a34-ccc40f5f091a"],[{"index":{"value":556},"size":{"value":1}},"720adbd6-24b0-49ac-b123-61cc037a9636"]] {"ide":{"node":{"e3b7fac7-0c08-4f20-8a0c-a58f1b118097":{"position":{"vector":[-224,13]}},"bb556514-570d-4a87-8b2a-6e7f198a975f":{"position":{"vector":[115,19]}},"71a97e88-9b19-4ec9-b3c8-ffd2940c4cb8":{"position":{"vector":[-224,-51]}},"c7bbc3e7-1377-429e-b60a-0c2d2cd4ea74":{"position":{"vector":[360,19]},"visualization":{"show":false,"fullscreen":false,"width":200}},"f2158ac6-2dd5-482d-9f3d-0bf4812d6d6e":{"position":{"vector":[297,-45]},"visualization":{"show":false,"fullscreen":false,"width":96}},"9457c3f8-c878-4f01-a5c7-39336f163a28":{"position":{"vector":[640,40]},"visualization":{"show":false,"fullscreen":false,"width":200}},"b2df8ba8-683c-45c2-9932-8e1c970c799a":{"position":{"vector":[219,-80]},"visualization":{"show":true,"fullscreen":false,"width":200}},"f40730ff-ac6c-45db-8970-534f3becda2a":{"position":{"vector":[219,-48]}}},"import":{}}} ``` To test the functionality, I asked AI to show me the result of the `operator70395` variable: 1. Init protocol connection ```json {"jsonrpc":"2.0","id":0,"method":"session/initProtocolConnection","params":{"clientId":"d8e948fd-6418-43c8-9f02-54827f09e10a"}} ``` 2. Create execution context ```json {"jsonrpc":"2.0","id":0,"method":"session/initProtocolConnection","params":{"clientId":"d8e948fd-6418-43c8-9f02-54827f09e10a"}} ``` 3. Push the main method ```json {"jsonrpc":"2.0","id":0,"method":"executionContext/push","params":{"contextId":"730a66ef-4222-46f8-8a03-d766946ab2bd","stackItem":{"methodPointer":{"module":"local.New_Project_1.Main","definedOnType":"local.New_Project_1.Main","name":"main"},"positionalArgumentsExpressions":[],"type":"ExplicitCall"}}} ``` 4. Ask AI for the variable contents ```json {"jsonrpc":"2.0","id":1,"method":"ai/completion_v2","params":{"contextId":"730a66ef-4222-46f8-8a03-d766946ab2bd","expressionId":"f09a4372-3231-4f2e-99f4-84aa751f9b60","prompt":"There is 'operator70395' variable defined in the program. What is the result of the variable 'operator70395'?"}} ``` I got the following responses: ```json {"jsonrpc":"2.0","method":"ai/completionProgress","params":{"code":"Visualization.AI.print(operator70395)","reason":"To provide the result of 'operator70395', I need to know its current value.","visualizationId":"edfb00a3-6ce5-41e1-bb8f-ab191809114e"}} ``` ```json {"jsonrpc":"2.0","id":1,"result":{"Success":{"fn":"def get_operator70395_result():\n return operator70395","fnCall":"get_operator70395_result()"}}} ```	2024-05-02 16:55:06 +00:00
Jaroslav Tulach	07b720a90a	Rewriting org.enso.runner.Main to Java (#9810) ... As part of changes for #9749, let's rewrite the launcher to Java.	2024-05-02 07:36:10 +00:00
Dmitry Bushev	5995a00958	Run ydoc-server with GraalVM (#9528) ... part of #7954 # Important Notes The workflow is: - `$ npm install` -- just in case - `$ npm --workspace=enso-gui2 run build-ydoc-server-polyglot` -- build the `ydocServer.js` bundle - `$ sbt ydoc-server/assembly` -- build the ydoc server jar - `env POLYGLOT_YDOC_SERVER=true npm --workspace=enso-gui2 run dev` -- run the dev server with the polyglot ydoc server. Providing `POLYGLOT_YDOC_SERVER_DEBUG=true` env variable enables the chrome debugger	2024-05-02 06:28:57 +00:00
James Dunkerley	d2e6ff260e	Restructure SQLite_Details. (#9832) ... ``` type SQLite_Details SQLite location:File|In_Memory type In_Memory ``` to ``` type SQLite From_File location:File In_Memory ``` # Important Notes Splits the In-Memory entry for Database Connect but still works nicely.  	2024-05-01 22:15:41 +00:00
Pavel Marek	6b0361c33c	Panics can be caught from TCO loops (#9705) ... In certain cases, when the `action` of `Panic.catch` is tail-call-optimized (via `@Tail_Call`) annotation, the panic is not caught. Fixed by ensuring that the `action` of `Panic.catch` is executed as `NOT_TAIL` rather than `TAIL_DIRECT`. # Important Notes The `handler` parameter of `Panic.catch` is executed as `NOT_TAIL` as well, just to be sure.	2024-05-01 11:13:29 +00:00
Pavel Marek	660c5e7a9d	Atom constructors can be private (#9692) ... Closes #8836. Atom constructors can be declared as private (project-private). project-private constructors can be called only from the same project. See the encapsulation.md docs for more info. --------- Co-authored-by: Jaroslav Tulach <jaroslav.tulach@enso.org> Co-authored-by: Radosław Waśko <radoslaw.wasko@enso.org> Co-authored-by: Hubert Plociniczak <hubert.plociniczak@gmail.com> Co-authored-by: Kaz Wesley <kaz@lambdaverse.org>	2024-04-29 14:43:18 +02:00
Jaroslav Tulach	c5bf2384e4	Removing Truffle API dependency from runtime-compiler project (#9785) ... Fixes #8888 by removing dependency on Truffle API and `polyglot-api` from `runtime-compiler` project.	2024-04-26 13:14:22 +00:00
Jaroslav Tulach	0d495ffd97	Make conversion of double to BigDecimal exact (#9740) ... Resolves #9607 by computing `Number.hash` by converting given number to `Float` first and then computing the hash. Also the conversion from `Float.to Decimal` is exact - done via `new BigDecimal(double)`. There is `Decimal.new` that handles the user-friendly conversion. However as a result `Decimal.from 2.1 != Decimal.new 2.1` - that's the only way to ensure consistency between hash code and conversions.	2024-04-25 11:22:50 +00:00
Jaroslav Tulach	931baa4276	Towards simplifying runtime-compiler dependencies (#8894)	2024-04-25 10:03:42 +02:00
Jaroslav Tulach	a786ad2d0a	Use InteropLibrary when accepting String values (#9773) ... While investigating #9749 a JavaScript call to `Polyglot.eval("enso", ....).eval_expression("id")` was made. It crashed as JavaScript isn't using `String` but `TruffleString` to represent strings.	2024-04-24 14:50:41 +00:00
Jaroslav Tulach	ff62c1e25f	Access non-self arguments when widget annotations are computed (#9410)	2024-04-24 03:58:32 +02:00
Jaroslav Tulach	96fdb67204	Special treatment for ..True and ..False (#9767)	2024-04-23 15:26:41 +02:00
Hubert Plociniczak	58009b7c04	In-memory suggestions (#9751) ... This change replaces an sqllite-backed suggestions' repo with a simple, in-memory, one. As `completion` functionality has been implemented completely in GUI, there is no need to support it in backend, which simplifies a lot of functionality. Closes #9650 and #9471. # Important Notes Loading suggestions and sending them to GUI on startup is almost instantaneous. Previously it would take ~10s just for `Standard.Base`.	2024-04-22 11:02:17 +00:00
Jaroslav Tulach	11dda5b9bc	Allow ..Nothing to resolve to Nothing (#9746)	2024-04-22 06:54:07 +02:00
Dmitry Bushev	f23455d223	Should not use auto-scoping for atom types (#9743) ... close #9738 Do now use autoscope syntax for type definitions without constructors. # Important Notes https://github.com/enso-org/enso/assets/357683/5147b9a6-f5f4-4e5e-8b3a-3d2fa3eab2d5 https://github.com/enso-org/enso/assets/357683/db1beff8-53de-4ea1-a087-b84e571904e8	2024-04-19 09:48:31 +00:00
Radosław Waśko	34f3331561	Implement recursive argument for File.delete (#9719) ... - Closes #8993	2024-04-17 16:53:45 +00:00
Hubert Plociniczak	d6f7afc624	Open Java modules for Snowflake setup (#9664) ... # Important Notes Some workarounds are being considered but we need this change sooner than later.	2024-04-16 21:01:32 +00:00
Hubert Plociniczak	ca9e1503db	Experiment in lock-free module invalidation (#9639) ... 1. Experimenting with invalidating modules' indexes without requiring full write-context locks. That should significantly improve the execution. 2. Improving performance by making background job executor run in a larger threadpool than 1.	2024-04-16 09:59:56 +00:00
Pavel Marek	0d915d0344	Update to GraalVM 24.0.0 (#9647) ... Update the GraalVM-related Maven packages from **23.1.2** to **24.0.0**. # Important Notes - Reverted workarounds mentioned in https://github.com/enso-org/enso/issues/9477 The language home search functionality in Truffle changed. It used to find the home for Enso from the class loader of `EnsoLanguage`: https://github.com/oracle/graal/blob/graal-23.1.2/truffle/src/com.oracle.truffle.polyglot/src/com/oracle/truffle/polyglot/LanguageCache.java#L362 In 24.0.0, the language home is no longer found via class loader, but via system properties: https://github.com/oracle/graal/blob/graal-24.0.0/truffle/src/com.oracle.truffle.polyglot/src/com/oracle/truffle/polyglot/LanguageCache.java#L353 I provided a "fix" for this by an explicit specification of the `org.graalvm.language.enso.home` system property in our launchers.	2024-04-12 17:01:49 +00:00
Pavel Marek	4dc7992ab5	Export works without import (#9683)	2024-04-12 14:23:34 +02:00
Michał Wawrzyniec Urbańczyk	cdf031f61f	[CI] Provide latest FlatBuffers to the Engine build. (#9654) ... This PR bumps the FlatBuffers version used by the backend to `24.3.25` (the latest version as of now). Since the newer FlatBuffers releases come with prebuilt binaries for all platforms we target, we can simplify the build process by simply downloading the required `flatc` binary from the official FlatBuffers GitHub release page. This allows us to remove the dependency on `conda`, which was the only reliable way to get the outdated `flatc`. The `conda` setup has been removed from the CI steps and the relevant code has been removed from the build script. The FlatBuffers version is no longer hard-coded in the Rust build script, it is inferred from the `build.sbt` definition (similar to GraalVM). # Important Notes This does not affect the GUI binary protocol implementation. While I initially wanted to update it, it turned out farly non-trivial. As there are multiple issues with the generated TS code, it was significantly refactored by hand and it is impossible to automatically update it. Work to address this problem is left as [a future task](https://github.com/enso-org/enso/issues/9658). As the Flatbuffers binary protocol is guaranteed to be compatible between versions (unlike the generated sources), there should be no adverse effects from bumping `flatc` only on the backend side.	2024-04-12 10:10:44 +00:00
GregoryTravis	bf90e2e8a8	Attach warning when converting from Decimal to Integer (#9660)	2024-04-11 15:44:58 +00:00
Jaroslav Tulach	32df870ad0	Accept small BigInteger values (#9655)	2024-04-09 14:55:33 +02:00
Radosław Waśko	fc557f8fd2	Improve handling of File.parent and File.name (#9642) ... - Closes #8906	2024-04-08 22:41:38 +00:00
Pavel Marek	7850312340	Do not disable BackgroundCompilation in benchmarks (#9646) ... * Do not disable BackgroundCompilation in benchmarks * Increase warmup for Table sorting benchmarks. #9470	2024-04-08 16:49:57 +02:00
Dmitry Bushev	1c4a927701	Use autoscoping when constructing tag values of suggestion arguments (#9293)	2024-04-08 12:39:49 +01:00
Dmitry Bushev	ab552ab677	GUI project does not receive suggestion database (#9634) ... close #9558 the `InvalidateModulesIndexCommand` may be waiting for the execution lock, while the handler times out.	2024-04-08 08:59:03 +00:00
GregoryTravis	c100a88ec3	Make the% consistent across both Integer sizes. (#9589)	2024-04-04 15:27:51 +00:00
Hubert Plociniczak	a82a429127	Improve perf of Graph.Scope.scopeFor hotspot (#9620) ... `scopeFor` appears to be a hotspot of the compiler. By choosing a more suitable data structure that indexes on the occurrence's id we seem to gain about 25% on some benchmarks. Quick win. Related to #9235. # Important Notes Local benchmark runs of `org.enso.compiler.benchmarks.module.ManyLocalVarsBenchmark.longMethodWithLotOfLocalVars ` Before ``` [info] # Warmup Iteration 1: 61.638 ms/op [info] # Warmup Iteration 2: 49.224 ms/op [info] # Warmup Iteration 3: 47.341 ms/op [info] # Warmup Iteration 4: 46.946 ms/op [info] # Warmup Iteration 5: 46.901 ms/op [info] # Warmup Iteration 6: 49.536 ms/op [info] Iteration 1: 50.438 ms/op [info] Iteration 2: 47.326 ms/op [info] Iteration 3: 46.917 ms/op [info] Iteration 4: 45.824 ms/op ``` After ``` [info] # Warmup Iteration 1: 86.493 ms/op [info] # Warmup Iteration 2: 36.084 ms/op [info] # Warmup Iteration 3: 32.588 ms/op [info] # Warmup Iteration 4: 33.895 ms/op [info] # Warmup Iteration 5: 31.986 ms/op [info] # Warmup Iteration 6: 31.236 ms/op [info] Iteration 1: 31.258 ms/op [info] Iteration 2: 31.673 ms/op [info] Iteration 3: 30.931 ms/op [info] Iteration 4: 30.902 ms/op ```	2024-04-04 15:26:06 +00:00
Jaroslav Tulach	d9c7bf4138	Testing autoscoped constructors in a vector (#9630)	2024-04-04 17:13:33 +02:00
Jaroslav Tulach	f8a546e85f	Instrumentation, visualization and autoscoped constructors (#9452) ... So far reproduces and later will fix #9381.	2024-04-03 12:14:23 +00:00
Jaroslav Tulach	dcccad9f7b	Removing useless methods (#9590)	2024-04-03 05:34:51 +02:00
Jaroslav Tulach	11e1e9efa0	Don't let the non-Enso types float around the Enso interpreter! (#9584)	2024-04-02 06:22:19 +02:00
GregoryTravis	ff562cb454	Conversions from Decimal to Integer and Float. (#9462) ... * wip * wip * Remove unnecessary conversion * changelog * also integer * cleanup * to_float inf * review * Using multiple simple if conditions * review * logging in conversions * cleanup * revert * pending test * truncation * Use TypeOfNode instead of TypesLibrary in InvokeConversionNode * combine cases * rename typesLib * String is not Enso type, return Text --------- Co-authored-by: Jaroslav Tulach <jaroslav.tulach@enso.org>	2024-03-30 10:42:56 -04:00
Jaroslav Tulach	55dc7ecc84	Make sure import and FQN behave the same (#9539)	2024-03-29 16:34:52 +01:00
Pavel Marek	0b94493258	Equality does not swallow errors (#9560) ... `42 == (Error.throw "foo")` now correctly returns an `Error` rather than False # Important Notes The error was in the wrong usage of the `org.enso.interpreter.dsl.AcceptsError` DSL annotation.	2024-03-29 04:11:16 +00:00
Hubert Plociniczak	1c724a4c56	Fix inline compilation benchmarks and Improve searching Graph.Link performance (#9520) ... As benchmarks show, a significant amount of time is spent traversing `Set` of `Graph.Link`s. That's unfortunate and unnecessary. We can equally keep helper maps that make search constant time. Fixed inline compilation benchmarks by properly cleaning up scopes after runs. Closes #9237. # Important Notes Things like   are all gone. There is plenty of it those are just samples. Benchmarks are back in order: ``` [info] # Warmup Iteration 1: 2.702 ms/op [info] # Warmup Iteration 2: 3.080 ms/op [info] # Warmup Iteration 3: 2.818 ms/op [info] # Warmup Iteration 4: 3.334 ms/op [info] # Warmup Iteration 5: 2.448 ms/op [info] # Warmup Iteration 6: 2.583 ms/op [info] Iteration 1: 2.908 ms/op [info] Iteration 2: 2.915 ms/op [info] Iteration 3: 2.774 ms/op [info] Iteration 4: 2.601 ms/op [info] Result "org.enso.compiler.benchmarks.inline.InlineCompilerBenchmark.longExpression": [info] 2.799 ±(99.9%) 0.953 ms/op [Average] [info] (min, avg, max) = (2.601, 2.799, 2.915), stdev = 0.148 [info] CI (99.9%): [1.846, 3.753] (assumes normal distribution) ```	2024-03-28 17:15:17 +00:00
James Dunkerley	e262801daa	Restructure Standard.Table. (#9559) ... Move the types from `Standard.Table.Data` to `Standard.Table`. Exceptions: - `Standard.Table.Data.Report_Unmatched` => `Standard.Table.Constants`. - `Standard.Table.Data.Join_Kind_Cross` => `Standard.Table.Internal.Join_Kind_Cross`. Also removed constructor as an atom type. - `Standard.Table.Extensions.Table_Ref` => `Standard.Table.Internal.Table_Ref`. - `Standard.Table.Data.Type.Value_Type_Helpers` => `Standard.Table.Internal.Value_Type_Helpers`. - `Standard.Table.Data.Type.Enso_Types` => `Standard.Table.Internal.Value_Type_Helpers`. - `Standard.Table.Data.Type.Storage` => `Standard.Table.Internal.Storage`. Changed all `Standard.Table` imports inside project to be project. Favoured importing from `Standard.Table.Main` in `Standard.Database`. Also fixed some linting in Enso_File.	2024-03-27 17:10:43 +00:00
Pavel Marek	8f7866896b	Read subprocess streams before calling Process.waitFor (#9550)	2024-03-27 18:01:50 +01:00
Pavel Marek	76061e1c04	Add IRDumper for Scala IR (#9543) ... Debugging/inspecting/watching changes in the [Scala IR](fe0f9046db/engine/runtime-parser/src/main/java/org/enso/compiler/core/IR.java) has always been very tricky. The only way to do that, other than attaching the debugger and inspecting nested object structures, has been [IR.pretty](fe0f9046db/engine/runtime-parser/src/main/java/org/enso/compiler/core/IR.java (L91)) method, that is not useful for large IRs. This PR add an [IRDumper](a98b674f9e/engine/runtime-compiler/src/main/java/org/enso/compiler/dump/IRDumper.java) utility class that dumps the `IR` into a [GraphViz](https://graphviz.org/) textual format that can be further processed by the [dot](https://graphviz.org/download/) program to generate, e.g., svg files from these IRs. A simple example (dumped by `IRDumper` into a file that is processed with `dot -O -Tsvg file`):  # Important Notes - GraphViz format is even simpler than JSON format. - No dependencies added, just 3 simple Java classes. - Dumping the IR is optional and not used anywhere, when desired, one can dump IRs for example from [Compiler.runPipeline](9a91b7bcc6/engine/runtime-compiler/src/main/scala/org/enso/compiler/Compiler.scala (L438))	2024-03-27 09:19:47 +00:00
Pavel Marek	e1fb1863ba	Add --disable-private-check runner option (#9556) ... I forgot to add the `--disable-private-check` cmdline option in https://github.com/enso-org/enso/pull/8202. This PR fixes this: ``` > enso -h | grep -A2 private --disable-private-check Disables private module checking at runtime. Useful for tests. ```	2024-03-27 09:03:35 +00:00
Dmitry Bushev	fb0559e7ab	Put all reexports of given entry in Suggestion Database (#9454) ... close #9351 Changelog: - update: deprecate the `reexport` suggestion field - add: `reexports` suggestion field containing the list of modules re-exporting this symbol - update: exports logic to gather all the symbols exported from a given module	2024-03-26 16:33:25 +00:00
Adam Obuchowicz	a6fc8cb932	Reimplement AI PoC from GUI1 (#9476) ... Fixes #9313 [Screencast from 2024-03-22 09-09-07.webm](https://github.com/enso-org/enso/assets/3919101/6ad86145-6882-4bde-993d-b1270f1ec06c) # Important Notes * This is PoC, so I didn't spend time on polishing the visuals; the design will likely change. * I modified the shortcut handler a bit, allowing making multiple actions for same binding - the action's handler will be called in unspecified order, until one of them handle the event (i.e. not return false). * To make it working regardless of imports, I needed to export AI module in Standard.Visualization. Moreover, needed to remove build_ai_prompt for Any, because it was causing issues - expect a bug report soon.	2024-03-25 09:14:41 +00:00
Hubert Plociniczak	c22d7422e6	Speedup visualization and widget responses (#9371) ... `ExecuteJob` can now be interrupted. We now have a separate threadpool for visualization-related jobs. # Important Notes In a lock step situation, a job or command could have been interrupted while waiting for one of the locks. As locks ensured only that they were released once all of them have been acquired this could leave engine in a broken state. Once `ExecuteJob` could be interrupted this became a blocker as it prevented project startup almost in every case. The change also makes it careful to avoid constant `ExecuteJob` restarts. Addresses #9278. There will be follow up work.	2024-03-21 14:06:48 +00:00
Radosław Waśko	6e5b4d93a3	Implement refreshing the Cloud token in Enso libraries (#9390) ... - Closes #9300 - Now the Enso libraries are themselves capable of refreshing the access token, thus there is no more problems if the token expires during a long running workflow. - Adds `get_optional_field` sibling to `get_required_field` for more unified parsing of JSON responses from the Cloud. - Adds `expected_type` that checks the type of extracted fields. This way, if the response is malformed we get a nice Enso Cloud error telling us what is wrong with the payload instead of a `Type_Error` later down the line. - Fixes `Test.expect_panic_with` to actually catch only panics. Before it used to also handle dataflow errors - but these have `.should_fail_with` instead. We should distinguish these scenarios.	2024-03-19 19:26:34 +00:00
Dmitry Bushev	d21cdb2197	Fix getters serialization (#9480) ... close #9429 Changelog: - fix: serialization of getter methods # Important Notes Returns a correct suggestion for the count getter ```json { "type":"Add", "id":248, "suggestion":{ "type":"method", "module":"Standard.Base.Data.Index_Sub_Range", "name":"count", "arguments":[ { "name":"self", "reprType":"Standard.Base.Data.Index_Sub_Range.Index_Sub_Range", "isSuspended":false, "hasDefault":false, "defaultValue":null, "tagValues":null } ], "selfType":"Standard.Base.Data.Index_Sub_Range.Index_Sub_Range", "returnType":"Standard.Base.Data.Numbers.Integer", "isStatic":false, "annotations":[ ] } } ```	2024-03-19 15:33:26 +00:00
Radosław Waśko	90b3003312	Un-nest AliasAnalysis Info and Graph to allow easier usage from Java (#9451)	2024-03-18 15:16:24 +00:00
GregoryTravis	9a9eff1aa6	Decimal type: constuctors, comparisons, and arithmetic (#9272)	2024-03-15 21:13:41 +00:00
Jaroslav Tulach	4332eab45a	Avoid Interop TypeOfNode specializations for EnsoObject (#9431)	2024-03-15 19:52:41 +01:00
Hubert Plociniczak	3755f90fef	Avoid ArrayIndexOutOfBoundsException with no args (#9393) ... The `null` check creates a new Array but always assumed a non-empty one which may lead to ``` java.lang.ArrayIndexOutOfBoundsException: Index 0 out of bounds for length 0 at org.enso.runtime/org.enso.interpreter.service.ExecutionService$FunctionPointer.collectNotAppliedArguments(ExecutionService.java:778) at org.enso.runtime/org.enso.interpreter.instrument.job.ProgramExecutionSupport$.sendExpressionUpdate(ProgramExecutionSupport.scala:430) at org.enso.runtime/org.enso.interpreter.instrument.job.ProgramExecutionSupport$.$anonfun$executeProgram$3(ProgramExecutionSupport.scala:81) at org.enso.runtime/org.enso.interpreter.service.ExecutionCallbacks.callOnComputedCallback(ExecutionCallbacks.java:146) at org.enso.runtime/org.enso.interpreter.service.ExecutionCallbacks.updateCachedResult(ExecutionCallbacks.java:117 ... ``` Added a guard to prevent the exception. The flag will be useless anyway as we won't enter the for-loop in this case. Appears to be introduced via #8743. Discovered while debugging #9389.	2024-03-15 10:44:30 +00:00
Jaroslav Tulach	8d9c25cdda	Syntax Color and Debug JavaScript/Python in Enso Source (#9440)	2024-03-15 10:28:13 +01:00
GregoryTravis	dc84317ff1	Reproduce Float-passing problem (#9201)	2024-03-14 19:35:18 +00:00
Pavel Marek	c4029eed4f	dry-run benchmarks exits when some benchmark fails (#9397) ... If some benchmark fails in dry-run (compileOnly) mode, the whole process exits with non-zero return code. Also fixes failing engine compiler benchmarks. # Important Notes Manually added failure: ```diff diff --git a/engine/runtime-benchmarks/src/main/java/org/enso/interpreter/bench/benchmarks/semantic/ArrayProxyBenchmarks.java b/engine/runtime-benchmarks/src/main/java/org/enso/interpreter/bench/benchmarks/semantic/ArrayProxyBenchmarks.java index c8d86cecc..f9f4d7cbc 100644 --- a/engine/runtime-benchmarks/src/main/java/org/enso/interpreter/bench/benchmarks/semantic/ArrayProxyBenchmarks.java +++ b/engine/runtime-benchmarks/src/main/java/org/enso/interpreter/bench/benchmarks/semantic/ArrayProxyBenchmarks.java @@ -95,7 +95,8 @@ public class ArrayProxyBenchmarks { @Benchmark public void sumOverComputingProxy(Blackhole matter) { - performBenchmark(matter); + //performBenchmark(matter); + throw new AssertionError("My error"); } @Benchmark ``` Run with `sbt "-Dbench.compileOnly=true runtime-benchmarks/benchOnly org.enso.interpreter.bench.benchmarks.semantic.ArrayProxyBenchmarks.sumOverComputingProxy"` fails with: ``` [info] Running benchmarks [org.enso.interpreter.bench.benchmarks.semantic.ArrayProxyBenchmarks.sumOverComputingProxy] in compileOnly mode [info] # JMH version: 1.36 [info] # VM version: JDK 21.0.2, Java HotSpot(TM) 64-Bit Server VM, 21.0.2+13-LTS-jvmci-23.1-b30 [info] # VM invoker: /home/pavel/.sdkman/candidates/java/21.0.2-graal/bin/java [info] # VM options: -XX:ThreadPriorityPolicy=1 -XX:+UnlockExperimentalVMOptions -XX:+EnableJVMCIProduct -XX:-UnlockExperimentalVMOptions -Dslf4j.provider=org.slf4j.nop.NOPServiceProvider -Dbench.compileOnly=true --module-path=/home/pavel/.cache/coursier/v1/https/repo1.maven.org/maven2/org/graalvm/sdk/nativeimage/23.1.2/nativeimage-23.1.2.jar:/home/pavel/.cache/coursier/v1/https/repo1.maven.org/maven2/org/graalvm/sdk/word/23.1.2/word-23.1.2.jar:/home/pavel/.cache/coursier/v1/https/repo1.maven.org/maven2/org/graalvm/sdk/jniutils/23.1.2/jniutils-23.1.2.jar:/home/pavel/.cache/coursier/v1/https/repo1.maven.org/maven2/org/graalvm/sdk/collections/23.1.2/collections-23.1.2.jar:/home/pavel/.cache/coursier/v1/https/repo1.maven.org/maven2/org/graalvm/polyglot/polyglot/23.1.2/polyglot-23.1.2.jar:/home/pavel/.cache/coursier/v1/https/repo1.maven.org/maven2/org/graalvm/truffle/truffle-api/23.1.2/truffle-api-23.1.2.jar:/home/pavel/.cache/coursier/v1/https/repo1.maven.org/maven2/org/graalvm/truffle/truffle-runtime/23.1.2/truffle-runtime-23.1.2.jar:/home/pavel/.cache/coursier/v1/https/repo1.maven.org/maven2/org/graalvm/truffle/truffle-compiler/23.1.2/truffle-compiler-23.1.2.jar:/home/pavel/.cache/coursier/v1/https/repo1.maven.org/maven2/org/graalvm/js/js-language/23.1.2/js-language-23.1.2.jar:/home/pavel/.cache/coursier/v1/https/repo1.maven.org/maven2/org/graalvm/regex/regex/23.1.2/regex-23.1.2.jar:/home/pavel/.cache/coursier/v1/https/repo1.maven.org/maven2/org/graalvm/shadowed/icu4j/23.1.2/icu4j-23.1.2.jar:/home/pavel/.cache/coursier/v1/https/repo1.maven.org/maven2/org/graalvm/python/python-language/23.1.2/python-language-23.1.2.jar:/home/pavel/.cache/coursier/v1/https/repo1.maven.org/maven2/org/graalvm/python/python-resources/23.1.2/python-resources-23.1.2.jar:/home/pavel/.cache/coursier/v1/https/repo1.maven.org/maven2/org/bouncycastle/bcutil-jdk18on/1.76/bcutil-jdk18on-1.76.jar:/home/pavel/.cache/coursier/v1/https/repo1.maven.org/maven2/org/bouncycastle/bcpkix-jdk18on/1.76/bcpkix-jdk18on-1.76.jar:/home/pavel/.cache/coursier/v1/https/repo1.maven.org/maven2/org/bouncycastle/bcprov-jdk18on/1.76/bcprov-jdk18on-1.76.jar:/home/pavel/.cache/coursier/v1/https/repo1.maven.org/maven2/org/graalvm/llvm/llvm-api/23.1.2/llvm-api-23.1.2.jar:/home/pavel/.cache/coursier/v1/https/repo1.maven.org/maven2/org/graalvm/truffle/truffle-nfi/23.1.2/truffle-nfi-23.1.2.jar:/home/pavel/.cache/coursier/v1/https/repo1.maven.org/maven2/org/graalvm/truffle/truffle-nfi-libffi/23.1.2/truffle-nfi-libffi-23.1.2.jar:/home/pavel/.cache/coursier/v1/https/repo1.maven.org/maven2/org/graalvm/tools/profiler-tool/23.1.2/profiler-tool-23.1.2.jar:/home/pavel/.cache/coursier/v1/https/repo1.maven.org/maven2/org/graalvm/shadowed/json/23.1.2/json-23.1.2.jar:/home/pavel/.cache/coursier/v1/https/repo1.maven.org/maven2/org/tukaani/xz/1.9/xz-1.9.jar:/home/pavel/.cache/coursier/v1/https/repo1.maven.org/maven2/org/slf4j/slf4j-api/2.0.9/slf4j-api-2.0.9.jar:/home/pavel/.cache/coursier/v1/https/repo1.maven.org/maven2/org/slf4j/slf4j-nop/2.0.9/slf4j-nop-2.0.9.jar:/home/pavel/dev/enso/runtime.jar --add-modules=org.enso.runtime --add-exports=org.slf4j.nop/org.slf4j.nop=org.slf4j [info] # Blackhole mode: compiler (auto-detected, use -Djmh.blackhole.autoDetect=false to disable) [info] # Warmup: <none> [info] # Measurement: 1 iterations, 1 s each [info] # Timeout: 10 min per iteration [info] # Threads: 1 thread, will synchronize iterations [info] # Benchmark mode: Average time, time/op [info] # Benchmark: org.enso.interpreter.bench.benchmarks.semantic.ArrayProxyBenchmarks.sumOverComputingProxy [info] # Run progress: 0.00% complete, ETA 00:00:01 [info] # Fork: N/A, test runs in the host VM [info] # *** WARNING: Non-forked runs may silently omit JVM options, mess up profilers, disable compiler hints, etc. *** [info] # *** WARNING: Use non-forked runs only for debugging purposes, not for actual performance runs. *** [error] SLF4J: Attempting to load provider "org.slf4j.nop.NOPServiceProvider" specified via "slf4j.provider" system property [info] Iteration 1: <failure> [info] java.lang.AssertionError: My error [info] at org.enso.interpreter.bench.benchmarks.semantic.ArrayProxyBenchmarks.sumOverComputingProxy(ArrayProxyBenchmarks.java:99) [info] at org.enso.interpreter.bench.benchmarks.semantic.jmh_generated.ArrayProxyBenchmarks_sumOverComputingProxy_jmhTest.sumOverComputingProxy_avgt_jmhStub(ArrayProxyBenchmarks_sumOverComputingProxy_jmhTest.java:232) [info] at org.enso.interpreter.bench.benchmarks.semantic.jmh_generated.ArrayProxyBenchmarks_sumOverComputingProxy_jmhTest.sumOverComputingProxy_AverageTime(ArrayProxyBenchmarks_sumOverComputingProxy_jmhTest.java:173) [info] at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103) [info] at java.base/java.lang.reflect.Method.invoke(Method.java:580) [info] at org.openjdk.jmh.runner.BenchmarkHandler$BenchmarkTask.call(BenchmarkHandler.java:475) [info] at org.openjdk.jmh.runner.BenchmarkHandler$BenchmarkTask.call(BenchmarkHandler.java:458) [info] at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317) [info] at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:572) [info] at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317) [info] at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144) [info] at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642) [error] Benchmark run failed: Benchmark caught the exception [info] at java.base/java.lang.Thread.run(Thread.java:1583) [error] org.openjdk.jmh.runner.RunnerException: Benchmark caught the exception [error] at org.openjdk.jmh.runner.Runner.runBenchmarks(Runner.java:575) [error] at org.openjdk.jmh.runner.Runner.internalRun(Runner.java:310) [error] at org.openjdk.jmh.runner.Runner.run(Runner.java:209) [error] at org.enso.interpreter.bench.BenchmarksRunner.runCompileOnly(BenchmarksRunner.java:93) [error] at org.enso.interpreter.bench.BenchmarksRunner.run(BenchmarksRunner.java:36) [error] at org.enso.interpreter.bench.benchmarks.RuntimeBenchmarksRunner.main(RuntimeBenchmarksRunner.java:8) [error] Caused by: org.openjdk.jmh.runner.BenchmarkException: Benchmark error during the run [error] at org.openjdk.jmh.runner.BenchmarkHandler.runIteration(BenchmarkHandler.java:424) [error] at org.openjdk.jmh.runner.BaseRunner.runBenchmark(BaseRunner.java:281) [error] at org.openjdk.jmh.runner.BaseRunner.runBenchmark(BaseRunner.java:233) [error] at org.openjdk.jmh.runner.BaseRunner.doSingle(BaseRunner.java:138) [error] at org.openjdk.jmh.runner.BaseRunner.runBenchmarksEmbedded(BaseRunner.java:110) [error] at org.openjdk.jmh.runner.Runner.runBenchmarks(Runner.java:555) [error] ... 5 more [error] Suppressed: java.lang.AssertionError: My error [error] at org.enso.interpreter.bench.benchmarks.semantic.ArrayProxyBenchmarks.sumOverComputingProxy(ArrayProxyBenchmarks.java:99) [error] at org.enso.interpreter.bench.benchmarks.semantic.jmh_generated.ArrayProxyBenchmarks_sumOverComputingProxy_jmhTest.sumOverComputingProxy_avgt_jmhStub(ArrayProxyBenchmarks_sumOverComputingProxy_jmhTest.java:232) [error] at org.enso.interpreter.bench.benchmarks.semantic.jmh_generated.ArrayProxyBenchmarks_sumOverComputingProxy_jmhTest.sumOverComputingProxy_AverageTime(ArrayProxyBenchmarks_sumOverComputingProxy_jmhTest.java:173) [error] at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103) [error] at java.base/java.lang.reflect.Method.invoke(Method.java:580) [error] at org.openjdk.jmh.runner.BenchmarkHandler$BenchmarkTask.call(BenchmarkHandler.java:475) [error] at org.openjdk.jmh.runner.BenchmarkHandler$BenchmarkTask.call(BenchmarkHandler.java:458) [error] at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317) [error] at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:572) [error] at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317) [error] at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144) [error] at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642) [error] at java.base/java.lang.Thread.run(Thread.java:1583) [error] Nonzero exit code returned from runner: 1 [error] (Compile / run) Nonzero exit code returned from runner: 1 [error] Total time: 5 s, completed Mar 13, 2024, 12:49:59 PM ```	2024-03-14 15:21:38 +00:00
Hubert Plociniczak	f82e8020fe	Arrow builder is not an Array (#9358) ... Follow up on #9150 - making sure that Arrow builder is not accidentally treated as an Array by disallowing reading elements. # Important Notes Also making sure that the length of the resulting Arrow Array is consistent with what user requested.	2024-03-13 14:37:41 +00:00
Kaz Wesley	a1c0d9ac08	Autoscope syntax (#9372) ... Add autoscope syntax (`..Ident`). # Important Notes - Also rename previous `Tree.Autoscope` to `SuspendedDefaultArguments`.	2024-03-12 19:31:16 +00:00
AdRiley	8e1bb16afd	Remove File from File./ (#9330) ... Closes #8905	2024-03-11 10:12:09 +00:00
Jaroslav Tulach	2330fdb8af	Provide Persistance for Persistance.Reference (#9326)	2024-03-08 18:23:17 +01:00
Hubert Plociniczak	f80dd9f593	Demonstrate usage of foreign arrow function (#9150) ... Including arrow language in the distribution by default. Added a basic example for creating an Arrow array. Making sure that memory layout agrees with Arrow specification (padding, continuous allocation of memory chunks). Related to #9118. This should unblock work on allowing serialization/deserialization to/from Parquet but I'd like to delay it to a follow up ticket as it is going to be a significant amount of specialized work.	2024-03-08 15:20:55 +00:00
Dmitry Bushev	ba1c1d9a94	Use to_display_text to preview warnings (#9325) ... close #9200 Changelog: - feat: use `.to_display_text` method to preview warnings # Important Notes 	2024-03-08 12:32:15 +00:00
Jaroslav Tulach	7e498a049d	Trading shouldNotReachHere() for an abstract method (#9312) ... Avoiding `shouldNotReachHere()` in favor of less fatal exceptions/constructs.	2024-03-07 13:02:24 +00:00
Dmitry Bushev	acf124e089	Visualization tests maintenance (#9294) ... Adjusted a couple of flaky tests reported by @mwu-tow	2024-03-06 15:48:56 +00:00
Jaroslav Tulach	6acec1b30b	Use .. to identify autoscoped constructors (#9285)	2024-03-06 10:28:15 +01:00
Pavel Marek	f02213ae2b	Enable splitting for EqualsSimpleNode (#9268) ... Fixes the regression introduced by #9070 in `org.enso.benchmarks.generated.Collections.list_meta_fold` benchmark. # Important Notes As can be seen on the graph in IGV:  For some reason, `EqualsSimpleNode` is POLYMORPHIC. That seems to be the most visible performance problem. First, I tried to introduce `ConditionProfile` with: ```diff diff --git a/engine/runtime/src/main/java/org/enso/interpreter/node/expression/builtin/meta/EqualsNode.java b/engine/runtime/src/main/java/org/enso/interpreter/node/expression/builtin/meta/EqualsNode.java index b368fb7fe..57274b37e 100644 --- a/engine/runtime/src/main/java/org/enso/interpreter/node/expression/builtin/meta/EqualsNode.java +++ b/engine/runtime/src/main/java/org/enso/interpreter/node/expression/builtin/meta/EqualsNode.java @@ -9,6 +9,7 @@ import com.oracle.truffle.api.dsl.Specialization; import com.oracle.truffle.api.frame.VirtualFrame; import com.oracle.truffle.api.interop.ArityException; import com.oracle.truffle.api.nodes.Node; +import com.oracle.truffle.api.profiles.ConditionProfile; import org.enso.interpreter.dsl.AcceptsError; import org.enso.interpreter.dsl.BuiltinMethod; import org.enso.interpreter.node.EnsoRootNode; @@ -46,6 +47,7 @@ public final class EqualsNode extends Node { @Child private EqualsSimpleNode node; @Child private TypeOfNode types; @Child private WithConversionNode convert; + private final ConditionProfile equalsProfile = ConditionProfile.create(); private static final EqualsNode UNCACHED = new EqualsNode(EqualsSimpleNodeGen.getUncached(), TypeOfNode.getUncached(), true); @@ -85,7 +87,7 @@ public final class EqualsNode extends Node { public boolean execute( VirtualFrame frame, @AcceptsError Object self, @AcceptsError Object other) { var areEqual = node.execute(frame, self, other); - if (!areEqual) { + if (!equalsProfile.profile(areEqual)) { var selfType = types.execute(self); var otherType = types.execute(other); if (selfType != otherType) { ``` But that did not resolve the issue. My second attempt was to enable splitting for `EqualsSimpleNode` with `@com.oracle.truffle.api.dsl.ReportPolymorphism` annotation, which seems to resolve the issue. The benchmark is back to its original score, and `EqualsSimpleNode` is no longer POLYMORPHIC.	2024-03-05 11:00:16 +00:00
Dmitry Bushev	02bd863c29	Add ascription type information to suggestions database (#9267) ... close #9258 Changelog: - fix: add information about the type descriptions to the suggestion database	2024-03-05 09:02:41 +00:00
Jaroslav Tulach	5676618bad	Autoscoped constructors (#9190) ... Fixes #8645 by recognizing `~` prefix to constructor names.	2024-03-04 11:41:02 +00:00
Dmitry Bushev	fad1b45bcf	Fix attaching generic annotations (#9234) ... Fixes the issue with attaching generic annotations in complex types. Annotations in the type body could be lost during the compilation if its constructor was defined at the end of the type definition.	2024-03-01 18:01:50 +00:00
Pavel Marek	96bfcb3e63	Add compiler benchmarks (#9158) ... Add compiler benchmarks to `engine/runtime-benchmarks`. All the benchmarks generate source code on the fly into `engine/runtime-benchmarks/target/bench-data` directory. Random data generators are set with the same seed. For the convenience of reviewers, I am attaching the benchmark sources in [bench-data.zip](https://github.com/enso-org/enso/files/14423372/bench-data.zip). I have created benchmarks that measure the performance of a whole module compilation, and benchmarks that measure the performance of inline compilation. They directly call `run` and `runInline` methods on `org.enso.compiler.Compiler`. # Important Notes - The results will be available in https://enso-org.github.io/engine-benchmark-results/engine-benchs.html in a few days after the merge of this PR. - The benchmark parameters are tweaked so that an average iteration takes less than 400 ms and more than 30 ms. - Ensured that the benchmarks measure performance of the compiler, for example: 	2024-03-01 13:37:18 +00:00
Radosław Waśko	386132cdab	Fix matching JS strings (#9203) ... - Fixes #9202	2024-02-29 15:07:29 +00:00
Dmitry Bushev	6aa213757b	Unexpected warning when running a standalone script (#9114) ... close #9109 Fixes the issue when the runner displays unexpected log messages ``` > .\built-distribution\enso-engine-0.0.0-dev-windows-amd64\enso-0.0.0-dev\bin\enso --run .\test.enso [WARN] [2024-02-20T12:04:21+01:00] [enso.org.enso.interpreter.runtime.SerializationPool] Serialization of module `test` failed: Unable to write cache data for test.` 42 ```	2024-02-23 18:19:06 +00:00
Dmitry Bushev	7ff90aa3f7	Synchronize suggestions loading after the reconnect 2 (#9142) ... related #8689, #9072 Fixes a race between the language server SQL updating logic and the engine `DeserializeLibrarySuggestionsJob`s when the library suggestions may start loading before the database is properly cleaned up after the reconnect. # Important Notes As a side effect, arguments are showing slightly (~1 second) faster due to the lower contention between the engine jobs. #### Before https://github.com/enso-org/enso/assets/357683/cbda2da4-9080-4b9b-b836-81e54694d468 #### After https://github.com/enso-org/enso/assets/357683/bf442284-47be-456d-b1dd-2413b6ad8244	2024-02-23 11:18:01 +00:00
Pavel Marek	21e1284086	Enso tests can be run with filter from cmdline (#9065) ... Simplify the `Test.Suite.run_with_filter` to accept a single filter parameter that searches for all the groups and specs that matches that filter. This filter can be a simple text provided from the command line. # Important Notes - Pending groups are now printed at the end of the run - `Test.Suite.run_with_filter` is simplified to accept a single filter parameter that is either `Text` or `Nothing`. See the docs. - Passing a filter from the command line is therefore straightforward, it is treated as a regex. - For convenience, I have left all the `main` methods in all the test sources. I have just refactored them to accept the `filter` argument from the command line. - For example, to run only a single spec from `Vector_Spec.enso`, invoke `enso --run test/Base_Tests/src/Data/Vector_Spec.enso "should allow vector creation with a programmatic constructor"` - **Majority of the PR is a regex replace** of `^main =` for `main filter=Nothing =` and of `suite.run_with_filter` for `suite.run_with_filter filter`. - **Fixed some internal engine bugs:** - `AtomWithHole` allows to specify only one hole - https://github.com/enso-org/enso/pull/9065/files#diff-0f7bb7e85cf86a965de133aa7e6b5958ceb889bd1921c01e00d3a9ceb19626ef - NaN keys in hash maps are handled in polyglot maps as well - c5257f6c2b78f893214ff67300893b593ea05e21..db4b3c0e9828ee79208d52e02586b24bb845b0d6	2024-02-22 12:31:44 +00:00
Hubert Plociniczak	0133e9ef4f	Drop inefficient SemVer implementation (#9089) ... `Bump` library uses parser combinators behind the scenes which are known to be good at expressing grammars but are not performance-oriented. This change ditches the dependency in favour of an existing Java implementation. `jsemver` implements the full specification, which is probably an overkill in our case, but proved to be an almost drop-in replacement for the previous library. Closes #8692 # Important Notes Peformance improvements: - roughly 50ms compared to the previous approach (from 80ms to 20-40ms) I don't see any time spent in the new implementation during startup so it could be potentially aggressively inlined. Further more, we could use a facade and offer our own strip down version of semver.	2024-02-22 09:59:09 +00:00
Jaroslav Tulach	462c96805b	Avoid excessive logging during development (#9101)	2024-02-20 13:49:54 +01:00
Pavel Marek	96082c3bae	Remove akka from runtime (#8953) ... There are two projects transitively required by `runtime`, that have akka dependencies: - `downloader` - `connected-lock-manager` This PR replaces the `akka-http` dependency in `downloader` by HttpClient from JDK, and splits `connected-lock-manager` into two projects such that there are no akka classes in `runtime.jar`. # Important Notes - Simplify the `downloader` project - remove akka. - Add HTTP tests to the `downloader` project that uses our `http-test-helper` that is normally used for stdlib tests. - It required few tweaks so that we can embed that server in a unit test. - Split `connected-lock-manager` project into two projects - remove akka from `runtime`. - **Native image build fixes and quality of life improvements:** - Output of `native-image` is captured 743e167aa4 - The output will no longer be intertwined with the output from other commands on the CI. - Arguments to the `native-image` are passed via an argument file, not via command line - ba0a69de6e - This resolves an issue on Windows with "Command line too long", for example in https://github.com/enso-org/enso/actions/runs/7934447148/job/21665456738?pr=8953#step:8:2269	2024-02-19 16:39:05 +00:00
Jaroslav Tulach	a664dd9d56	Equality with conversions (#9070)	2024-02-19 17:18:56 +01:00
Radosław Waśko	cf71a05c3b	Refactor common context handling pattern (#9087)	2024-02-19 11:59:42 +00:00
Dmitry Bushev	a25d716932	Keep single execute expression job in the queue (#9077) ... close #8965 Changelog: - update: keep a single `ExecuteExpressionJob` in the queue - update: make `ExecuteExpressionCommand` synchronous to preserve the order of commands - refactor: separate data structures for `Visualization` and `OneshotExpression` to simplify the logic	2024-02-19 09:18:04 +00:00
Hubert Plociniczak	fe0f9046db	Introduce hash seed to invaldiate caches (#9082)	2024-02-16 23:43:30 +00:00
Hubert Plociniczak	d29c2cd66a	Serialize UUID for non-library modules (#9057) ... Missing ID's in IR meant that instrumentation wouldn't be applied for loaded modules. This is the reason why after a restart engine wouldn't send **any** expression updates. Closes #8689. # Important Notes After the change [Kazam_screencast_00038.webm](https://github.com/enso-org/enso/assets/292128/4249287b-6c41-4c9d-b138-e7af59512566) The video somehow doesn't show that all nodes are loaded after the restart, but once I moved the screen they are there. This appears to be a bug in the recording somehow.	2024-02-15 16:50:27 +00:00
Hubert Plociniczak	5c624d21d7	Revert "Synchronize suggestions loading after the reconnect (#9043)" (#9072)	2024-02-15 13:39:56 +00:00
Dmitry Bushev	702e6c1bb8	Set default timeouts in incremental updates test (#9053) ... Fix random failures of `IncrementalUpdatesTest` on CI https://github.com/enso-org/enso/actions/runs/7885050954/job/21515333651#step:8:5274	2024-02-14 17:07:44 +00:00
Radosław Waśko	d45f0fe4df	Check type of self in static dispatch (#8867) ... - Fixes #8805 - also btw. fixes #8706	2024-02-14 15:50:13 +00:00
Dmitry Bushev	6efa26b48e	Add support for positionalArgumentsExpressions of text visualizations (#9052) ... close #9028 Changelog: - add: support `positionalArgumentsExpressions` parameter for visualization expressions represented as strings - add: language server API tests - add: runtime visualization tests # Important Notes https://github.com/enso-org/enso/assets/357683/4e6f207b-ed64-41b9-b94b-96fb9db63ce4	2024-02-13 23:08:30 +00:00
Dmitry Bushev	9c982e07b0	Synchronize suggestions loading after the reconnect (#9043) ... related #8689 Fixes a race between the language server SQL updating logic and the engine `DeserializeLibrarySuggestionsJob`s when the library suggestions may start loading before the database is properly cleaned up after the reconnect.	2024-02-13 17:52:15 +00:00
GregoryTravis	3bdd1a0dce	Re-fetch Warnings in Warning.getWarnings() to correctly wrap them (#9011)	2024-02-13 15:12:32 +00:00
Jaroslav Tulach	04161b33e4	Don't print stacktraces of IOException (#9024) ... Fixes #8896 by logging `IOException` only with `WARNING` and not `SEVERE`. As such the stacktrace of the exception isn't included in the console and failures to store cache are reported as simple messages, not exceptions with stack trace.	2024-02-13 14:01:42 +00:00
Pavel Marek	5919eda753	Fix incremental compilation of runtime/test (#8975)	2024-02-13 10:05:31 +01:00
Jaroslav Tulach	6ff36e570f	Propagate location to resolution errors (#9025)	2024-02-12 10:25:38 +01:00
Hubert Plociniczak	b00dc9e9c0	Minor cleanups to docker image (#8925) ... * Minor cleanups to docker image * format * nit	2024-02-11 21:52:47 +01:00
AdRiley	1dc8c1cb24	Merge empty_error (#9000) ... We don't need 3 copies of empty_error. This PR makes them one.	2024-02-09 14:18:14 +00:00