Ilya Bogdanov 022a5b0d1b Make the code editor editable again (#7844) ... Fixes #7474 Again, a quite complicated issue. The code editor was broken by https://github.com/enso-org/enso/pull/7167 for a few reasons: 1. The text component's shortcuts depend on the `focused` FRP endpoint, which is controlled by `deprecated_(de)focus` inputs. `focused` output was not changed by the code editor `model.focus()` call. (we still use `deprecated_focus` for all other components) 2. `focus()` FRP input was added to the text component but never triggered. It's too easy to confuse it with the `focus()` method of the `object::Instance` (Deref is evil!) 3. The graph editor handles clicks on the background by `blur_tree()`, effectively blurring any focused element in the application. But clicking on code editor (to focus it) also causes a click on the background! So we focus the code editor, and then handle the background click, defocusing it from the graph editor's point of view. It allows graph editor to open CB on <kbd>Enter</kbd> while the code editor is still active. I solved (3) by disallowing CB opening while code editor is visible. Not ideal, but I guess it solves the issue. Do you think the other solution is possible – to add some overlay for the code editor and avoid triggering `blur_tree` when clicking on it? That won't work because you still can't defocus the code editor using the new API, so it will always be focused. So we have a situation when half of the app uses the new focus system, another half uses the old one, and none works properly. https://github.com/enso-org/enso/assets/6566674/3a0d36ed-4d50-4606-9486-272fbd5d9cb7		2023-10-05 08:40:52 +00:00
..
gui	Make the code editor editable again (#7844)	2023-10-05 08:40:52 +00:00
gui2	Add automatic generation of missing group colors (#7902)	2023-10-04 11:24:10 +00:00
ide-desktop	[GUI2] Fix and add tests for delta format translation. (#7968)	2023-10-04 10:53:54 +00:00